1. 27 Jul, 2010 1 commit
    • Anton Blanchard's avatar
      [SCSI] ibmvscsi: Fix oops when an interrupt is pending during probe · 8f83d768
      Anton Blanchard authored
      A driver needs to be ready to take an interrupt as soon as it registers
      an interrupt handler. I noticed the following oops when testing kdump:
      
      ipr: IBM Power RAID SCSI Device Driver version: 2.5.0 (February 11, 2010)
      ibmvscsi 30000002: SRP_VERSION: 16.a
      ibmvscsi 30000002: SRP_VERSION: 16.a
      Unable to handle kernel paging request for data at address 0x00000000
      ...
      pc: c000000004085e34: .tasklet_action+0xf4/0x1dc
      ...
      c000000004086fe4 .__do_softirq+0x16c/0x2c0
      c00000000403138c .call_do_softirq+0x14/0x24
      c00000000400ee14 .do_softirq+0xa0/0x104
      c00000000408690c .irq_exit+0x70/0xd0
      c00000000400f190 .do_IRQ+0x214/0x2a8
      c000000004004804 hardware_interrupt_entry+0x1c/0x98
      --- Exception: 501 (Hardware Interrupt) at c00000000400c544 .raw_local_irq_restore+0x48/0x54
      c00000000465d2a8 ._raw_spin_unlock_irqrestore+0x74/0xa0
      c0000000040e7f00 .__setup_irq+0x2ec/0x3f0
      c0000000040e8198 .request_threaded_irq+0x194/0x22c
      c00000000446d854 .rpavscsi_init_crq_queue+0x284/0x3f0
      c00000000446c764 .ibmvscsi_probe+0x688/0x710
      c00000000402903c .vio_bus_probe+0x37c/0x3e4
      c000000004403f10 .driver_probe_device+0xec/0x1b8
      c000000004404088 .__driver_attach+0xac/0xf4
      c000000004403184 .bus_for_each_dev+0x98/0x104
      c000000004403c98 .driver_attach+0x40/0x60
      c0000000044026f0 .bus_add_driver+0x154/0x324
      c0000000044045d0 .driver_register+0xe8/0x1ac
      c00000000402b2a8 .vio_register_driver+0x54/0x74
      c000000004933ea4 .ibmvscsi_module_init+0x80/0xc0
      c000000004009834 .do_one_initcall+0x98/0x1d8
      c0000000049005b4 .kernel_init+0x27c/0x33c
      c000000004031550 .kernel_thread+0x54/0x70
      
      srp_task needs to be setup before request_irq. The patch below fixes the oops.
      Signed-off-by: default avatarAnton Blanchard <anton@samba.org>
      Acked-by: default avatarBrian King <brking@linux.vnet.ibm.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
      8f83d768
  2. 21 Jul, 2010 4 commits
  3. 12 Jun, 2010 1 commit
  4. 11 Jun, 2010 34 commits