- 29 Feb, 2016 40 commits
-
-
Dilip Kumar Uppugandla authored
BugLink: http://bugs.launchpad.net/bugs/1541456 Driver has following initialization sequence for Target mode 1. Driver initialization starts 2. ISP Abort is scheduled when the target is enabled. qla2xxx [0000:04:00.0]-4807:25: ISP abort scheduled qla2xxx [0000:04:00.0]-00af:25: Performing ISP error recovery - ha=ffff880caa9e0000. 3. DPC thread starts the ISP Abort 4. While DPC is resetting the chip and initializing the firmware, we get async events from the firmware about P2P mode, LOOP UP and PORT UPDATE. 5. PRLI from a initiator is delivered to us followed by a PLOGI and then a SCSI command which creates a session. 6. If the SCSI command is a WRITE in this case, we issue XFR RDY and it gets dropped as can be seen with messages RESET-XFR because ISP Abort is still active qla2xxx [0000:04:00.0]-e902:25: RESET-XFR active/old-count/new-count = 1/1/1. 7. If the SCSI command is a READ, we issue RESPONSE and they get dropped as well because Abort is still active. qla2xxx [0000:04:00.0]-e901:25: RESET-RSP active/old-count/new-count = 1/1/1 8. Now eventually, ISP Abort finishes clearing the DPC flags. qla2xxx [0000:04:00.0]-8822:25: qla2x00_abort_isp succeeded. qla2xxx [0000:04:00.0]-4808:25: ISP abort end. 9. Since we dropped SCSI commands silently (without any responses sent to the initiator) initiator waits for a SCSI timeout (which is 60 seconds in our case), Sends an ABTS which fails since there no se_cmd found for the tag that ABTS is referencing as the commands were cleaned up in Step 6 and 7. 10. Initiator send an IO after the ABTS which succeed fine. To fix the above case, the following changes have been made: - To prevent target from dropping commands silently, use the online flag instead to check for an active chip reset. Once the port is online during a chip reset phase, we are good to process the commands. - Clean up qla2x00_restart_isp to not set the online flag and process ATIO as it is unnecessary. During a chip reset, interrupts are enabled only after setting the online flag to 1, so ATIO's won't be missed and hence no need to process ATIO's after setting the online flag. Signed-off-by:
Dilip Kumar Uppugandla <dilip@purestorage.com> Signed-off-by:
Himanshu Madhani <himanshu.madhani@qlogic.com> Signed-off-by:
Nicholas Bellinger <nab@linux-iscsi.org> (cherry picked from commit 3bb67df5) Signed-off-by:
Tim Gardner <tim.gardner@canonical.com>
-
Quinn Tran authored
BugLink: http://bugs.launchpad.net/bugs/1541456 set ATIO/Request/Response Queues and Default number of outstanding command to 4k. Signed-off-by:
Quinn Tran <quinn.tran@qlogic.com> Signed-off-by:
-
Quinn Tran authored
BugLink: http://bugs.launchpad.net/bugs/1541456Signed-off-by:
-
Quinn Tran authored
BugLink: http://bugs.launchpad.net/bugs/1541456 99% of the time the ATIOQ has SCSI command. The other 1% of time is something else. Most of the time this interrupt does not need to hold the hardware_lock. We're moving the ATIO interrupt thread to a different lock to reduce lock contention. Signed-off-by:
-
Quinn Tran authored
BugLink: http://bugs.launchpad.net/bugs/1541456 queue work element to specific process lessen cache miss Signed-off-by:
-
Quinn Tran authored
BugLink: http://bugs.launchpad.net/bugs/1541456 Register to receive notification of when irq setting change occured. Signed-off-by:
-
Quinn Tran authored
BugLink: http://bugs.launchpad.net/bugs/1541456 Sessions management (add, deleted, modify) currently are serialized through the hardware_lock. Hardware_lock is a high traffic lock. This lock is accessed by both the transmit & receive sides. Sessions management is now moved off to another lock call sess_lock. This is done to reduce lock contention and increase traffic throughput. Signed-off-by:
-
Quinn Tran authored
BugLink: http://bugs.launchpad.net/bugs/1541456 Replace QLA_TGT_STATE_ABORTED state with a bit because the current state of the command is lost when an abort is requested by upper layer. Signed-off-by:
Hannes Reinecke <hare@suse.com> Signed-off-by:
-
Alexei Potashnik authored
BugLink: http://bugs.launchpad.net/bugs/1541456 Until now ack'ing of a new PLOGI has only been delayed if there was an existing session for the same WWN. Ack was released when the session deletion completed. If there was another WWN session with the same fc_id/loop_id pair (aka "conflicting session"), PLOGI was still ack'ed immediately. This potentially caused a problem when old session deletion logged fc_id/loop_id out of FW after new session has been established. Two work-arounds were attempted before: 1. Dropping PLOGIs until conflicting session goes away. 2. Detecting initiator being logged out of FW and issuing LOGO to force re-login. This patch introduces proper solution to the problem where PLOGI is held until either existing session with same WWN or any conflicting session goes away. Mechanism supports one session holding two PLOGI acks as well as one PLOGI ack being held by many sessions. Signed-off-by:
Alexei Potashnik <alexei@purestorage.com> Acked-by:
-
Alexei Potashnik authored
BugLink: http://bugs.launchpad.net/bugs/1541456 1. Initiator A is logged in with fc_id(1)/loop_id(1) 2. Initiator A re-logs in with fc_id(2)/loop_id(2) 3. Part of old session deletion async logoout for 1/1 is queued 4. Initiator B logs in with fc_id(1)/loop_id(1), starts passing data and creates session. 5. Async logo from 3 is processed by DPC and sent to FW Now initiator B has the session but is logged out from FW. This condition is detected first with CTIO error 29 at which point we should delete current session. During session deletion we will send LOGO to initiator to force re-login. Under rare circumstances initiator might be logged out of FW, not have driver session, but still think it's logged in. E.g. the above sequence plus session deletion due to re-config. Incoming commands will fail to create local session because initiator is not found in FW. In this case we also issue LOGO to initiator to force him re-login. Finally this patch fixes exchange leak when commands where received in logged out state. In this case loop_id must be set to FFFF when corresponding exchange is terminated. The patch modifies exchange termination to always use FFFF, since in certain scenarios it's impossible to tell whether command was received in logged in or logged out state. Signed-off-by:
-
Himanshu Madhani authored
BugLink: http://bugs.launchpad.net/bugs/1541456 This patch adds interface to send explicit LOGO explicit LOGO using using ELS commands from driver. Signed-off-by:
Giridhar Malavali <giridhar.malavali@qlogic.com> Signed-off-by:
-
Quinn Tran authored
BugLink: http://bugs.launchpad.net/bugs/1541456 DebugFS now will show fw_resource_count node. FW Resource count Original TGT exchg count[0] current TGT exchg count[0] original Initiator Exchange count[2048] Current Initiator Exchange count[2048] Original IOCB count[2078] Current IOCB count[2067] MAX VP count[254] MAX FCF count[0] Signed-off-by:
-
Himanshu Madhani authored
BugLink: http://bugs.launchpad.net/bugs/1541456 Following counters are added in target mode to help debugging efforts. Target Counters qla_core_sbt_cmd = 0 qla_core_ret_sta_ctio = 0 qla_core_ret_ctio = 0 core_qla_que_buf = 0 core_qla_snd_status = 0 core_qla_free_cmd = 0 num alloc iocb failed = 0 num term exchange sent = 0 num Q full sent = 0 Signed-off-by:
-
Himanshu Madhani authored
BugLink: http://bugs.launchpad.net/bugs/1541456 This patch enables Exchange offload support in Qlogic ISP. To enable exchange offload with Qlogic ISP24XX/25XX/26XX, set module parameter ql2xexchoffld to any non-zero number. This will alow ISP firmware to store exchange data structures used by firmware to host memory provided by driver. ISP firmware can supports upto 32k total active exchanges. Signed-off-by:
-
Himanshu Madhani authored
BugLink: http://bugs.launchpad.net/bugs/1541456 This patch enables Extended Logins support in Qlogic ISP. To enable extended login with Qlogic ISP24XX/25XX/26XX, set module parameter ql2xexlogins to any non-zero number. This will alow ISP firmware to store port database structure information of remote login sessions to host memory provided by driver. ISP firmware supports upto 16k total logins. Signed-off-by:
-
Himanshu Madhani authored
BugLink: http://bugs.launchpad.net/bugs/1541456 Remove firmware binary names for the ISPs, which are not submitted to linux-firmware. Signed-off-by:
Julian Calaby <julian.calaby@gmail.com> Reviewed-by:
Xose Vazquez Perez <xose.vazquez@gmail.com> Cc: Hannes Reinecke <hare@suse.de> Signed-off-by:
Martin K. Petersen <martin.petersen@oracle.com> (cherry picked from commit 940a7f09) Signed-off-by:
-
Jake Oshins authored
BugLink: http://bugs.launchpad.net/bugs/1541120 The Linux kernel already has the concept of IRQ domain, wherein a component can expose a set of IRQs which are managed by a particular interrupt controller chip or other subsystem. The PCI driver exposes the notion of an IRQ domain for Message-Signaled Interrupts (MSI) from PCI Express devices. This patch exposes the functions which are necessary for creating a MSI IRQ domain within a module. [ tglx: Split it into x86 and core irq parts ] Signed-off-by:
Jake Oshins <jakeo@microsoft.com> Cc: gregkh@linuxfoundation.org Cc: kys@microsoft.com Cc: devel@linuxdriverproject.org Cc: olaf@aepfle.de Cc: apw@canonical.com Cc: vkuznets@redhat.com Cc: haiyangz@microsoft.com Cc: marc.zyngier@arm.com Cc: bhelgaas@google.com Link: http://lkml.kernel.org/r/1449769983-12948-4-git-send-email-jakeo@microsoft.comSigned-off-by:
Thomas Gleixner <tglx@linutronix.de> (cherry picked from commit a4289dc2) Signed-off-by:
-
Jake Oshins authored
BugLink: http://bugs.launchpad.net/bugs/1541120 The Linux kernel already has the concept of IRQ domain, wherein a component can expose a set of IRQs which are managed by a particular interrupt controller chip or other subsystem. The PCI driver exposes the notion of an IRQ domain for Message-Signaled Interrupts (MSI) from PCI Express devices. This patch exposes the functions which are necessary for creating a MSI IRQ domain within a module. [ tglx: Split it into x86 and core irq parts ] Signed-off-by:
-
James Smart authored
BugLink: http://bugs.launchpad.net/bugs/1541592 Update version to 11.0.0.10 for upstream patch set Signed-off-by:
Dick Kennedy <dick.kennedy@avagotech.com> Signed-off-by:
James Smart <james.smart@avagotech.com> Reviewed-by:
Hannes Reinicke <hare@suse.de> Signed-off-by:
-
Punit Vara authored
BugLink: http://bugs.launchpad.net/bugs/1541592 This patch is to the lpfc_els.c which resolves following warning reported by coccicheck: WARNING: kzalloc should be used for rdp_context, instead of kmalloc/memset Signed-off-by:
Punit Vara <punitvara@gmail.com> Signed-off-by:
Matthew R. Ochs <mrochs@linux.vnet.ibm.com> Reviewed-by:
Sebastian Herbszt <herbszt@gmx.de> Signed-off-by:
-
Markus Elfring authored
BugLink: http://bugs.launchpad.net/bugs/1541592 The mempool_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by:
Markus Elfring <elfring@users.sourceforge.net> Signed-off-by:
-
James Smart authored
BugLink: http://bugs.launchpad.net/bugs/1541592 Add logging for misconfigured optics acqe reported by fw. Signed-off-by:
-
James Smart authored
BugLink: http://bugs.launchpad.net/bugs/1541592 Fix external loopback failure. Rx sequence reassembly was incorrect. Signed-off-by:
-
James Smart authored
BugLink: http://bugs.launchpad.net/bugs/1541592 Fix mbox reuse in PLOGI completion. Moved allocations so that buffer properly init'd. Signed-off-by:
-
James Smart authored
BugLink: http://bugs.launchpad.net/bugs/1541592 Use new FDMI speed definitions for 10G, 25G and 40G FCoE. Signed-off-by:
-
James Smart authored
BugLink: http://bugs.launchpad.net/bugs/1541592 Make write check error processing more resilient. Checks to catch writes that fw reports weren't fully complete yet SCSI status indicated fine needed correction. Signed-off-by:
-
James Smart authored
BugLink: http://bugs.launchpad.net/bugs/1541592 Fix RDP ACC being too long. Signed-off-by:
-
James Smart authored
BugLink: http://bugs.launchpad.net/bugs/1541592 Fix RDP Speed reporting. Signed-off-by:
-
James Smart authored
BugLink: http://bugs.launchpad.net/bugs/1541592 Modularize, cleanup, add comments - for FDMI code in driver Note: I don't like the comments with leading # - but as we have a lot if present, I'm deferring to handle it in one big fix later. Signed-off-by:
-
James Smart authored
BugLink: http://bugs.launchpad.net/bugs/1541592 Fix crash in fcp command completion path. Missed null check. Signed-off-by:
-
James Smart authored
BugLink: http://bugs.launchpad.net/bugs/1541592 Fix driver crash when module parameter lpfc_fcp_io_channel set to 16 Signed-off-by:
-
James Smart authored
BugLink: http://bugs.launchpad.net/bugs/1541592 Fix RegLogin failed error seen on Lancer FC during port bounce Fix the statemachine and ref counting. Signed-off-by:
-
James Smart authored
BugLink: http://bugs.launchpad.net/bugs/1541592 Fix the FLOGI discovery logic to comply with T11 standards We weren't properly setting fabric parameters, such as R_A_TOV and E_D_TOV, when we registered the vfi object in default configs and pt2pt configs. Revise to now pass service params with the values to the firmware and ensure they are reset on link bounce. Required reworking the call sequence in the discovery threads. Signed-off-by:
-
James Smart authored
BugLink: http://bugs.launchpad.net/bugs/1541592 Fix FCF Infinite loop in lpfc_sli4_fcf_rr_next_index_get. Signed-off-by:
-
Tim Gardner authored
BugLink: http://bugs.launchpad.net/bugs/1542296Signed-off-by:
-
Tim Gardner authored
Signed-off-by: -
dann frazier authored
On NUMA implementations of Cavium ThunderX, node1 memory addresses start with bit 40 set to 1, and therefore requires >= 41 bits of VA. A side effect of this is an increase from 3 to 4 page table levels. Note: The alternative way to increase VA bits w/o moving to 4 level page tables would be to adopt a larger page size. That would have a far more significant impact to memory usage, and is known to have issue with current Ubuntu userspace: https://lists.ubuntu.com/archives/ubuntu-devel/2014-December/038572.html http://bugs.launchpad.net/bugs/1520162Signed-off-by:
dann frazier <dann.frazier@canonical.com> Signed-off-by:
-
Uma Krishnan authored
Add support for future IBM Coherent Accelerator (CXL) device with ID of 0x0601. Signed-off-by:
Uma Krishnan <ukrishn@linux.vnet.ibm.com> Reviewed-by:
Michael Ellerman <mpe@ellerman.id.au> (cherry picked from commit 68adb7bf) Signed-off-by:
-
Brian Norris authored
Some developers really like to have -Werror enabled for their code, as it helps to ensure warning free code. Others don't want -Werror, as it (for example) can cause problems when newer (or older) compilers have different sets of warnings, or new warnings can appear just when turning up the warning level (e.g., make W=1 or W=2). Thus, it seems prudent to have the use of -Werror be configurable. It so happens that cxl is only built on PowerPC, and PowerPC already has a nice set of Kconfig options for this, under CONFIG_PPC_WERROR. So let's use that, and the world is a happy place again! (Note that PPC_WERROR defaults to =y, so the common case compile should still be enforcing -Werror.) Fixes: d3d73f4b ("cxl: Compile with -Werror") Signed-off-by:
Brian Norris <computersforpeace@gmail.com> Signed-off-by:
-
Brian Norris authored
GCC 4.6.3 does not support -Wno-unused-const-variable. Instead, use the kbuild infrastructure that checks if this options exists. Fixes: 2cd55c68 ("cxl: Fix build failure due to -Wunused-variable behaviour change") Suggested-by:
Michal Marek <mmarek@suse.com> Suggested-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
