- 25 Feb, 2022 11 commits
-
-
Michael Straube authored
Remove unnecessary includes and the unused define _RTW_RF_C_ from rtw_rf.c. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20220222082847.6687-4-straube.linux@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Michael Straube authored
Convert the array ch_freq_map to a simple integer array and use the indices as channel numbers. This simplifies the code and avoids looping through the array to get the frequency. To avoid out of bounds array access return a default value for invalid channel values, like the original code did. Signed-off-by:
-
Michael Straube authored
According to the Realtek documentation the chips this driver supports are 2.4 GHz only chips. Frequencies for 5 GHz channels can be removed from the ch_freq_map array. Signed-off-by:
-
Phillip Potter authored
Remove the 'arg' variable from the block inside the if statement in the UpdateHalRAMask8188EUsb function in hal/usb_halinit.c, as due to the recent DBG_88E cleanup series, this is now set but not used. Also remove the rest of the lines in this block that further modify 'arg' as they are superfluous, due to it never being used afterwards. Reported-by:
kernel test robot <lkp@intel.com> Signed-off-by:
Phillip Potter <phil@philpotter.co.uk> Link: https://lore.kernel.org/r/20220222233506.72778-1-phil@philpotter.co.ukSigned-off-by:
-
Philipp Hortmann authored
This patch fixes the checkpatch.pl warning like: CHECK: Lines should not end with a '(' Reviewed-by:Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/e0d6d3d787051e3aef56fdba1aee8c2bbbe14e89.1645477326.git.philipp.g.hortmann@gmail.comSigned-off-by:
-
Philipp Hortmann authored
This patch fixes the checkpatch.pl warning like: WARNING: Unnecessary ftrace-like logging - prefer using ftrace Reviewed-by:
-
Philipp Hortmann authored
This patch fixes the checkpatch.pl warning like: - CHECK: Macro argument reuse 'uVar' - possible side-effects? Moved the only twice used function to the file where it is used. Reviewed-by:
-
Philipp Hortmann authored
This patch fixes the checkpatch.pl warnings like: - CHECK: Avoid CamelCase: <uVar> Reviewed-by:
-
Philipp Hortmann authored
This patch fixes the checkpatch.pl warnings like: - CHECK: spinlock_t definition without comment Reviewed-by:
-
Philipp Hortmann authored
This patch fixes the checkpatch.pl warnings like: CHECK: Avoid CamelCase: <EnCFG_BBType_a> 175: FILE: drivers/staging/vt6656/mac.h:175: +#define EnCFG_BBType_a 0x00 and affected places in mac.c Reviewed-by:
-
Xiaoke Wang authored
devm_kmalloc() returns a pointer to allocated memory on success, NULL on failure. While there is a memory allocation of devm_kmalloc() without proper check. It is better to check the return value of it to prevent wrong memory access. And I use the err label which is introduced by the previous patch to handle the error. Link: https://lore.kernel.org/r/tencent_24A24A3EFF61206ECCC4B94B1C5C1454E108@qq.comReviewed-by:
Jérôme Pouiller <jerome.pouiller@silabs.com> Signed-off-by:
Xiaoke Wang <xkernel.wang@foxmail.com> Link: https://lore.kernel.org/r/tencent_D9887936F780A393C232DC48C9EC3F1D4405@qq.comSigned-off-by:
-
- 21 Feb, 2022 18 commits
-
-
Marcelo Aloisio da Silva authored
Braces are not necessary for single statement blocks. Reviewed-by:
Marcelo Aloisio da Silva <marcelo.as@aol.com> Link: https://lore.kernel.org/r/20220220174150.GA11496@snoopySigned-off-by:
-
Moses Christopher Bollavarapu authored
There is a BIT(nr) macro available in vdso/bits.h which is doing the same left shift operation Example: (1 << 7) == BIT(7) Reviewed-by:
Moses Christopher Bollavarapu <mosescb.dev@gmail.com> Link: https://lore.kernel.org/r/20220219183234.31216-1-mosescb.dev@gmail.comSigned-off-by:
-
Marcelo Aloisio da Silva authored
Fix the following error reported by checkpatch.pl: ERROR: that open brace { should be on the previous line + if (rtw_p2p_chk_state(pwdinfo, P2P_STATE_NONE)) + { Signed-off-by: -
Michael Straube authored
Remove unused aes tables from rtw_security.c and, while at it, remove unused extern declarations from rtw_security.h. Signed-off-by:
-
Michael Straube authored
There are lots of unused macros in the rtw_security.h header. Remove them. Signed-off-by:
-
Michael Straube authored
Each case in ODM_CmnInfoUpdate() just sets a single variable. Set the variables directly and remove ODM_CmnInfoUpdate(). Signed-off-by:
-
Michael Straube authored
The variable pBandWidth in odm_dm_struct stores constants from enum ht_channel_width. Change the type of pBandWidth from u8 pointer to enum ht_channel_width pointer to get rid of a type cast in function Update_ODM_ComInfo_88E(). Signed-off-by:
-
Michael Straube authored
The enums odm_bw and ht_channel_width are redundant. Keep ht_channel_width and remove odm_bw. Signed-off-by:
-
Michael Straube authored
The variables bScanInProcess in struct mlme_priv and bpower_saving in struct pwrctrl_priv are both unsed to store only boolean values true and false. Convert them from u8 to bool to avoid type casts in the function Update_ODM_ComInfo_88E(). Signed-off-by:
-
Michael Straube authored
Each case in ODM_CmnInfoHook() just sets a single variable. Set the variables directly and remove ODM_CmnInfoHook(). Signed-off-by:
-
Martin Kaiser authored
NumQryPhyStatusOFDM in struct odm_phy_dbg_info is set but not used. Remove it. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20220218093034.854049-5-martin@kaiser.cxSigned-off-by:
-
Martin Kaiser authored
NumQryPhyStatusCCK in struct odm_phy_dbg_info is set but not used. Remove it. Signed-off-by:
-
Martin Kaiser authored
The RxSNR array in struct phy_info is set but not used. Remove it. Signed-off-by:
-
Martin Kaiser authored
The RxMIMOSignalQuality array in struct signal_stat is set but not used. Remove it. Signed-off-by:
-
Marcelo Aloisio da Silva authored
Should not use assignment in if condition. Signed-off-by:
-
Hangyu Hua authored
unregister_netdev need to be called when register_netdev succeeds qlge_health_create_reporters fails. Fixes: d8827ae8 ("staging: qlge: deal with the case that devlink_health_reporter_create fails") Signed-off-by:
Hangyu Hua <hbh25y@gmail.com> Link: https://lore.kernel.org/r/20220221085552.93561-1-hbh25y@gmail.comSigned-off-by:
-
Xiaoke Wang authored
One error handler of wfx_init_common() return without calling ieee80211_free_hw(hw), which may result in memory leak. And I add one err label to unify the error handler, which is useful for the subsequent changes. Suggested-by:
-
Riccardo Ferrazzo authored
Some variants of the WF200 disallow active scan on channel 12 and 13. For these parts, the channels 12 and 13 are marked IEEE80211_CHAN_NO_IR. However, the beacon hint procedure was removing the flag IEEE80211_CHAN_NO_IR from channels where a BSS is discovered. This was making subsequent scans to fail because the driver was trying active scans on prohibited channels. Signed-off-by:
Riccardo Ferrazzo <rferrazzo@came.com> Reviewed-by:
-
- 17 Feb, 2022 11 commits
-
-
Phillip Potter authored
Where it is possible (without out-of-patch-series-scope large scale refactoring), correct code to remove checkpatch warnings about lines that are too long, also correcting operator spacing where appropriate for these lines as well. These warnings occur mostly due to so many DBG_88E removals and parentheses tweaks etc. being adjacent to such long lines, which are therefore included in the resultant diff. Signed-off-by:
-
Phillip Potter authored
Remove padapter parameter from aes_decipher function in core/rtw_security.c, as I added it previously during debugging tweaks and it is no longer required. Signed-off-by:
-
Phillip Potter authored
Remove the rtw_sctx_chk_waring_status function from core/rtw_amit.c, as it has only one caller which is unnecessary. Suggested-by:
-
Phillip Potter authored
A number of style problems were left behind by the DBG_88E cleanup: (1) Empty if/else blocks. (2) Parenthesised if/while statements containing only one line. (3) Entire blocks which server zero purpose after removal of DBG_88E. (4) Various warnings about whitespace, and constant comparison order. (5) Use of __constant_htons instead when htons should be used. Fix up these issues across the driver in any file touched by the previous cleanup. Long line warnings will be addresses in a later patch. Signed-off-by:
-
Phillip Potter authored
Remove rtw_debug module parameter, and also the internal GlobalDebugLevel flag and all places where it is referenced. As hal/odm_debug.c is now essentially empty, also remove this file and edit the Makefile to no longer reference it. The DBG_88E macro was the last user of these and has now been removed, making the parameter and flag redundant. Signed-off-by:
-
Phillip Potter authored
Remove DBG_88E macro definition as it has no remaining callers within the driver. This is part of the ongoing effort to cleanup the driver to use standard debug mechanisms where appropriate. Signed-off-by:
-
Phillip Potter authored
Remove all remaining calls to preprocessor aliases of DBG_88E, as well as these definitions themselves. This is a prerequisite for removing the DBG_88E macro itself. Signed-off-by:
-
Phillip Potter authored
Remove the one remaining DBG_88E call from include/usb_ops.h. After some thought, it makes more sense to just entirely strip all of these calls, so that debugging code in the driver can be more consistent and useful going forwards. Signed-off-by:
-
Phillip Potter authored
Remove all remaining DBG_88E calls from the os_dep subdirectory. After some thought, it makes more sense to just entirely strip all of these calls, so that debugging code in the driver can be more consistent and useful going forwards. Signed-off-by:
-
Phillip Potter authored
Remove all remaining DBG_88E calls from os_dep/ioctl_linux.c, patching separately from the rest of the os_dep subdirectory for ease of review due to the sheer number of calls. After some thought, it makes more sense to just entirely strip all of these calls, so that debugging code in the driver can be more consistent and useful going forwards. Signed-off-by:
-
Phillip Potter authored
Remove all remaining DBG_88E calls from the hal subdirectory. After some thought, it makes more sense to just entirely strip all of these calls, so that debugging code in the driver can be more consistent and useful going forwards. Reported-by:
-
