list_entry() will never return a NULL pointer, thus remove the
check.
Signed-off-by: Yuesong Li <liyuesong@vivo.com>
Link: https://lore.kernel.org/r/20240822025736.1208339-1-liyuesong@vivo.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This adds a blank line after the declaration of rtl92e_config_bb, in
order to fix the following checkpatch warning:

CHECK: Please use a blank line after function/struct/union/enum
declarations
Signed-off-by: Vinicius Peixoto <vpeixoto@lkcamp.dev>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240821204714.5839-1-vpeixoto@lkcamp.devSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Adhere to Linux kernel coding style.
Reported by checkpath :
CHECK: spaces preferred around that '&' (ctx:VxV)
Signed-off-by: Guillaume Lefèvre-Crimé <guillaume.lefevre.crime@netc.fr>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240816183756.59250-1-guillaume.lefevre.crime@netc.frSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove iv32 from rtllib_tkip_get_key() as it is set but otherwise
unused.

Flagged by allmodconfig W=1 builds with gcc-13 and clang-18.
Compile tested only.
Signed-off-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240821-rtl8192e-unused-var-v1-1-08b9e869260e@kernel.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable CmdID_WritePortUchar to cmd_id_write_port_uchar
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20240821030856.57423-7-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable CmdID_WritePortUshort to cmd_id_write_port_ushort
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20240821030856.57423-6-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable CmdID_WritePortUlong to cmd_id_write_port_ulong
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20240821030856.57423-5-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable CmdID_BBRegWrite10 to cmd_id_bbreg_write10
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20240821030856.57423-4-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable CmdID_SetTxPowerLevel to
cmd_id_set_tx_power_level to fix checkpatch warning Avoid
CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20240821030856.57423-3-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable CmdID_End to cmd_id_end
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20240821030856.57423-2-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes the "Alignment should match open parenthesis" checks
detected by checkpatch.pl.
Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://lore.kernel.org/r/20240817100559.33174-1-dominik.karol.piatkowski@protonmail.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

In commit 174ac41a ("staging: rtl8723bs: remove obsolete wext
support") a dep on CFG80211_WEXT was added to allow wext userspace
calls to be managed via the compatibility support. This is an
optional dependency which the driver has no dependency on and
stops users/distros etc from dropping CFG80211_WEXT if they want
to enable this driver. Drop this dependency as if users want this
legacy feature they will be explicitly enabling it themselves.
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20240814145250.943457-1-pbrobinson@gmail.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename variable nSubframe_Length to subframe_len
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link: https://lore.kernel.org/r/20240812013650.199675-1-tdavies@darkphysics.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Delete braces {} for single statement blocks to shorten code.
Signed-off-by: Jiwon Kim <jiwonaid0@gmail.com>
Reviewed-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240805135623.2069-1-jiwonaid0@gmail.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch message "CHECK: Alignment should match open parenthesis".
Signed-off-by: Thais-ra <thais_ra@riseup.net>
Link: https://lore.kernel.org/r/20240803072236.368-1-thais_ra@riseup.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch improves the readability of the code related to the Multicast
Address Register (REG_MAR) in the rtl8723bs driver. It adds comments to
clarify the purpose and offset of the register, making the code more
self-documenting without introducing new macros.
Signed-off-by: Manjae Cho <manjae.cho@samsung.com>
Reviewed-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240731225134.917542-1-manjae.cho@samsung.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality or semantics.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Jens Frederich <jfrederich@gmail.com>
Cc: Jon Nettleton <jon.nettleton@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20240731130130.1148153-3-tzimmermann@suse.deSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality or semantics.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20240731130130.1148153-2-tzimmermann@suse.deSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: vme_user: vme.h: alignment of closing parenthesis should match open parenthesis in function declaration

Adhere to Linux kernel coding style.

Reported by checkpatch:

CHECK: Alignment should match open parenthesis
Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
Link: https://lore.kernel.org/r/20240731070507.6290-1-riyandhiman14@gmail.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

These macros just duplicate macros from include/linux/ieee80211.h.
We can safely remove them from rtllib.h.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240730082928.62284-1-straube.linux@gmail.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Noticing that some messages were capitalized and some weren't, I
capitalized them to match the rest. This makes the messages relatively
easier to understand for an end user, and reduces confusion about
capitalization. A comment was also capitalized.
Signed-off-by: Steven Davis <goldside000@outlook.com>
Link: https://lore.kernel.org/r/SJ2P223MB102626B10E837EF5A93ED1F1F7B02@SJ2P223MB1026.NAMP223.PROD.OUTLOOK.COMSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch error "ERROR: code indent should use tabs where possible"
in include/rtw_mlme_ext.h:388.
Signed-off-by: Santiago Ruano Rincón <santiagorr@riseup.net>
Link: https://lore.kernel.org/r/20240730080531.991195-1-santiagorr@riseup.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch error "foo * bar" should be "foo *bar"
in osdep_service.h:105
Signed-off-by: Kartik Kulkarni <kartik.koolks@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20240730134155.37784-1-kartik.koolks@gmail.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch error "ERROR: that open brace {
should be on the previous line"
Signed-off-by: Tchadel Icard <hello@tchadelicard.fr>
Link: https://lore.kernel.org/r/20240730070910.34996-1-hello@tchadelicard.frSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes superfluous tabs at the beginning of the file and
commented includes
Signed-off-by: Benjamin Somers <benjamin.somers@resel.fr>
Link: https://lore.kernel.org/r/20240730070518.2850-1-benjamin.somers@resel.frSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch error code indent should use tabs in file
hal_pwr_seq.h:104
Signed-off-by: Emmanuel Arias <eamanu@riseup.net>
Link: https://lore.kernel.org/r/20240730070059.33210-1-eamanu@riseup.netSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

It fixes the following checkpatch.pl error
"ERROR: that open brace { should be on the previous line" and avoids the
warning "WARNING: braces {} are not necessary for single statement blocks".
Signed-off-by: Sai Sree Kartheek Adivi <sskartheekadivi@gmail.com>
Link: https://lore.kernel.org/r/20240730065901.35254-1-sskartheekadivi@gmail.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch diagnostic "ERROR: that open brace { should be on the
previous line" in rtw_security.h:173
Signed-off-by: Guilherme Puida Moreira <guilherme@puida.xyz>
Link: https://lore.kernel.org/r/20240730064812.1979-1-guilherme@puida.xyzSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixed checkpath Alignment should match open parenthesis
Signed-off-by: David Prévot <david@tilapin.org>
Link: https://lore.kernel.org/r/20240730064707.914-1-david@tilapin.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix the following checkpatch.pl error:

ERROR: trailing whitespace
Signed-off-by: Felix Yan <felixonmars@archlinux.org>
Link: https://lore.kernel.org/r/20240730063746.176245-1-felixonmars@archlinux.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This commit fixes the following checkpatch.pl warnings:

WARNING: function definition argument 'int' should also have an identifier name
+	void (*call)(int, int, void *);

WARNING: function definition argument 'int' should also have an identifier name
+	void (*call)(int, int, void *);

WARNING: function definition argument 'void *' should also have an identifier name
+	void (*call)(int, int, void *);
Signed-off-by: Agathe Porte <gagath@debian.org>
Link: https://lore.kernel.org/r/20240730062843.64977-1-gagath@debian.orgSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Adhere to Linux Kernal coding style.

Reported by checkpatch

CHECK: Alignment should match open parenthesis
Signed-off-by: Griffin Kroah-Hartman <griffin@kroah.com>
Link: https://lore.kernel.org/r/20240729130213.48941-2-griffin@kroah.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Adhere to Linux kernel coding style.

Reported by checkpatch:

CHECK: Alignment should match open parenthesis
Signed-off-by: Griffin Kroah-Hartman <griffin@kroah.com>
Link: https://lore.kernel.org/r/20240729130213.48941-1-griffin@kroah.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Wolfram contributed this driver in 2016. He is not using it anymore and
confirmed it to be removed.

It is hard to find hardware around the globe. When it is offered it is
expensive and performance is low.

Remove unused driver.

Link: https://lore.kernel.org/linux-staging/igi27iwrzg3ovgj3sym4gsi45timpkt4vkl5ss5dbftdzat6p4@ctxcjocvunpt/Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240728052552.GA8748@matrix-ESPRIMO-P710Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Adhere to Linux kernel coding style

Reported by checkpatch:

CHECK: spinlock_t definition without comment
CHECK: mutex definition without comment
Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
Link: https://lore.kernel.org/r/20240727093106.11214-1-riyandhiman14@gmail.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Adhere to Linux kernel coding style

Reported by checkpatch:

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
Link: https://lore.kernel.org/r/20240725130351.14877-1-riyandhiman14@gmail.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch makes three error messages in the driver easier to read by
capitalizing the first letters properly.
For example, "channel already linked" becomes "Channel already linked", and
"expect" becomes "expected", as you would typically
find in an error message.
This patch improves user experience by making the errors clearer.
Signed-off-by: Steven Davis <goldside000@outlook.com>
Link: https://lore.kernel.org/r/SJ2P223MB1026E786B28986901BC1C126F7A92@SJ2P223MB1026.NAMP223.PROD.OUTLOOK.COMSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

It fix the following checkpatch.pl warning:
Avoid multiple line dereference - prefer %s
Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Moon Yeounsu <yyyynoom@gmail.com>
Link: https://lore.kernel.org/r/20240721040504.1483-1-yyyynoom@gmail.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Adhere to Linux kernel coding style.

Reported by checkpatch:

CHECK: Alignment should match open parenthesis
Signed-off-by: Griffin Kroah-Hartman <griffin@kroah.com>
Link: https://lore.kernel.org/r/20240715141102.142186-1-griffin@kroah.comSigned-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>