1. 03 Feb, 2007 11 commits
  2. 31 Jan, 2007 27 commits
  3. 30 Jan, 2007 2 commits
    • Linus Torvalds's avatar
      Revert "net: ifb error path loop fix" · bcdddfb6
      Linus Torvalds authored
      This reverts commit 0c0b3ae6.
      
      Quoth David:
      
        "Jeff, please revert
      
         It's wrong.  We had a lengthy analysis of this piece of code
         several months ago, and it is correct.
      
         Consider, if we run the loop and we get an error
         the following happens:
      
         1) attempt of ifb_init_one(i) fails, therefore we should
            not try to "ifb_free_one()" on "i" since it failed
         2) the loop iteration first increments "i", then it
            check for error
      
         Therefore we must decrement "i" twice before the first
         free during the cleanup.  One to "undo" the for() loop
         increment, and one to "skip" the ifb_init_one() case which
         failed."
      Reported-by: default avatarDavid Miller <davem@davemloft.net>
      Acked-by: default avatarJeff Garzik <jgarzik@pobox.com>
      Cc: Andrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      bcdddfb6
    • Serge E. Hallyn's avatar
      [PATCH] namespaces: fix task exit disaster · 0f245285
      Serge E. Hallyn authored
      This is based on a patch by Eric W.  Biederman, who pointed out that pid
      namespaces are still fake, and we only have one ever active.
      
      So for the time being, we can modify any code which could access
      tsk->nsproxy->pid_ns during task exit to just use &init_pid_ns instead,
      and move the exit_task_namespaces call in do_exit() back above
      exit_notify(), so that an exiting nfs server has a valid tsk->sighand to
      work with.
      
      Long term, pulling pid_ns out of nsproxy might be the cleanest solution.
      Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
      
      [ Eric's patch fixed to take care of free_pid() too ]
      Signed-off-by: default avatarSerge E. Hallyn <serue@us.ibm.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      0f245285