- 22 Mar, 2011 40 commits
-
-
Malcolm Priestley authored
Old versions of these boxes have the BS2F7HZ0194 tuner module on both the LME2510 and LME2510C. Firmware dvb-usb-lme2510-s0194.fw and/or dvb-usb-lme2510c-s0194.fw files are required. See Documentation/dvb/lmedm04.txt Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by:
Mauro Carvalho Chehab <mchehab@redhat.com>
-
Alexander Strakh authored
Error path in file drivers/media/video/tlg2300/pd-video.c: 1. First mutex_unlock on &pd->lock in line 767 (in function that called from line 805) 2. Second in line 806 805 pd_vidioc_s_fmt(pd, &f->fmt.pix); 806 mutex_unlock(&pd->lock); Found by Linux Device Drivers Verification Project Signed-off-by:
Alexander Strakh <strakh@ispras.ru> Acked-by:
Huang Shijie <shijie8@gmail.com> Signed-off-by:
-
Tejun Heo authored
wl1273_device->work is unused. Remove it along with the spurious flush_scheduled_work() call in wl1273_fm_module_exit(). Signed-off-by:
Tejun Heo <tj@kernel.org> Cc: Matti Aaltonen <matti.j.aaltonen@nokia.com> Signed-off-by:
-
Jesper Juhl authored
On Thu, 17 Feb 2011, Matthias Schwarzott wrote: > On Sunday 06 February 2011, Jesper Juhl wrote: > > If the memory allocation to 'state' succeeds but we jump to the 'error' > > label before 'state' is assigned to fe->tuner_priv, then the call to > > 'zl10036_release(fe)' at the 'error:' label will not free 'state', but > > only what was previously assigned to 'tuner_priv', thus leaking the memory > > allocated to 'state'. > > There are may ways to fix this, including assigning the allocated memory > > directly to 'fe->tuner_priv', but I did not go for that since the > > additional pointer derefs are more expensive than the local variable, so I > > just added a 'kfree(state)' call. I guess the call to 'zl10036_release' > > might not even be needed in this case, but I wasn't sure, so I left it in. > > > Yeah, that call to zl10036_release can be completely eleminated. > Another thing is: jumping to the error label only makes sense when memory was > already allocated. So the jump in line 471 can be replaced by "return NULL", > as the other error handling before allocation: > if (NULL == config) { > printk(KERN_ERR "%s: no config specified", __func__); > goto error; > } > > I suggest to improve the patch to clean the code up when changing that. > > But I am fine with commiting this patch also if you do not want to change it. > Thank you for your feedback. It makes a lot of sense. Changing it is not a problem :) How about the updated patch below? If the memory allocation to 'state' succeeds but we jump to the 'error' label before 'state' is assigned to fe->tuner_priv, then the call to 'zl10036_release(fe)' at the 'error:' label will not free 'state', but only what was previously assigned to 'tuner_priv', thus leaking the memory allocated to 'state'. This patch fixes the leak and also does not jump to 'error:' before mem has been allocated but instead just returns. Also some small style cleanups. Signed-off-by:Jesper Juhl <jj@chaosbits.net> Signed-off-by:
Matthias Schwarzott <zzam@gentoo.org> Signed-off-by:
-
Jiri Slaby authored
mem->dma_handle is a dma address obtained by dma_alloc_coherent which needn't be a physical address in presence of IOMMU, as a hardware IOMMU can (and most likely) will return a bus address where physical != bus address. So ensure we are remapping (remap_pfn_range) the right page in __videobuf_mmap_mapper by using virt_to_phys(mem->vaddr) and not mem->dma_handle. While at it, use PFN_DOWN instead of explicit shift. [mchehab@redhat.com: Fix compilation breakage due to the lack of a comma] Signed-off-by:
Jiri Slaby <jslaby@suse.cz> Reviewed-by:
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Signed-off-by:
-
Laurent Pinchart authored
Commit 4057ac6c V4L/DVB (13505): uvcvideo: Refactor chain scan broke output terminals parsing. Fix it. Signed-off-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: stable@kernel.org Signed-off-by:
-
Stephan Lachowsky authored
The scheme used to index format in uvc_fixup_video_ctrl() is not robust: format index is based on descriptor ordering, which does not necessarily match bFormatIndex ordering. Searching for first matching format will prevent uvc_fixup_video_ctrl() from using the wrong format/frame to make adjustments. Signed-off-by:
Stephan Lachowsky <stephan.lachowsky@maxim-ic.com> Cc: stable@kernel.org Signed-off-by:
-
Pawel Osciak authored
Fix vb2 not handling return value from start_streaming() callback. Signed-off-by:
Pawel Osciak <pawel@osciak.com> Signed-off-by:
-
Pawel Osciak authored
poll() should be returning poll-specific error values, not E* errors. Signed-off-by:
-
Pawel Osciak authored
Signed-off-by:
-
Pawel Osciak authored
Multi-planar API was added to 2.6.39 version of Video for Linux 2 API. Signed-off-by:
-
Antti Palosaari authored
Split FW download packages smarter way and bug free. Implementation is based of Andrea Merello's example he provided for tda18218 driver. Count remaining FW bytes down in loop instead of division and modulo combination used earlier. Thanks to: Andrea Merello <andrea.merello@gmail.com> Signed-off-by:
Antti Palosaari <crope@iki.fi> Cc: Andrea Merello <andrea.merello@gmail.com> Signed-off-by:
-
Antti Palosaari authored
Quick test shows that FW must be running before other checks so make it happen earlier. Signed-off-by:
-
Antti Palosaari authored
Split FW download packages smarter way and bug free. Implementation is based of Andrea Merello's example he provided for tda18218 driver. Count remaining FW bytes down in loop instead of division and modulo combination used earlier. Thanks-to: Andrea Merello <andrea.merello@gmail.com> Signed-off-by:
-
Antti Palosaari authored
Map rc-terratec-slim-2 for TerraTec Cinergy T Stick RC device. Signed-off-by:
-
Antti Palosaari authored
Remote used for TerraTec Cinergy T Stick RC. Keytable from Martin Groszhauser <mgroszhauser@gmail.com> Signed-off-by:
-
Antti Palosaari authored
Signed-off-by:
-
Ian Armstrong authored
Patch from Ian Armstrong. I've encountered a couple of problems with the current af9015 driver as supplied with the 2.6.37 kernel, that the attached patch appears to fix. (I've generated this patch against the current v4l-dvb git). Some key-presses are lost. A key-press is only generated upon 'valid' data (buf[14] == (u8) ~buf[15]), but the buffer is wiped before this check. Sometimes the 15th byte has not been set at the time of read, so the data isn't valid & ignored. On the next poll the 15th byte has been set, but the rest of the data was wiped previously, so the data is still invalid & the key is lost. Weird repeat error, where an old key press is sometimes repeated in error. ie. button sequence '1 (pause) 2 (pause) 3 (pause) 4' generates output like '1 (pause) 2 (pause) 23 (pause) 4'. The current driver zeroes the data for the key pushed, but sometimes this data is already zero but with other bytes set suggesting a repeat code. This results in the last key being incorrectly repeated. This patch attempts to reduce the risk of a missed key-press & also stop the random repeat of an old key-press when a new key is pressed. Signed-off-by:
Ian Armstrong <ian@iarmst.demon.co.uk> Signed-off-by:
-
Jean-François Moine authored
[mchehab@redhat.com: Fix a few CodingStyle issues] Tested-by:
Kjell Claesson <kjell.claesson@epost.tidanet.se> Tested-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
Jean-François Moine <moinejf@free.fr> Signed-off-by:
-
Jean-François Moine authored
- change copyright and erroneous comment - small code optimization - have constant the device template Signed-off-by:
-
Jean-François Moine authored
Signed-off-by:
-
Jean-François Moine authored
Signed-off-by:
-
Jean-François Moine authored
- update copyright and module author - set the sensor table as constant Signed-off-by:
-
Hans de Goede authored
Signed-off-by:
-
Jean-François Moine authored
Acked-by:
-
Jean-François Moine authored
This file contains functions for the auto gain. It must be used with the new control mechanism. Acked-by:
-
Jean-François Moine authored
- change some comments and copyright - change an erroneous register name - change hdcs2020b to hdcs2020 Signed-off-by:
-
Jean-François Moine authored
Signed-off-by:
-
Hans de Goede authored
Not only the qx3 microscope has a button, but some cameras too. Tested with the Trust sp@cecam 100 (and with a creative and ezcam without button). Signed-off-by:
-
Xiaochen Wang authored
allows the driver to proceed and initialize the below two values even if the kmalloc() fails. hdw->std_info_enum.def.type_enum.value_names hdw->std_info_enum.def.type_enum.count Signed-off-by:Xiaochen Wang <wangxiaochen0@gmail.com> Signed-off-by:
Mike Isely <isely@pobox.com> Signed-off-by:
-
Mike Isely authored
This was caught via a compiler warning. Amazingly enough this bit of benign dreck dates all the way back to 2008. Signed-off-by: -
Mike Isely authored
Signed-off-by:
-
Hans Verkuil authored
DocBook validation fix. Signed-off-by:
Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by:
-
Hans Verkuil authored
Signed-off-by:
-
Hans Verkuil authored
The xmlto validation produced a number of errors that are now fixed. Sadly, the DocBook/Makefile still adds --skip-validation to xmlto, so these errors are missed during a normal compile. Signed-off-by:
-
Andrzej Pietrasiewicz authored
Memory allocated by alloc_page() function might contain some potentially important data from other system processes. The patch adds a flag to zero the allocated page before giving it to videobuf2 (and then to userspace). Signed-off-by:
Andrzej Pietrasiewicz <andrzej.p@samsung.com> Signed-off-by:
Kyungmin Park <kyungmin.park@samsung.com> Signed-off-by:
Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by:
-
Marek Szyprowski authored
__vb2_queue_free function doesn't really return anything useful. This patch removes support for the return value to simplify the code. Signed-off-by:
-
Marek Szyprowski authored
Return immediately if the target number of buffers is the same as the current one and memory access type doesn't change. Signed-off-by:
-
Andrzej Pietrasiewicz authored
This patch fixes two minor memory leaks in videobuf2-dma-sg module. They might happen only in case some other operations (like memory allocation) failed. Signed-off-by:
-
Marek Szyprowski authored
This patch fixes 2 minor bugs in videobuf2 core: 1. Queue should be reallocated if one change the memory access method without changing the number of buffers. 2. In case of REQBUFS(0), the request should not be passed to the driver. Signed-off-by:
-
