- 28 Oct, 2014 12 commits
-
-
Tina Johnson authored
Unnecessary parentheses around the right hand side of an assignment is removed using the following semantic patch: @@ identifier x,f; constant C; @@ ( -x = (f / C ); +x = f / C ; | -x = (f % C ); +x = f % C ; ) Signed-off-by:
Tina Johnson <tinajohnson.1234@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tina Johnson authored
Unnecessary parentheses around the right hand side of an assignment is removed using the following semantic patch: @@ identifier x,f; constant C; @@ ( -x = (f / C ); +x = f / C ; | -x = (f % C ); +x = f % C ; ) Signed-off-by:
-
Tina Johnson authored
Unnecessary parentheses around the right hand side of an assignment is removed using the following semantic patch: @@ identifier x,f; constant C; @@ ( -x = (f / C ); +x = f / C ; | -x = (f % C ); +x = f % C ; ) Signed-off-by:
-
Tina Johnson authored
Unnecessary parentheses around the right hand side of an assignment is removed using the following semantic patch: @@ identifier x,f; constant C; @@ ( -x = (f / C ); +x = f / C ; | -x = (f % C ); +x = f % C ; ) Signed-off-by:
-
Vaishali Thakkar authored
This patch fixes following sparse warning at number of places in file rtl819x_BAProc.c. Warning: incorrect type in assignment (different base types) expected unsigned short [unsigned] [usertype] tmp got restricted __le16 [usertype] <noident> Here, code before this change is correct. But this change silents sparse warnings and will not harm code too. Signed-off-by:Vaishali Thakkar <vthakkar1994@gmail.com> Reviewed-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Jiayi Ye authored
Successive assignments to the same location is meaningless and can be deleted. The Coccinelle semantic patch was used to find cases. @@ expression e1,e2,e3; @@ ( (<+...e1++...+>)=e2; | (<+...e1--...+>)=e2; | (<+...++e1...+>)=e2; | (<+...--e1...+>)=e2; | e1=e2; e1 = <+...e1...+>; | *e1=e2; *e1=e3; ) Signed-off-by:
Jiayi Ye <yejiayily@gmail.com> Reviewed-by:
Josh Triplett <josh@joshtriplett.org> Signed-off-by:
-
Jiayi Ye authored
Successive assignments to the same location is meaningless and can be deleted. The Coccinelle semantic patch was used to find cases. @@ expression e1,e2,e3; @@ ( (<+...e1++...+>)=e2; | (<+...e1--...+>)=e2; | (<+...++e1...+>)=e2; | (<+...--e1...+>)=e2; | e1=e2; e1 = <+...e1...+>; | *e1=e2; *e1=e3; ) Signed-off-by:
-
Surya Seetharaman authored
Removes the following errors generated using checkpatch.pl tool: drivers/staging/lustre/lustre/ldlm/ldlm_internal.h:247: ERROR: space required after that ';' (ctx:VxV) drivers/staging/lustre/lustre/ldlm/ldlm_internal.h:269: ERROR: space required after that ';' (ctx:VxV) Signed-off-by:
Surya Seetharaman <suryaseetharaman.9@gmail.com> Signed-off-by:
-
Jiayi Ye authored
Successive assignments to the same location is meaningless and can be deleted. The Coccinelle semantic patch was used to find cases. @@ expression e1,e2,e3; @@ ( (<+...e1++...+>)=e2; | (<+...e1--...+>)=e2; | (<+...++e1...+>)=e2; | (<+...--e1...+>)=e2; | e1=e2; e1 = <+...e1...+>; | *e1=e2; *e1=e3; ) Signed-off-by:
-
Ebru Akagunduz authored
fc variable type was u16 and it has an assignment from cpu_to_le16() so its type changed as __le16. This bug found by sparse. Signed-off-by:
Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by:
-
Tapasweni Pathak authored
kfree on NULL pointer is a no-op. This patch used the following semantic patch to find an instance where NULL check is present before kfree // <smpl> @@ expression E; @@ - if (E != NULL) { kfree(E); } + kfree(E); @@ expression E; @@ - if (E != NULL) { kfree(E); E = NULL; } + kfree(E); + E = NULL; // </smpl> Code is made more simpler by breaking up of sequence of kmallocs and adding some more exit labels. Removed unnecessary initialization of buf and fmtbuf to NULL as they are local variables. Suggested-by:Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
Tapasweni Pathak <tapaswenipathak@gmail.com> Acked-by:
-
Tapasweni Pathak authored
The region set by the call to memset, immediately overwritten by the subsequent call to memcpy makes the memset redundant. This patch removes the redundant memset before memcpy using the following coccinelle script: @@ expression e1,e2,e3,e4; @@ - memset(e1,e2,e3); memcpy(e1,e4,e3); Signed-off-by:
-
- 27 Oct, 2014 28 commits
-
-
Tina Ruchandani authored
This patch fixes the following checkpatch error: ERROR: do not use assignment in if condition 2172: FILE: drivers/staging/lustre/lustre/llite/llite_lib.c:2172: if (!inode || !(sbi = ll_i2sbi(inode))) { Signed-off-by:Tina Ruchandani <ruchandani.tina@gmail.com> Suggested-by:
-
Tina Ruchandani authored
This patch makes the following functions static as they are only used in their respective files. These functions were detected by sparse. - lib-md.c : lnet_md_validate - lib-move.c : lnet_ni_* lnet_setpayloadbuffer lnet_peer_alive_locked lnet_msg2bufpool lnet_post_routed_recv_locked lnet_configure / lnet_unconfigure lnet_ioctl init_lnet fini_lnet Signed-off-by: -
Jiayi Ye authored
If net is null and failed path is executed, dereference null may happen. This patch fixes it. The following Coccinelle semantic patch was used. @@ expression E, E1; identifier f; statement S1,S2,S3; @@ * if (E == NULL) { ... when != if (E == NULL) S1 else S2 when != E = E1 * E->f ... when any return ...; } else S3 Signed-off-by: -
Roberta Dobrescu authored
This patch removes duplicated argument to ||, fixing the following warning detected using coccinelle tool: duplicated argument to && or ||. Signed-off-by:
Roberta Dobrescu <roberta.dobrescu@gmail.com> Signed-off-by:
-
Roberta Dobrescu authored
This patch removes uneeded return variables, using only 'return _SUCCESS' instead. It fixes the following warning detected by coccinelle: Unneeded variable. It was done using the following semantic patch: @@ identifier ret; type T; expression e; @@ -T ret = e; ... when != ret when strict -return ret; +return e; Signed-off-by: -
Roberta Dobrescu authored
This patch removes uneeded return variables, using only 'return _SUCCESS' instead. It fixes the following warning detected by coccinelle: Unneeded variable. It was done using the following semantic patch: @@ identifier ret; type T; expression e; @@ -T ret = e; ... when != ret when strict -return ret; +return e; Signed-off-by: -
Roberta Dobrescu authored
This patch removes uneeded return variables, just using 'return _SUCCESS' or 'return HCI_STATUS_SUCCESS' instead. This fixes the following warning detected using coccinelle: Unneeded variable. It was done using the following semantic patch: @@ identifier ret; type T; expression e; @@ -T ret = e; ... when != ret when strict -return ret; +return e; Signed-off-by: -
Roberta Dobrescu authored
This patch fixes the following warning detected using coccinelle: Unneeded semicolon. Signed-off-by:
-
Roberta Dobrescu authored
This patch removes unnecessary comparisons to bool. It fixes the following warning detected using coccinelle tool: WARNING: Comparison to bool. Signed-off-by:
-
Tina Ruchandani authored
This patch fixes the following checkpatch warning: ERROR: Macros with complex values should be enclosed in parentheses 1535: FILE: drivers/staging/rtl8723au/core/rtw_mlme.c:1535: Signed-off-by:
-
Jiayi Ye authored
Successive assignments to the same location is meaningless and can be deleted. The Coccinelle semantic patch was used to find cases. @@ expression e1,e2,e3; @@ ( (<+...e1++...+>)=e2; | (<+...e1--...+>)=e2; | (<+...++e1...+>)=e2; | (<+...--e1...+>)=e2; | e1=e2; e1 = <+...e1...+>; | *e1=e2; *e1=e3; ) Signed-off-by:
-
Vaishali Thakkar authored
This patch replaces driver specific functions(RT_usb_endpoint_is_bulk_in, RT_usb_endpoint_is_bulk_out, RT_usb_endpoint_is_int_in) with USB API functions(usb_endpoint_is_bulk_in, usb_endpoint_is_bulk_out, usb_endpoint_is_int_in). Also, this patch removes these three RT functions as they are no longer needed after replacement. This patch also have one line over 80 characters as limiting it to 80 characters does not make code look good. Signed-off-by:
-
Benjamin Romer authored
Rename the struct to spar_vbus_channel_protocol. Fix CamelCase member names: ChannelHeader => channel_header HdrInfo => hdr_info ChpInfo => chp_info BusInfo => bus_info DevInfo => dev_info Update all references to use the changed names. Signed-off-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
-
Benjamin Romer authored
Remove the typedef and rename to struct spar_vbus_headerinfo. Fix CamelCase member names: structBytes => struct_bytes deviceInfoStructBytes => device_info_struct_bytes devInfoCount => dev_info_count chpInfoByteOffset => chp_info_offset busInfoByteOffset => bus_info_offset devInfoByteOffset => dev_info_offset Update all references to changed names. Signed-off-by:
-
Benjamin Romer authored
Fix the name to SPAR_VBUS_CHANNEL_OK_SERVER and fix the CamelCase parameter: actualBytes => actual_bytes Signed-off-by:
-
Benjamin Romer authored
Remove the unused logCtx parameter and fix the CamelCase name: pChannel => ch Update calls to the macro to remove the unused second parameter. Signed-off-by:
-
Benjamin Romer authored
Fix the CamelCase name: UltraVbusChannelProtocolGuid => spar_vbus_channel_protocol_uuid Update related macro names to match. Update references to changed names. Fix indentation in macros where names changed. Signed-off-by:
-
Benjamin Romer authored
The following macros and functions are unused, and should be deleted: NUMSIGNALS IO_CHANNEL_SIZE QSLOTSFROMBYTES QSIZEFROMBYTES SignalQInit INIT_CLIENTSTRING ULTRA_IO_CHANNEL_SERVER_READY ULTRA_IO_CHANNEL_SERVER_NOTREADY ULTRA_VHBA_init_channel ULTRA_VHBA_set_max ULTRA_VNIC_init_channel Signed-off-by:
-
Benjamin Romer authored
Remove the typedef from ULTRA_IO_CHANNEL_PROTOCOL and use the name struct spar_io_channel_protocol instead. Fix CamelCase member names: ChannelHeader => channel_header cmdQ => cmd_q rspQ => rsp_q zoneGuid => zone_uuid ClientString => client_string Update all references to changed names. Signed-off-by:
-
Benjamin Romer authored
Fix the CamelCase member of this structure: vHba => v_hba Signed-off-by:
-
Benjamin Romer authored
Fix CamelCase names: UniqueNum => unique_num RcvsDroppedDelta => rcvs_dropped_delta Signed-off-by:
-
Benjamin Romer authored
Fix the CamelCase name in this struct: UniqueNum => unique_num Signed-off-by:
-
Benjamin Romer authored
Fix CamelCase names: ErrorCode => error_code Valid => valid SegmentNumber => segment_number SenseKey => sense_key Reserved => reserved IncorrectLength => incorrect_length EndOfMedia => end_of_media FileMark => file_mark Information => information AdditionalSenseLength => additional_sense_length CommandSpecificInformation => commmand_specific_information AdditionalSenseCode => additional_sense_code AdditionalSenseCodeQualifier => additional_sense_code_qualifier FieldReplaceableUnitCode => fru_code SenseKeySpecific => sense_key_specific Signed-off-by:
-
Benjamin Romer authored
Get rid of the typedef and use enum vdisk_mgmt_types instead. Reformat the enumeration names and update any references to use the enum directly. Signed-off-by:
-
Benjamin Romer authored
Get rid of the typedef and use enum task_mgmt_types in its place. Clean up the indentation of the enumeration values and update all use of the name to the new name. Signed-off-by:
-
Benjamin Romer authored
Fix the CamelCase parameter in this macro: Address => address Signed-off-by:
-
Benjamin Romer authored
Take out the typedef and just use enum net_types instead. Signed-off-by:
-
Benjamin Romer authored
Nobody is using this one either... Signed-off-by:
-
