- 11 Sep, 2022 9 commits
-
-
Philipp Hortmann authored
Rename variable bActionAllowed to action_allowed to avoid CamelCase which is not accepted by checkpatch.pl. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/e8b617ab58c360bb485cb51d080a8ef81cd47869.1662402870.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
Rename variable ChangeSource to change_source to avoid CamelCase which is not accepted by checkpatch.pl. Signed-off-by:
-
Martin Kaiser authored
The rtw_is_scan_deny macro returns false. Remove the macro and resulting dead code. Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150 Acked-by:
Pavel Skripkin <paskripkin@gmail.com> Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20220910180236.489808-5-martin@kaiser.cxSigned-off-by:
-
Martin Kaiser authored
The rtw_clear_scan_deny macro is empty. Remove it. Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150 Acked-by:
-
Martin Kaiser authored
Remove the rtw_set_scan_deny_timer_hdl macro, it's not used. Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150 Acked-by:
-
Martin Kaiser authored
The rtw_set_scan_deny macro does nothing. Remove it. Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150 Acked-by:
-
Nam Cao authored
In function device_init_td0_ring, memory is allocated for member td_info of priv->apTD0Rings[i], with i increasing from 0. In case of allocation failure, the memory is freed in reversed order, with i decreasing to 0. However, the case i=0 is left out and thus memory is leaked. Modify the memory freeing loop to include the case i=0. Tested-by:
Nam Cao <namcaov@gmail.com> Link: https://lore.kernel.org/r/20220909141338.19343-1-namcaov@gmail.comSigned-off-by:
-
Michael Straube authored
The function c2h_evt_read() is only used in rtw_cmd.c. Make it static. This addresses the TODO item: * Remove the HAL layer and migrate its functionality into the relevant parts of the driver. Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150 Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20220909100232.8305-1-straube.linux@gmail.comSigned-off-by:
-
Nam Cao authored
Remove null check for priv->tx0_bufs, because it can never be null at this point. Signed-off-by:
-
- 09 Sep, 2022 30 commits
-
-
GUO Zihua authored
CFI (Control Flow Integrity) is a safety feature allowing the system to detect and react should a potential control flow hijacking occurs. In particular, the Forward-Edge CFI protects indirect function calls by ensuring the prototype of function that is actually called matches the definition of the function hook. Since Linux now supports CFI, it will be a good idea to fix mismatched return type for implementation of hooks. Otherwise this would get cought out by CFI and cause a panic. Use enums from netdev_tx_t as return value instead. Then change return type to netdev_tx_t. Fixes: cf68fffb ("add support for Clang CFI") Signed-off-by:
GUO Zihua <guozihua@huawei.com> Link: https://lore.kernel.org/r/20220909082048.14486-3-guozihua@huawei.comSigned-off-by:
-
GUO Zihua authored
As _rtw_xmit_entry() would always return 0, we are save to delete the return value for it. Signed-off-by:
-
GUO Zihua authored
CFI (Control Flow Integrity) is a safety feature allowing the system to detect and react should a potential control flow hijacking occurs. In particular, the Forward-Edge CFI protects indirect function calls by ensuring the prototype of function that is actually called matches the definition of the function hook. Since Linux now supports CFI, it will be a good idea to fix mismatched return type for implementation of hooks. Otherwise this would get cought out by CFI and cause a panic. Use enums from netdev_tx_t as return value instead, then change return type to netdev_tx_t. Note that rtllib_xmit_inter() would return 1 only on allocation failure and the queue is stopped if that happens, meeting the documented requirement if NETDEV_TX_BUSY should be returned by ndo_start_xmit. Signed-off-by:
-
GUO Zihua authored
CFI (Control Flow Integrity) is a safety feature allowing the system to detect and react should a potential control flow hijacking occurs. In particular, the Forward-Edge CFI protects indirect function calls by ensuring the prototype of function that is actually called matches the definition of the function hook. Since Linux now supports CFI, it will be a good idea to fix mismatched return type for implementation of hooks. Otherwise this would get cought out by CFI and cause a panic. Use enums from netdev_tx_t as return value instead, then change return type to netdev_tx_t. Signed-off-by:
-
Asif Khan authored
Replace camelcase variable UserPriority with snake case variable user_priority. Signed-off-by:
Asif Khan <asif.kgauri@gmail.com> Link: https://lore.kernel.org/r/20220904192400.8309-1-asif.kgauri@gmail.comSigned-off-by:
-
Greg Kroah-Hartman authored
In the greybus audio_helper code, the debugfs file for the dapm has the potential to be removed and memory will be leaked. There is also the very real potential for this code to remove ALL debugfs entries from the system, and it seems like this is what will really happen if this code ever runs. This all is very wrong as the greybus audio driver did not create this debugfs file, the sound core did and controls the lifespan of it. So remove all of the debugfs logic from the audio_helper code as there's no way it could be correct. If this really is needed, it can come back with a fixup for the incorrect usage of the debugfs_lookup() call which is what caused this to be noticed at all. Cc: Johan Hovold <johan@kernel.org> Cc: Alex Elder <elder@kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: stable <stable@kernel.org> Link: https://lore.kernel.org/r/20220902143715.320500-1-gregkh@linuxfoundation.orgSigned-off-by:
-
Michael Straube authored
Remove the RETURN labels in rtw_alloc_etherdev_with_old_priv() and rtw_alloc_etherdev() and return directly to clean up the code and improve readability. Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150 Signed-off-by:
-
Michael Straube authored
The functions UpdateBrateTbl() and UpdateBrateTblForSoftAP() are only used in rtw_mlme_ext.c. Make them static. Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150 Signed-off-by:
-
Michael Straube authored
The parameter 'Adapter' of UpdateBrateTbl() is unused. Remove it. Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150 Signed-off-by:
-
Michael Straube authored
The parameters 'Enable' and 'Linked' of _BeaconFunctionEnable() are unused. Remove them. Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150 Signed-off-by:
-
Michael Straube authored
Remove some unused enums to clean up the driver code. Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150 Signed-off-by:
-
Martin Kaiser authored
Do not blink the led to indicate that we're scanning if we are already connected to a wireless network. Tested-by:
-
Martin Kaiser authored
When WPS fails, WPS blinking is no longer in progress. The if statement can be removed. Tested-by:
-
Martin Kaiser authored
Cancel blink_work if WPS fails. Another worker will be scheduled after the state variables are updated. Tested-by:
-
Martin Kaiser authored
Always update the status variables in rtw_led_control when we start WPS blinking. The code is easier to understand without the if conditions. Tested-by:
-
Martin Kaiser authored
In rtw_led_control, we can always cancel a running blink worker when we start WPS blinking. The worker will be scheduled again and there's no point in having more than one pending blink worker. Tested-by:
-
Martin Kaiser authored
Simplify one of the cases in rtw_led_control. If we're already blinking during WPS, we don't have to restart this blinking when the caller requests it again. We can simply return and keep on blinking. Tested-by:
-
Martin Kaiser authored
When a caller of rtw_led_control requests that the led be switched off, we should cancel the blink worker and set all blinking state variables to false. This does not depend on the current blinking state. Tested-by:
-
Martin Kaiser authored
The rtw_sitesurvey_cmd function may receive an array of channels in the ch and ch_num parameters. All of the callers set ch = NULL and ch_num = 0. Remove the two parameters from rtw_sitesurvey_cmd and the code to process them. Tested-by:
-
Michael Straube authored
The function indicate_wx_scan_complete_event() is declared multiple times. That is not needed. Remove redundant declarations to clean up the driver code and remove the now empty header mlme_osdep.h. Signed-off-by:
-
Nam Cao authored
Remove function rtw_is_wps_ie because it is not used. Signed-off-by:
-
Nam Cao authored
Remove function IsHexDigit because it is not used. Signed-off-by:
-
Nam Cao authored
Remove function rtw_hal_is_disable_sw_channel_plan because it is not used. Signed-off-by:
-
Nam Cao authored
Remove function hal_btcoex_SetManualControl because it is not used. Signed-off-by:
-
Nam Cao authored
Remove function GetHexValueFromString because it is not used. Signed-off-by:
-
Nam Cao authored
Remove function odm_PauseDIG because it is not used. Signed-off-by:
-
Nam Cao authored
Remove rtw_odm.c and rtw_odm.h because the content of these files is not used. Signed-off-by:
-
Nam Cao authored
Delete function rtw_change_ifname because it is not used. Signed-off-by:
-
Nam Cao authored
The function rtw_set_chplan_cmd is not used. Remove it. Signed-off-by:
-
Nam Cao authored
Remove function rtw_setdatarate_cmd because it is not used. Signed-off-by:
-
- 05 Sep, 2022 1 commit
-
-
Greg Kroah-Hartman authored
Resolves the merge issue with: drivers/staging/r8188eu/os_dep/os_intfs.c Signed-off-by:
-
