- 25 Mar, 2019 5 commits
-
-
Madhumitha Prabakaran authored
Fix preferred form of passing a size of a struct to improve readability and eradicate an opportunity for a bug when the pointer variable type is changed but the corresponding sizeof that is passed to a memory allocator is not. Signed-off-by:
Madhumitha Prabakaran <madhumithabiw@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Vatsala Narang authored
Replace 'unsigned' with 'unsigned int' to get rid of checkpatch warning Signed-off-by:
Vatsala Narang <vatsalanarang@gmail.com> Signed-off-by:
-
Bhanusree Pola authored
The function devm_ioremap already prints error message when there is no enough memory. Remove print statements that give error messages Issue found using coccinelle The following semantic patch is used to solve this: <smpl> @@ expression x; constant char[] C; identifier f; @@ x = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\| usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...)); if(x==NULL) { ... ( -f(C,...); | -f(...,C); ) ... } </smpl> Signed-off-by:Bhanusree Pola <bhanusreemahesh@gmail.com> Reviewed-by:
Fabio Estevam <festevam@gmail.com> Signed-off-by:
-
Vatsala Narang authored
Adjust code to fix the style issue-lines should not end with a parentheses Signed-off-by:
-
Ganesh Biradar authored
Fix the comment style of SPDX license identifier based on header file type Signed-off-by:
Ganesh Biradar <grbesd1@gmail.com> Signed-off-by:
-
- 24 Mar, 2019 8 commits
-
-
Payal Kshirsagar authored
Correct misspelled word. Signed-off-by:
Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com> Signed-off-by:
-
Vatsala Narang authored
Corrected the identation of switch case to get rid of checkpatch error Signed-off-by:
-
Vatsala Narang authored
Replace 'foo * bar' with 'foo *bar' to fix a checkpatch warning Signed-off-by:
-
Vatsala Narang authored
Replace negoitation with negotiation to get rid of checkpatch warning. Signed-off-by:
-
Nishka Dasgupta authored
Remove function rtw_alloc_network() as all it does is call _rtw_alloc_network(). Rename _rtw_alloc_network() to rtw_alloc_network(). Change references to _rtw_alloc_network() to refer to rtw_alloc_network(). Issue first noticed while using Coccinelle and ret.cocci. Signed-off-by:
Nishka Dasgupta <nishka.dasgupta@yahoo.com> Signed-off-by:
-
Nishka Dasgupta authored
Remove unnecessary parentheses around variables. Issue found with Checkpatch. Signed-off-by:
-
Nishka Dasgupta authored
Change datatype of local variable from sint to int. Signed-off-by:
-
Nishka Dasgupta authored
Remove function rtw_init_mlme_priv() as all it does is call _rtw_init_mlme_priv(). Change the name of _rtw_init_mlme_priv() to rtw_init_mlme_priv() and its return type to int. Remove references to _rtw_init_mlme_priv() from the corresponding header file. Suggestion to delete return variable from rtw_init_mlme_priv() put forward by Coccinelle using ret.cocci. Signed-off-by:
-
- 22 Mar, 2019 12 commits
-
-
George Hilliard authored
The buffer descriptor setup loop is correct only if it is setting up at least one bd struct. Besides, there is an error if dma_map_sg() returns 0, which is possible and must be handled. Additionally, remove the BUG_ON() checking sglen, which is unnecessary because we configure DMA with that constraint during init. Signed-off-by:
George Hilliard <thirtythreeforty@gmail.com> Signed-off-by:
-
George Hilliard authored
The kernel complained: [ 510.277151] WARNING: CPU: 0 PID: 395 at fs/proc/generic.c:360 proc_register+0xf0/0x108 [ 510.292891] proc_dir_entry '/proc/msdc_debug' already registered when doing a modprobe/rmmod/modprobe of this module if debug messages are compiled in. Fix this by removing the proc entry when the module is unloaded. Signed-off-by: -
Bhanusree Pola authored
Test for NULL as !x instead of NULL comparisions. Issue found using coccinelle Semantic patch used to solve the problem is as follows // <smpl> @@ expression x; statement S; @@ x = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\| usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...)); -if(x==NULL) +if(!x) S @@ expression e; @@ -e == NULL +!e // </smpl> Signed-off-by:
Gao Xiang <gaoxiang25@huawei.com> Signed-off-by:
-
Michael Straube authored
Remove unnecessary parentheses in rtl8188eu_xmit.c. Reported by checkpatch. Signed-off-by:
Michael Straube <straube.linux@gmail.com> Signed-off-by:
-
Nishka Dasgupta authored
Remove unnecessary local return variables in rtw_mlme_ext.c. Issue found with Coccinelle using ret.cocci. Signed-off-by:
-
Nishka Dasgupta authored
Change NULL comparisons to Boolean negations. Issue found with Coccinelle using matchnull.cocci. Signed-off-by:
-
Nishka Dasgupta authored
Remove return variables from wilc_spi.c. Issue found with Coccinelle using ret.cocci. Signed-off-by:
-
Nishka Dasgupta authored
Remove return variable from host_interface.c. Issue found with Coccinelle using ret.cocci. Signed-off-by:
-
Vatsala Narang authored
Add spaces around '-' operator to get rid of checkpatch warning. Signed-off-by:
-
Jules Irenge authored
Remove empty space to solve checkpatch.pl warning: "WARNING: line over 80 characters". Signed-off-by:
Jules Irenge <jbi.octave@gmail.com> Signed-off-by:
-
Bhanusree Pola authored
Remove print statements that provide information about error messages when memory allocation is failed. Issue found using coccinelle The following semantic patch is used to solve this: <smpl> @@ expression x; constant char[] C; identifier f; @@ x = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\| usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...)); if(x==NULL) { ... ( -f(C,...); | -f(...,C); ) ... } </smpl> Signed-off-by:Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Arash Fotouhi authored
Added blank line after declarations. Signed-off-by:
Arash Fotouhi <arash@arashfotouhi.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
- 21 Mar, 2019 15 commits
-
-
Himadri Pandya authored
Remove typedef for struct pno_scan_info as The Linux kernel coding style guidelines discourage the use of typedefs for struct types. Signed-off-by:
Himadri Pandya <himadri18.07@gmail.com> Signed-off-by:
-
Himadri Pandya authored
Remove typedef for struct pno_scan_channel_info as The Linux kernel coding style guidelines discourage the use of typedefs for struct types. Signed-off-by:
-
Himadri Pandya authored
Remove typedef from struct pno_ssid_list as The Linux kernel coding style guidelines discourage the use of typedefs for struct types. Signed-off-by:
-
Himadri Pandya authored
Remove typedef for struct pno_ssid as The Linux kernel coding style guidelines discourage the use of typedefs for struct types. Signed-off-by:
-
Himadri Pandya authored
Remove typedef for struct pno_nlo_info as the Linux kernel coding style guidelines discourage the use of typedefs for struct types. Signed-off-by:
-
Nishka Dasgupta authored
Change NULL comparison to Boolean negation. Issue found with Coccinelle using matchnull.cocci. Signed-off-by:
-
Payal Kshirsagar authored
To avoid style issues, remove multiple blank lines. Signed-off-by:
-
Payal Kshirsagar authored
Align code to the open parenthesis to fix the alignment issue. Signed-off-by:
-
Payal Kshirsagar authored
Fix unnecessary parentheses issue. Signed-off-by:
-
Payal Kshirsagar authored
Align code to the open parenthesis to fix the alignment issue. Signed-off-by:
-
Payal Kshirsagar authored
To avoid style issues, remove multiple blank lines. Signed-off-by:
-
Payal Kshirsagar authored
Align code to the open parenthesis to fix the alignment issue. Signed-off-by:
-
Payal Kshirsagar authored
To avoid style issues, remove multiple blank lines. Signed-off-by:
-
Bhanusree Pola authored
Test for NULL as !x instead of NULL comparisions for functions that return NULL on failure. Issue found using coccinelle Semantic patch used to solve the problem is as follows // <smpl> @@ expression x; statement S; @@ x = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\| usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...)); -if(x==NULL) +if(!x) // </smpl> Signed-off-by:
-
Himadri Pandya authored
Kmalloc normally produces a backtrace when there is not enough memory. So it is unnecessary to print an error message that provides only this information. Hence, remove pr_error() from memory allocation check. Issue found using Coccinelle. Signed-off-by:
-
