1. 04 Jun, 2008 5 commits
    • Alan Cox's avatar
      libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl · a57c1bad
      Alan Cox authored
      - Make ata_sff_altstatus private so nobody uses it by mistake
      - Drop the 400nS delay from it
      
      Add
      
      ata_sff_irq_status	-	encapsulates the IRQ check logic
      
      This function keeps the existing behaviour for altstatus using devices. I
      actually suspect the logic was wrong before the changes but -rc isn't the
      time to play with that
      
      ata_sff_sync		-	ensure writes hit the device
      
      Really we want an io* operation for 'is posted' eg ioisposted(ioaddr) so
      that we can fix the nasty delay this causes on most systems.
      
      - ata_sff_pause		-	400nS delay
      
      Ensure the command hit the device and delay 400nS
      
      - ata_sff_dma_pause
      
      Ensure the I/O hit the device and enforce an HDMA1:0 transition delay.
      Requires altstatus register exists, BUG if not so we don't risk
      corruption in MWDMA modes. (UDMA the checksum will save your backside in
      theory)
      
      The only other complication then is devices with their own handlers.
      rb532 can use dma_pause but scc needs to access its own altstatus
      register for internal errata workarounds so directly call the drivers own
      altstatus function.
      Signed-off-by: default avatarAlan Cox <alan@redhat.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      a57c1bad
    • Tejun Heo's avatar
      libata: kill unused constants · 4f0ebe3c
      Tejun Heo authored
      Kill a few unused constants.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      4f0ebe3c
    • Mark Lord's avatar
      sata_mv: PHY_MODE4 cleanups · ba069e37
      Mark Lord authored
      The handling for PHY_MODE4 was originally just cloned from the
      Marvell proprietary driver (with their blessing).
      But we can do better than that.
      
      Tidy things up with some judicious mask definitions, to improve maintainability.
      Signed-off-by: default avatarMark Lord <mlord@pobox.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      ba069e37
    • Colin Ian King's avatar
      [libata] ata_piix: more acer short cable quirks · e1fefea9
      Colin Ian King authored
      Add ICH6 on ACER Aspire 1694WLMi to list of laptops that use short cables
      rather than 80 wire
      
      OriginalAuthor: Tiago Sousa
      OriginalLocation: http://launchpadlibrarian.net/11627664/new.ich_laptop.short.cables.diff
      Bug: #187121
      Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
      Signed-off-by: default avatarmaximilian attems <max@stro.at>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      e1fefea9
    • Holger Macht's avatar
      [libata] ACPI: Properly handle bay devices in dock stations · 664d080c
      Holger Macht authored
      * Differentiate between bay devices in dock stations and others:
      
       - When an ACPI_NOTIFY_EJECT_REQUEST appears, just signal uevent to
         userspace (that is when the optional eject button on a bay device is
         pressed/pulled) giving the possibility to unmount file systems and to
         clean up. Also, only send uevent in case we get an EJECT_REQUEST
         without doing anything else. In other cases, you'll get an add/remove
         event because libata attaches/detaches the device.
      
       - In case of a dock event, which in turn signals an
         ACPI_NOTIFY_EJECT_REQUEST, immediately detach the device, because it
         may already have been gone
      
      * In case of an ACPI_NOTIFY_DEVICE/BUS_CHECK, evaluate _STA to check if
        the device has been plugged or unplugged. If plugged, hotplug it, if
        unplugged, just signal event to userspace
        (initial patch by Matthew Garrett <mjg59@srcf.ucam.org>)
      
      * Call ACPI _EJ0 for detached devices
      Signed-off-by: default avatarHolger Macht <hmacht@suse.de>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      664d080c
  2. 02 Jun, 2008 7 commits
  3. 31 May, 2008 8 commits
  4. 30 May, 2008 20 commits