1. 28 Feb, 2011 7 commits
    • Felix Fietkau's avatar
      p54: fix a NULL pointer dereference bug · a5a7103f
      Felix Fietkau authored
      If the RSSI calibration table was not found or not parsed properly,
      priv->rssi_db will be NULL, p54_rssi_find needs to be able to deal
      with that.
      Signed-off-by: default avatarFelix Fietkau <nbd@openwrt.org>
      Acked-by: default avatarChristian Lamparter <chunkeey@googlemail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      a5a7103f
    • Alessio Igor Bogani's avatar
      rtlwifi: fix places where uninitialized data is used · c2a7dca0
      Alessio Igor Bogani authored
      drivers/net/wireless/rtlwifi/rtl8192ce/trx.c: In function ‘rtl92ce_rx_query_desc’:
      drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:255:5: warning: ‘rf_rx_num’ may be used uninitialized in this function
      drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:257:12: warning: ‘total_rssi’ may be used uninitialized in this function
      drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:466:6: warning: ‘weighting’ may be used uninitialized in this function
      
      This work was supported by a hardware donation from the CE Linux Forum.
      Signed-off-by: default avatarAlessio Igor Bogani <abogani@kernel.org>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      c2a7dca0
    • Alessio Igor Bogani's avatar
      rtlwifi: Add the missing rcu_read_lock/unlock · 701c2be0
      Alessio Igor Bogani authored
      ===================================================
      [ INFO: suspicious rcu_dereference_check() usage. ]
      ---------------------------------------------------
      net/mac80211/sta_info.c:125 invoked rcu_dereference_check() without protection!
      
      other info that might help us debug this:
      
      rcu_scheduler_active = 1, debug_locks = 0
      5 locks held by wpa_supplicant/468:
       #0:  (rtnl_mutex){+.+.+.}, at: [<c1465d84>] rtnl_lock+0x14/0x20
       #1:  (&rdev->mtx){+.+.+.}, at: [<f84b8c2b>] cfg80211_mgd_wext_siwfreq+0x6b/0x170 [cfg80211]
       #2:  (&rdev->devlist_mtx){+.+.+.}, at: [<f84b8c37>] cfg80211_mgd_wext_siwfreq+0x77/0x170 [cfg80211]
       #3:  (&wdev->mtx){+.+.+.}, at: [<f84b8c44>] cfg80211_mgd_wext_siwfreq+0x84/0x170 [cfg80211]
       #4:  (&rtlpriv->locks.conf_mutex){+.+.+.}, at: [<f8506476>] rtl_op_bss_info_changed+0x26/0xc10 [rtlwifi]
      
      stack backtrace:
      Pid: 468, comm: wpa_supplicant Not tainted 2.6.38-rc6+ #79
      Call Trace:
       [<c108806a>] ? lockdep_rcu_dereference+0xaa/0xb0
       [<f8523d2c>] ? sta_info_get_bss+0x19c/0x1b0 [mac80211]
       [<f8523d62>] ? ieee80211_find_sta+0x22/0x40 [mac80211]
       [<f850661c>] ? rtl_op_bss_info_changed+0x1cc/0xc10 [rtlwifi]
       [<c153671c>] ? __mutex_unlock_slowpath+0x14c/0x160
       [<c153673d>] ? mutex_unlock+0xd/0x10
       [<f8507180>] ? rtl_op_config+0x120/0x310 [rtlwifi]
       [<c10896db>] ? trace_hardirqs_on+0xb/0x10
       [<f8522169>] ? ieee80211_bss_info_change_notify+0xf9/0x1f0 [mac80211]
       [<f8506450>] ? rtl_op_bss_info_changed+0x0/0xc10 [rtlwifi]
       [<f853646f>] ? ieee80211_set_channel+0xbf/0xd0 [mac80211]
       [<f84b5f41>] ? cfg80211_set_freq+0x121/0x180 [cfg80211]
       [<f85363b0>] ? ieee80211_set_channel+0x0/0xd0 [mac80211]
       [<f84b8ceb>] ? cfg80211_mgd_wext_siwfreq+0x12b/0x170 [cfg80211]
       [<f84b87eb>] ? cfg80211_wext_siwfreq+0x9b/0x100 [cfg80211]
       [<c153b98b>] ? sub_preempt_count+0x7b/0xb0
       [<c150f874>] ? ioctl_standard_call+0x74/0x3b0
       [<c1465d84>] ? rtnl_lock+0x14/0x20
       [<f84b8750>] ? cfg80211_wext_siwfreq+0x0/0x100 [cfg80211]
       [<c14568bd>] ? __dev_get_by_name+0x8d/0xb0
       [<c150fddb>] ? wext_handle_ioctl+0x16b/0x180
       [<f84b8750>] ? cfg80211_wext_siwfreq+0x0/0x100 [cfg80211]
       [<c145bc7a>] ? dev_ioctl+0x5ba/0x720
       [<c108a947>] ? __lock_acquire+0x3e7/0x19b0
       [<c1443b0b>] ? sock_ioctl+0x1eb/0x290
       [<c108bfa5>] ? lock_release_non_nested+0x95/0x2f0
       [<c1443920>] ? sock_ioctl+0x0/0x290
       [<c114d74d>] ? do_vfs_ioctl+0x7d/0x5c0
       [<c1112232>] ? might_fault+0x62/0xb0
       [<c113e3c6>] ? fget_light+0x226/0x390
       [<c1112278>] ? might_fault+0xa8/0xb0
       [<c114dd17>] ? sys_ioctl+0x87/0x90
       [<c1002f9f>] ? sysenter_do_call+0x12/0x38
      
      This work was supported by a hardware donation from the CE Linux Forum.
      Signed-off-by: default avatarAlessio Igor Bogani <abogani@kernel.org>
      Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      701c2be0
    • Dan Carpenter's avatar
      iwlwifi: remove duplicate initialization · c3371d64
      Dan Carpenter authored
      rate_mask is initialized again later so this can be removed.  Btw, if
      rate_control_send_low(sta, priv_sta, txrc) returns false, that means
      that "sta" is non-NULL.  That's why the second initialization of
      rate_mask is a little simpler than the first.
      Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
      Acked-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      c3371d64
    • Gustavo F. Padovan's avatar
      Bluetooth: Fix BT_L2CAP and BT_SCO in Kconfig · d45dcef7
      Gustavo F. Padovan authored
      If we want something "bool" built-in in something "tristate" it can't
      "depend on" the tristate config option.
      
      Report by DaveM:
      
         I give it 'y' just to make it happen, for both, and afterways no
         matter how many times I rerun "make oldconfig" I keep seeing things
         like this in my build:
      
      scripts/kconfig/conf --silentoldconfig Kconfig
      include/config/auto.conf:986:warning: symbol value 'm' invalid for BT_SCO
      include/config/auto.conf:3156:warning: symbol value 'm' invalid for BT_L2CAP
      Reported-by: default avatarDavid S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarGustavo F. Padovan <padovan@profusion.mobi>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      d45dcef7
    • John W. Linville's avatar
      f54b92b9
    • John W. Linville's avatar
      at76c50x-usb: fix warning caused by at76_mac80211_tx now returning void · 10889f13
      John W. Linville authored
        CC [M]  drivers/net/wireless/at76c50x-usb.o
      drivers/net/wireless/at76c50x-usb.c: In function ‘at76_mac80211_tx’:
      drivers/net/wireless/at76c50x-usb.c:1759:4: warning: ‘return’ with a value, in function returning void
      
      This is fallout from commit 7bb45683
      ("mac80211: make tx() operation return void").
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      10889f13
  2. 26 Feb, 2011 5 commits
  3. 25 Feb, 2011 14 commits
  4. 24 Feb, 2011 1 commit
    • Johannes Berg's avatar
      rtl8192c: fix compilation errors · 41cae2d0
      Johannes Berg authored
      On my G5 this fails to compile with
      
      drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c:701: error: __ksymtab__rtl92c_phy_txpwr_idx_to_dbm causes a section type conflict
      drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c:701: error: __ksymtab__rtl92c_phy_txpwr_idx_to_dbm causes a section type conflict
      drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c:677: error: __ksymtab__rtl92c_phy_dbm_to_txpwr_Idx causes a section type conflict
      drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c:677: error: __ksymtab__rtl92c_phy_dbm_to_txpwr_Idx causes a section type conflict
      
      since you can't export static functions.
      Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      41cae2d0
  5. 23 Feb, 2011 13 commits