- 19 Oct, 2017 2 commits
-
-
Hannes Reinecke authored
Hitachi USP-V returns 'ILLEGAL FUNCTION' when the internal staging mechanism encountered an error. These errors should not be retried on another path. [mkp: s/invalid/illegal/] Signed-off-by:
Hannes Reinecke <hare@suse.de> Signed-off-by:
Martin K. Petersen <martin.petersen@oracle.com>
-
Kurt Garloff authored
All EMC SYMMETRIX support REPORT_LUNS, even if configured to report SCSI-2 for whatever reason. Signed-off-by:
Kurt Garloff <garloff@suse.de> Signed-off-by:
-
- 18 Oct, 2017 2 commits
-
-
Hannes Reinecke authored
HITACHI is always supporting VPD pages, even though it's claiming to support SCSI Revision 3 only. Signed-off-by:
Hannes Reinecke <hare@suse.com> Signed-off-by:
-
Hannes Reinecke authored
The AIX VDASD devices do support VPD pages, but implement only SPC. So set BLIST_TRY_VPD_PAGES to correctly display the VPD information in sysfs. [mkp: typo] Signed-off-by:
-
- 17 Oct, 2017 28 commits
-
-
weiping zhang authored
/sys/class/scsi_disk/0:2:0:0/manage_start_stop can be changed to 0 unexpectly by writing an invalid string. Signed-off-by:
weiping zhang <zhangweiping@didichuxing.com> Signed-off-by:
-
weiping zhang authored
/sys/class/scsi_disk/0:2:0:0/allow_restart can be changed to 0 unexpectedly by writing an invalid string such as the following: echo asdf > /sys/class/scsi_disk/0:2:0:0/allow_restart Signed-off-by:
-
Hannes Reinecke authored
When checking the model and vendor string we need to use the minimum value of either string, otherwise we'll miss out on wildcard matches. And we should take care when matching with zero size strings; results might be unpredictable. With this patch the rules for matching devinfo strings are as follows: - Vendor strings must match exactly - Empty Model strings will only match if the devinfo model is also empty - Model strings shorter than the devinfo model string will not match Fixes: 5e7ff2ca ("SCSI: fix new bug in scsi_dev_info_list string matching") Signed-off-by:
Alan Stern <stern@rowland.harvard.edu> Reviewed-by:
Bart Van Assche <bart.vanassche@wdc.com> Reviewed-by:
Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by:
-
Hannes Reinecke authored
Signed-off-by:
-
Hannes Reinecke authored
Reformat blacklist flags to make the values easier to read and to enhance error checking. Signed-off-by:
-
Hannes Reinecke authored
Each scsi device is scanned according to the found blacklist flags, but this information is never presented to sysfs. This makes it quite hard to figure out if blacklisting worked as expected. With this patch we're exporting an additional attribute 'blacklist' containing the blacklist flags for this device. Signed-off-by:
-
Hannes Reinecke authored
For testing purposes we need to be able to pass in the inquiry vendor and model. Signed-off-by:
Doug Gilbert <dgilbert@interlog.com> Reviewed-by:
-
Damien Le Moal authored
The three values starting at byte 8 of the Zoned Block Device Characteristics VPD page B6h are 32 bits values, not 64bits. So use get_unaligned_be32() to retrieve the values and not get_unaligned_be64() Fixes: 89d94756 ("sd: Implement support for ZBC devices") Cc: <stable@vger.kernel.org> Signed-off-by:
Damien Le Moal <damien.lemoal@wdc.com> Reviewed-by:
Christoph Hellwig <hch@lst.de> Signed-off-by:
-
Damien Le Moal authored
Instead of open coding, use the min() macro to calculate a report zones reply buffer length in sd_zbc_check_zone_size() and the round_up() macro for calculating the number of zones in sd_zbc_setup(). No functional change is introduced by this patch. Signed-off-by:
-
Damien Le Moal authored
Rearrange sd_zbc_setup() to include use_16_for_rw and use_10_for_rw assignments and move the calculation of sdkp->zone_shift together with the assignment of the verified zone_blocks value in sd_zbc_check_zone_size(). No functional change is introduced by this patch. Signed-off-by:
-
Damien Le Moal authored
Fix comments style (use kernel-doc style) and content to clarify some functions. Also fix some functions signature indentation and remove a useless blank line in sd_zbc_read_zones(). No functional change is introduced by this patch. Signed-off-by:
-
Damien Le Moal authored
Move standard macro definitions for the zone types and zone conditions to scsi_proto.h together with the definitions related to the REPORT ZONES command. While at it, define all values in the enums to be clear. Also remove unnecessary includes in sd_zbc.c. No functional change is introduced by this patch. Signed-off-by:
-
Christoph Hellwig authored
Always use bsg_job->reply instead of scsi_req(bsg_job->req)->sense), as they always point to the same memory. Never set scsi_req(bsg_job->req)->result and we'll set that value through bsg_job_done. [mkp: applied by hand, fixed whitespace] Signed-off-by:
Himanshu Madhani <himanshu.madhani@cavium.com> Tested-by:
-
Christoph Hellwig authored
As a user of bsg-lib the SAS transport should not poke into request internals but use the bsg_job fields instead. Signed-off-by:
-
Christoph Hellwig authored
bsg_job_done takes care of updating the scsi_request structure fields. Signed-off-by:
-
Christoph Hellwig authored
We already support 256 or more segments as long as the architecture supports SG chaining (all the ones that matter do), so removed the weird playing with limits from the job handler. Signed-off-by:
-
Christos Gkekas authored
Remove redundant variables in quedi_fw.c that are set but not used. Signed-off-by:
Christos Gkekas <chris.gekas@gmail.com> Acked-by:
Manish Rangankar <Manish.Rangankar@cavium.com> Signed-off-by:
-
Giridhar Malavali authored
Based on the FC4 type, login will proceed to either FCP or FC-NVMe remote ports. Signed-off-by:
Giridhar Malavali <giridhar.malavali@cavium.com> Signed-off-by:
-
Himanshu Madhani authored
In some environments, user can choose to not enable SCSI-MQ but wants to use FC-NVMe feature of the driver. Since driver relies on Q-Pairs to allocate FC-NVMe resources, use existing module parameter to create Q-Pairs when FC-NVMe is enabled. Signed-off-by:
Ewan D. Milne <emilne@redhat.com> Signed-off-by:
-
Himanshu Madhani authored
Signed-off-by:
-
Duane Grigsby authored
If we discovered a topology that is N2N then we will issue a login to the target. If our WWPN is bigger than the target's WWPN then we will initiate login, otherwise we will just wait for the target to initiate login. [mkp: many whitespace errors] Signed-off-by:
Duane Grigsby <duane.grigsby@cavium.com> Signed-off-by:
Michael Hernandez <michael.hernandez@cavium.com> Signed-off-by:
-
Duane Grigsby authored
The MBC_GET_PORT_DATABASE command normally checks the port state information. This patch allows it to save that info in the fcport structure and ignore the check if the query flag is set. [mkp: typo] Signed-off-by:
-
Himanshu Madhani authored
Signed-off-by:
-
Himanshu Madhani authored
[mkp: fixed whitespace] Signed-off-by:
-
Dan Carpenter authored
The ! has higher precedence than the & operation. I've added parenthesis so this works as intended. Fixes: 952c303b ("scsi: lpfc: Ensure io aborts interlocked with the target.") Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Colin Ian King authored
Functions ahc_devlimited_syncrate and ahc_linux_initialize_scsi_bus are declared static in their prototypes but are missing in their definitions, so add the missing static. Cleans up sparse warnings: symbol 'ahc_devlimited_syncrate' was not declared. Should it be static? symbol 'ahc_linux_initialize_scsi_bus' was not declared. Should it be static? Signed-off-by:
Colin Ian King <colin.king@canonical.com> Reviewed-by:
-
Arnd Bergmann authored
gcc-8 points out a logic error that has existed since the start of the git history: drivers/scsi/nsp32.c: In function 'nsp32_selection_autoscsi': drivers/scsi/nsp32.c:607:27: error: bitwise comparison always evaluates to false [-Werror=tautological-compare] if(((phase & BUSMON_BSY) == 1) || (phase & BUSMON_SEL) == 1) { ^~ Presumably the author intended to check if one of two bits was set, so that's what I'm changing the code to. This will obviously change the behavior of the code, hopefully to do the right thing, but I have not tested this or checked if the new "(phase & BUSMON_BSY) || (phase & BUSMON_SEL)" condition should indeed be treated as a fatal error. Signed-off-by:Arnd Bergmann <arnd@arndb.de> Acked-by:
GOTO Masanori <gotom@debian.or.jp> Signed-off-by:
-
Dan Carpenter authored
We could allocate less memory than intended because we do: bfad->regdata = kzalloc(len << 2, GFP_KERNEL); The shift can overflow leading to a crash. This is debugfs code so the impact is very small. I fixed the network version of this in March with commit 13e2d518 ("bna: integer overflow bug in debugfs"). Fixes: ab2a9ba1 ("[SCSI] bfa: add debugfs support") Signed-off-by:
-
- 11 Oct, 2017 8 commits
-
-
Varun Prakash authored
In case of mgmt cmds, task->hdr is dereferenced after transmitting the pdu in iscsi_tcp_task_xmit(). To handle this case current code increments the Tx skb reference count and frees the skb in cxgbi_cleanup_task(). In some error cases this results in skb leak. To fix this in case of mgmt cmds, allocate a separate buffer for iSCSI hdr and free this buffer in cxgbi_cleanup_task(). Signed-off-by:
Varun Prakash <varun@chelsio.com> Signed-off-by:
-
Varun Prakash authored
In case of connection reset Tx skb queue can have some skbs which are not transmitted so purge Tx skb queue in release_offload_resources() to avoid skb leak. Signed-off-by:
-
Varun Prakash authored
In case of vlan pass 0 as ifindex to find route instead of passing real_dev ifindex, if we pass real_dev ifindex then ip_route_output_ports() and ip6_route_output() will check for route through real_dev not through vlan interface. Signed-off-by:
-
Randy Dunlap authored
Update the description of 'scsi_logging_level' from 8 4-bit nibbles to the (pre-git) reality of 10 3-bit bitfields. Signed-off-by:
Randy Dunlap <rdunlap@infradead.org> Reviewed-by:
Kyle Fortin <kyle.fortin@oracle.com> Reviewed-by:
Steffen Maier <maier@linux.vnet.ibm.com> Signed-off-by:
-
Randy Dunlap authored
Fix typo: I20 should be I2O. Signed-off-by:
-
Jitendra Bhivare authored
Version 11.4.0.1 Signed-off-by:
Jitendra Bhivare <jitendra.bhivare@broadcom.com> Signed-off-by:
-
Jitendra Bhivare authored
Signed-off-by:
-
Jitendra Bhivare authored
The patch fixes errors reported by tools like smatch: - removes unused structure fields - removes dead code - fixes code identation Signed-off-by:
-
