1. 20 Jul, 2024 3 commits
    • Jason-JH.Lin's avatar
      mailbox: mtk-cmdq: Move devm_mbox_controller_register() after devm_pm_runtime_enable() · a8bd68e4
      Jason-JH.Lin authored
      When mtk-cmdq unbinds, a WARN_ON message with condition
      pm_runtime_get_sync() < 0 occurs.
      
      According to the call tracei below:
        cmdq_mbox_shutdown
        mbox_free_channel
        mbox_controller_unregister
        __devm_mbox_controller_unregister
        ...
      
      The root cause can be deduced to be calling pm_runtime_get_sync() after
      calling pm_runtime_disable() as observed below:
      1. CMDQ driver uses devm_mbox_controller_register() in cmdq_probe()
         to bind the cmdq device to the mbox_controller, so
         devm_mbox_controller_unregister() will automatically unregister
         the device bound to the mailbox controller when the device-managed
         resource is removed. That means devm_mbox_controller_unregister()
         and cmdq_mbox_shoutdown() will be called after cmdq_remove().
      2. CMDQ driver also uses devm_pm_runtime_enable() in cmdq_probe() after
         devm_mbox_controller_register(), so that devm_pm_runtime_disable()
         will be called after cmdq_remove(), but before
         devm_mbox_controller_unregister().
      
      To fix this problem, cmdq_probe() needs to move
      devm_mbox_controller_register() after devm_pm_runtime_enable() to make
      devm_pm_runtime_disable() be called after
      devm_mbox_controller_unregister().
      
      Fixes: 623a6143 ("mailbox: mediatek: Add Mediatek CMDQ driver")
      Signed-off-by: default avatarJason-JH.Lin <jason-jh.lin@mediatek.com>
      Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
      Signed-off-by: default avatarJassi Brar <jassisinghbrar@gmail.com>
      a8bd68e4
    • Ben Levinsky's avatar
      mailbox: zynqmp-ipi: Make polling period configurable · 0e3bb6ee
      Ben Levinsky authored
      There are cases where remote that is acking mailbox message can take longer
      than the default tx_poll_period value. Therefore, enable this to be mutable.
      
      Added tx_poll_period field while inserting the module to set the
      poll period for ack after sending mailbox message.
      Signed-off-by: default avatarBen Levinsky <ben.levinsky@amd.com>
      Acked-by: default avatarMichal Simek <michal.simek@amd.com>
      Signed-off-by: default avatarJassi Brar <jassisinghbrar@gmail.com>
      0e3bb6ee
    • Arnd Bergmann's avatar
      mailbox: qcom-cpucp: fix 64BIT dependency · cbf50095
      Arnd Bergmann authored
      This newly added driver fails compile testing on 32-bit architectures
      because it relies on 64-bit MMIO register access:
      
      drivers/mailbox/qcom-cpucp-mbox.c: In function 'qcom_cpucp_mbox_irq_fn':
      drivers/mailbox/qcom-cpucp-mbox.c:54:18: error: implicit declaration of function 'readq'; did you mean 'readb'? [-Wimplicit-function-declaration]
         54 |         status = readq(cpucp->rx_base + APSS_CPUCP_RX_MBOX_STAT);
            |                  ^~~~~
            |                  readb
      drivers/mailbox/qcom-cpucp-mbox.c:65:17: error: implicit declaration of function 'writeq'; did you mean 'writeb'? [-Wimplicit-function-declaration]
         65 |                 writeq(BIT(i), cpucp->rx_base + APSS_CPUCP_RX_MBOX_CLEAR);
            |                 ^~~~~~
            |                 writeb
      
      Change the Kconfig dependency to disallow that configuration as well.
      
      Fixes: 0e2a9a03 ("mailbox: Add support for QTI CPUCP mailbox controller")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
      Signed-off-by: default avatarJassi Brar <jassisinghbrar@gmail.com>
      cbf50095
  2. 10 Jul, 2024 11 commits
  3. 07 Jul, 2024 3 commits
    • Linus Torvalds's avatar
      Linux 6.10-rc7 · 256abd8e
      Linus Torvalds authored
      256abd8e
    • Linus Torvalds's avatar
      Merge tag 'clk-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux · 5a4bd506
      Linus Torvalds authored
      Pull clk fixes from Stephen Boyd:
       "A set of clk fixes for the Qualcomm, Mediatek, and Allwinner drivers:
      
         - Fix the Qualcomm Stromer Plus PLL set_rate() clk_op to explicitly
           set the alpha enable bit and not set bits that don't exist
      
         - Mark Qualcomm IPQ9574 crypto clks as voted to avoid stuck clk
           warnings
      
         - Fix the parent of some PLLs on Qualcomm sm6530 so their rate is
           correct
      
         - Fix the min/max rate clamping logic in the Allwinner driver that
           got broken in v6.9
      
         - Limit runtime PM enabling in the Mediatek driver to only
           mt8183-mfgcfg so that system wide resume doesn't break on other
           Mediatek SoCs"
      
      * tag 'clk-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux:
        clk: mediatek: mt8183: Only enable runtime PM on mt8183-mfgcfg
        clk: sunxi-ng: common: Don't call hw_to_ccu_common on hw without common
        clk: qcom: gcc-ipq9574: Add BRANCH_HALT_VOTED flag
        clk: qcom: apss-ipq-pll: remove 'config_ctl_hi_val' from Stromer pll configs
        clk: qcom: clk-alpha-pll: set ALPHA_EN bit for Stromer Plus PLLs
        clk: qcom: gcc-sm6350: Fix gpll6* & gpll7 parents
      5a4bd506
    • Linus Torvalds's avatar
      Merge tag 'powerpc-6.10-4' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux · c6653f49
      Linus Torvalds authored
      Pull powerpc fixes from Michael Ellerman:
      
       - Fix unnecessary copy to 0 when kernel is booted at address 0
      
       - Fix usercopy crash when dumping dtl via debugfs
      
       - Avoid possible crash when PCI hotplug races with error handling
      
       - Fix kexec crash caused by scv being disabled before other CPUs
         call-in
      
       - Fix powerpc selftests build with USERCFLAGS set
      
      Thanks to Anjali K, Ganesh Goudar, Gautam Menghani, Jinglin Wen,
      Nicholas Piggin, Sourabh Jain, Srikar Dronamraju, and Vishal Chourasia.
      
      * tag 'powerpc-6.10-4' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux:
        selftests/powerpc: Fix build with USERCFLAGS set
        powerpc/pseries: Fix scv instruction crash with kexec
        powerpc/eeh: avoid possible crash when edev->pdev changes
        powerpc/pseries: Whitelist dtl slub object for copying to userspace
        powerpc/64s: Fix unnecessary copy to 0 when kernel is booted at address 0
      c6653f49
  4. 06 Jul, 2024 3 commits
    • Linus Torvalds's avatar
      Merge tag '6.10-rc6-smb3-client-fix' of git://git.samba.org/sfrench/cifs-2.6 · 256fdd4b
      Linus Torvalds authored
      Pull smb client fix from Steve French:
       "Fix for smb3 readahead performance regression"
      
      * tag '6.10-rc6-smb3-client-fix' of git://git.samba.org/sfrench/cifs-2.6:
        cifs: Fix read-performance regression by dropping readahead expansion
      256fdd4b
    • Linus Torvalds's avatar
      Merge tag 'i2c-for-6.10-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux · 22f902df
      Linus Torvalds authored
      Pull i2c fix from Wolfram Sang:
       "An i2c driver fix"
      
      * tag 'i2c-for-6.10-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux:
        i2c: pnx: Fix potential deadlock warning from del_timer_sync() call in isr
      22f902df
    • Michael Ellerman's avatar
      selftests/powerpc: Fix build with USERCFLAGS set · 8b7f59de
      Michael Ellerman authored
      Currently building the powerpc selftests with USERCFLAGS set to anything
      causes the build to break:
      
        $ make -C tools/testing/selftests/powerpc V=1 USERCFLAGS=-Wno-error
        ...
        gcc -Wno-error    cache_shape.c ...
        cache_shape.c:18:10: fatal error: utils.h: No such file or directory
           18 | #include "utils.h"
              |          ^~~~~~~~~
        compilation terminated.
      
      This happens because the USERCFLAGS are added to CFLAGS in lib.mk, which
      causes the check of CFLAGS in powerpc/flags.mk to skip setting CFLAGS at
      all, resulting in none of the usual CFLAGS being passed. That can
      be seen in the output above, the only flag passed to the compiler is
      -Wno-error.
      
      Fix it by dropping the conditional setting of CFLAGS in flags.mk.
      Instead always set CFLAGS, but also append USERCFLAGS if they are set.
      
      Note that appending to CFLAGS (with +=) wouldn't work, because flags.mk
      is included by multiple Makefiles (to support partial builds), causing
      CFLAGS to be appended to multiple times. Additionally that would place
      the USERCFLAGS prior to the standard CFLAGS, meaning the USERCFLAGS
      couldn't override the standard flags. Being able to override the
      standard flags is desirable, for example for adding -Wno-error.
      
      With the fix in place, the CFLAGS are set correctly, including the
      USERCFLAGS:
      
        $ make -C tools/testing/selftests/powerpc V=1 USERCFLAGS=-Wno-error
        ...
        gcc -std=gnu99 -O2 -Wall -Werror -DGIT_VERSION='"v6.10-rc2-7-gdea17e7e56c3"'
        -I/home/michael/linux/tools/testing/selftests/powerpc/include -Wno-error
        cache_shape.c ...
      
      Fixes: 5553a793 ("selftests/powerpc: Add flags.mk to support pmu buildable")
      Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
      Link: https://msgid.link/20240706120833.909853-1-mpe@ellerman.id.au
      8b7f59de
  5. 05 Jul, 2024 11 commits
  6. 04 Jul, 2024 9 commits