Commits · a9422fd40410842b51496a00297ab1dabde57af0 · Kirill Smelkov / linux

08 May, 2024 40 commits

bcachefs: kill bch2_dev_bkey_exists() in bkey_pick_read_device() · a9422fd4
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
a9422fd4
bcachefs: pass bch_dev to read_from_stale_dirty_pointer() · db39a35d
Kent Overstreet authored May 01, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
db39a35d
bcachefs: bch2_dev_bucket_exists() uses bch2_dev_rcu() · 78e9b548
Kent Overstreet authored May 01, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
78e9b548
bcachefs: kill bch2_dev_bkey_exists() in btree_gc.c · ad897d24
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
ad897d24
bcachefs: bch2_extent_normalize() -> bch2_dev_rcu() · 9cadb4ea
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
9cadb4ea
bcachefs: bch2_bkey_has_target() -> bch2_dev_rcu() · 8e3cc200
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
8e3cc200
bcachefs: extent_ptr_invalid() -> bch2_dev_rcu() · 8feecbed
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
8feecbed
bcachefs: ptr_stale() -> dev_ptr_stale() · 3858aa42
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
3858aa42
bcachefs: extent_ptr_durability() -> bch2_dev_rcu() · 302c980a
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
302c980a
bcachefs: bch2_extent_merge() -> bch2_dev_rcu() · 3793b3f9
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
3793b3f9
bcachefs: ec_validate_checksums() -> bch2_dev_tryget() · c387d844
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
c387d844

Kent Overstreet authored Apr 30, 2024

Wrapper around bch2_dev_have_ref() for open_buckets; we do guarantee
that the device an open_bucket points to exists.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

8783856a

bcachefs: move replica_set from bch_dev to bch_fs · dbd04080

Kent Overstreet authored Apr 30, 2024

This is needed for the next patch - the write submit path has to be able
to allocate a replica bio even when we weren't able to get a ref on the
device.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

dbd04080

bcachefs: Kill bch2_dev_bkey_exists() in backpointer code · 633cf069
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
633cf069
bcachefs: PTR_BUCKET_POS() now takes bch_dev · 1f2f92ec
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
1f2f92ec

bcachefs: bch2_dev_iterate() · fa6cce09

Kent Overstreet authored Apr 30, 2024

New helper for getting refs to devices as we iterate.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

fa6cce09

bcachefs: bch2_evacuate_bucket() -> bch2_dev_tryget() · cb4d340a
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
cb4d340a
bcachefs: bch2_bucket_ref_update() now takes bch_dev · 07d7c4da
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
07d7c4da
bcachefs: bch2_trigger_alloc() -> bch2_dev_tryget() · a7f1c26f
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
a7f1c26f
bcachefs: bch2_check_alloc_key() -> bch2_dev_tryget_noerror() · 9b3059a1
Kent Overstreet authored Apr 30, 2024
```
More elimination of bch2_dev_bkey_exists() usage.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
9b3059a1
bcachefs: Convert to bch2_dev_tryget_noerror() · 4cd91e2f
Kent Overstreet authored May 03, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
4cd91e2f

bcachefs: bch2_dev_tryget() · b07eb825

Kent Overstreet authored Apr 30, 2024

Most uses of bch2_dev_bkey_exists() are going away, where we assume that
because a key references a device the device most exist - instead, we'll
be explicitly checking if the device exists and getting a reference to
it.

This adds the new helpers.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

b07eb825

bcachefs: bch2_have_enough_devs() checks for nonexistent device · 6349b07c
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
6349b07c
bcachefs: journal_replay_entry_early() checks for nonexistent device · adf81796
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
adf81796
bcachefs: bch2_dev_btree_bitmap_marked() -> bch2_dev_rcu() · 13a16dab
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
13a16dab

bcachefs: Pass device to bch2_bucket_do_index() · 267039d0

Kent Overstreet authored Apr 30, 2024

Eliminating bch2_dev_bkey_exists() uses and replacing them with proper
checks; this one was unnecessary since the caller already has it.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

267039d0

bcachefs: Pass device to bch2_alloc_write_key() · f5faf43f
Kent Overstreet authored Apr 30, 2024
```
More elimating bch2_dev_bkey_exists()
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
f5faf43f
bcachefs: bch2_dev_safe() -> bch2_dev_rcu() · 23f308ae
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
23f308ae
bcachefs: Debug asserts for ca->ref · 552aa548
Kent Overstreet authored May 03, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
552aa548

bcachefs: New helpers for device refcounts · f295298b

Kent Overstreet authored May 03, 2024

This will be used in the next patch for adding some new debug mode
asserts.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

f295298b

bcachefs: bch2_print_allocator_stuck() · e98786ea

Kent Overstreet authored May 03, 2024

If we block on the allocator for more than 10 seconds, print out some
useful debugging info.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

e98786ea

closures: closure_sync_timeout() · 4c5b7294

Kent Overstreet authored May 03, 2024

Add a new variant of closure_sync_timeout() that takes a timeout.

Note that when this returns -ETIME the closure will still be waiting on
something, i.e. it's not safe to return if you've got a stack allocated
closure.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

4c5b7294

bcachefs: bch2_bkey_drop_ptrs() declares loop iter · 9a768ab7
Kent Overstreet authored May 01, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
9a768ab7
bcachefs: x-macroize journal flags enums · b895c703
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
b895c703

bcachefs: On device add, prefer unused slots · 3a718c06

Kent Overstreet authored Apr 30, 2024

We can't strictly guarantee that no pointers refer to nonexistent
devices - we attempt to, but we need to be safe when the filesystem is
corrupt.

Therefore, change device_add to try to pick a slot that's never been
used, or the slot that's been unused the longest.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

3a718c06

bcachefs: Kill opts.buckets_nouse · ffcbec60

Kent Overstreet authored Apr 06, 2024

Now explicitly allocate and free the buckets_nouse bitmap - this is
going to be used for online fsck.

To go RW when we haven't check allocations, we'll do a much slimmed down
version that just initializes the buckets_nouse bitmaps.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

ffcbec60

bcachefs: CodingStyle · 706833db
Kent Overstreet authored Apr 29, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
706833db
bcachefs: simplify bch2_trans_start_alloc_update() · abe2f470
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
abe2f470
bcachefs: __mark_stripe_bucket() now takes bch_alloc_v4 · 0acf2169
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
0acf2169
bcachefs: __mark_pointer now takes bch_alloc_v4 · be11ae16
Kent Overstreet authored Apr 30, 2024
```
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
```
be11ae16