1. 28 Jul, 2024 14 commits
    • Masahiro Yamada's avatar
      rust: fix the default format for CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT · aacf93e8
      Masahiro Yamada authored
      Another oddity in these config entries is their default value can fall
      back to 'n', which is a value for bool or tristate symbols.
      
      The '|| echo n' is an incorrect workaround to avoid the syntax error.
      This is not a big deal, as the entry is hidden by 'depends on RUST' in
      situations where '$(RUSTC) --version' or '$(BINDGEN) --version' fails.
      Anyway, it looks odd.
      
      The default of a string type symbol should be a double-quoted string
      literal. Turn it into an empty string when the version command fails.
      
      Fixes: 2f7ab126 ("Kbuild: add Rust support")
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      Link: https://lore.kernel.org/r/20240727140302.1806011-2-masahiroy@kernel.org
      [ Rebased on top of v6.11-rc1. - Miguel ]
      Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
      aacf93e8
    • Masahiro Yamada's avatar
      rust: suppress error messages from CONFIG_{RUSTC,BINDGEN}_VERSION_TEXT · 5ce86c6c
      Masahiro Yamada authored
      While this is a somewhat unusual case, I encountered odd error messages
      when I ran Kconfig in a foreign architecture chroot.
      
        $ make allmodconfig
        sh: 1: rustc: not found
        sh: 1: bindgen: not found
        #
        # configuration written to .config
        #
      
      The successful execution of 'command -v rustc' does not necessarily mean
      that 'rustc --version' will succeed.
      
        $ sh -c 'command -v rustc'
        /home/masahiro/.cargo/bin/rustc
        $ sh -c 'rustc --version'
        sh: 1: rustc: not found
      
      Here, 'rustc' is built for x86, and I ran it in an arm64 system.
      
      The current code:
      
        command -v $(RUSTC) >/dev/null 2>&1 && $(RUSTC) --version || echo n
      
      can be turned into:
      
        command -v $(RUSTC) >/dev/null 2>&1 && $(RUSTC) --version 2>/dev/null || echo n
      
      However, I did not understand the necessity of 'command -v $(RUSTC)'.
      
      I simplified it to:
      
        $(RUSTC) --version 2>/dev/null || echo n
      
      Fixes: 2f7ab126 ("Kbuild: add Rust support")
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      Link: https://lore.kernel.org/r/20240727140302.1806011-1-masahiroy@kernel.org
      [ Rebased on top of v6.11-rc1. - Miguel ]
      Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
      5ce86c6c
    • Linus Torvalds's avatar
      Linux 6.11-rc1 · 8400291e
      Linus Torvalds authored
      8400291e
    • Linus Torvalds's avatar
      Merge tag 'kbuild-fixes-v6.11' of... · a0c04bd5
      Linus Torvalds authored
      Merge tag 'kbuild-fixes-v6.11' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
      
      Pull Kbuild fixes from Masahiro Yamada:
      
       - Fix RPM package build error caused by an incorrect locale setup
      
       - Mark modules.weakdep as ghost in RPM package
      
       - Fix the odd combination of -S and -c in stack protector scripts,
         which is an error with the latest Clang
      
      * tag 'kbuild-fixes-v6.11' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild:
        kbuild: Fix '-S -c' in x86 stack protector scripts
        kbuild: rpm-pkg: ghost modules.weakdep file
        kbuild: rpm-pkg: Fix C locale setup
      a0c04bd5
    • Linus Torvalds's avatar
      minmax: simplify and clarify min_t()/max_t() implementation · 017fa3e8
      Linus Torvalds authored
      This simplifies the min_t() and max_t() macros by no longer making them
      work in the context of a C constant expression.
      
      That means that you can no longer use them for static initializers or
      for array sizes in type definitions, but there were only a couple of
      such uses, and all of them were converted (famous last words) to use
      MIN_T/MAX_T instead.
      
      Cc: David Laight <David.Laight@aculab.com>
      Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      017fa3e8
    • Linus Torvalds's avatar
      minmax: add a few more MIN_T/MAX_T users · 4477b39c
      Linus Torvalds authored
      Commit 3a7e02c0 ("minmax: avoid overly complicated constant
      expressions in VM code") added the simpler MIN_T/MAX_T macros in order
      to avoid some excessive expansion from the rather complicated regular
      min/max macros.
      
      The complexity of those macros stems from two issues:
      
       (a) trying to use them in situations that require a C constant
           expression (in static initializers and for array sizes)
      
       (b) the type sanity checking
      
      and MIN_T/MAX_T avoids both of these issues.
      
      Now, in the whole (long) discussion about all this, it was pointed out
      that the whole type sanity checking is entirely unnecessary for
      min_t/max_t which get a fixed type that the comparison is done in.
      
      But that still leaves min_t/max_t unnecessarily complicated due to
      worries about the C constant expression case.
      
      However, it turns out that there really aren't very many cases that use
      min_t/max_t for this, and we can just force-convert those.
      
      This does exactly that.
      
      Which in turn will then allow for much simpler implementations of
      min_t()/max_t().  All the usual "macros in all upper case will evaluate
      the arguments multiple times" rules apply.
      
      We should do all the same things for the regular min/max() vs MIN/MAX()
      cases, but that has the added complexity of various drivers defining
      their own local versions of MIN/MAX, so that needs another level of
      fixes first.
      
      Link: https://lore.kernel.org/all/b47fad1d0cf8449886ad148f8c013dae@AcuMS.aculab.com/
      Cc: David Laight <David.Laight@aculab.com>
      Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      4477b39c
    • Linus Torvalds's avatar
      Merge tag 'ubifs-for-linus-6.11-rc1-take2' of... · 7e2d0ba7
      Linus Torvalds authored
      Merge tag 'ubifs-for-linus-6.11-rc1-take2' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs
      
      Pull UBI and UBIFS updates from Richard Weinberger:
      
       - Many fixes for power-cut issues by Zhihao Cheng
      
       - Another ubiblock error path fix
      
       - ubiblock section mismatch fix
      
       - Misc fixes all over the place
      
      * tag 'ubifs-for-linus-6.11-rc1-take2' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/ubifs:
        ubi: Fix ubi_init() ubiblock_exit() section mismatch
        ubifs: add check for crypto_shash_tfm_digest
        ubifs: Fix inconsistent inode size when powercut happens during appendant writing
        ubi: block: fix null-pointer-dereference in ubiblock_create()
        ubifs: fix kernel-doc warnings
        ubifs: correct UBIFS_DFS_DIR_LEN macro definition and improve code clarity
        mtd: ubi: Restore missing cleanup on ubi_init() failure path
        ubifs: dbg_orphan_check: Fix missed key type checking
        ubifs: Fix unattached inode when powercut happens in creating
        ubifs: Fix space leak when powercut happens in linking tmpfile
        ubifs: Move ui->data initialization after initializing security
        ubifs: Fix adding orphan entry twice for the same inode
        ubifs: Remove insert_dead_orphan from replaying orphan process
        Revert "ubifs: ubifs_symlink: Fix memleak of inode->i_link in error path"
        ubifs: Don't add xattr inode into orphan area
        ubifs: Fix unattached xattr inode if powercut happens after deleting
        mtd: ubi: avoid expensive do_div() on 32-bit machines
        mtd: ubi: make ubi_class constant
        ubi: eba: properly rollback inside self_check_eba
      7e2d0ba7
    • Nathan Chancellor's avatar
      kbuild: Fix '-S -c' in x86 stack protector scripts · 3415b10a
      Nathan Chancellor authored
      After a recent change in clang to stop consuming all instances of '-S'
      and '-c' [1], the stack protector scripts break due to the kernel's use
      of -Werror=unused-command-line-argument to catch cases where flags are
      not being properly consumed by the compiler driver:
      
        $ echo | clang -o - -x c - -S -c -Werror=unused-command-line-argument
        clang: error: argument unused during compilation: '-c' [-Werror,-Wunused-command-line-argument]
      
      This results in CONFIG_STACKPROTECTOR getting disabled because
      CONFIG_CC_HAS_SANE_STACKPROTECTOR is no longer set.
      
      '-c' and '-S' both instruct the compiler to stop at different stages of
      the pipeline ('-S' after compiling, '-c' after assembling), so having
      them present together in the same command makes little sense. In this
      case, the test wants to stop before assembling because it is looking at
      the textual assembly output of the compiler for either '%fs' or '%gs',
      so remove '-c' from the list of arguments to resolve the error.
      
      All versions of GCC continue to work after this change, along with
      versions of clang that do or do not contain the change mentioned above.
      
      Cc: stable@vger.kernel.org
      Fixes: 4f7fd4d7 ("[PATCH] Add the -fstack-protector option to the CFLAGS")
      Fixes: 60a5317f ("x86: implement x86_32 stack protector")
      Link: https://github.com/llvm/llvm-project/commit/6461e537815f7fa68cef06842505353cf5600e9c [1]
      Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      3415b10a
    • Richard Weinberger's avatar
      ubi: Fix ubi_init() ubiblock_exit() section mismatch · 92a286e9
      Richard Weinberger authored
      Since ubiblock_exit() is now called from an init function,
      the __exit section no longer makes sense.
      
      Cc: Ben Hutchings <bwh@kernel.org>
      Reported-by: default avatarkernel test robot <lkp@intel.com>
      Closes: https://lore.kernel.org/oe-kbuild-all/202407131403.wZJpd8n2-lkp@intel.com/Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
      Reviewed-by: default avatarZhihao Cheng <chengzhihao1@huawei.com>
      92a286e9
    • Linus Torvalds's avatar
      Merge tag 'v6.11-merge' of git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux · e172f1e9
      Linus Torvalds authored
      Pull turbostat updates from Len Brown:
      
       - Enable turbostat extensions to add both perf and PMT (Intel
         Platform Monitoring Technology) counters via the cmdline
      
       - Demonstrate PMT access with built-in support for Meteor Lake's
         Die C6 counter
      
      * tag 'v6.11-merge' of git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux:
        tools/power turbostat: version 2024.07.26
        tools/power turbostat: Include umask=%x in perf counter's config
        tools/power turbostat: Document PMT in turbostat.8
        tools/power turbostat: Add MTL's PMT DC6 builtin counter
        tools/power turbostat: Add early support for PMT counters
        tools/power turbostat: Add selftests for added perf counters
        tools/power turbostat: Add selftests for SMI, APERF and MPERF counters
        tools/power turbostat: Move verbose counter messages to level 2
        tools/power turbostat: Move debug prints from stdout to stderr
        tools/power turbostat: Fix typo in turbostat.8
        tools/power turbostat: Add perf added counter example to turbostat.8
        tools/power turbostat: Fix formatting in turbostat.8
        tools/power turbostat: Extend --add option with perf counters
        tools/power turbostat: Group SMI counter with APERF and MPERF
        tools/power turbostat: Add ZERO_ARRAY for zero initializing builtin array
        tools/power turbostat: Replace enum rapl_source and cstate_source with counter_source
        tools/power turbostat: Remove anonymous union from rapl_counter_info_t
        tools/power/turbostat: Switch to new Intel CPU model defines
      e172f1e9
    • Linus Torvalds's avatar
      Merge tag 'cxl-for-6.11' of git://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl · e62f81bb
      Linus Torvalds authored
      Pull CXL updates from Dave Jiang:
       "Core:
      
         - A CXL maturity map has been added to the documentation to detail
           the current state of CXL enabling.
      
           It provides the status of the current state of various CXL features
           to inform current and future contributors of where things are and
           which areas need contribution.
      
         - A notifier handler has been added in order for a newly created CXL
           memory region to trigger the abstract distance metrics calculation.
      
           This should bring parity for CXL memory to the same level vs
           hotplugged DRAM for NUMA abstract distance calculation. The
           abstract distance reflects relative performance used for memory
           tiering handling.
      
         - An addition for XOR math has been added to address the CXL DPA to
           SPA translation.
      
           CXL address translation did not support address interleave math
           with XOR prior to this change.
      
        Fixes:
      
         - Fix to address race condition in the CXL memory hotplug notifier
      
         - Add missing MODULE_DESCRIPTION() for CXL modules
      
         - Fix incorrect vendor debug UUID define
      
        Misc:
      
         - A warning has been added to inform users of an unsupported
           configuration when mixing CXL VH and RCH/RCD hierarchies
      
         - The ENXIO error code has been replaced with EBUSY for inject poison
           limit reached via debugfs and cxl-test support
      
         - Moving the PCI config read in cxl_dvsec_rr_decode() to avoid
           unnecessary PCI config reads
      
         - A refactor to a common struct for DRAM and general media CXL
           events"
      
      * tag 'cxl-for-6.11' of git://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl:
        cxl/core/pci: Move reading of control register to immediately before usage
        cxl: Remove defunct code calculating host bridge target positions
        cxl/region: Verify target positions using the ordered target list
        cxl: Restore XOR'd position bits during address translation
        cxl/core: Fold cxl_trace_hpa() into cxl_dpa_to_hpa()
        cxl/test: Replace ENXIO with EBUSY for inject poison limit reached
        cxl/memdev: Replace ENXIO with EBUSY for inject poison limit reached
        cxl/acpi: Warn on mixed CXL VH and RCH/RCD Hierarchy
        cxl/core: Fix incorrect vendor debug UUID define
        Documentation: CXL Maturity Map
        cxl/region: Simplify cxl_region_nid()
        cxl/region: Support to calculate memory tier abstract distance
        cxl/region: Fix a race condition in memory hotplug notifier
        cxl: add missing MODULE_DESCRIPTION() macros
        cxl/events: Use a common struct for DRAM and General Media events
      e62f81bb
    • Linus Torvalds's avatar
      Merge tag 'unicode-next-6.11' of git://git.kernel.org/pub/scm/linux/kernel/git/krisman/unicode · 7b5d4818
      Linus Torvalds authored
      Pull unicode update from Gabriel Krisman Bertazi:
       "Two small fixes to silence the compiler and static analyzers tools
        from Ben Dooks and Jeff Johnson"
      
      * tag 'unicode-next-6.11' of git://git.kernel.org/pub/scm/linux/kernel/git/krisman/unicode:
        unicode: add MODULE_DESCRIPTION() macros
        unicode: make utf8 test count static
      7b5d4818
    • Jose Ignacio Tornos Martinez's avatar
      kbuild: rpm-pkg: ghost modules.weakdep file · d01c1407
      Jose Ignacio Tornos Martinez authored
      In the same way as for other similar files, mark as ghost the new file
      generated by depmod for configured weak dependencies for modules,
      modules.weakdep, so that although it is not included in the package,
      claim the ownership on it.
      Signed-off-by: default avatarJose Ignacio Tornos Martinez <jtornosm@redhat.com>
      Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      d01c1407
    • Linus Torvalds's avatar
      Merge tag '6.11-rc-smb-client-fixes-part2' of git://git.samba.org/sfrench/cifs-2.6 · 5437f30d
      Linus Torvalds authored
      Pull more smb client updates from Steve French:
      
       - fix for potential null pointer use in init cifs
      
       - additional dynamic trace points to improve debugging of some common
         scenarios
      
       - two SMB1 fixes (one addressing reconnect with POSIX extensions, one a
         mount parsing error)
      
      * tag '6.11-rc-smb-client-fixes-part2' of git://git.samba.org/sfrench/cifs-2.6:
        smb3: add dynamic trace point for session setup key expired failures
        smb3: add four dynamic tracepoints for copy_file_range and reflink
        smb3: add dynamic tracepoint for reflink errors
        cifs: mount with "unix" mount option for SMB1 incorrectly handled
        cifs: fix reconnect with SMB1 UNIX Extensions
        cifs: fix potential null pointer use in destroy_workqueue in init_cifs error path
      5437f30d
  2. 27 Jul, 2024 24 commits
    • Linus Torvalds's avatar
      Merge tag 'block-6.11-20240726' of git://git.kernel.dk/linux · 6342649c
      Linus Torvalds authored
      Pull block fixes from Jens Axboe:
      
       - NVMe pull request via Keith:
           - Fix request without payloads cleanup  (Leon)
           - Use new protection information format (Francis)
           - Improved debug message for lost pci link (Bart)
           - Another apst quirk (Wang)
           - Use appropriate sysfs api for printing chars (Markus)
      
       - ublk async device deletion fix (Ming)
      
       - drbd kerneldoc fixups (Simon)
      
       - Fix deadlock between sd removal and release (Yang)
      
      * tag 'block-6.11-20240726' of git://git.kernel.dk/linux:
        nvme-pci: add missing condition check for existence of mapped data
        ublk: fix UBLK_CMD_DEL_DEV_ASYNC handling
        block: fix deadlock between sd_remove & sd_release
        drbd: Add peer_device to Kernel doc
        nvme-core: choose PIF from QPIF if QPIFS supports and PIF is QTYPE
        nvme-pci: Fix the instructions for disabling power management
        nvme: remove redundant bdev local variable
        nvme-fabrics: Use seq_putc() in __nvmf_concat_opt_tokens()
        nvme/pci: Add APST quirk for Lenovo N60z laptop
      6342649c
    • Linus Torvalds's avatar
      Merge tag 'io_uring-6.11-20240726' of git://git.kernel.dk/linux · 8c930747
      Linus Torvalds authored
      Pull io_uring fixes from Jens Axboe:
      
       - Fix a syzbot issue for the msg ring cache added in this release. No
         ill effects from this one, but it did make KMSAN unhappy (me)
      
       - Sanitize the NAPI timeout handling, by unifying the value handling
         into all ktime_t rather than converting back and forth (Pavel)
      
       - Fail NAPI registration for IOPOLL rings, it's not supported (Pavel)
      
       - Fix a theoretical issue with ring polling and cancelations (Pavel)
      
       - Various little cleanups and fixes (Pavel)
      
      * tag 'io_uring-6.11-20240726' of git://git.kernel.dk/linux:
        io_uring/napi: pass ktime to io_napi_adjust_timeout
        io_uring/napi: use ktime in busy polling
        io_uring/msg_ring: fix uninitialized use of target_req->flags
        io_uring: align iowq and task request error handling
        io_uring: kill REQ_F_CANCEL_SEQ
        io_uring: simplify io_uring_cmd return
        io_uring: fix io_match_task must_hold
        io_uring: don't allow netpolling with SETUP_IOPOLL
        io_uring: tighten task exit cancellations
      8c930747
    • Linus Torvalds's avatar
      Merge tag 'vfs-6.11-rc1.fixes.3' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs · bc4eee85
      Linus Torvalds authored
      Pull vfs fixes from Christian Brauner:
       "This contains two fixes for this merge window:
      
        VFS:
      
         - I noticed that it is possible for a privileged user to mount most
           filesystems with a non-initial user namespace in sb->s_user_ns.
      
           When fsopen() is called in a non-init namespace the caller's
           namespace is recorded in fs_context->user_ns. If the returned file
           descriptor is then passed to a process privileged in init_user_ns,
           that process can call fsconfig(fd_fs, FSCONFIG_CMD_CREATE*),
           creating a new superblock with sb->s_user_ns set to the namespace
           of the process which called fsopen().
      
           This is problematic as only filesystems that raise FS_USERNS_MOUNT
           are known to be able to support a non-initial s_user_ns. Others may
           suffer security issues, on-disk corruption or outright crash the
           kernel. Prevent that by restricting such delegation to filesystems
           that allow FS_USERNS_MOUNT.
      
           Note, that this delegation requires a privileged process to
           actually create the superblock so either the privileged process is
           cooperaing or someone must have tricked a privileged process into
           operating on a fscontext file descriptor whose origin it doesn't
           know (a stupid idea).
      
           The bug dates back to about 5 years afaict.
      
        Misc:
      
         - Fix hostfs parsing when the mount request comes in via the legacy
           mount api.
      
           In the legacy mount api hostfs allows to specify the host directory
           mount without any key.
      
           Restore that behavior"
      
      * tag 'vfs-6.11-rc1.fixes.3' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs:
        hostfs: fix the host directory parse when mounting.
        fs: don't allow non-init s_user_ns for filesystems without FS_USERNS_MOUNT
      bc4eee85
    • Linus Torvalds's avatar
      Merge tag 'rust-6.11' of https://github.com/Rust-for-Linux/linux · 910bfc26
      Linus Torvalds authored
      Pull Rust updates from Miguel Ojeda:
       "The highlight is the establishment of a minimum version for the Rust
        toolchain, including 'rustc' (and bundled tools) and 'bindgen'.
      
        The initial minimum will be the pinned version we currently have, i.e.
        we are just widening the allowed versions. That covers three stable
        Rust releases: 1.78.0, 1.79.0, 1.80.0 (getting released tomorrow),
        plus beta, plus nightly.
      
        This should already be enough for kernel developers in distributions
        that provide recent Rust compiler versions routinely, such as Arch
        Linux, Debian Unstable (outside the freeze period), Fedora Linux,
        Gentoo Linux (especially the testing channel), Nix (unstable) and
        openSUSE Slowroll and Tumbleweed.
      
        In addition, the kernel is now being built-tested by Rust's pre-merge
        CI. That is, every change that is attempting to land into the Rust
        compiler is tested against the kernel, and it is merged only if it
        passes. Similarly, the bindgen tool has agreed to build the kernel in
        their CI too.
      
        Thus, with the pre-merge CI in place, both projects hope to avoid
        unintentional changes to Rust that break the kernel. This means that,
        in general, apart from intentional changes on their side (that we will
        need to workaround conditionally on our side), the upcoming Rust
        compiler versions should generally work.
      
        In addition, the Rust project has proposed getting the kernel into
        stable Rust (at least solving the main blockers) as one of its three
        flagship goals for 2024H2 [1].
      
        I would like to thank Niko, Sid, Emilio et al. for their help
        promoting the collaboration between Rust and the kernel.
      
        Toolchain and infrastructure:
      
         - Support several Rust toolchain versions.
      
         - Support several bindgen versions.
      
         - Remove 'cargo' requirement and simplify 'rusttest', thanks to
           'alloc' having been dropped last cycle.
      
         - Provide proper error reporting for the 'rust-analyzer' target.
      
        'kernel' crate:
      
         - Add 'uaccess' module with a safe userspace pointers abstraction.
      
         - Add 'page' module with a 'struct page' abstraction.
      
         - Support more complex generics in workqueue's 'impl_has_work!'
           macro.
      
        'macros' crate:
      
         - Add 'firmware' field support to the 'module!' macro.
      
         - Improve 'module!' macro documentation.
      
        Documentation:
      
         - Provide instructions on what packages should be installed to build
           the kernel in some popular Linux distributions.
      
         - Introduce the new kernel.org LLVM+Rust toolchains.
      
         - Explain '#[no_std]'.
      
        And a few other small bits"
      
      Link: https://rust-lang.github.io/rust-project-goals/2024h2/index.html#flagship-goals [1]
      
      * tag 'rust-6.11' of https://github.com/Rust-for-Linux/linux: (26 commits)
        docs: rust: quick-start: add section on Linux distributions
        rust: warn about `bindgen` versions 0.66.0 and 0.66.1
        rust: start supporting several `bindgen` versions
        rust: work around `bindgen` 0.69.0 issue
        rust: avoid assuming a particular `bindgen` build
        rust: start supporting several compiler versions
        rust: simplify Clippy warning flags set
        rust: relax most deny-level lints to warnings
        rust: allow `dead_code` for never constructed bindings
        rust: init: simplify from `map_err` to `inspect_err`
        rust: macros: indent list item in `paste!`'s docs
        rust: add abstraction for `struct page`
        rust: uaccess: add typed accessors for userspace pointers
        uaccess: always export _copy_[from|to]_user with CONFIG_RUST
        rust: uaccess: add userspace pointers
        kbuild: rust-analyzer: improve comment documentation
        kbuild: rust-analyzer: better error handling
        docs: rust: no_std is used
        rust: alloc: add __GFP_HIGHMEM flag
        rust: alloc: fix typo in docs for GFP_NOWAIT
        ...
      910bfc26
    • Linus Torvalds's avatar
      Merge tag 'apparmor-pr-2024-07-25' of... · ff305644
      Linus Torvalds authored
      Merge tag 'apparmor-pr-2024-07-25' of git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor
      
      Pull apparmor updates from John Johansen:
       "Cleanups
         - optimization: try to avoid refing the label in apparmor_file_open
         - remove useless static inline function is_deleted
         - use kvfree_sensitive to free data->data
         - fix typo in kernel doc
      
        Bug fixes:
         - unpack transition table if dfa is not present
         - test: add MODULE_DESCRIPTION()
         - take nosymfollow flag into account
         - fix possible NULL pointer dereference
         - fix null pointer deref when receiving skb during sock creation"
      
      * tag 'apparmor-pr-2024-07-25' of git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor:
        apparmor: unpack transition table if dfa is not present
        apparmor: try to avoid refing the label in apparmor_file_open
        apparmor: test: add MODULE_DESCRIPTION()
        apparmor: take nosymfollow flag into account
        apparmor: fix possible NULL pointer dereference
        apparmor: fix typo in kernel doc
        apparmor: remove useless static inline function is_deleted
        apparmor: use kvfree_sensitive to free data->data
        apparmor: Fix null pointer deref when receiving skb during sock creation
      ff305644
    • Linus Torvalds's avatar
      Merge tag 'landlock-6.11-rc1-houdini-fix' of... · 86b405ad
      Linus Torvalds authored
      Merge tag 'landlock-6.11-rc1-houdini-fix' of git://git.kernel.org/pub/scm/linux/kernel/git/mic/linux
      
      Pull landlock fix from Mickaël Salaün:
       "Jann Horn reported a sandbox bypass for Landlock. This includes the
        fix and new tests. This should be backported"
      
      * tag 'landlock-6.11-rc1-houdini-fix' of git://git.kernel.org/pub/scm/linux/kernel/git/mic/linux:
        selftests/landlock: Add cred_transfer test
        landlock: Don't lose track of restrictions on cred_transfer
      86b405ad
    • Linus Torvalds's avatar
      Merge tag 'gpio-fixes-for-v6.11-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux · 8e333791
      Linus Torvalds authored
      Pull gpio fix from Bartosz Golaszewski:
      
       - don't use sprintf() with non-constant format string
      
      * tag 'gpio-fixes-for-v6.11-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux:
        gpio: virtuser: avoid non-constant format string
      8e333791
    • Linus Torvalds's avatar
      Merge tag 'devicetree-fixes-for-6.11-1' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux · bf80f139
      Linus Torvalds authored
      Pull more devicetree updates from Rob Herring:
       "Most of this is a treewide change to of_property_for_each_u32() which
        was small enough to do in one go before rc1 and avoids the need to
        create of_property_for_each_u32_some_new_name().
      
         - Treewide conversion of of_property_for_each_u32() to drop internal
           arguments making struct property opaque
      
         - Add binding for Amlogic A4 SoC watchdog
      
         - Fix constraints for AD7192 'single-channel' property"
      
      * tag 'devicetree-fixes-for-6.11-1' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux:
        dt-bindings: iio: adc: ad7192: Fix 'single-channel' constraints
        of: remove internal arguments from of_property_for_each_u32()
        dt-bindings: watchdog: add support for Amlogic A4 SoCs
      bf80f139
    • Linus Torvalds's avatar
      Merge tag 'iommu-fixes-v6.11-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/iommu/linux · b465ed28
      Linus Torvalds authored
      Pull iommu fixes from Will Deacon:
       "We're still resolving a regression with the handling of unexpected
        page faults on SMMUv3, but we're not quite there with a fix yet.
      
         - Fix NULL dereference when freeing domain in Unisoc SPRD driver
      
         - Separate assignment statements with semicolons in AMD page-table
           code
      
         - Fix Tegra erratum workaround when the CPU is using 16KiB pages"
      
      * tag 'iommu-fixes-v6.11-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/iommu/linux:
        iommu: arm-smmu: Fix Tegra workaround for PAGE_SIZE mappings
        iommu/amd: Convert comma to semicolon
        iommu: sprd: Avoid NULL deref in sprd_iommu_hw_en
      b465ed28
    • Linus Torvalds's avatar
      Merge tag 'firewire-fixes-6.11-rc1' of... · 04216211
      Linus Torvalds authored
      Merge tag 'firewire-fixes-6.11-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394
      
      Pull firewire fixes from Takashi Sakamoto:
       "The recent integration of compiler collections introduced the
        technology to check flexible array length at runtime by providing
        proper annotations. In v6.10 kernel, a patch was merged into firewire
        subsystem to utilize it, however the annotation was inadequate.
      
        There is also the related change for the flexible array in sound
        subsystem, but it causes a regression where the data in the payload of
        isochronous packet is incorrect for some devices. These bugs are now
        fixed"
      
      * tag 'firewire-fixes-6.11-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394:
        ALSA: firewire-lib: fix wrong value as length of header for CIP_NO_HEADER case
        Revert "firewire: Annotate struct fw_iso_packet with __counted_by()"
      04216211
    • Linus Torvalds's avatar
      Merge tag 'spi-fix-v6.11-merge-window' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi · ab11658f
      Linus Torvalds authored
      Pull spi fixes from Mark Brown:
       "The bulk of this is a series of fixes for the microchip-core driver
        mostly originating from one of their customers, I also applied an
        additional patch adding support for controlling the word size which
        came along with it since it's still the merge window and clearly had a
        bunch of fairly thorough testing.
      
        We also have a fix for the compatible used to bind spidev to the
        BH2228FV"
      
      * tag 'spi-fix-v6.11-merge-window' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi:
        spi: spidev: add correct compatible for Rohm BH2228FV
        dt-bindings: trivial-devices: fix Rohm BH2228FV compatible string
        spi: microchip-core: add support for word sizes of 1 to 32 bits
        spi: microchip-core: ensure TX and RX FIFOs are empty at start of a transfer
        spi: microchip-core: fix init function not setting the master and motorola modes
        spi: microchip-core: only disable SPI controller when register value change requires it
        spi: microchip-core: defer asserting chip select until just before write to TX FIFO
        spi: microchip-core: fix the issues in the isr
      ab11658f
    • Linus Torvalds's avatar
      Merge tag 'regulator-fix-v6.11-merge-window' of... · 560e8050
      Linus Torvalds authored
      Merge tag 'regulator-fix-v6.11-merge-window' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator
      
      Pull regulator fixes from Mark Brown:
       "These two commits clean up the excessively loose dependencies for the
        RZG2L USB VBCTRL regulator driver, ensuring it shouldn't prompt for
        people who can't use it"
      
      * tag 'regulator-fix-v6.11-merge-window' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator:
        regulator: Further restrict RZG2L USB VBCTRL regulator dependencies
        regulator: renesas-usb-vbus-regulator: Update the default
      560e8050
    • Linus Torvalds's avatar
      Merge tag 'regmap-fix-v6.11-merge-window' of... · 8f3f7598
      Linus Torvalds authored
      Merge tag 'regmap-fix-v6.11-merge-window' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap
      
      Pull regmap fix from Mark Brown:
       "Arnd sent a workaround for a false positive warning which was showing
        up with GCC 14.1"
      
      * tag 'regmap-fix-v6.11-merge-window' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap:
        regmap: maple: work around gcc-14.1 false-positive warning
      8f3f7598
    • Linus Torvalds's avatar
      Merge tag 'clk-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux · de5f4fbe
      Linus Torvalds authored
      Pull clk fixes from Stephen Boyd:
       "A few clk driver fixes for the merge window to fix the build and boot
        on some SoCs.
      
         - Initialize struct clk_init_data in the TI da8xx-cfgchip driver so
           that stack contents aren't used for things like clk flags leading
           to unexpected behavior
      
         - Don't leak stack contents in a debug print in the new Sophgo clk
           driver
      
         - Disable the new T-Head clk driver on 32-bit targets to fix the
           build due to a division
      
         - Fix Samsung Exynos4 fin_pll wreckage from the clkdev rework done
           last cycle by using a struct clk_hw directly instead of a struct
           clk consumer"
      
      * tag 'clk-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux:
        clk: samsung: fix getting Exynos4 fin_pll rate from external clocks
        clk: T-Head: Disable on 32-bit Targets
        clk: sophgo: clk-sg2042-pll: Fix uninitialized variable in debug output
        clk: davinci: da8xx-cfgchip: Initialize clk_init_data before use
      de5f4fbe
    • Linus Torvalds's avatar
      Merge tag 'i3c/for-6.11' of git://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux · c85e1497
      Linus Torvalds authored
      Pull i3c updates from Alexandre Belloni:
       "This cycle, there are new features for the Designware controller and
        fixes for the other IPs:
      
         - dw: optional apb clock and power management support, IBI handling
           fixes
      
         - mipi-i3c-hci: IBI handling fixes
      
         - svc: a few fixes"
      
      * tag 'i3c/for-6.11' of git://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux:
        dt-bindings: i3c: add header for generic I3C flags
        i3c: master: svc: Fix error code in svc_i3c_master_do_daa_locked()
        i3c: master: Enhance i3c_bus_type visibility for device searching & event monitoring
        i3c: dw: Add power management support
        i3c: dw: Add some functions for reusability
        i3c: dw: Save timing registers and other values
        i3c: master: svc: Improve DAA STOP handle code logic
        i3c: dw: Add optional apb clock
        i3c: dw: Use new *_enabled clk API
        dt-bindings: i3c: dw: Add apb clock binding
        i3c: master: svc: Convert comma to semicolon
        i3c: mipi-i3c-hci: Round IBI data chunk size to HW supported value
        i3c: mipi-i3c-hci: Error out instead on BUG_ON() in IBI DMA setup
        i3c: mipi-i3c-hci: Set IBI Status and Data Ring base addresses
        i3c: mipi-i3c-hci: Switch to lower_32_bits()/upper_32_bits() helpers
        i3c: dw: Remove ibi_capable property
        i3c: dw: Fix IBI intr programming
        i3c: dw: Fix clearing queue thld
        i3c: mipi-i3c-hci: Fix number of DAT/DCT entries for HCI versions < 1.1
        i3c: master: svc: resend target address when get NACK
      c85e1497
    • Linus Torvalds's avatar
      Merge tag 'thermal-6.11-rc1-3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · 1fcaa5db
      Linus Torvalds authored
      Pull thermal control fix from Rafael Wysocki:
       "Prevent the thermal core from flooding the kernel log with useless
        messages if thermal zone temperature can never be determined (or its
        sensor has failed permanently) and make it finally give up and disable
        defective thermal zones (Rafael Wysocki)"
      
      * tag 'thermal-6.11-rc1-3' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        thermal: core: Back off when polling thermal zones on errors
        thermal: trip: Split thermal_zone_device_set_mode()
      1fcaa5db
    • Linus Torvalds's avatar
      Merge tag 'mm-hotfixes-stable-2024-07-26-14-33' of... · 7b0acd91
      Linus Torvalds authored
      Merge tag 'mm-hotfixes-stable-2024-07-26-14-33' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
      
      Pull misc hotfixes from Andrew Morton:
       "11 hotfixes, 7 of which are cc:stable.  7 are MM, 4 are other"
      
      * tag 'mm-hotfixes-stable-2024-07-26-14-33' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm:
        nilfs2: handle inconsistent state in nilfs_btnode_create_block()
        selftests/mm: skip test for non-LPA2 and non-LVA systems
        mm/page_alloc: fix pcp->count race between drain_pages_zone() vs __rmqueue_pcplist()
        mm: memcg: add cacheline padding after lruvec in mem_cgroup_per_node
        alloc_tag: outline and export free_reserved_page()
        decompress_bunzip2: fix rare decompression failure
        mm/huge_memory: avoid PMD-size page cache if needed
        mm: huge_memory: use !CONFIG_64BIT to relax huge page alignment on 32 bit machines
        mm: fix old/young bit handling in the faulting path
        dt-bindings: arm: update James Clark's email address
        MAINTAINERS: mailmap: update James Clark's email address
      7b0acd91
    • Linus Torvalds's avatar
      Merge tag 'timers-urgent-2024-07-26' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 5256184b
      Linus Torvalds authored
      Pull timer migration updates from Thomas Gleixner:
       "Fixes and minor updates for the timer migration code:
      
         - Stop testing the group->parent pointer as it is not guaranteed to
           be stable over a chain of operations by design.
      
           This includes a warning which would be nice to have but it produces
           false positives due to the racy nature of the check.
      
         - Plug a race between CPUs going in and out of idle and a CPU hotplug
           operation. The latter can create and connect a new hierarchy level
           which is missed in the concurrent updates of CPUs which go into
           idle. As a result the events of such a CPU might not be processed
           and timers go stale.
      
           Cure it by splitting the hotplug operation into a prepare and
           online callback. The prepare callback is guaranteed to run on an
           online and therefore active CPU. This CPU updates the hierarchy and
           being online ensures that there is always at least one migrator
           active which handles the modified hierarchy correctly when going
           idle. The online callback which runs on the incoming CPU then just
           marks the CPU active and brings it into operation.
      
         - Improve tracing and polish the code further so it is more obvious
           what's going on"
      
      * tag 'timers-urgent-2024-07-26' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        timers/migration: Fix grammar in comment
        timers/migration: Spare write when nothing changed
        timers/migration: Rename childmask by groupmask to make naming more obvious
        timers/migration: Read childmask and parent pointer in a single place
        timers/migration: Use a single struct for hierarchy walk data
        timers/migration: Improve tracing
        timers/migration: Move hierarchy setup into cpuhotplug prepare callback
        timers/migration: Do not rely always on group->parent
      5256184b
    • Linus Torvalds's avatar
      Merge tag 'riscv-for-linus-6.11-mw2' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux · c9f33436
      Linus Torvalds authored
      Pull more RISC-V updates from Palmer Dabbelt:
      
       - Support for NUMA (via SRAT and SLIT), console output (via SPCR), and
         cache info (via PPTT) on ACPI-based systems.
      
       - The trap entry/exit code no longer breaks the return address stack
         predictor on many systems, which results in an improvement to trap
         latency.
      
       - Support for HAVE_ARCH_STACKLEAK.
      
       - The sv39 linear map has been extended to support 128GiB mappings.
      
       - The frequency of the mtime CSR is now visible via hwprobe.
      
      * tag 'riscv-for-linus-6.11-mw2' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux: (21 commits)
        RISC-V: Provide the frequency of time CSR via hwprobe
        riscv: Extend sv39 linear mapping max size to 128G
        riscv: enable HAVE_ARCH_STACKLEAK
        riscv: signal: Remove unlikely() from WARN_ON() condition
        riscv: Improve exception and system call latency
        RISC-V: Select ACPI PPTT drivers
        riscv: cacheinfo: initialize cacheinfo's level and type from ACPI PPTT
        riscv: cacheinfo: remove the useless input parameter (node) of ci_leaf_init()
        RISC-V: ACPI: Enable SPCR table for console output on RISC-V
        riscv: boot: remove duplicated targets line
        trace: riscv: Remove deprecated kprobe on ftrace support
        riscv: cpufeature: Extract common elements from extension checking
        riscv: Introduce vendor variants of extension helpers
        riscv: Add vendor extensions to /proc/cpuinfo
        riscv: Extend cpufeature.c to detect vendor extensions
        RISC-V: run savedefconfig for defconfig
        RISC-V: hwprobe: sort EXT_KEY()s in hwprobe_isa_ext0() alphabetically
        ACPI: NUMA: replace pr_info with pr_debug in arch_acpi_numa_init
        ACPI: NUMA: change the ACPI_NUMA to a hidden option
        ACPI: NUMA: Add handler for SRAT RINTC affinity structure
        ...
      c9f33436
    • Linus Torvalds's avatar
      Merge tag 'for-linus-6.11-rc1a-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip · c17f1224
      Linus Torvalds authored
      Pull xen fixes from Juergen Gross:
       "Two fixes for issues introduced in this merge window:
      
         - fix enhanced debugging in the Xen multicall handling
      
         - two patches fixing a boot failure when running as dom0 in PVH mode"
      
      * tag 'for-linus-6.11-rc1a-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip:
        x86/xen: fix memblock_reserve() usage on PVH
        x86/xen: move xen_reserve_extra_memory()
        xen: fix multicall debug data referencing
      c17f1224
    • Hongbo Li's avatar
      hostfs: fix the host directory parse when mounting. · ef9ca17c
      Hongbo Li authored
      hostfs not keep the host directory when mounting. When the host
      directory is none (default), fc->source is used as the host root
      directory, and this is wrong. Here we use `parse_monolithic` to
      handle the old mount path for parsing the root directory. For new
      mount path, The `parse_param` is used for the host directory parse.
      Reported-and-tested-by: default avatarMaciej Żenczykowski <maze@google.com>
      Fixes: cd140ce9 ("hostfs: convert hostfs to use the new mount API")
      Link: https://lore.kernel.org/all/CANP3RGceNzwdb7w=vPf5=7BCid5HVQDmz1K5kC9JG42+HVAh_g@mail.gmail.com/
      Cc: Christian Brauner <brauner@kernel.org>
      Signed-off-by: default avatarHongbo Li <lihongbo22@huawei.com>
      Link: https://lore.kernel.org/r/20240725065130.1821964-1-lihongbo22@huawei.com
      [brauner: minor fixes]
      Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
      ef9ca17c
    • Seth Forshee (DigitalOcean)'s avatar
      fs: don't allow non-init s_user_ns for filesystems without FS_USERNS_MOUNT · e1c5ae59
      Seth Forshee (DigitalOcean) authored
      Christian noticed that it is possible for a privileged user to mount
      most filesystems with a non-initial user namespace in sb->s_user_ns.
      When fsopen() is called in a non-init namespace the caller's namespace
      is recorded in fs_context->user_ns. If the returned file descriptor is
      then passed to a process priviliged in init_user_ns, that process can
      call fsconfig(fd_fs, FSCONFIG_CMD_CREATE), creating a new superblock
      with sb->s_user_ns set to the namespace of the process which called
      fsopen().
      
      This is problematic. We cannot assume that any filesystem which does not
      set FS_USERNS_MOUNT has been written with a non-initial s_user_ns in
      mind, increasing the risk for bugs and security issues.
      
      Prevent this by returning EPERM from sget_fc() when FS_USERNS_MOUNT is
      not set for the filesystem and a non-initial user namespace will be
      used. sget() does not need to be updated as it always uses the user
      namespace of the current context, or the initial user namespace if
      SB_SUBMOUNT is set.
      
      Fixes: cb50b348 ("convenience helpers: vfs_get_super() and sget_fc()")
      Reported-by: default avatarChristian Brauner <brauner@kernel.org>
      Signed-off-by: default avatarSeth Forshee (DigitalOcean) <sforshee@kernel.org>
      Link: https://lore.kernel.org/r/20240724-s_user_ns-fix-v1-1-895d07c94701@kernel.orgReviewed-by: default avatarAlexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
      Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
      e1c5ae59
    • Takashi Sakamoto's avatar
      ALSA: firewire-lib: fix wrong value as length of header for CIP_NO_HEADER case · c1839501
      Takashi Sakamoto authored
      In a commit 1d717123 ("ALSA: firewire-lib: Avoid
      -Wflex-array-member-not-at-end warning"), DEFINE_FLEX() macro was used to
      handle variable length of array for header field in struct fw_iso_packet
      structure. The usage of macro has a side effect that the designated
      initializer assigns the count of array to the given field. Therefore
      CIP_HEADER_QUADLETS (=2) is assigned to struct fw_iso_packet.header,
      while the original designated initializer assigns zero to all fields.
      
      With CIP_NO_HEADER flag, the change causes invalid length of header in
      isochronous packet for 1394 OHCI IT context. This bug affects all of
      devices supported by ALSA fireface driver; RME Fireface 400, 800, UCX, UFX,
      and 802.
      
      This commit fixes the bug by replacing it with the alternative version of
      macro which corresponds no initializer.
      
      Cc: stable@vger.kernel.org
      Fixes: 1d717123 ("ALSA: firewire-lib: Avoid -Wflex-array-member-not-at-end warning")
      Reported-by: default avatarEdmund Raile <edmund.raile@proton.me>
      Closes: https://lore.kernel.org/r/rrufondjeynlkx2lniot26ablsltnynfaq2gnqvbiso7ds32il@qk4r6xps7jh2/Reviewed-by: default avatarTakashi Iwai <tiwai@suse.de>
      Link: https://lore.kernel.org/r/20240725155640.128442-1-o-takashi@sakamocchi.jpSigned-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
      c1839501
    • Takashi Sakamoto's avatar
      Revert "firewire: Annotate struct fw_iso_packet with __counted_by()" · 00e3913b
      Takashi Sakamoto authored
      This reverts commit d3155742.
      
      The header_length field is byte unit, thus it can not express the number of
      elements in header field. It seems that the argument for counted_by
      attribute can have no arithmetic expression, therefore this commit just
      reverts the issued commit.
      Suggested-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
      Link: https://lore.kernel.org/r/20240725161648.130404-1-o-takashi@sakamocchi.jpSigned-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
      00e3913b
  3. 26 Jul, 2024 2 commits
    • Linus Torvalds's avatar
      minmax: avoid overly complicated constant expressions in VM code · 3a7e02c0
      Linus Torvalds authored
      The minmax infrastructure is overkill for simple constants, and can
      cause huge expansions because those simple constants are then used by
      other things.
      
      For example, 'pageblock_order' is a core VM constant, but because it was
      implemented using 'min_t()' and all the type-checking that involves, it
      actually expanded to something like 2.5kB of preprocessor noise.
      
      And when that simple constant was then used inside other expansions:
      
        #define pageblock_nr_pages      (1UL << pageblock_order)
        #define pageblock_start_pfn(pfn)  ALIGN_DOWN((pfn), pageblock_nr_pages)
      
      and we then use that inside a 'max()' macro:
      
      	case ISOLATE_SUCCESS:
      		update_cached = false;
      		last_migrated_pfn = max(cc->zone->zone_start_pfn,
      			pageblock_start_pfn(cc->migrate_pfn - 1));
      
      the end result was that one statement expanding to 253kB in size.
      
      There are probably other cases of this, but this one case certainly
      stood out.
      
      I've added 'MIN_T()' and 'MAX_T()' macros for this kind of "core simple
      constant with specific type" use.  These macros skip the type checking,
      and as such need to be very sparingly used only for obvious cases that
      have active issues like this.
      Reported-by: default avatarLorenzo Stoakes <lorenzo.stoakes@oracle.com>
      Link: https://lore.kernel.org/all/36aa2cad-1db1-4abf-8dd2-fb20484aabc3@lucifer.local/
      Cc: David Laight <David.Laight@aculab.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      3a7e02c0
    • Linus Torvalds's avatar
      minmax: avoid overly complex min()/max() macro arguments in xen · e8432ac8
      Linus Torvalds authored
      We have some very fancy min/max macros that have tons of sanity checking
      to warn about mixed signedness etc.
      
      This is all things that a sane compiler should warn about, but there are
      no sane compiler interfaces for this, and '-Wsign-compare' is broken [1]
      and not useful.
      
      So then we compensate (some would say over-compensate) by doing the
      checks manually with some truly horrid macro games.
      
      And no, we can't just use __builtin_types_compatible_p(), because the
      whole question of "does it make sense to compare these two values" is a
      lot more complicated than that.
      
      For example, it makes a ton of sense to compare unsigned values with
      simple constants like "5", even if that is indeed a signed type.  So we
      have these very strange macros to try to make sensible type checking
      decisions on the arguments to 'min()' and 'max()'.
      
      But that can cause enormous code expansion if the min()/max() macros are
      used with complicated expressions, and particularly if you nest these
      things so that you get the first big expansion then expanded again.
      
      The xen setup.c file ended up ballooning to over 50MB of preprocessed
      noise that takes 15s to compile (obviously depending on the build host),
      largely due to one single line.
      
      So let's split that one single line to just be simpler.  I think it ends
      up being more legible to humans too at the same time.  Now that single
      file compiles in under a second.
      Reported-and-reviewed-by: default avatarLorenzo Stoakes <lorenzo.stoakes@oracle.com>
      Link: https://lore.kernel.org/all/c83c17bb-be75-4c67-979d-54eee38774c6@lucifer.local/
      Link: https://staticthinking.wordpress.com/2023/07/25/wsign-compare-is-garbage/ [1]
      Cc: David Laight <David.Laight@aculab.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      e8432ac8