- 07 Jun, 2023 13 commits
-
-
Jani Nikula authored
Prepare for re-enabling -Wunused-but-set-variable. for_each_new_intel_plane_in_state() requires passing in a struct intel_plane_state pointer, which it uses, but in many places this leads to warning about unused but set variables. Annotate them with __maybe_unused. Signed-off-by:
Jani Nikula <jani.nikula@intel.com> Reviewed-by:
Jouni Högander <jouni.hogander@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/438ff3b257b7f85ecca5750ae8687336faee0a79.1685119007.git.jani.nikula@intel.com
-
Jani Nikula authored
Prepare for re-enabling -Wunused-but-set-variable. The variable is indeed 'unused' as the name suggests, but we can't just drop it because i915_vma_unbind_unlocked() is annotated __must_check. Apparently the selftest does not really need to check the value. Signed-off-by:
-
Jani Nikula authored
Prepare for re-enabling -Wunused-but-set-variable. The variable 'c' appears unused, but I'm not sure what should be done with it. Annotate it with __maybe_unused. Signed-off-by:
Andi Shyti <andi.shyti@linux.intel.com> Reviewed-by:
-
Jani Nikula authored
Prepare for re-enabling -Wunused-but-set-variable. Signed-off-by:
-
Jani Nikula authored
Prepare for re-enabling -Wunused-but-set-variable. Apparently sseu is leftover from commit 9a92732f ("drm/i915/gt: Add general DSS steering iterator to intel_gt_mcr"). Signed-off-by:
-
Jani Nikula authored
Prepare for re-enabling -Wunused-but-set-variable. Signed-off-by:
-
Jani Nikula authored
Prepare for re-enabling -Wunused-but-set-variable. Signed-off-by:
-
Jani Nikula authored
Prepare for re-enabling -Wunused-but-set-variable. Signed-off-by:
-
Jani Nikula authored
Prepare for re-enabling -Wunused-but-set-variable. The vbp is not used for anything in the readout, as we get e.g. crtc_vtotal from BXT_MIPI_TRANS_VTOTAL. Signed-off-by:
-
Jani Nikula authored
Prepare for re-enabling -Wunused-but-set-variable. Signed-off-by:
-
Jani Nikula authored
Prepare for re-enabling -Wunused-but-set-variable. The intel_dp variable has been unused since commit ef79fafe ("drm/i915: Eliminate intel_dp.regs.dp_tp_{ctl,status}"). Signed-off-by:
-
Jani Nikula authored
We assume the plane offset is 0. Warn if it's not. This also fixes a warn on unused but set variable offset. v2: initialize offset on the gen2/3 path (Ville) Suggested-by:
Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by:
-
Jani Nikula authored
Only the EDID code and sysfs should look at the EDID property. Stop using it. Signed-off-by:
-
- 05 Jun, 2023 6 commits
-
-
Matt Roper authored
If i915_driver_create() fails to create a valid 'i915' object, we should just disable the PCI device and return immediately without trying to call i915_probe_error() that relies on a valid i915 pointer. Fixes: 12e6f6dc ("drm/i915/display: Handle GMD_ID identification in display code") Reported-by:
Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/all/55236f93-dcc5-481e-b788-9f7e95b129d8@kili.mountain/Signed-off-by:
Matt Roper <matthew.d.roper@intel.com> Reviewed-by:
Gustavo Sousa <gustavo.sousa@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230601173804.557756-1-matthew.d.roper@intel.com
-
Matt Roper authored
Moving display-specific runtime info initialization into display/ makes the display code more self-contained and also makes it easier to call from the Xe driver. v2: - Drop unnecessary display/ prefix from #includes. (Jani) - Clear runtime info if fusing leaves no pipes remaining, the same as we do when fusing indicates the entire display controller is unavailable. (Jani) - Move adjustment of DRIVER_MODESET / DRIVER_ATOMIC after call to intel_display_device_info_runtime_init(); HAS_DISPLAY may have changed to false during the runtime init. (Jani) Cc: Jani Nikula <jani.nikula@linux.intel.com> Signed-off-by:
-
Ville Syrjälä authored
Apparently desktop gen3 parts don't support the 10bit gamma mode at all. Stop claiming otherwise. As is the case with pipe A on gen3 mobile parts, the PIPECONF gamma mode bit can be set but it has no effect on the output. PNV seems to be the only slight exception, but generally the desktop PNV variant looks more like a mobile part so this is not entirely surprising. Fixes: 67630bac ("drm/i915: Add 10bit gamma mode for gen2/3") Signed-off-by:
Uma Shankar <uma.shankar@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230531135625.3467-1-ville.syrjala@linux.intel.com
-
Arun R Murthy authored
For modifier not supporting async flip, print the modifier and display version. Helps in reading the error message. v2: Reframe the error message (Jani) Signed-off-by:
Arun R Murthy <arun.r.murthy@intel.com> Signed-off-by:
-
Mika Kahola authored
In case when only two or less transmit lanes are owned such as MFD (DP-alt with x2 lanes) we need to reset only one data lane (lane0). With only x2 lanes we don't need to poll for the phy current status on both data lanes since only the owned data lane will respond. v2: Find better naming for lanes and revise the commit message (Luca) Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com> (v1) Signed-off-by:
Mika Kahola <mika.kahola@intel.com> Reviewed-by: Luca Coelho <luciano.coelho@intel.com> (v2) Signed-off-by:
-
Jouni Högander authored
HW default for wake sync pulses is 18. 10 precharge and 8 preamble. There is no reason to change this especially as it is causing problems with certain eDP panels. v3: Change "Fixes:" commit v2: Remove "fast wake" repeat from subject Signed-off-by:
Luca Coelho <luciano.coelho@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230530101649.2549949-1-jouni.hogander@intel.com
-
- 02 Jun, 2023 17 commits
-
-
Chaitanya Kumar Borah authored
According to Bspec, the voltage level for 480MHz is to be set as 1 instead of 2. BSpec: 49208 Fixes: 06f1b06d ("drm/i915/display: Add 480 MHz CDCLK steps for RPL-U") v2: rebase Signed-off-by:
Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com> Reviewed-by:
-
Maarten Lankhorst authored
When intel_dp_init_connector fails, some power wells used in dp aux communication may not be completely disabled yet. This may result in a null pointer dereference when icl_aux_pw_to_phy() is called from icl_combo_phy_aux_power_well_disable() after the encoder and connector are already freed. Signed-off-by:
Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Imre Deak <imre.deak@intel.com> Cc: Jani Nikula <jani.nikula@intel.com> Acked-by:
Imre Deak <imre.deak@intel.com> Signed-off-by:
-
Maarten Lankhorst authored
enum i915_drm_suspend_mode suspend_mode is only used in intel_display_power, while we only care about whether we perform a s2idle. Remove it and use a simple bool. v2: Rebase Signed-off-by:
-
Sui Jingfeng authored
'rbiter' -> 'arbiter' Signed-off-by:
Sui Jingfeng <suijingfeng@loongson.cn> Signed-off-by:
-
Jani Nikula authored
Convert the remaining uses of struct edid based drm_get_edid(), drm_connector_update_edid_property() and drm_add_edid_modes() calls to the struct drm_edid based drm_edid_read_ddc(), drm_edid_connector_update() and drm_edid_connector_add_modes(). Reviewed-by:
Ankit Nautiyal <ankit.k.nautiyal@intel.com> Signed-off-by:
-
Jani Nikula authored
Convert the topology manager to use struct drm_edid, add drm_dp_mst_edid_read() that returns drm_edid, and rewrite the old drm_dp_mst_get_edid() to use it. Note that the old drm_get_edid() ended up calling drm_connector_update_edid_property(). This responsibility is now deferred to drivers, which all do it anyway after calling drm_dp_mst_edid_read() or drm_dp_mst_get_edid(). Reviewed-by:
Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by:
-
Jani Nikula authored
It's a bit tedious to check for NULL before calling drm_edid_duplicate(). Make it handle NULL parameter graciously. Reviewed-by:
-
Jani Nikula authored
Use drm_edid_read_switcheroo() to switch from struct edid to struct drm_edid. Reviewed-by:
Lukas Wunner <lukas@wunner.de> Signed-off-by:
-
Jani Nikula authored
Add a switcheroo variant to the struct drm_edid based EDID read functions. Reviewed-by:
-
Jani Nikula authored
Use the information stored in display info. Reviewed-by:
-
Jani Nikula authored
Use the information stored in display info. Reviewed-by:
-
Jani Nikula authored
Use the information stored in display info. Reviewed-by:
-
Jani Nikula authored
Use the information stored in display info. Reviewed-by:
-
Jani Nikula authored
Use the information stored in display info. Add intel_dp_has_hdmi_sink() helper to access it. v2: Rebased Reviewed-by:
-
Jani Nikula authored
Use the information stored in display info. Reviewed-by:
-
Jani Nikula authored
Caching the has_audio in struct drm_dp_mst_port seems odd, and oddly placed. Defer audio handling to drivers, and use the info from the connector display info. i915 was the only one using it anyway. Reviewed-by:
-
Jani Nikula authored
Since we already iterate everything that's needed for determining audio, reduce the need to call drm_detect_monitor_audio() by storing has_audio to connector info. Reviewed-by:
-
- 31 May, 2023 4 commits
-
-
Jani Nikula authored
Use localized __diag_push(), __diag_ignore_all() with rationale, and __diag_pop() for specific initializations instead of blanket disabling of -Woverride-init across several files. Signed-off-by:
-
Jani Nikula authored
Sync the drm-intel-gt-next changes back to drm-intel-next via drm-next. Signed-off-by: -
Suraj Kandpal authored
Rename comp_mutex to hdcp_mutex as it does not just protect component related variables which was a terminology used when hdcp was to be binded as a mei component from MTL we use gsc cs which does not use the component binding path for HDCP. Cc: Jani Nikula <jani.nikula@intel.com> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> Signed-off-by:
Suraj Kandpal <suraj.kandpal@intel.com> Reviewed-by:
-
Suraj Kandpal authored
Rename variables to move away from master convention to arbiter %s/hdcp.master/hdcp.arbiter %s/i915_hdcp_master/i915_hdcp_arbiter %s/comp_master/comp_arbiter --v2 - delete i915_hdcp_comp_master redundant declaration [Chaitanya] - use %s/foo/bar/ format in commit message to show changes [Chaitanya] --v3 - replace i915_hdcp_comp_master declaration with i915_hdcp_arbiter to avoid any compile fail with old compilers [Chaitanya] Cc: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> Cc: Jani Nikula <jani.nikula@intel.com> Signed-off-by:
-
