- 31 May, 2015 40 commits
-
-
Oleg Drokin authored
This moves all remaining procfs handling in llite layer to debugfs. Signed-off-by:
Dmitry Eremin <dmitry.eremin@intel.com> Signed-off-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Nicholas Mc Guire authored
API consolidation with coccinelle found: ./drivers/staging/panel/panel.c:782:2-18: consolidation with schedule_timeout_*() recommended This is a 1:1 conversion with respect to schedule_timeout() to the schedule_timeout_interruptible() helper only - so only an API consolidation to improve readability. The timeout was being passed as (ms * HZ + 999) / 1000 but that simply looks wrong - rather than "manual" converting to jiffies, msecs_to_jiffies which handles all corner-cases correctly, was used. Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y, CONFIG_PARPORT=m, CONFIG_PANEL=m Signed-off-by:Nicholas Mc Guire <hofrat@osadl.org> Acked-by:
Willy Tarreau <w@1wt.eu> Signed-off-by:
-
Nicholas Mc Guire authored
API consolidation with coccinelle found: ./drivers/staging/comedi/drivers/me_daq.c:177:1-17: consolidation with schedule_timeout_*() recommended This is a 1:1 conversion of the current calls to an available helper only - so only an API consolidation to improve readability. Signed-off-by:Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Masanari Iida authored
This patch fix a spelling typo in printk within sm750.c Signed-off-by:
Masanari Iida <standby24x7@gmail.com> Signed-off-by:
-
Michel von Czettritz authored
As suggested by Sudip this patch removes the redundant 1360x768@60 option from the fb_videomode struct array. The removed option and the option one it differ in a typo and a flag. Signed-off-by:
Michel von Czettritz <michel.von.czettritz@gmail.com> Signed-off-by:
-
Isaac Assegai authored
Replace spaces at the start of lines with tabs to rectify the following warning: WARNING: please, no spaces at the start of a line Signed-off-by:
Isaac Assegai <isaac.a.travers@gmail.com> Signed-off-by:
-
Jakub Sitnicki authored
Remove #ifdef's enclosed by an #ifdef test for the same macro to improve readability. No code changes: md5, CONFIG_88EU_AP_MODE=y: b819a33f65133607ebc33b8999ee3a79 r8188eu.o.before b819a33f65133607ebc33b8999ee3a79 r8188eu.o.after md5, CONFIG_88EU_AP_MODE=n: 94c84035d59285408b866a57b442276d r8188eu.o.before 94c84035d59285408b866a57b442276d r8188eu.o.after Signed-off-by:Jakub Sitnicki <jsitnicki@gmail.com> Signed-off-by:
-
Luca Ceresoli authored
"If the name of a function is an action or an imperative command, the function should return an error-code integer." (Documentation/CodingStyle) Several action-like functions in this driver return a boolean: _SUCCESS = 1 on success, _FAIL = 0 on error, defined in drivers/staging/rtl8188eu/include/osdep_service.h. Change rtw_start_drv_threads() to return a proper 0-or-error value. Signed-off-by:
Luca Ceresoli <luca@lucaceresoli.net> Cc: Greg Kroah-Hartman <gregkh@linux.com> Cc: Larry Finger <Larry.Finger@lwfinger.net> Cc: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Luca Ceresoli authored
Also remove them from .h files. Signed-off-by:
-
Luca Ceresoli authored
The loadparam() function cannot fail, it's called only once and its return value is ignored there. Signed-off-by:
-
Luca Ceresoli authored
Fixes checkpatch warnings: WARNING: Missing a blank line after declarations Signed-off-by:
-
Luca Ceresoli authored
Even though these are not reported by checkpatch, they are coding style issues. Signed-off-by:
-
Shailendra Verma authored
Fix spelling error in comment in function tegra_nvec_remove. Signed-off-by:
Shailendra Verma <shailendra.capricorn@gmail.com> Acked-by:
Marc Dietrich <marvin24@gmx.de> Signed-off-by:
-
Luca Ceresoli authored
The loadparam() function cannot fail, it's called only once and its return value is ignored there. Signed-off-by:
-
Luca Ceresoli authored
Signed-off-by:
-
Luca Ceresoli authored
"step 2" does mean much as there is no "step 1" stated anywhere... Signed-off-by:
-
Haggai Eran authored
With an RTL8191SU USB adaptor, sometimes the hints for a fragmented packet are set, but the packet length is too large. Allocate enough space to prevent memory corruption and a resulting kernel panic [1]. [1] http://www.spinics.net/lists/linux-wireless/msg136546.html Cc: <stable@vger.kernel.org> Signed-off-by:
Haggai Eran <haggai.eran@gmail.com> ACKed-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Sudip Mukherjee authored
del_timer_sync() is not to be called in the interrupt context unless the timer is irqsafe. but most of the functions where commits 6501c8e7 and 382d020f touched were called in interrupt context. And as a result the WARN_ON was getting triggered. Changed to del_timer() in places which were called from interrupt. Fixes: 382d020f ("Staging: rtl8712: Eliminate use of _cancel_timer" Fixes: 6501c8e7 ("Staging: rtl8712: Eliminate use of _cancel_timer_ex") Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=97711Reported-by:
Arek Rusniak <arek.rusi@gmail.com> Tested-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
-
Vladimirs Ambrosovs authored
This patch fixes the leak, which was present in fwserial driver in the init function. In case the tty driver allocation failed the function returned error, leaving debugfs entry in the filesystem. To fix the issue additional error label was added, so that the code will jump to it in case of allocation failure, and free debugfs entries. Signed-off-by:
Vladimirs Ambrosovs <rodriguez.twister@gmail.com> Reviewed-by:
Peter Hurley <peter@hurleysoftware.com> Signed-off-by:
-
Jagan Teki authored
Fixes Warning encounter this by applying checkpatch.pl against this file: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) pahole output for respective structures: - addr->sa_data struct sockaddr { sa_family_t sa_family; /* 0 2 */ char sa_data[14]; /* 2 14 */ /* size: 16, cachelines: 1, members: 2 */ /* last cacheline: 16 bytes */ }; - pnetdev->dev_addr dev_addr is interface address infor from generic net_device structure which is properly aligned and have some patches with this change as well. "staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()" (sha1: 36e4d882) Signed-off-by:Jagan Teki <jteki@openedev.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Larry Finger <Larry.Finger@lwfinger.net> Cc: Florian Schilhabel <florian.c.schilhabel@googlemail.com> Signed-off-by:
-
Jagan Teki authored
This patch fixes line over 80 characters warninings while running checkpatch.pl - "WARNING: line over 80 characters" Signed-off-by:
-
Sai.Jiang authored
Remove two warnings of missing-blank-line-after-declaration. Signed-off-by:
Sai.Jiang <sai.d.jiang@foxmail.com> Signed-off-by:
-
Dan Carpenter authored
We can't save two different values in "flags" so it means that IRQs are not enabled properly at the end of this function. This isn't a problem in the current code because it's always called with IRQs disabled so we don't want to enable them at the end. This bug is old but it's thanks to David Matlack's recent cleanups that Smatch can detect it. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
David Matlack <dmatlack@google.com> Signed-off-by:
-
Masanari Iida authored
This patch fix 2 spelling typos in printk within gdm72xx. Signed-off-by:
-
Jaime Arrocha authored
gdm_endian.c: small changes were done to remove testing for host endianness and in-driver conversion for byte-ordering. The linux/kernel.h functions are used now. gdm_endian.h: removal of code no longer needed with changes in gdm_endian.c. Signed-off-by:
Jaime Arrocha <jarr@kerneldev.net> Signed-off-by:
-
Nicholas Mc Guire authored
schedule_timeout takes a timeout in jiffies but the code currently is passing in a constant POLLING_INTERVAL which makes this timeout HZ dependent, so pass it through msecs_to_jiffies() to fix this up. patch was compile tested for x86_64_defconfig + CONFIG_STAGING=y, CONFIG_RTS5208=m Patch is against 4.0-rc5 (localversion-next is -next-20150527) Signed-off-by:
-
Akinobu Mita authored
For 6-byte r/w commands, transfer length 0 means 256 blocks of data, not 0 block. Signed-off-by:
Akinobu Mita <akinobu.mita@gmail.com> Cc: Micky Ching <micky_ching@realsil.com.cn> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-scsi@vger.kernel.org Signed-off-by:
-
Peter Senna Tschudin authored
As the first argument of gf_write64() was of type unsigned long, and as some calls to gf_write64() were casting the first argument from void * to u64 the compiler and/or sparse were printing warnings for casts of wrong sizes when compiling for i386. This patch changes the type of the first argument of gf_write64() to const void *, and update calls to the function. This change fixed the warnings and allowed to remove casts from 3 calls to gf_write64(). In addition gf_write64() was renamed to gf_write_ptr() as the name was misleading because it only writes 32 bits on 32 bit systems. gf_write_dma_addr() was added to handle dma_addr_t values which is used at drivers/staging/goldfish/goldfish_audio.c. Signed-off-by:
Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by:
-
Alex Dowad authored
This fixes a checkpatch style warning in ft1000_ioctl. Signed-off-by:
Alex Dowad <alexinbeijing@gmail.com> Signed-off-by:
-
Colin Cronin authored
Fixed comment spelling errors Signed-off-by:
Colin Cronin <colinpatrickcronin@gmail.com> Signed-off-by:
-
Simon Guo authored
Declare request_cache variable as static. It is only used by drivers/staging/lustre/lustre/ptlrpc/client.c, and its naming is common which will lead to namespace pollution. Signed-off-by:
Simon Guo <wei.guo.simon@gmail.com> Signed-off-by:
-
Oleg Drokin authored
lustre_dlm_flags.h was autogenerated with a wrong script that mistakenly stated it is GPLv3 when in fact it should be GPLv2. Also since we are no longer autogenerating this header, drop all such mentionings. Reported by: George G. Davis <ggdavisiv@gmail.com> Signed-off-by:
Andreas Dilger <andreas.dilger@intel.com> CC: George G. Davis <ggdavisiv@gmail.com> Signed-off-by:
-
Julia Lawall authored
Delete jump to a label on the next line, when that label is not used elsewhere. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ identifier l; @@ -if (...) goto l; -l: // </smpl> Signed-off-by:
Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
-
Marcus Folkesson authored
Warnings reported by sparse: drivers/staging/lustre/lustre/ptlrpc/pinger.c:94:5: warning: symbol 'ptlrpc_ping' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/pinger.c:113:6: warning: symbol 'ptlrpc_update_next_ping' was not declared. Should it be static drivers/staging/lustre/lustre/ptlrpc/pinger.c:144:6: warning: symbol 'pinger_check_timeout' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/pinger.c:425:21: warning: symbol 'ptlrpc_new_timeout' was not declared. Should it be static? drivers/staging/lustre/lustre/ptlrpc/pinger.c:551:1: warning: symbol 'pet_list' was not declared. Should it be static? Signed-off-by:
Marcus Folkesson <marcus.folkesson@gmail.com> Signed-off-by:
-
Dmitry Eremin authored
change type of * obd->obd_proc_entry * obd->obd_svc_procroot * lov->lov_pool_proc_entry * obd_type->typ_procroot * pool_desc->pool_proc_entry Signed-off-by:
Dmitry Eremin <dmiter4ever@gmail.com> Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
-
Dmitry Eremin authored
Signed-off-by:
-
Dmitry Eremin authored
Signed-off-by:
-
Dmitry Eremin authored
Since we are removing lustre sysctls, this enum is no longer needed. Signed-off-by:
-
Oleg Drokin authored
Signed-off-by:
-
Oleg Drokin authored
Signed-off-by:
-
