- 17 Oct, 2015 40 commits
-
-
Amitoj Kaur Chawla authored
Remove intialisation of a variable that is immediately reassigned. The semantic patch used to find this is: // <smpl> @@ type T; identifier x; constant C; expression e; @@ T x - = C ; x = e; // </smpl> Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Cristina Moraru authored
Thus using the preferred style for multi-line coments as mentioned in Documentation/CodingStyle. It also silences 'Block comments use * on subsequent lines' and 'Block comments use a trailing */ on a separate line' checkpatch.pl warnings. Signed-off-by:
Cristina Moraru <cristina.moraru09@gmail.com> Signed-off-by:
-
Shivani Bhardwaj authored
Compiler can typecast variables implicitly so, explicit type cast is not required and should be removed. Semantic patch used: @@ type T; T e; identifier x; @@ * T x = (T)e; Signed-off-by:
Shivani Bhardwaj <shivanib134@gmail.com> Signed-off-by:
-
Shivani Bhardwaj authored
Remove explicit type conversion as it is not required. Semantic patch used: @@ type T; T e; identifier x; @@ * T x = (T)e; Signed-off-by:
-
Shivani Bhardwaj authored
Remove explicit typecast from variables as compiler can typecast implicitly. Semantic patch used: @@ type T; T e; identifier x; @@ * T x = (T)e; Signed-off-by:
-
Cristina Moraru authored
Thus use the preferred style for multi-line coments as mentioned in Documentation/CodingStyle. It also silences 'Block comments use * on subsequent lines' checkpatch.pl warnings. Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove intialisation of a variable that is immediately reassigned. The semantic patch used to find this is: // <smpl> @@ type T; identifier x; constant C; expression e; @@ T x - = C ; x = e; // </smpl> Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove intialisation of a variable that is immediately reassigned. The semantic patch used to find this is: // <smpl> @@ type T; identifier x; constant C; expression e; @@ T x - = C ; x = e; // </smpl> Signed-off-by:
-
Cristina Moraru authored
Fix 'line over 80 characters' checkpatch.pl warnings Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove intialisation of a variable that is immediately reassigned. The semantic patch used to find this is: // <smpl> @@ type T; identifier x; constant C; expression e; @@ T x - = C ; x = e; // </smpl> Signed-off-by:
-
Shraddha Barke authored
void pointers do not need to be cast to other pointer types. The semantic patch used to find this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
Shraddha Barke <shraddha.6596@gmail.com> Signed-off-by:
-
Shraddha Barke authored
void pointers do not need to be cast to other pointer types. Semantic patch: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Shraddha Barke authored
void pointers do not need to be cast to other pointer types. The semantic patch used to find this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Shraddha Barke authored
void pointers do not need to be cast to other pointer types. The semantic patch used to find this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Shraddha Barke authored
void pointers do not need to be cast to other pointer types. The semantic patch used to find this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Shraddha Barke authored
void pointers do not need to be cast to other pointer types. The semantic patch used to find this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Shraddha Barke authored
void pointers do not need to be cast to other pointer types. The semantic patch used to find this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Shraddha Barke authored
void pointers do not need to be cast to other pointer types. The semantic patch used to find this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Shraddha Barke authored
void pointers do not need to be cast to other pointer types. The semantic patch used to find this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Shivani Bhardwaj authored
Explicit type conversion is not required and should be removed. Semantic patch used: @@ type T; T e; identifier x; @@ * T x = (T)e; Signed-off-by:
-
Shivani Bhardwaj authored
Type conversion of variables can be done by compiler implicitly so, explicit conversions should be removed. Semantic patch used: @@ type T; T e; identifier x; @@ * T x = (T)e; Signed-off-by:
Daniel Baluta <daniel.baluta@intel.com> Signed-off-by:
-
Salva Peiró authored
The dgnc_mgmt_ioctl() code fails to initialize the 16 _reserved bytes of struct digi_dinfo after the ->dinfo_nboards member. Add an explicit memset(0) before filling the structure to avoid the info leak. Signed-off-by:
Salva Peiró <speirofr@gmail.com> Signed-off-by:
-
Shivani Bhardwaj authored
Remove parentheses surrounding the first argument of the macro DIV_ROUND_UP as they are not required. Semantic patch used: @@ expression e1,e2; @@ DIV_ROUND_UP( - ( e1 - ) ,e2) Signed-off-by:
-
Shivani Bhardwaj authored
The variable pdata is already NULL tested before so, any further tests should be removed. Signed-off-by:
-
Shraddha Barke authored
Remove the macros since they are not used anywhere throughout the kernel. Signed-off-by:
-
Ioana Ciornei authored
Remove the use of CamelCase to follow the kernel naming conventions Signed-off-by:
Ioana Ciornei <ciorneiioana@gmail.com> Reviewed-by:
-
Ioana Ciornei authored
Remove multiple blank lines since there is no practical reason to have it Signed-off-by:
-
Ioana Ciornei authored
Insert a blank line after declarations Signed-off-by:
-
Ioana Ciornei authored
Add spaces around binary operators like -, +, * etc in order to improve readability Signed-off-by:
-
Ioana Ciornei authored
Remove the space after an explicit cast because there is no point in having it Signed-off-by:
-
Ioana Ciornei authored
Use !condition instead off condition == NULL when comparing with NULL Signed-off-by:
-
Ioana Ciornei authored
Indent parameters and arguments passed to function calls to match open paranthesis Signed-off-by:
-
Ioana Ciornei authored
Convert uint32_t to u32 and uint64_t to u64 in order to follow the kernel best practice Signed-off-by:
-
Ioana Ciornei authored
Simplify return flow ad7150_write_event_params in order to reduce code length. Since i2c_smbus_write_word_data only returns a negative value or 0 the change is safe. This patch fixes the following coccicheck warning: drivers/staging/iio/cdc/ad7150.c:182:2-5: WARNING: end returns can be simpified if negative or 0 value Signed-off-by:
-
Shivani Bhardwaj authored
Explicit type conversion is not required to remove it. Semantic patch used: @@ type T; T e; identifier x; @@ * T x = (T)e; Signed-off-by:
-
Shivani Bhardwaj authored
The variable inst is a __u32 type and hence the function used should be simple_strtoul. Semantic patch used: @@ typedef __u32; __u32 e; @@ e = - simple_strtol + simple_strtoul (...) Signed-off-by:
-
Shivani Bhardwaj authored
The variable rc is supposed to hold the value returned by function kstrtoul which can either be 0, -EINVAL (-22) or -ERANGE (-34). Therefore, the check must be performed on rc instead of val for error values. Also, rc can never be greater than 0. Signed-off-by:
-
Shraddha Barke authored
Remove macro OBD_SLAB_FREE_RTN0 since it is defined but not used Signed-off-by:
-
Shivani Bhardwaj authored
struct it is already NULL tested before so, it should be removed from the if test expression. Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Shivani Bhardwaj authored
Variable op_data is already tested for NULL value and therefore any further checks should be removed. Semantic patch used: @@ expression E;@@ if(E==NULL) {... return ...;} - if(E){ ... - } Signed-off-by:
-
