1. 22 Dec, 2015 12 commits
  2. 17 Dec, 2015 1 commit
    • Felipe Balbi's avatar
      usb: of: fix build breakage on !OF · be99c843
      Felipe Balbi authored
      If OF is disabled, we will try to define a stub for
      of_usb_get_dr_mode_by_phy(), however that missed a
      static inline annotation which made us redefine the
      stub over and over again. Fix that.
      
      Fixes: 98bfb394 ("usb: of: add an api to get
      	dr_mode by the phy node")
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      be99c843
  3. 16 Dec, 2015 20 commits
  4. 15 Dec, 2015 7 commits
    • Geert Uytterhoeven's avatar
      usb: phy: Remove unused Renesas R-Car (Gen1) USB PHY driver · 375da627
      Geert Uytterhoeven authored
      As of commit 3d7608e4 ("ARM: shmobile: bockw: remove legacy
      board file and config"), the Renesas R-Car (Gen1) USB PHY driver is no
      longer used.
      In theory it could still be used on R-Car Gen1 SoCs, but that would
      require adding DT support to the driver. Instead, a new driver using the
      generic PHY framework should be written, as was done for R-Car Gen2.
      
      Remove the driver for good.
      Acked-by: default avatarSimon Horman <horms+renesas@verge.net.au>
      Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      375da627
    • Vladimir Zapolskiy's avatar
      usb: gadget: lpc32xxx_udc: clean up and sort include directives out · 2de59c09
      Vladimir Zapolskiy authored
      Remove mach/irq.h from the list of included headers, there is no
      compilation dependency on this include file, and the change is needed
      to prevent a compilation failure, when mach/irq.h is removed.
      
      Additionally remove other unneeded includes and sort out their order.
      Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      2de59c09
    • Felipe Balbi's avatar
      usb: dwc3: trace: show request flags · 46a01427
      Felipe Balbi authored
      struct usb_request have 3 flags which might be
      important to know about during debug. This patch
      shows each of the 3 flags as a single letter:
      
      z -> for zero
      s -> short not okay
      i -> interrupt
      
      A capital letter means the feature is enabled
      while a lower case letter means it is disabled;
      
      Thus 'zsI' indicates that a ZLP is not needed,
      that we can accept a short packet and interrupt
      for this request should be enabled.
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      46a01427
    • Felipe Balbi's avatar
      usb: dwc3: gadget: handle request->zero · 04c03d10
      Felipe Balbi authored
      So far, dwc3 has always missed request->zero
      handling for every endpoint. Let's implement
      that so we can handle cases where transfer must
      be finished with a ZLP.
      
      Note that dwc3 is a little special. Even though
      we're dealing with a ZLP, we still need a buffer
      of wMaxPacketSize bytes; to hide that detail from
      every gadget driver, we have a preallocated buffer
      of 1024 bytes (biggest bulk size) to use (and
      share) among all endpoints.
      Reported-by: default avatarRavi B <ravibabu@ti.com>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      04c03d10
    • Rasmus Villemoes's avatar
      usb: musb: convert printk to pr_* · 3ff4b573
      Rasmus Villemoes authored
      This file already uses pr_debug in a few places; this converts the
      remaining printks.
      Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      3ff4b573
    • Douglas Anderson's avatar
      usb: dwc2: host: Clear interrupts before handling them · 29539019
      Douglas Anderson authored
      In general it is wise to clear interrupts before processing them.  If
      you don't do that, you can get:
       1. Interrupt happens
       2. You look at system state and process interrupt
       3. A new interrupt happens
       4. You clear interrupt without processing it.
      
      This patch was actually a first attempt to fix missing device insertions
      as described in (usb: dwc2: host: Fix missing device insertions) and it
      did solve some of the signal bouncing problems but not all of
      them (which is why I submitted the other patch).  Specifically, this
      patch itself would sometimes change:
       1. hardware sees connect
       2. hardware sees disconnect
       3. hardware sees connect
       4. dwc2_port_intr() - clears connect interrupt
       5. dwc2_handle_common_intr() - calls dwc2_hcd_disconnect()
      
      ...to:
       1. hardware sees connect
       2. hardware sees disconnect
       3. dwc2_port_intr() - clears connect interrupt
       4. hardware sees connect
       5. dwc2_handle_common_intr() - calls dwc2_hcd_disconnect()
      
      ...but with different timing then sometimes we'd still miss cable
      insertions.
      
      In any case, though this patch doesn't fix any (known) problems, it
      still seems wise as a general policy to clear interrupt before handling
      them.
      
      Note that for dwc2_handle_usb_port_intr(), instead of moving the clear
      of PRTINT to the beginning of the function we remove it completely.  The
      only way to clear PRTINT is to clear the sources that set it in the
      first place.
      Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      29539019
    • Douglas Anderson's avatar
      usb: dwc2: host: Add missing spinlock in dwc2_hcd_reset_func() · 4a065c7b
      Douglas Anderson authored
      The dwc2_hcd_reset_func() function is only ever called directly by a
      delayed work function.  As such no locks are already held when the
      function is called.
      
      Doing a read-modify-write of CPU registers and setting fields in the
      main hsotg data structure is a bad idea without locks.  Let's add
      locks.
      
      The bug was found by code inspection only.  It turns out that the
      dwc2_hcd_reset_func() is only ever called today if the
      "host_support_fs_ls_low_power" parameter is enabled and no code in
      mainline enables that parameter.  Thus no known issues in mainline are
      fixed by this patch, but it's still probably wise to fix the function.
      Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
      Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
      4a065c7b