1. 19 Mar, 2021 6 commits
    • Kuninori Morimoto's avatar
      ASoC: soc-pcm: indicate error message at dpcm_apply_symmetry() · bbd2bac8
      Kuninori Morimoto authored
      Indicating error message when failed case is very useful for debuging.
      In many case, its style is like below.
      
      	int function(...)
      	{
      		...
      		return ret;
      	}
      
      	int caller(...)
      	{
      		...
      		ret = function(...);
      		if (ret < 0)
      			dev_err(...)
      		...
      	}
      
      This is not so bad, but in this style *each caller* needs to indicate
      duplicate same error message, and some caller is forgetting to do it.
      And caller can't indicate detail function() error information.
      
      If function() indicates error message, we can get same and
      detail information without forgot.
      
      	int function(...)
      	{
      		...
      		if (ret < 0)
      			dev_err(...)
      
      		return ret;
      	}
      
      	int caller(...)
      	{
      		...
      		ret = function(...);
      		...
      	}
      
      This patch follow above style at dpcm_apply_symmetry(...)
      Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Link: https://lore.kernel.org/r/87k0q9utb9.wl-kuninori.morimoto.gx@renesas.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      bbd2bac8
    • Kuninori Morimoto's avatar
      ASoC: soc-pcm: indicate error message at dpcm_be_dai_trigger() · db3aa39c
      Kuninori Morimoto authored
      Indicating error message when failed case is very useful for debuging.
      In many case, its style is like below.
      
      	int function(...)
      	{
      		...
      		return ret;
      	}
      
      	int caller(...)
      	{
      		...
      		ret = function(...);
      		if (ret < 0)
      			dev_err(...)
      		...
      	}
      
      This is not so bad, but in this style *each caller* needs to indicate
      duplicate same error message, and some caller is forgetting to do it.
      And caller can't indicate detail function() error information.
      
      If function() indicates error message, we can get same and
      detail information without forgot.
      
      	int function(...)
      	{
      		...
      		if (ret < 0)
      			dev_err(...)
      
      		return ret;
      	}
      
      	int caller(...)
      	{
      		...
      		ret = function(...);
      		...
      	}
      
      Now, dpcm_be_dai_trigger() user uses it like below.
      
      	err = dpcm_be_dai_trigger(...);
      	if (err < 0)
      		dev_err(..., "ASoC: trigger FE failed %d\n", err);
      
      But we can get more detail information if dpcm_be_dai_trigger() itself
      had dev_err(). And above error message is confusable,
      failed is *BE*, not *FE*.
      
      This patch indicates error message at dpcm_be_dai_trigger().
      Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Link: https://lore.kernel.org/r/87lfaputbe.wl-kuninori.morimoto.gx@renesas.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      db3aa39c
    • Kuninori Morimoto's avatar
      ASoC: soc-pcm: indicate error message at dpcm_path_get() · d479f00b
      Kuninori Morimoto authored
      Indicating error message when failed case is very useful for debuging.
      In many case, its style is like below.
      
      	int function(...)
      	{
      		...
      		return ret;
      	}
      
      	int caller(...)
      	{
      		...
      		ret = function(...);
      		if (ret < 0)
      			dev_err(...)
      		...
      	}
      
      This is not so bad, but in this style *each caller* needs to indicate
      duplicate same error message, and some caller is forgetting to do it.
      And caller can't indicate detail function() error information.
      
      If function() indicates error message, we can get same and
      detail information without forgot.
      
      	int function(...)
      	{
      		...
      		if (ret < 0)
      			dev_err(...)
      
      		return ret;
      	}
      
      	int caller(...)
      	{
      		...
      		ret = function(...);
      		...
      	}
      
      Now, many place uses dpcm_path_get() like below
      
      	ret = dpcm_path_get(...);
      	if (ret < 0)
      		goto error;
      (A)	else if (ret == 0)
      		dev_dbg(...)
      
      But here, (A) part can be indicated at dpcm_path_get() not caller.
      It is simple and readable code.
      
      This patch do it.
      Small detail behaviors will be exchanged by this patch.
      
      	1) indicates debug info (= path numbers) if path > 0 case only
      	   (It was *always* indicated).
      	2) soc_dpcm_fe_runtime_update() is indicating error message
      	   for paths < 0 case, but it is already done at dpcm_path_get().
      	   Thus just remove it. but dev_dbg() vs dev_warn() is exchanged.
      Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Link: https://lore.kernel.org/r/87mtv5utbj.wl-kuninori.morimoto.gx@renesas.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      d479f00b
    • Kuninori Morimoto's avatar
      ASoC: soc-pcm: indicate error message at soc_pcm_prepare() · dab7eeb4
      Kuninori Morimoto authored
      Indicating error message when failed case is very useful for debuging.
      In many case, its style is like below.
      
      	int function(...)
      	{
      		...
      		return ret;
      	}
      
      	int caller(...)
      	{
      		...
      		ret = function(...);
      		if (ret < 0)
      			dev_err(...)
      		...
      	}
      
      This is not so bad, but in this style *each caller* needs to indicate
      duplicate same error message, and some caller is forgetting to do it.
      And caller can't indicate detail function() error information.
      
      If function() indicates error message, we can get same and
      detail information without forgot.
      
      	int function(...)
      	{
      		...
      		if (ret < 0)
      			dev_err(...)
      
      		return ret;
      	}
      
      	int caller(...)
      	{
      		...
      		ret = function(...);
      		...
      	}
      
      This patch follow above style at soc_pcm_prepare().
      
      By this patch, dpcm_fe/be_dai_prepare(...)
      temporary lacks FE/BE error info, but it will reborn soon.
      Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Link: https://lore.kernel.org/r/87o8flutbn.wl-kuninori.morimoto.gx@renesas.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      dab7eeb4
    • Kuninori Morimoto's avatar
      ASoC: soc-pcm: indicate error message at soc_pcm_hw_params() · cb11f79b
      Kuninori Morimoto authored
      Indicating error message when failed case is very useful for debuging.
      In many case, its style is like below.
      
      	int function(...)
      	{
      		...
      		return ret;
      	}
      
      	int caller(...)
      	{
      		...
      		ret = function(...);
      		if (ret < 0)
      			dev_err(...)
      		...
      	}
      
      This is not so bad, but in this style *each caller* needs to indicate
      duplicate same error message, and some caller is forgetting to do it.
      And caller can't indicate detail function() error information.
      
      If function() indicates error message, we can get same and
      detail information without forgot.
      
      	int function(...)
      	{
      		...
      		if (ret < 0)
      			dev_err(...)
      
      		return ret;
      	}
      
      	int caller(...)
      	{
      		...
      		ret = function(...);
      		...
      	}
      
      This patch follow above style at soc_pcm_hw_params().
      
      By this patch, dpcm_fe/be_dai_hw_params(...)
      temporary lacks FE/BE error info, but it will reborn soon.
      Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Link: https://lore.kernel.org/r/87pn01utbt.wl-kuninori.morimoto.gx@renesas.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      cb11f79b
    • Kuninori Morimoto's avatar
      ASoC: soc-pcm: indicate error message at soc_pcm_open() · e4b044f4
      Kuninori Morimoto authored
      Indicating error message when failed case is very useful for debuging.
      In many case, its style is like below.
      
      	int function(...)
      	{
      		...
      		return ret;
      	}
      
      	int caller(...)
      	{
      		...
      		ret = function(...);
      		if (ret < 0)
      			dev_err(...)
      		...
      	}
      
      This is not so bad, but in this style *each caller* needs to indicate
      duplicate same error message, and some caller is forgetting to do it.
      And caller can't indicate detail function() error information.
      
      If function() indicates error message, we can get same and
      detail information without forgot.
      
      	int function(...)
      	{
      		...
      		if (ret < 0)
      			dev_err(...)
      
      		return ret;
      	}
      
      	int caller(...)
      	{
      		...
      		ret = function(...);
      		...
      	}
      
      This patch follow above style at soc_pcm_open().
      
      By this patch, dpcm_fe/be_dai_startup(...)
      temporary lacks FE/BE error info, but it will reborn soon.
      Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Link: https://lore.kernel.org/r/87r1khutby.wl-kuninori.morimoto.gx@renesas.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      e4b044f4
  2. 18 Mar, 2021 34 commits