1. 17 Apr, 2021 3 commits
    • David S. Miller's avatar
      Merge branch '1GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue · bc45f524
      David S. Miller authored
      Tony Nguyen says:
      
      ====================
      1GbE Intel Wired LAN Driver Updates 2021-04-16
      
      This series contains updates to igb and igc drivers.
      
      Ederson adjusts Tx buffer distributions in Qav mode to improve
      TSN-aware traffic for igb. He also enable PPS support and auxiliary PHC
      functions for igc.
      
      Grzegorz checks that the MTA register was properly written and
      retries if not for igb.
      
      Sasha adds reporting of EEE low power idle counters to ethtool and fixes
      a return value being overwritten through looping for igc.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      bc45f524
    • Gustavo A. R. Silva's avatar
      flow_dissector: Fix out-of-bounds warning in __skb_flow_bpf_to_target() · 1e3d976d
      Gustavo A. R. Silva authored
      Fix the following out-of-bounds warning:
      
      net/core/flow_dissector.c:835:3: warning: 'memcpy' offset [33, 48] from the object at 'flow_keys' is out of the bounds of referenced subobject 'ipv6_src' with type '__u32[4]' {aka 'unsigned int[4]'} at offset 16 [-Warray-bounds]
      
      The problem is that the original code is trying to copy data into a
      couple of struct members adjacent to each other in a single call to
      memcpy().  So, the compiler legitimately complains about it. As these
      are just a couple of members, fix this by copying each one of them in
      separate calls to memcpy().
      
      This helps with the ongoing efforts to globally enable -Warray-bounds
      and get us closer to being able to tighten the FORTIFY_SOURCE routines
      on memcpy().
      
      Link: https://github.com/KSPP/linux/issues/109Reported-by: default avatarkernel test robot <lkp@intel.com>
      Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1e3d976d
    • David S. Miller's avatar
      Merge branch 'ethtool-stats' · 1c86514d
      David S. Miller authored
      Jakub Kicinski says:
      
      ====================
      ethtool: add uAPI for reading standard stats
      
      Continuing the effort of providing a unified access method
      to standard stats, and explicitly tying the definitions to
      the standards this series adds an API for general stats
      which do no fit into more targeted control APIs.
      
      There is nothing clever here, just a netlink API for dumping
      statistics defined by standards and RFCs which today end up
      in ethtool -S under infinite variations of names.
      
      This series adds basic IEEE stats (for PHY, MAC, Ctrl frames)
      and RMON stats. AFAICT other RFCs only duplicate the IEEE
      stats.
      
      This series does _not_ add a netlink API to read driver-defined
      stats. There seems to be little to gain from moving that part
      to netlink.
      
      The netlink message format is very simple, and aims to allow
      adding stats and groups with no changes to user tooling (which
      IIUC is expected for ethtool).
      
      On user space side we can re-use -S, and make it dump
      standard stats if --groups are defined.
      
      $ ethtool -S eth0 --groups eth-phy eth-mac eth-ctrl rmon
      Stats for eth0:
      eth-phy-SymbolErrorDuringCarrier: 0
      eth-mac-FramesTransmittedOK: 0
      eth-mac-FrameTooLongErrors: 0
      eth-ctrl-MACControlFramesTransmitted: 0
      eth-ctrl-MACControlFramesReceived: 1
      eth-ctrl-UnsupportedOpcodesReceived: 0
      rmon-etherStatsUndersizePkts: 0
      rmon-etherStatsJabbers: 0
      rmon-rx-etherStatsPkts64Octets: 1
      rmon-rx-etherStatsPkts128to255Octets: 0
      rmon-rx-etherStatsPkts1024toMaxOctets: 1
      rmon-tx-etherStatsPkts64Octets: 1
      rmon-tx-etherStatsPkts128to255Octets: 0
      rmon-tx-etherStatsPkts1024toMaxOctets: 1
      
      v1:
      
      Driver support for mlxsw, mlx5 and bnxt included.
      
      Compared to the RFC I went ahead with wrapping the stats into
      a 1:1 nest. Now IDs of stats can start from 0, at a cost of
      slightly "careful" u64 alignment handling.
      
      v2:
      
      Add missing kdoc in patch 5.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1c86514d
  2. 16 Apr, 2021 37 commits