1. 31 May, 2019 26 commits
  2. 30 May, 2019 1 commit
  3. 29 May, 2019 2 commits
    • Imre Deak's avatar
      drm/mst: Fix MST sideband up-reply failure handling · d8fd3722
      Imre Deak authored
      Fix the breakage resulting in the stacktrace below, due to tx queue
      being full when trying to send an up-reply. txmsg->seqno is -1 in this
      case leading to a corruption of the mstb object by
      
      	txmsg->dst->tx_slots[txmsg->seqno] = NULL;
      
      in process_single_up_tx_qlock().
      
      [  +0,005162] [drm:process_single_tx_qlock [drm_kms_helper]] set_hdr_from_dst_qlock: failed to find slot
      [  +0,000015] [drm:drm_dp_send_up_ack_reply.constprop.19 [drm_kms_helper]] failed to send msg in q -11
      [  +0,000939] BUG: kernel NULL pointer dereference, address: 00000000000005a0
      [  +0,006982] #PF: supervisor write access in kernel mode
      [  +0,005223] #PF: error_code(0x0002) - not-present page
      [  +0,005135] PGD 0 P4D 0
      [  +0,002581] Oops: 0002 [#1] PREEMPT SMP NOPTI
      [  +0,004359] CPU: 1 PID: 1200 Comm: kworker/u16:3 Tainted: G     U            5.2.0-rc1+ #410
      [  +0,008433] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP, BIOS ICLSFWR1.R00.3175.A00.1904261428 04/26/2019
      [  +0,013323] Workqueue: i915-dp i915_digport_work_func [i915]
      [  +0,005676] RIP: 0010:queue_work_on+0x19/0x70
      [  +0,004372] Code: ff ff ff 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 41 56 49 89 f6 41 55 41 89 fd 41 54 55 53 48 89 d3 9c 5d fa e8 e7 81 0c 00 <f0> 48 0f ba 2b 00 73 31 45 31 e4 f7 c5 00 02 00 00 74 13 e8 cf 7f
      [  +0,018750] RSP: 0018:ffffc900007dfc50 EFLAGS: 00010006
      [  +0,005222] RAX: 0000000000000046 RBX: 00000000000005a0 RCX: 0000000000000001
      [  +0,007133] RDX: 000000000001b608 RSI: 0000000000000000 RDI: ffffffff82121972
      [  +0,007129] RBP: 0000000000000202 R08: 0000000000000000 R09: 0000000000000001
      [  +0,007129] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88847bfa5096
      [  +0,007131] R13: 0000000000000010 R14: ffff88849c08f3f8 R15: 0000000000000000
      [  +0,007128] FS:  0000000000000000(0000) GS:ffff88849dc80000(0000) knlGS:0000000000000000
      [  +0,008083] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      [  +0,005749] CR2: 00000000000005a0 CR3: 0000000005210006 CR4: 0000000000760ee0
      [  +0,007128] PKRU: 55555554
      [  +0,002722] Call Trace:
      [  +0,002458]  drm_dp_mst_handle_up_req+0x517/0x540 [drm_kms_helper]
      [  +0,006197]  ? drm_dp_mst_hpd_irq+0x5b/0x9c0 [drm_kms_helper]
      [  +0,005764]  drm_dp_mst_hpd_irq+0x5b/0x9c0 [drm_kms_helper]
      [  +0,005623]  ? intel_dp_hpd_pulse+0x205/0x370 [i915]
      [  +0,005018]  intel_dp_hpd_pulse+0x205/0x370 [i915]
      [  +0,004836]  i915_digport_work_func+0xbb/0x140 [i915]
      [  +0,005108]  process_one_work+0x245/0x610
      [  +0,004027]  worker_thread+0x37/0x380
      [  +0,003684]  ? process_one_work+0x610/0x610
      [  +0,004184]  kthread+0x119/0x130
      [  +0,003240]  ? kthread_park+0x80/0x80
      [  +0,003668]  ret_from_fork+0x24/0x50
      
      Cc: Lyude Paul <lyude@redhat.com>
      Cc: Dave Airlie <airlied@redhat.com>
      Signed-off-by: default avatarImre Deak <imre.deak@intel.com>
      Reviewed-by: default avatarLyude Paul <lyude@redhat.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20190523212433.9058-1-imre.deak@intel.com
      d8fd3722
    • Andrey Grodzovsky's avatar
  4. 28 May, 2019 5 commits
  5. 27 May, 2019 6 commits
    • Dave Airlie's avatar
      Merge tag 'drm-intel-next-2019-05-24' of git://anongit.freedesktop.org/drm/drm-intel into drm-next · 14ee642c
      Dave Airlie authored
      Features:
      - Engine discovery query (Tvrtko)
      - Support for DP YCbCr4:2:0 outputs (Gwan-gyeong)
      - HDCP revocation support, refactoring (Ramalingam)
      - Remove DRM_AUTH from IOCTLs which also have DRM_RENDER_ALLOW (Christian König)
      - Asynchronous display power disabling (Imre)
      - Perma-pin uC firmware and re-enable global reset (Fernando)
      - GTT remapping for display, for bigger fb size and stride (Ville)
      - Enable pipe HDR mode on ICL if only HDR planes are used (Ville)
      - Kconfig to tweak the busyspin durations for i915_wait_request (Chris)
      - Allow multiple user handles to the same VM (Chris)
      - GT/GEM runtime pm improvements using wakerefs (Chris)
      - Gen 4&5 render context support (Chris)
      - Allow userspace to clone contexts on creation (Chris)
      - SINGLE_TIMELINE flags for context creation (Chris)
      - Allow specification of parallel execbuf (Chris)
      
      Refactoring:
      - Header refactoring (Jani)
      - Move GraphicsTechnology files under gt/ (Chris)
      - Sideband code refactoring (Chris)
      
      Fixes:
      - ICL DSI state readout and checker fixes (Vandita)
      - GLK DSI picture corruption fix (Stanislav)
      - HDMI deep color fixes (Clinton, Aditya)
      - Fix driver unbinding from a device in use (Janusz)
      - Fix clock gating with pipe scaling (Radhakrishna)
      - Disable broken FBC on GLK (Daniel Drake)
      - Miscellaneous GuC fixes (Michal)
      - Fix MG PHY DP register programming (Imre)
      - Add missing combo PHY lane power setup (Imre)
      - Workarounds for early ICL VBT issues (Imre)
      - Fix fastset vs. pfit on/off on HSW EDP transcoder (Ville)
      - Add readout and state check for pch_pfit.force_thru (Ville)
      - Miscellaneous display fixes and refactoring (Ville)
      - Display workaround fixes (Ville)
      - Enable audio even if ELD is bogus (Ville)
      - Fix use-after-free in reporting create.size (Chris)
      - Sideband fixes to avoid BYT hard lockups (Chris)
      - Workaround fixes and improvements (Chris)
      
      Maintainer shortcomings:
      - Failure to adequately describe and give credit for all changes (Jani)
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      
      From: Jani Nikula <jani.nikula@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/87sgt3n45z.fsf@intel.com
      14ee642c
    • Dave Airlie's avatar
      Merge tag 'drm-misc-next-2019-05-24' of git://anongit.freedesktop.org/drm/drm-misc into drm-next · 88cd7a2c
      Dave Airlie authored
      drm-misc-next for v5.3, try #2:
      
      UAPI Changes:
      - Add HDR source metadata property.
      - Make drm.h compile on GNU/kFreeBSD by including stdint.h
      - Clarify how the userspace reviewer has to review new kernel UAPI.
      - Clarify that for using new UAPI, merging to drm-next or drm-misc-next should be enough.
      
      Cross-subsystem Changes:
      - video/hdmi: Add unpack function for DRM infoframes.
      - Device tree bindings:
        * Updating a property for Mali Midgard GPUs
        * Updating a property for STM32 DSI panel
        * Adding support for FriendlyELEC HD702E 800x1280 panel
        * Adding support for Evervision VGG804821 800x480 5.0" WVGA TFT panel
        * Adding support for the EDT ET035012DM6 3.5" 320x240 QVGA 24-bit RGB TFT.
        * Adding support for Three Five displays TFC S9700RTWV43TR-01B 800x480 panel
          with resistive touch found on TI's AM335X-EVM.
        * Adding support for EDT ETM0430G0DH6 480x272 panel.
      - Add OSD101T2587-53TS driver with DT bindings.
      - Add Samsung S6E63M0 panel driver with DT bindings.
      - Add VXT VL050-8048NT-C01 800x480 panel with DT bindings.
      - Dma-buf:
        - Make mmap callback actually optional.
        - Documentation updates.
        - Fix debugfs refcount inbalance.
        - Remove unused sync_dump function.
      - Fix device tree bindings in drm-misc-next after a botched merge.
      
      Core Changes:
      - Add support for HDR infoframes and related EDID parsing.
      - Remove prime sg_table caching, now done inside dma-buf.
      - Add shiny new drm_gem_vram helpers for simple VRAM drivers;
        with some fixes to the new API on top.
      - Small fix to job cleanup without timeout handler.
      - Documentation fixes to drm_fourcc.
      - Replace lookups of drm_format with struct drm_format_info;
        remove functions that become obsolete by this conversion.
      - Remove double include in bridge/panel.c and some drivers.
      - Remove drmP.h include from drm/edid and drm/dp.
      - Fix null pointer deref in drm_fb_helper_hotplug_event().
      - Remove most members from drm_fb_helper_crtc, only mode_set is kept.
      - Remove race of fb helpers with userspace; only restore mode
        when userspace is not master.
      - Move legacy setup from drm_file.c to drm_legacy_misc.c
      - Rework scheduler job destruction.
      - drm/bus was removed, remove from TODO.
      - Add __drm_atomic_helper_crtc_reset() to subclass crtc_state,
        and convert some drivers to use it (conversion is not complete yet).
      - Bump vblank timeout wait to 100 ms for atomic.
      - Docbook fix for drm_hdmi_infoframe_set_hdr_metadata.
      
      Driver Changes:
      - sun4i: Use DRM_GEM_CMA_VMAP_DRIVER_OPS instead of definining manually.
      - v3d: Small cleanups, adding support for compute shaders,
             reservation/synchronization fixes and job management refactoring,
             fixes MMU and debugfs.
      - lima: Fix null pointer in irq handler on startup, set default timeout for scheduled jobs.
      - stm/ltdc: Assorted fixes and adding FB modifier support.
      - amdgpu: Avoid hw reset if guilty job was already signaled.
      - virtio: Add seqno to fences, add trace events, use correct flags for fence allocation.
      - Convert AST, bochs, mgag200, vboxvideo, hisilicon to the new drm_gem_vram API.
      - sun6i_mipi_dsi: Support DSI GENERIC_SHORT_WRITE_2 transfers.
      - bochs: Small fix to use PTR_RET_OR_ZERO and driver unload.
      - gma500: header fixes
      - cirrus: Remove unused files.
      - mediatek: Fix compiler warning after merging the HDR series.
      - vc4: Rework binner bo handling.
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      
      From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/052875a5-27ba-3832-60c2-193d950afdff@linux.intel.com
      88cd7a2c
    • Sam Ravnborg's avatar
      drm: drop use of drmP.h in drm/* · 0500c04e
      Sam Ravnborg authored
      The use of the drmP.h header file is deprecated.
      Remove use from all files in drm/*
      so people do not look there and follow a bad example.
      
      Build tested allyesconfig,allmodconfig on x86, arm etc.
      Including alpha that is as always more challenging than
      the rest.
      Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Acked-by: default avatarDaniel Vetter <daniel@ffwll.ch>
      Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Cc: Maxime Ripard <maxime.ripard@bootlin.com>
      Cc: Sean Paul <sean@poorly.run>
      Cc: David Airlie <airlied@linux.ie>
      Link: https://patchwork.freedesktop.org/patch/msgid/20190526173535.32701-8-sam@ravnborg.org
      0500c04e
    • Sam Ravnborg's avatar
      drm: make drm_trace.h self-contained · 34112ded
      Sam Ravnborg authored
      Do not require users of drm_trace.h to include other
      files just to let it build
      Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Acked-by: default avatarDaniel Vetter <daniel@ffwll.ch>
      Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Cc: Maxime Ripard <maxime.ripard@bootlin.com>
      Cc: Sean Paul <sean@poorly.run>
      Cc: David Airlie <airlied@linux.ie>
      Link: https://patchwork.freedesktop.org/patch/msgid/20190526173535.32701-7-sam@ravnborg.org
      34112ded
    • Sam Ravnborg's avatar
      drm: make drm_legacy.h self-contained · b8d11488
      Sam Ravnborg authored
      Do not require users of drm_legacy.h to include other
      files just to let it build
      Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Acked-by: default avatarDaniel Vetter <daniel@ffwll.ch>
      Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Cc: Maxime Ripard <maxime.ripard@bootlin.com>
      Cc: Sean Paul <sean@poorly.run>
      Cc: David Airlie <airlied@linux.ie>
      Link: https://patchwork.freedesktop.org/patch/msgid/20190526173535.32701-6-sam@ravnborg.org
      b8d11488
    • Sam Ravnborg's avatar
      drm: make drm_internal.h self-contained · 7a44fdce
      Sam Ravnborg authored
      Do not require users of drm_internal.h to include other
      files just to let it build
      Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Acked-by: default avatarDaniel Vetter <daniel@ffwll.ch>
      Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Cc: Maxime Ripard <maxime.ripard@bootlin.com>
      Cc: Sean Paul <sean@poorly.run>
      Cc: David Airlie <airlied@linux.ie>
      Link: https://patchwork.freedesktop.org/patch/msgid/20190526173535.32701-5-sam@ravnborg.org
      7a44fdce