1. 15 Mar, 2004 6 commits
  2. 11 Mar, 2004 1 commit
    • Mark M. Hoffman's avatar
      [PATCH] I2C: sensor chip driver refactoring · cbc22621
      Mark M. Hoffman authored
      This patch is a refactoring of some common code among all sensors chip
      drivers (except asb100, which was written this way to begin with.)
      It saves a handful of lines and ~100-300 bytes per module.  It compiles
      ok.  I've only tested it against one of the drivers, but the changes are
      similar across the board and quite mechanical.  Please apply.
      cbc22621
  3. 10 Mar, 2004 1 commit
    • Jean Delvare's avatar
      [PATCH] I2C: Cleanup fan_div in w83781d · c188b751
      Jean Delvare authored
      Here is a proposed patch that cleanups the fan_div code from w83781d.
      The original code was obviously taken from the 2.4 driver, but the way
      things were done in 2.4 do not make any sense anymore (because we now
      have a single value per interface file).
      
      Since fan divisor bits are spread over three different regs with various
      bitmask manipulations, I don't think it makes much sense to have a
      single function as we do in most other cases. Having three different
      functions makes more sense, although they are of course similar. The
      size increment is only 581 bytes, I don't think its a problem since it
      also makes the code much more efficient and readable too IMHO.
      
      I agree that the original code was working - it was simply doing far too
      much work each time one would want to change a fan divisor.
      
      Originally, I took a look at the code because I wanted to fix the fact
      that changing fan divisors breaks fan mins. But it looked like a good
      cleanup before doing that was required. Once this patch will have been
      accepted, I'll work on the other one.
      
      I've tested my patch successfully on a W83781D and an AS99127F rev.1.
      Note that this means that one part of the code wasn't tested, because
      these are the two chips of the family that do not support divisors
      greater than 8. If anyone can test it, please do.
      c188b751
  4. 09 Mar, 2004 6 commits
    • Jean Delvare's avatar
      [PATCH] I2c: Kconfig for non-sensors i2c chip drivers · 2ddfac4e
      Jean Delvare authored
      Quoting myself:
      
      > I think that it would make sense to have a specific menu entry for
      > these, separate from the sensors stuff. Looks like an easy thing to
      > do.
      
      Here is a proposed patch that does this. Comments welcome.
      2ddfac4e
    • Jean Delvare's avatar
      [PATCH] I2C: fix i2c adapters class for now · 73126bc4
      Jean Delvare authored
      Please accept this temporary fix for the class issue. I'd like users of
      the i2c-ali1535, i2c-sis5595 and i2c-via driver to be able to use
      sensors as soon as possible, even if we have not yet determined what our
      policy WRT classes should be.
      
      Thanks.
      
      BTW, don't you think I2C_ADAP_CLASS_SMBUS is a misnomer? It's about
      hardware monitoring, not the SMBus protocol. I'd say
      I2C_ADAP_CLASS_HWMON or I2C_ADAP_CLASS_SENSORS would have been more
      appropriate (although it may be a bit late for a change...)
      73126bc4
    • Randy Dunlap's avatar
      [PATCH] I2C: fix i2c-prosavage.c section usage · 5ed3593c
      Randy Dunlap authored
      prosavage_remove() is called during init, so it shouldn't be
      marked as exit code.  (It matters when CONFIG_HOTPLUG=n.)
      5ed3593c
    • Mark M. Hoffman's avatar
      [PATCH] I2C: sysfs interface update for w83627hf · 90d1a336
      Mark M. Hoffman authored
      This patch updates the sysfs names of the w83627hf driver
      to match the new standard.  The patch applies on top of
      one recently applied to your tree [1].  I have tested it
      using a w83627thf & the latest lm_sensors CVS.  Please apply.
      
      [1] http://archives.andrew.net.au/lm-sensors/msg06746.html
      90d1a336
    • Russell King's avatar
      [PATCH] I2C: Fix i2c_use_client() · 293ff9af
      Russell King authored
      i2c_use_client() contains a bogosity.  If i2c_inc_use_client() returns
      success, i2c_use_client() returns an error.  If i2c_inc_use_client()
      fails, i2c_use_client() might succeed.
      
      Fix it so that (a) we get the correct sense between these two functions,
      and (b) propagate the error code from i2c_inc_use_client(), rather than
      making our own one up.
      293ff9af
    • Jean Delvare's avatar
      [PATCH] I2C: Prevent i2c-dev oops with debug · 7fcd561a
      Jean Delvare authored
      Looks like i2c-dev suffers the same problem with dev_dbg as i2c-core did
      twice. Here is a patch that fixed a oops I and another user were
      experiencing when running sensors-detect.
      7fcd561a
  5. 08 Mar, 2004 1 commit
  6. 07 Mar, 2004 5 commits
  7. 06 Mar, 2004 20 commits
    • Andrew Morton's avatar
      [PATCH] floppy oops fix · bdfe6862
      Andrew Morton authored
      From: Zwane Mwaikambo <zwane@linuxpower.ca>
      
      It looks like a block request snuck through before we had initialised the
      motor_off_timer timers.  So I pushed the timer init earlier.
      bdfe6862
    • Andrew Morton's avatar
      [PATCH] OSS Sound Driver Forte needs ac97_codec · 1ec55db5
      Andrew Morton authored
      From: Marc-Christian Petersen <m.c.p@wolk-project.de>
      
      OSS Sound Driver Forte needs ac97_codec.
      1ec55db5
    • Andrew Morton's avatar
      [PATCH] fix i2c compile warnings · b2ea9dcb
      Andrew Morton authored
      drivers/i2c/busses/i2c-elv.c: In function `i2c_bitelv_init':
      
      drivers/i2c/busses/i2c-elv.c:155: warning: unsigned int format, long int arg (arg 2)
      drivers/i2c/busses/i2c-elv.c:155: warning: unsigned int format, long int arg (arg 2)
      drivers/i2c/busses/i2c-velleman.c: In function `i2c_bitvelle_init':
      drivers/i2c/busses/i2c-velleman.c:141: warning: unsigned int format, long int arg (arg 2)
      drivers/i2c/busses/i2c-velleman.c:141: warning: unsigned int format, long int arg (arg 2)
      b2ea9dcb
    • Andrew Morton's avatar
      [PATCH] Documentation/cdrom/ide-cd fix · 2cc53dd5
      Andrew Morton authored
      From: David Joerg <davidjoerg@web.de>
      
      Fix the description of the IO ports for the IDE primary and secondary
      interfaces.
      2cc53dd5
    • Andrew Morton's avatar
      [PATCH] alpha ptrace race fix · 01d63346
      Andrew Morton authored
      From: Aneesh Kumar KV <aneesh.kumar@digital.com>
      
      We need to set the tasks's exit code prior to waking it, not afterwards.
      
      Acked by rth.
      01d63346
    • Andrew Morton's avatar
      [PATCH] Fix nobh_prepare_write() race · b12088bf
      Andrew Morton authored
      Dave Kleikamp <shaggy@austin.ibm.com> points out a race between
      nobh_prepare_write() and end_buffer_read_sync().  end_buffer_read_sync()
      calls unlock_buffer(), waking the nobh_prepare_write() thread, which
      immediately frees the buffer_head.  end_buffer_read_sync() then calls
      put_bh() which decrements b_count for the already freed structure.  The
      SLAB_DEBUG code detects the slab corruption.
      
      We fix this by giving nobh_prepare_write() a private buffer_head end_o
      handler which doesn't touch the buffer's contents after unlocking it.
      b12088bf
    • Andrew Morton's avatar
      [PATCH] CONFIG_LBD fixes · d67c0fd5
      Andrew Morton authored
      From: Eric Sandeen <sandeen@sgi.com>
      
      Several functions in buffer.c are using unsigned long where they should be
      using sector_t.
      
      Also, use pgoff_t in several places so it is easier to tell what is beingused
      as a pagecache index, what is being used as a disk index and what is being
      used as an offset-into-page.
      d67c0fd5
    • Andrew Morton's avatar
      [PATCH] fix oops in emu10k1_wavein_open() error recovery · 1cd4dae0
      Andrew Morton authored
      If a large pci_alloc_consistent() GFP_ATOMIC allocation fails this driver's
      recovery code will call emu10k1_wavein_close() far earlier than it should: it
      goes splat in emu10k1_timer_uninstall().
      
      Fix it by simply removing that call: we haven't allocated any resources yet
      anyway.
      
      Note that one of the callers of emu10k1_wavein_open(), emu10k1_audio_read()
      will sit there stupidly retrying the open.  But it has a sleep in there so
      something might eventually give way.
      1cd4dae0
    • Andrew Morton's avatar
      [PATCH] i2o subsystem minor bugfixes · 50d89de7
      Andrew Morton authored
      From: Markus Lidel <Markus.Lidel@shadowconnect.com>
      
      drivers/message/i2o/i2o_block.c:
      
       - corrected the initialization sequence of the request queues.
      
       - added initialization to queue spinlocks.
      
       - release device in i2o_scan because else the device could not be queried.
      
       - i2o_block event threads wait on signal KILL but signal TERM was sent.
      
      drivers/message/i2o/i2o_core.c:
      
       - set the HRT length to 0 at initialization, to avoid calling free on
         unallocated memory.
      
       - i2o_core event threads wait on signal KILL but signal TERM was sent.
      
       - added a limit of 3 tries to get the HRT from the controller.
      
       - removed the dpt parameter, which was used to force DPT controllers get
         handled by the i2o driver.  Now all available i2o controllers will be
         handled by this driver.
      
      drivers/message/i2o/i2o_scsi.c:
      
       - beautifying of printk calls.
      
       - added scsi_unregister to properly clean up on module unload.
      
      drivers/message/i2o/Kconfig:
      
       - added help for i2o_block and i2o_scsi to describe the differences between
         the two drivers.
      
      include/linux/i2o-dev.h:
      
       - cleaned typo "tate" into "state".
      
      include/linux/i2o.h:
      
       - removed defines from i2o_block and insert it here.
      
      (Acked by Alan)
      50d89de7
    • Andrew Morton's avatar
      [PATCH] v4l1 compatibility module fix. · 84e0e179
      Andrew Morton authored
      From: Gerd Knorr <kraxel@bytesex.org>
      
      This patch fixes a bug in the v4l1-compat module and makes it pass the
      correct buffer type to the v4l2 driver on VIDIOC_STREAM(ON|OFF) ioctls.
      84e0e179
    • Andrew Morton's avatar
      [PATCH] add missing MODULE_LICENSEs · 18e0d45e
      Andrew Morton authored
      From: Arjan van de Ven <arjanv@redhat.com>
      18e0d45e
    • Andrew Morton's avatar
      [PATCH] ext2/ext3 -ENOSPC bug · 5e9087ad
      Andrew Morton authored
      From: Chris Mason <mason@suse.com>
      
      find_group_other looks buggy for ext2 and ext3 in 2.6, it can cause -ENOSPC
      errors when the fs has plenty of free room.
      
      To hit the bug, you need a filesystem where:
      
      parent_group has no free blocks (but might have free inodes) Every other
      group with free inodes has no free blocks.
      
      That gets you down to the final linear search in find_group_other.  The
      linear search has two bugs:
      
      group = parent_group + 1; means we start searching at parent_group + 2
      because the loop increments group before using it.
      
      for(i = 2 ; i < ngroups ; i++) means we don't search through all the
      groups.
      
      The end result is that parent_group and parent_group + 1 are not checked
      for free inodes in the final linear search.  ext3 has the same problem.
      5e9087ad
    • Andrew Morton's avatar
      [PATCH] sb16 sample size fix · f8abc670
      Andrew Morton authored
      From: Andreas Kies <andikies@t-online.de>
      
      Fix improperly handled 16 bit sample size.  If you use an odd number of
      bytes in 16 bit mode the driver fails to work.
      f8abc670
    • Andrew Morton's avatar
      [PATCH] serial_core.h needs sched.h · 9352726c
      Andrew Morton authored
      In file included from drivers/misc/ibmasm/uart.c:27:
      include/linux/serial_core.h: In function `uart_handle_dcd_change':
      include/linux/serial_core.h:407: `TASK_INTERRUPTIBLE' undeclared (first use in this function)
      9352726c
    • Andrew Morton's avatar
      [PATCH] kill a dead function in lockd · 03970c32
      Andrew Morton authored
      From: Christoph Hellwig <hch@lst.de>
      
      sleep_on hurts my eyes and this offender is compltely unused, so..
      03970c32
    • Andrew Morton's avatar
      [PATCH] c99 initializers for cs46xx_wrapper · 61a318bf
      Andrew Morton authored
      From: Arnd Bergmann <arnd@arndb.de>
      
      This use of deprecated struct initializers was hidden behind macro magic
      and has appearantly not been noticed before.
      61a318bf
    • Andrew Morton's avatar
      [PATCH] Fix initrd Kconfig dependencies · 57d5b52e
      Andrew Morton authored
      From: "Jim Gifford" <maillist@jg555.com>
      
      Prevent initrd from being built if ram device is built as a module.
      57d5b52e
    • Andrew Morton's avatar
      [PATCH] char/rio/rioctrl: fix ioctl return values · 8f048a26
      Andrew Morton authored
      From: "Randy.Dunlap" <rddunlap@osdl.org>
      
      From: Tony Breeds <tony@bakeyournoodle.com>
      
      It fixes 3 places where the ioctl returns positives instead of negatives.
      I've gotten feedback from the maintainer (Rogier Wolff (sp?) and he has no
      objections.
      8f048a26
    • Andrew Morton's avatar
      [PATCH] fix put_compat_timespec prototype · e729d83f
      Andrew Morton authored
      From: Arnd Bergmann <arnd@arndb.de>
      
      The wrong argument in put_compat_timespec is marked const, causing
      unnecessary compiler warnings.
      e729d83f
    • Andrew Morton's avatar
      [PATCH] ppc64: Convert mm_context_t to a struct · 5b9c017d
      Andrew Morton authored
      From: David Gibson <david@gibson.dropbear.id.au>
      
      Converts the mm_context_t on ppc64 to be a struct.  This lets us separate
      the low_hpages flag into a separate field rather than folding it into the
      actual context id.  That makes things neater, since the flag is
      conceptually separate and has, for example, should be propogate across a
      fork whereas the context ID obviously isn't.  The mm_context_id is the only
      place to put arch-specific information in the mm_struct.
      
      This patch will also make some interesting extensions to the hugepage
      support much easier, such as allowing dynamic resizing of the hugepage
      address space, or using special pagetables for hugepages.
      5b9c017d