1. 14 Apr, 2024 3 commits
  2. 13 Apr, 2024 5 commits
    • Linus Torvalds's avatar
      Merge tag 'ata-6.9-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux · 7efd0a74
      Linus Torvalds authored
      Pull ata fixes from Damien Le Moal:
      
       - Add the mask_port_map parameter to the ahci driver. This is a
         follow-up to the recent snafu with the ASMedia controller and its
         virtual port hidding port-multiplier devices. As ASMedia confirmed
         that there is no way to determine if these slow-to-probe virtual
         ports are actually representing the ports of a port-multiplier
         devices, this new parameter allow masking ports to significantly
         speed up probing during system boot, resulting in shorter boot times.
      
       - A fix for an incorrect handling of a port unlock in
         ata_scsi_dev_rescan().
      
       - Allow command duration limits to be detected for ACS-4 devices are
         there are such devices out in the field.
      
      * tag 'ata-6.9-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux:
        ata: libata-core: Allow command duration limits detection for ACS-4 drives
        ata: libata-scsi: Fix ata_scsi_dev_rescan() error path
        ata: ahci: Add mask_port_map module parameter
      7efd0a74
    • Linus Torvalds's avatar
      Merge tag 'zonefs-6.9-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/zonefs · 76b0e9c4
      Linus Torvalds authored
      Pull zonefs fix from Damien Le Moal:
      
       - Suppress a coccicheck warning using str_plural()
      
      * tag 'zonefs-6.9-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/zonefs:
        zonefs: Use str_plural() to fix Coccinelle warning
      76b0e9c4
    • Linus Torvalds's avatar
      Merge tag 'v6.9-rc3-SMB3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6 · fa4022cb
      Linus Torvalds authored
      Pull smb client fixes from Steve French:
      
       - fix for oops in cifs_get_fattr of deleted files
      
       - fix for the remote open counter going negative in some directory
         lease cases
      
       - fix for mkfifo to instantiate dentry to avoid possible crash
      
       - important fix to allow handling key rotation for mount and remount
         (ie cases that are becoming more common when password that was used
         for the mount will expire soon but will be replaced by new password)
      
      * tag 'v6.9-rc3-SMB3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6:
        smb3: fix broken reconnect when password changing on the server by allowing password rotation
        smb: client: instantiate when creating SFU files
        smb3: fix Open files on server counter going negative
        smb: client: fix NULL ptr deref in cifs_mark_open_handles_for_deleted_file()
      fa4022cb
    • Igor Pylypiv's avatar
      ata: libata-core: Allow command duration limits detection for ACS-4 drives · c0297e7d
      Igor Pylypiv authored
      Even though the command duration limits (CDL) feature was first added
      in ACS-5 (major version 12), there are some ACS-4 (major version 11)
      drives that implement CDL as well.
      
      IDENTIFY_DEVICE, SUPPORTED_CAPABILITIES, and CURRENT_SETTINGS log pages
      are mandatory in the ACS-4 standard so it should be safe to read these
      log pages on older drives implementing the ACS-4 standard.
      
      Fixes: 62e4a60e ("scsi: ata: libata: Detect support for command duration limits")
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarIgor Pylypiv <ipylypiv@google.com>
      Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
      c0297e7d
    • Damien Le Moal's avatar
      ata: libata-scsi: Fix ata_scsi_dev_rescan() error path · 79336504
      Damien Le Moal authored
      Commit 0c76106c ("scsi: sd: Fix TCG OPAL unlock on system resume")
      incorrectly handles failures of scsi_resume_device() in
      ata_scsi_dev_rescan(), leading to a double call to
      spin_unlock_irqrestore() to unlock a device port. Fix this by redefining
      the goto labels used in case of errors and only unlock the port
      scsi_scan_mutex when scsi_resume_device() fails.
      
      Bug found with the Smatch static checker warning:
      
      	drivers/ata/libata-scsi.c:4774 ata_scsi_dev_rescan()
      	error: double unlocked 'ap->lock' (orig line 4757)
      Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
      Fixes: 0c76106c ("scsi: sd: Fix TCG OPAL unlock on system resume")
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
      Reviewed-by: default avatarNiklas Cassel <cassel@kernel.org>
      79336504
  3. 12 Apr, 2024 21 commits
    • Linus Torvalds's avatar
      Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux · 8f2c0577
      Linus Torvalds authored
      Pull arm64 fix from Catalin Marinas:
       "Fix the TLBI RANGE operand calculation causing live migration under
        KVM/arm64 to miss dirty pages due to stale TLB entries"
      
      * tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux:
        arm64: tlb: Fix TLBI RANGE operand
      8f2c0577
    • Linus Torvalds's avatar
      Merge tag 'soc-fixes-6.9-1' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc · 678e14c7
      Linus Torvalds authored
      Pull SoC fixes from Arnd Bergmann:
       "The device tree changes this time are all for NXP i.MX platforms,
        addressing issues with clocks and regulators on i.MX7 and i.MX8.
      
        The old OMAP2 based Nokia N8x0 tablet get a couple of code fixes for
        regressions that came in.
      
        The ARM SCMI and FF-A firmware interfaces get a couple of minor bug
        fixes.
      
        A regression fix for RISC-V cache management addresses a problem with
        probe order on Sifive cores"
      
      * tag 'soc-fixes-6.9-1' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc: (23 commits)
        MAINTAINERS: Change Krzysztof Kozlowski's email address
        arm64: dts: imx8qm-ss-dma: fix can lpcg indices
        arm64: dts: imx8-ss-dma: fix can lpcg indices
        arm64: dts: imx8-ss-dma: fix adc lpcg indices
        arm64: dts: imx8-ss-dma: fix pwm lpcg indices
        arm64: dts: imx8-ss-dma: fix spi lpcg indices
        arm64: dts: imx8-ss-conn: fix usb lpcg indices
        arm64: dts: imx8-ss-lsio: fix pwm lpcg indices
        ARM: dts: imx7s-warp: Pass OV2680 link-frequencies
        ARM: dts: imx7-mba7: Use 'no-mmc' property
        arm64: dts: imx8-ss-conn: fix usdhc wrong lpcg clock order
        arm64: dts: freescale: imx8mp-venice-gw73xx-2x: fix USB vbus regulator
        arm64: dts: freescale: imx8mp-venice-gw72xx-2x: fix USB vbus regulator
        cache: sifive_ccache: Partially convert to a platform driver
        firmware: arm_scmi: Make raw debugfs entries non-seekable
        firmware: arm_scmi: Fix wrong fastchannel initialization
        firmware: arm_ffa: Fix the partition ID check in ffa_notification_info_get()
        ARM: OMAP2+: fix USB regression on Nokia N8x0
        mmc: omap: restore original power up/down steps
        mmc: omap: fix deferred probe
        ...
      678e14c7
    • Linus Torvalds's avatar
      Merge tag 'iommu-fixes-v6.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu · c7c4e130
      Linus Torvalds authored
      Pull iommu fixes from Joerg Roedel:
      
       - Intel VT-d Fixes:
           - Allocate local memory for PRQ page
           - Fix WARN_ON in iommu probe path
           - Fix wrong use of pasid config
      
       - AMD IOMMU Fixes:
           - Lock inversion fix
           - Log message severity fix
           - Disable SNP when v2 page-tables are used
      
       - Mediatek driver:
           - Fix module autoloading
      
      * tag 'iommu-fixes-v6.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu:
        iommu/amd: Change log message severity
        iommu/vt-d: Fix WARN_ON in iommu probe path
        iommu/vt-d: Allocate local memory for page request queue
        iommu/vt-d: Fix wrong use of pasid config
        iommu: mtk: fix module autoloading
        iommu/amd: Do not enable SNP when V2 page table is enabled
        iommu/amd: Fix possible irq lock inversion dependency issue
      c7c4e130
    • Linus Torvalds's avatar
      Merge tag 'pci-v6.9-fixes-1' of git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci · b3812ff0
      Linus Torvalds authored
      Pull pci fixes from Bjorn Helgaas:
      
       - Revert a quirk that prevented Secondary Bus Reset for LSI / Agere
         FW643.
      
         We thought the device was broken, but the reset does work correctly
         on other platforms, and the reset avoids leaking data out of VMs
         (Bjorn Helgaas)
      
       - Update MAINTAINERS to reflect that Gustavo Pimentel is no longer
         reachable (Manivannan Sadhasivam)
      
      * tag 'pci-v6.9-fixes-1' of git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci:
        Revert "PCI: Mark LSI FW643 to avoid bus reset"
        MAINTAINERS: Drop Gustavo Pimentel as PCI DWC Maintainer
      b3812ff0
    • Linus Torvalds's avatar
      Merge tag 'block-6.9-20240412' of git://git.kernel.dk/linux · d7ad0581
      Linus Torvalds authored
      Pull block fixes from Jens Axboe:
      
       - MD pull request via Song:
             - UAF fix (Yu)
      
       - Avoid out-of-bounds shift in blk-iocost (Rik)
      
       - Fix for q->blkg_list corruption (Ming)
      
       - Relax virt boundary mask/size segment checking (Ming)
      
      * tag 'block-6.9-20240412' of git://git.kernel.dk/linux:
        block: fix that blk_time_get_ns() doesn't update time after schedule
        block: allow device to have both virt_boundary_mask and max segment size
        block: fix q->blkg_list corruption during disk rebind
        blk-iocost: avoid out of bounds shift
        raid1: fix use-after-free for original bio in raid1_write_request()
      d7ad0581
    • Linus Torvalds's avatar
      Merge tag 'io_uring-6.9-20240412' of git://git.kernel.dk/linux · c7adbe2e
      Linus Torvalds authored
      Pull io_uring fixes from Jens Axboe:
      
       - Fix for sigmask restoring while waiting for events (Alexey)
      
       - Typo fix in comment (Haiyue)
      
       - Fix for a msg_control retstore on SEND_ZC retries (Pavel)
      
      * tag 'io_uring-6.9-20240412' of git://git.kernel.dk/linux:
        io-uring: correct typo in comment for IOU_F_TWQ_LAZY_WAKE
        io_uring/net: restore msg_control on sendzc retry
        io_uring: Fix io_cqring_wait() not restoring sigmask on get_timespec64() failure
      c7adbe2e
    • Linus Torvalds's avatar
      Merge tag 'ceph-for-6.9-rc4' of https://github.com/ceph/ceph-client · 90d3eaaf
      Linus Torvalds authored
      Pull ceph fixes from Ilya Dryomov:
       "Two CephFS fixes marked for stable and a MAINTAINERS update"
      
      * tag 'ceph-for-6.9-rc4' of https://github.com/ceph/ceph-client:
        MAINTAINERS: remove myself as a Reviewer for Ceph
        ceph: switch to use cap_delay_lock for the unlink delay list
        ceph: redirty page before returning AOP_WRITEPAGE_ACTIVATE
      90d3eaaf
    • Linus Torvalds's avatar
      Kconfig: add some hidden tabs on purpose · d5cf50da
      Linus Torvalds authored
      Commit d96c3600 ("tracing: Fix FTRACE_RECORD_RECURSION_SIZE Kconfig
      entry") removed a hidden tab because it apparently showed breakage in
      some third-party kernel config parsing tool.
      
      It wasn't clear what tool it was, but let's make sure it gets fixed.
      Because if you can't parse tabs as whitespace, you should not be parsing
      the kernel Kconfig files.
      
      In fact, let's make such breakage more obvious than some esoteric ftrace
      record size option.  If you can't parse tabs, you can't have page sizes.
      
      Yes, tab-vs-space confusion is sadly a traditional Unix thing, and
      'make' is famous for being broken in this regard.  But no, that does not
      mean that it's ok.
      
      I'd add more random tabs to our Kconfig files, but I don't want to make
      things uglier than necessary.  But it *might* bbe necessary if it turns
      out we see more of this kind of silly tooling.
      
      Fixes: d96c3600 ("tracing: Fix FTRACE_RECORD_RECURSION_SIZE Kconfig entry")
      Link: https://lore.kernel.org/lkml/CAHk-=wj-hLLN_t_m5OL4dXLaxvXKy_axuoJYXif7iczbfgAevQ@mail.gmail.com/Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      d5cf50da
    • Linus Torvalds's avatar
      Merge tag 'trace-v6.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace · 5939d451
      Linus Torvalds authored
      Pull tracing fixes from Steven Rostedt:
      
       - Fix the buffer_percent accounting as it is dependent on three
         variables:
      
           1) pages_read - number of subbuffers read
           2) pages_lost - number of subbuffers lost due to overwrite
           3) pages_touched - number of pages that a writer entered
      
         These three counters only increment, and to know how many active
         pages there are on the buffer at any given time, the pages_read and
         pages_lost are subtracted from pages_touched.
      
         But the pages touched was incremented whenever any writer went to the
         next subbuffer even if it wasn't the only one, so it was incremented
         more than it should be causing the counter for how many subbuffers
         currently have content incorrect, which caused the buffer_percent
         that holds waiters until the ring buffer is filled to a given
         percentage to wake up early.
      
       - Fix warning of unused functions when PERF_EVENTS is not configured in
      
       - Replace bad tab with space in Kconfig for FTRACE_RECORD_RECURSION_SIZE
      
       - Fix to some kerneldoc function comments in eventfs code.
      
      * tag 'trace-v6.9-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace:
        ring-buffer: Only update pages_touched when a new page is touched
        tracing: hide unused ftrace_event_id_fops
        tracing: Fix FTRACE_RECORD_RECURSION_SIZE Kconfig entry
        eventfs: Fix kernel-doc comments to functions
      5939d451
    • Linus Torvalds's avatar
      Merge tag 'mips-fixes_6.9_1' of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux · e00011a1
      Linus Torvalds authored
      Pull MIPS fix from Thomas Bogendoerfer:
       "Fix for syscall_get_nr() to make it work even if tracing is disabled"
      
      * tag 'mips-fixes_6.9_1' of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux:
        MIPS: scall: Save thread_info.syscall unconditionally on entry
      e00011a1
    • Linus Torvalds's avatar
      Merge tag 'drm-fixes-2024-04-12' of https://gitlab.freedesktop.org/drm/kernel · d1c13e80
      Linus Torvalds authored
      Pull drm fixes from Dave Airlie:
       "Looks like everyone woke up after holidays, this weeks pull has a
        bunch of stuff all over, 2 weeks worth of amdgpu is a lot of it, then
        i915/xe have a few, a bunch of msm fixes, then some scattered driver
        fixes.
      
        I expect things will settle down for rc5.
      
        client:
         - Protect connector modes with mode_config mutex
      
        ast:
         - Fix soft lockup
      
        host1x:
         - Do not setup DMA for virtual addresses
      
        ivpu:
         - Fix deadlock in context_xa
         - PCI fixes
         - Fixes to error handling
      
        nouveau:
         - gsp: Fix OOB access
         - Fix casting
      
        panfrost:
         - Fix error path in MMU code
      
        qxl:
         - Revert "drm/qxl: simplify qxl_fence_wait"
      
        vmwgfx:
         - Enable DMA for SEV mappings
      
        i915:
         - Couple CDCLK programming fixes
         - HDCP related fix
         - 4 Bigjoiner related fixes
         - Fix for a circular locking around GuC on reset+wedged case
      
        xe:
         - Fix double display mutex initializations
         - Fix u32 -> u64 implicit conversions
         - Fix RING_CONTEXT_CONTROL not marked as masked
      
        msm:
         - DP refcount leak fix on disconnect
         - Add missing newlines to prints in msm_fb and msm_kms
         - fix dpu debugfs entry permissions
         - Fix the interface table for the catalog of X1E80100
         - fix irq message printing
         - Bindings fix to add DP node as child of mdss for mdss node
         - Minor typo fix in DP driver API which handles port status change
         - fix CHRASHDUMP_READ()
         - fix HHB (highest bank bit) for a619 to fix UBWC corruption
      
        amdgpu:
         - GPU reset fixes
         - Fix some confusing logging
         - UMSCH fix
         - Aborted suspend fix
         - DCN 3.5 fixes
         - S4 fix
         - MES logging fixes
         - SMU 14 fixes
         - SDMA 4.4.2 fix
         - KASAN fix
         - SMU 13.0.10 fix
         - VCN partition fix
         - GFX11 fixes
         - DWB fixes
         - Plane handling fix
         - FAMS fix
         - DCN 3.1.6 fix
         - VSC SDP fixes
         - OLED panel fix
         - GFX 11.5 fix
      
        amdkfd:
         - GPU reset fixes
         - fix ioctl integer overflow"
      
      * tag 'drm-fixes-2024-04-12' of https://gitlab.freedesktop.org/drm/kernel: (65 commits)
        amdkfd: use calloc instead of kzalloc to avoid integer overflow
        drm/xe: Label RING_CONTEXT_CONTROL as masked
        drm/xe/xe_migrate: Cast to output precision before multiplying operands
        drm/xe/hwmon: Cast result to output precision on left shift of operand
        drm/xe/display: Fix double mutex initialization
        drm/amdgpu: differentiate external rev id for gfx 11.5.0
        drm/amd/display: Adjust dprefclk by down spread percentage.
        drm/amd/display: Set VSC SDP Colorimetry same way for MST and SST
        drm/amd/display: Program VSC SDP colorimetry for all DP sinks >= 1.4
        drm/amd/display: fix disable otg wa logic in DCN316
        drm/amd/display: Do not recursively call manual trigger programming
        drm/amd/display: always reset ODM mode in context when adding first plane
        drm/amdgpu: fix incorrect number of active RBs for gfx11
        drm/amd/display: Return max resolution supported by DWB
        amd/amdkfd: sync all devices to wait all processes being evicted
        drm/amdgpu: clear set_q_mode_offs when VM changed
        drm/amdgpu: Fix VCN allocation in CPX partition
        drm/amd/pm: fix the high voltage issue after unload
        drm/amd/display: Skip on writeback when it's not applicable
        drm/amdgpu: implement IRQ_STATE_ENABLE for SDMA v4.4.2
        ...
      d1c13e80
    • Yu Kuai's avatar
      block: fix that blk_time_get_ns() doesn't update time after schedule · 3ec48489
      Yu Kuai authored
      While monitoring the throttle time of IO from iocost, it's found that
      such time is always zero after the io_schedule() from ioc_rqos_throttle,
      for example, with the following debug patch:
      
      +       printk("%s-%d: %s enter %llu\n", current->comm, current->pid, __func__, blk_time_get_ns());
              while (true) {
                      set_current_state(TASK_UNINTERRUPTIBLE);
                      if (wait.committed)
                              break;
                      io_schedule();
              }
      +       printk("%s-%d: %s exit  %llu\n", current->comm, current->pid, __func__, blk_time_get_ns());
      
      It can be observerd that blk_time_get_ns() always return the same time:
      
      [ 1068.096579] fio-1268: ioc_rqos_throttle enter 1067901962288
      [ 1068.272587] fio-1268: ioc_rqos_throttle exit  1067901962288
      [ 1068.274389] fio-1268: ioc_rqos_throttle enter 1067901962288
      [ 1068.472690] fio-1268: ioc_rqos_throttle exit  1067901962288
      [ 1068.474485] fio-1268: ioc_rqos_throttle enter 1067901962288
      [ 1068.672656] fio-1268: ioc_rqos_throttle exit  1067901962288
      [ 1068.674451] fio-1268: ioc_rqos_throttle enter 1067901962288
      [ 1068.872655] fio-1268: ioc_rqos_throttle exit  1067901962288
      
      And I think the root cause is that 'PF_BLOCK_TS' is always cleared
      by blk_flush_plug() before scheduel(), hence blk_plug_invalidate_ts()
      will never be called:
      
      blk_time_get_ns
       plug->cur_ktime = ktime_get_ns();
       current->flags |= PF_BLOCK_TS;
      
      io_schedule:
       io_schedule_prepare
        blk_flush_plug
         __blk_flush_plug
          /* the flag is cleared, while time is not */
          current->flags &= ~PF_BLOCK_TS;
       schedule
       sched_update_worker
        /* the flag is not set, hence plug->cur_ktime is not cleared */
        if (tsk->flags & PF_BLOCK_TS)
         blk_plug_invalidate_ts()
      
      blk_time_get_ns
       /* got the time stashed before schedule */
       return plug->cur_ktime;
      
      Fix the problem by clearing cached time in __blk_flush_plug().
      
      Fixes: 06b23f92 ("block: update cached timestamp post schedule/preemption")
      Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
      Link: https://lore.kernel.org/r/20240411032349.3051233-2-yukuai1@huaweicloud.comSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
      3ec48489
    • Vasant Hegde's avatar
      iommu/amd: Change log message severity · b8246a2a
      Vasant Hegde authored
      Use consistent log severity (pr_warn) to log all messages in SNP
      enable path.
      Suggested-by: default avatarTom Lendacky <thomas.lendacky@amd.com>
      Signed-off-by: default avatarVasant Hegde <vasant.hegde@amd.com>
      Link: https://lore.kernel.org/r/20240410101643.32309-1-vasant.hegde@amd.comSigned-off-by: default avatarJoerg Roedel <jroedel@suse.de>
      b8246a2a
    • Lu Baolu's avatar
      iommu/vt-d: Fix WARN_ON in iommu probe path · 89436f4f
      Lu Baolu authored
      Commit 1a75cc71 ("iommu/vt-d: Use rbtree to track iommu probed
      devices") adds all devices probed by the iommu driver in a rbtree
      indexed by the source ID of each device. It assumes that each device
      has a unique source ID. This assumption is incorrect and the VT-d
      spec doesn't state this requirement either.
      
      The reason for using a rbtree to track devices is to look up the device
      with PCI bus and devfunc in the paths of handling ATS invalidation time
      out error and the PRI I/O page faults. Both are PCI ATS feature related.
      
      Only track the devices that have PCI ATS capabilities in the rbtree to
      avoid unnecessary WARN_ON in the iommu probe path. Otherwise, on some
      platforms below kernel splat will be displayed and the iommu probe results
      in failure.
      
       WARNING: CPU: 3 PID: 166 at drivers/iommu/intel/iommu.c:158 intel_iommu_probe_device+0x319/0xd90
       Call Trace:
        <TASK>
        ? __warn+0x7e/0x180
        ? intel_iommu_probe_device+0x319/0xd90
        ? report_bug+0x1f8/0x200
        ? handle_bug+0x3c/0x70
        ? exc_invalid_op+0x18/0x70
        ? asm_exc_invalid_op+0x1a/0x20
        ? intel_iommu_probe_device+0x319/0xd90
        ? debug_mutex_init+0x37/0x50
        __iommu_probe_device+0xf2/0x4f0
        iommu_probe_device+0x22/0x70
        iommu_bus_notifier+0x1e/0x40
        notifier_call_chain+0x46/0x150
        blocking_notifier_call_chain+0x42/0x60
        bus_notify+0x2f/0x50
        device_add+0x5ed/0x7e0
        platform_device_add+0xf5/0x240
        mfd_add_devices+0x3f9/0x500
        ? preempt_count_add+0x4c/0xa0
        ? up_write+0xa2/0x1b0
        ? __debugfs_create_file+0xe3/0x150
        intel_lpss_probe+0x49f/0x5b0
        ? pci_conf1_write+0xa3/0xf0
        intel_lpss_pci_probe+0xcf/0x110 [intel_lpss_pci]
        pci_device_probe+0x95/0x120
        really_probe+0xd9/0x370
        ? __pfx___driver_attach+0x10/0x10
        __driver_probe_device+0x73/0x150
        driver_probe_device+0x19/0xa0
        __driver_attach+0xb6/0x180
        ? __pfx___driver_attach+0x10/0x10
        bus_for_each_dev+0x77/0xd0
        bus_add_driver+0x114/0x210
        driver_register+0x5b/0x110
        ? __pfx_intel_lpss_pci_driver_init+0x10/0x10 [intel_lpss_pci]
        do_one_initcall+0x57/0x2b0
        ? kmalloc_trace+0x21e/0x280
        ? do_init_module+0x1e/0x210
        do_init_module+0x5f/0x210
        load_module+0x1d37/0x1fc0
        ? init_module_from_file+0x86/0xd0
        init_module_from_file+0x86/0xd0
        idempotent_init_module+0x17c/0x230
        __x64_sys_finit_module+0x56/0xb0
        do_syscall_64+0x6e/0x140
        entry_SYSCALL_64_after_hwframe+0x71/0x79
      
      Fixes: 1a75cc71 ("iommu/vt-d: Use rbtree to track iommu probed devices")
      Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10689Signed-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
      Link: https://lore.kernel.org/r/20240407011429.136282-1-baolu.lu@linux.intel.comReviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
      Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
      89436f4f
    • Jacob Pan's avatar
      iommu/vt-d: Allocate local memory for page request queue · a34f3e20
      Jacob Pan authored
      The page request queue is per IOMMU, its allocation should be made
      NUMA-aware for performance reasons.
      
      Fixes: a222a7f0 ("iommu/vt-d: Implement page request handling")
      Signed-off-by: default avatarJacob Pan <jacob.jun.pan@linux.intel.com>
      Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
      Link: https://lore.kernel.org/r/20240403214007.985600-1-jacob.jun.pan@linux.intel.comSigned-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
      Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
      a34f3e20
    • Xuchun Shang's avatar
      iommu/vt-d: Fix wrong use of pasid config · 5b3625a4
      Xuchun Shang authored
      The commit "iommu/vt-d: Add IOMMU perfmon support" introduce IOMMU
      PMU feature, but use the wrong config when set pasid filter.
      
      Fixes: 7232ab8b ("iommu/vt-d: Add IOMMU perfmon support")
      Signed-off-by: default avatarXuchun Shang <xuchun.shang@linux.alibaba.com>
      Reviewed-by: default avatarKan Liang <kan.liang@linux.intel.com>
      Link: https://lore.kernel.org/r/20240401060753.3321318-1-xuchun.shang@linux.alibaba.comSigned-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
      Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
      5b3625a4
    • Krzysztof Kozlowski's avatar
      iommu: mtk: fix module autoloading · 7537e31d
      Krzysztof Kozlowski authored
      Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
      based on the alias from of_device_id table.
      Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
      Link: https://lore.kernel.org/r/20240410164109.233308-1-krzk@kernel.orgSigned-off-by: default avatarJoerg Roedel <jroedel@suse.de>
      7537e31d
    • Vasant Hegde's avatar
      iommu/amd: Do not enable SNP when V2 page table is enabled · b650b38b
      Vasant Hegde authored
      DTE[Mode]=0 is not supported when SNP is enabled in the host. That means
      to support SNP, IOMMU must be configured with V1 page table (See IOMMU
      spec [1] for the details). If user passes kernel command line to configure
      IOMMU domains with v2 page table (amd_iommu=pgtbl_v2) then disable SNP
      as the user asked by not forcing the page table to v1.
      
      [1] https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/specifications/48882_IOMMU.pdf
      
      Cc: Ashish Kalra <ashish.kalra@amd.com>
      Cc: Michael Roth <michael.roth@amd.com>
      Cc: Tom Lendacky <thomas.lendacky@amd.com>
      Signed-off-by: default avatarVasant Hegde <vasant.hegde@amd.com>
      Reviewed-by: default avatarTom Lendacky <thomas.lendacky@amd.com>
      Link: https://lore.kernel.org/r/20240410085702.31869-1-vasant.hegde@amd.comSigned-off-by: default avatarJoerg Roedel <jroedel@suse.de>
      b650b38b
    • Vasant Hegde's avatar
      iommu/amd: Fix possible irq lock inversion dependency issue · 84b1cec4
      Vasant Hegde authored
      LOCKDEP detector reported below warning:
      ----------------------------------------
      [   23.796949] ========================================================
      [   23.796950] WARNING: possible irq lock inversion dependency detected
      [   23.796952] 6.8.0fix+ #811 Not tainted
      [   23.796954] --------------------------------------------------------
      [   23.796954] kworker/0:1/8 just changed the state of lock:
      [   23.796956] ff365325e084a9b8 (&domain->lock){..-.}-{3:3}, at: amd_iommu_flush_iotlb_all+0x1f/0x50
      [   23.796969] but this lock took another, SOFTIRQ-unsafe lock in the past:
      [   23.796970]  (pd_bitmap_lock){+.+.}-{3:3}
      [   23.796972]
      
                     and interrupts could create inverse lock ordering between them.
      
      [   23.796973]
                     other info that might help us debug this:
      [   23.796974] Chain exists of:
                       &domain->lock --> &dev_data->lock --> pd_bitmap_lock
      
      [   23.796980]  Possible interrupt unsafe locking scenario:
      
      [   23.796981]        CPU0                    CPU1
      [   23.796982]        ----                    ----
      [   23.796983]   lock(pd_bitmap_lock);
      [   23.796985]                                local_irq_disable();
      [   23.796985]                                lock(&domain->lock);
      [   23.796988]                                lock(&dev_data->lock);
      [   23.796990]   <Interrupt>
      [   23.796991]     lock(&domain->lock);
      
      Fix this issue by disabling interrupt when acquiring pd_bitmap_lock.
      
      Note that this is temporary fix. We have a plan to replace custom bitmap
      allocator with IDA allocator.
      
      Fixes: 87a6f1f2 ("iommu/amd: Introduce per-device domain ID to fix potential TLB aliasing issue")
      Reviewed-by: default avatarSuravee Suthikulpanit <suravee.suthikulpanit@amd.com>
      Signed-off-by: default avatarVasant Hegde <vasant.hegde@amd.com>
      Link: https://lore.kernel.org/r/20240404102717.6705-1-vasant.hegde@amd.comSigned-off-by: default avatarJoerg Roedel <jroedel@suse.de>
      84b1cec4
    • Dave Airlie's avatar
      amdkfd: use calloc instead of kzalloc to avoid integer overflow · 3b0daecf
      Dave Airlie authored
      This uses calloc instead of doing the multiplication which might
      overflow.
      
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      3b0daecf
    • Dave Airlie's avatar
      Merge tag 'drm-msm-next-2024-04-11' of https://gitlab.freedesktop.org/drm/msm into drm-fixes · 6d837271
      Dave Airlie authored
      Fixes for v6.9
      
      Display:
      - Fixes for PM refcount leak when DP goes to disconnected state and
        also when link training fails. This is also one of the issues found
        with the pm runtime series
      - Add missing newlines to prints in msm_fb and msm_kms
      - Change permissions of some dpu debugfs entries which write to const
        data from catalog to read-only to avoid protection faults
      - Fix the interface table for the catalog of X1E80100. This is an
        important fix to bringup DP for X1E80100.
      - Logging fix to print the callback symbol in the invalid IRQ message
        case rather than printing when its known to be NULL.
      - Bindings fix to add DP node as child of mdss for mdss node
      - Minor typo fix in DP driver API which handles port status change
      
      GPU:
      - fix CHRASHDUMP_READ()
      - fix HHB (highest bank bit) for a619 to fix UBWC corruption
      Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
      From: Rob Clark <robdclark@gmail.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/CAF6AEGvFwRUcHGWva7oDeydq1PTiZMduuykCD2MWaFrT4iMGZA@mail.gmail.com
      6d837271
  4. 11 Apr, 2024 11 commits
    • Linus Torvalds's avatar
      Merge tag 'cxl-fixes-6.9-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl · 586b5dfb
      Linus Torvalds authored
      Pull cxl fixes from Dave Jiang:
      
       - Fix index of Clear Event Record handles in cxl_clear_event_record()
      
       - Fix use before init of map->reg_type in cxl_decode_regblock()
      
       - Fix initialization of mbox_cmd.size_out in cxl_mem_get_records_log()
      
       - Fix CXL path access_coordinate computation:
           - Remove unneded check of iter in loop
           - Fix of retrieving of access_coordinate in PCI topology walk
           - Fix of incorrect region access_coordinate data calculation
           - Consolidate of access_coordinates attached to downstream port
             context
           - Add check to validate access_coordinate validity to prevent
             incorrect data being exposed via sysfs
      
      * tag 'cxl-fixes-6.9-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl:
        cxl: Add checks to access_coordinate calculation to fail missing data
        cxl: Consolidate dport access_coordinate ->hb_coord and ->sw_coord into ->coord
        cxl: Fix incorrect region perf data calculation
        cxl: Fix retrieving of access_coordinates in PCIe path
        cxl: Remove checking of iter in cxl_endpoint_get_perf_coordinates()
        cxl/core: Fix initialization of mbox_cmd.size_out in get event
        cxl/core/regs: Fix usage of map->reg_type in cxl_decode_regblock() before assigned
        cxl/mem: Fix for the index of Clear Event Record Handle
      586b5dfb
    • Linus Torvalds's avatar
      Merge tag 'hyperv-fixes-signed-20240411' of... · 52e5070f
      Linus Torvalds authored
      Merge tag 'hyperv-fixes-signed-20240411' of git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux
      
      Pull hyperv fixes from Wei Liu:
      
       - Some cosmetic changes (Erni Sri Satya Vennela, Li Zhijian)
      
       - Introduce hv_numa_node_to_pxm_info() (Nuno Das Neves)
      
       - Fix KVP daemon to handle IPv4 and IPv6 combination for keyfile format
         (Shradha Gupta)
      
       - Avoid freeing decrypted memory in a confidential VM (Rick Edgecombe
         and Michael Kelley)
      
      * tag 'hyperv-fixes-signed-20240411' of git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux:
        Drivers: hv: vmbus: Don't free ring buffers that couldn't be re-encrypted
        uio_hv_generic: Don't free decrypted memory
        hv_netvsc: Don't free decrypted memory
        Drivers: hv: vmbus: Track decrypted status in vmbus_gpadl
        Drivers: hv: vmbus: Leak pages if set_memory_encrypted() fails
        hv/hv_kvp_daemon: Handle IPv4 and Ipv6 combination for keyfile format
        hv: vmbus: Convert sprintf() family to sysfs_emit() family
        mshyperv: Introduce hv_numa_node_to_pxm_info()
        x86/hyperv: Cosmetic changes for hv_apic.c
      52e5070f
    • Steven Rostedt (Google)'s avatar
      ring-buffer: Only update pages_touched when a new page is touched · ffe3986f
      Steven Rostedt (Google) authored
      The "buffer_percent" logic that is used by the ring buffer splice code to
      only wake up the tasks when there's no data after the buffer is filled to
      the percentage of the "buffer_percent" file is dependent on three
      variables that determine the amount of data that is in the ring buffer:
      
       1) pages_read - incremented whenever a new sub-buffer is consumed
       2) pages_lost - incremented every time a writer overwrites a sub-buffer
       3) pages_touched - incremented when a write goes to a new sub-buffer
      
      The percentage is the calculation of:
      
        (pages_touched - (pages_lost + pages_read)) / nr_pages
      
      Basically, the amount of data is the total number of sub-bufs that have been
      touched, minus the number of sub-bufs lost and sub-bufs consumed. This is
      divided by the total count to give the buffer percentage. When the
      percentage is greater than the value in the "buffer_percent" file, it
      wakes up splice readers waiting for that amount.
      
      It was observed that over time, the amount read from the splice was
      constantly decreasing the longer the trace was running. That is, if one
      asked for 60%, it would read over 60% when it first starts tracing, but
      then it would be woken up at under 60% and would slowly decrease the
      amount of data read after being woken up, where the amount becomes much
      less than the buffer percent.
      
      This was due to an accounting of the pages_touched incrementation. This
      value is incremented whenever a writer transfers to a new sub-buffer. But
      the place where it was incremented was incorrect. If a writer overflowed
      the current sub-buffer it would go to the next one. If it gets preempted
      by an interrupt at that time, and the interrupt performs a trace, it too
      will end up going to the next sub-buffer. But only one should increment
      the counter. Unfortunately, that was not the case.
      
      Change the cmpxchg() that does the real switch of the tail-page into a
      try_cmpxchg(), and on success, perform the increment of pages_touched. This
      will only increment the counter once for when the writer moves to a new
      sub-buffer, and not when there's a race and is incremented for when a
      writer and its preempting writer both move to the same new sub-buffer.
      
      Link: https://lore.kernel.org/linux-trace-kernel/20240409151309.0d0e5056@gandalf.local.home
      
      Cc: stable@vger.kernel.org
      Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
      Fixes: 2c2b0a78 ("ring-buffer: Add percentage of ring buffer full to wake up reader")
      Acked-by: default avatarMasami Hiramatsu (Google) <mhiramat@kernel.org>
      Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
      ffe3986f
    • Arnd Bergmann's avatar
      tracing: hide unused ftrace_event_id_fops · 5281ec83
      Arnd Bergmann authored
      When CONFIG_PERF_EVENTS, a 'make W=1' build produces a warning about the
      unused ftrace_event_id_fops variable:
      
      kernel/trace/trace_events.c:2155:37: error: 'ftrace_event_id_fops' defined but not used [-Werror=unused-const-variable=]
       2155 | static const struct file_operations ftrace_event_id_fops = {
      
      Hide this in the same #ifdef as the reference to it.
      
      Link: https://lore.kernel.org/linux-trace-kernel/20240403080702.3509288-7-arnd@kernel.org
      
      Cc: Masami Hiramatsu <mhiramat@kernel.org>
      Cc: Oleg Nesterov <oleg@redhat.com>
      Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
      Cc: Zheng Yejian <zhengyejian1@huawei.com>
      Cc: Kees Cook <keescook@chromium.org>
      Cc: Ajay Kaher <akaher@vmware.com>
      Cc: Jinjie Ruan <ruanjinjie@huawei.com>
      Cc: Clément Léger <cleger@rivosinc.com>
      Cc: Dan Carpenter <dan.carpenter@linaro.org>
      Cc: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
      Fixes: 620a30e9 ("tracing: Don't pass file_operations array to event_create_dir()")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
      5281ec83
    • Prasad Pandit's avatar
      tracing: Fix FTRACE_RECORD_RECURSION_SIZE Kconfig entry · d96c3600
      Prasad Pandit authored
      Fix FTRACE_RECORD_RECURSION_SIZE entry, replace tab with
      a space character. It helps Kconfig parsers to read file
      without error.
      
      Link: https://lore.kernel.org/linux-trace-kernel/20240322121801.1803948-1-ppandit@redhat.com
      
      Cc: Masami Hiramatsu <mhiramat@kernel.org>
      Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
      Fixes: 773c1670 ("ftrace: Add recording of functions that caused recursion")
      Signed-off-by: default avatarPrasad Pandit <pjp@fedoraproject.org>
      Reviewed-by: default avatarRandy Dunlap <rdunlap@infradead.org>
      Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
      d96c3600
    • Yang Li's avatar
      eventfs: Fix kernel-doc comments to functions · a8fa658e
      Yang Li authored
      This commit fix kernel-doc style comments with complete parameter
      descriptions for the lookup_file(),lookup_dir_entry() and
      lookup_file_dentry().
      
      Link: https://lore.kernel.org/linux-trace-kernel/20240322062604.28862-1-yang.lee@linux.alibaba.comSigned-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
      Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
      a8fa658e
    • Steve French's avatar
      smb3: fix broken reconnect when password changing on the server by allowing password rotation · 35f83426
      Steve French authored
      There are various use cases that are becoming more common in which password
      changes are scheduled on a server(s) periodically but the clients connected
      to this server need to stay connected (even in the face of brief network
      reconnects) due to mounts which can not be easily unmounted and mounted at
      will, and servers that do password rotation do not always have the ability
      to tell the clients exactly when to the new password will be effective,
      so add support for an alt password ("password2=") on mount (and also
      remount) so that we can anticipate the upcoming change to the server
      without risking breaking existing mounts.
      
      An alternative would have been to use the kernel keyring for this but the
      processes doing the reconnect do not have access to the keyring but do
      have access to the ses structure.
      Reviewed-by: default avatarBharath SM <bharathsm@microsoft.com>
      Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
      35f83426
    • Paulo Alcantara's avatar
      smb: client: instantiate when creating SFU files · c6ff4590
      Paulo Alcantara authored
      In cifs_sfu_make_node(), on success, instantiate rather than leave it
      with dentry unhashed negative to support callers that expect mknod(2)
      to always instantiate.
      
      This fixes the following test case:
      
        mount.cifs //srv/share /mnt -o ...,sfu
        mkfifo /mnt/fifo
        ./xfstests/ltp/growfiles -b -W test -e 1 -u -i 0 -L 30 /mnt/fifo
        ...
        BUG: unable to handle page fault for address: 000000034cec4e58
        #PF: supervisor read access in kernel mode
        #PF: error_code(0x0000) - not-present page
        PGD 0 P4D 0
        Oops: 0000 1 PREEMPT SMP PTI
        CPU: 0 PID: 138098 Comm: growfiles Kdump: loaded Not tainted
        5.14.0-436.3987_1240945149.el9.x86_64 #1
        Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011
        RIP: 0010:_raw_callee_save__kvm_vcpu_is_preempted+0x0/0x20
        Code: e8 15 d9 61 00 e9 63 ff ff ff 41 bd ea ff ff ff e9 58 ff ff ff e8
        d0 71 c0 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 <48> 8b 04
        fd 60 2b c1 99 80 b8 90 50 03 00 00 0f 95 c0 c3 cc cc cc
        RSP: 0018:ffffb6a143cf7cf8 EFLAGS: 00010206
        RAX: ffff8a9bc30fb038 RBX: ffff8a9bc666a200 RCX: ffff8a9cc0260000
        RDX: 00000000736f622e RSI: ffff8a9bc30fb038 RDI: 000000007665645f
        RBP: ffffb6a143cf7d70 R08: 0000000000001000 R09: 0000000000000001
        R10: 0000000000000001 R11: 0000000000000000 R12: ffff8a9bc666a200
        R13: 0000559a302a12b0 R14: 0000000000001000 R15: 0000000000000000
        FS: 00007fbed1dbb740(0000) GS:ffff8a9cf0000000(0000)
        knlGS:0000000000000000
        CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
        CR2: 000000034cec4e58 CR3: 0000000128ec6006 CR4: 0000000000770ef0
        DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
        DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
        PKRU: 55555554
        Call Trace:
         <TASK>
         ? show_trace_log_lvl+0x1c4/0x2df
         ? show_trace_log_lvl+0x1c4/0x2df
         ? __mutex_lock.constprop.0+0x5f7/0x6a0
         ? __die_body.cold+0x8/0xd
         ? page_fault_oops+0x134/0x170
         ? exc_page_fault+0x62/0x150
         ? asm_exc_page_fault+0x22/0x30
         ? _pfx_raw_callee_save__kvm_vcpu_is_preempted+0x10/0x10
         __mutex_lock.constprop.0+0x5f7/0x6a0
         ? __mod_memcg_lruvec_state+0x84/0xd0
         pipe_write+0x47/0x650
         ? do_anonymous_page+0x258/0x410
         ? inode_security+0x22/0x60
         ? selinux_file_permission+0x108/0x150
         vfs_write+0x2cb/0x410
         ksys_write+0x5f/0xe0
         do_syscall_64+0x5c/0xf0
         ? syscall_exit_to_user_mode+0x22/0x40
         ? do_syscall_64+0x6b/0xf0
         ? sched_clock_cpu+0x9/0xc0
         ? exc_page_fault+0x62/0x150
         entry_SYSCALL_64_after_hwframe+0x6e/0x76
      
      Cc: stable@vger.kernel.org
      Fixes: 72bc63f5 ("smb3: fix creating FIFOs when mounting with "sfu" mount option")
      Suggested-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      Signed-off-by: default avatarPaulo Alcantara (Red Hat) <pc@manguebit.com>
      Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
      c6ff4590
    • Steve French's avatar
      smb3: fix Open files on server counter going negative · 28e09476
      Steve French authored
      We were decrementing the count of open files on server twice
      for the case where we were closing cached directories.
      
      Fixes: 8e843bf3 ("cifs: return a single-use cfid if we did not get a lease")
      Cc: stable@vger.kernel.org
      Acked-by: default avatarBharath SM <bharathsm@microsoft.com>
      Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
      28e09476
    • Jeff Layton's avatar
      MAINTAINERS: remove myself as a Reviewer for Ceph · d3e04693
      Jeff Layton authored
      It has been a couple of years since I stepped down as CephFS maintainer.
      I'm not involved in any meaningful way with the project these days, so
      while I'm happy to help review the occasional patch, I don't need to be
      cc'ed on all of them.
      Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
      Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
      d3e04693
    • Xiubo Li's avatar
      ceph: switch to use cap_delay_lock for the unlink delay list · 17f8dc2d
      Xiubo Li authored
      The same list item will be used in both cap_delay_list and
      cap_unlink_delay_list, so it's buggy to use two different locks
      to protect them.
      
      Cc: stable@vger.kernel.org
      Fixes: dbc347ef ("ceph: add ceph_cap_unlink_work to fire check_caps() immediately")
      Link: https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/thread/AODC76VXRAMXKLFDCTK4TKFDDPWUSCN5Reported-by: default avatarMarc Ruhmann <ruhmann@luis.uni-hannover.de>
      Signed-off-by: default avatarXiubo Li <xiubli@redhat.com>
      Reviewed-by: default avatarIlya Dryomov <idryomov@gmail.com>
      Tested-by: default avatarMarc Ruhmann <ruhmann@luis.uni-hannover.de>
      Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
      17f8dc2d