- 22 Sep, 2011 2 commits
-
-
Ben Hutchings authored
Commit 96760015 ("ALSA: fm801: add error handling if auto-detect fails") seems to break systems that were previously working without a tuner. As a bonus, this should fix init and cleanup for the case where the tuner is explicitly disabled. Reported-and-tested-by:
Hor Jiun Shyong <jiunshyong@gmail.com> References: http://bugs.debian.org/641946Signed-off-by:
Ben Hutchings <ben@decadent.org.uk> Cc: stable@kernel.org [v3.0+] Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
Ben Hutchings authored
Commit 96760015 ("ALSA: fm801: add error handling if auto-detect fails") added incorrect error handling. Once we have successfully called snd_device_new(), the cleanup function fm801_free() will automatically be called by snd_card_free() and we must *not* also call fm801_free() directly. Reported-by:
-
- 20 Sep, 2011 1 commit
-
-
David Henningsson authored
Cc: stable@kernel.org BugLink: http://bugs.launchpad.net/bugs/854468Signed-off-by:
David Henningsson <david.henningsson@canonical.com> Signed-off-by:
-
- 19 Sep, 2011 1 commit
-
-
Takashi Iwai authored
When the system has only the headphone and the line-out jacks without speakers, the current auto-mute code doesn't work. It's because the spec->automute_lines flag is wrongly referred in update_speakers(). This flag must be meaningless when spec->automute_hp_lo isn't set, thus they should be always coupled. The patch fixes the problem and add a comment to indicate the relationship briefly. BugLink: http://bugs.launchpad.net/bugs/851697Reported-by:
Jayne Han <jayne.han@canonical.com> Cc: stable@kernel.org (3.0) Signed-off-by:
-
- 15 Sep, 2011 1 commit
-
-
Arjan van de Ven authored
wait_for_avail() in pcm_lib.c has a race in it (observed in practice by an Intel validation group). The function is supposed to return once space in the buffer has become available, or if some timeout happens. The entity that creates space (irq handler of sound driver and some such) will do a wake up on a waitqueue that this function registers for. However there are two races in the existing code 1) If space became available between the caller noticing there was no space and this function actually sleeping, the wakeup is missed and the timeout condition will happen instead 2) If a wakeup happened but not sufficient space became available, the code will loop again and wait for more space. However, if the second wake comes in prior to hitting the schedule_timeout_interruptible(), it will be missed, and potentially you'll wait out until the timeout happens. The fix consists of using more careful setting of the current state (so that if a wakeup happens in the main loop window, the schedule_timeout() falls through) and by checking for available space prior to going into the schedule_timeout() loop, but after being on the waitqueue and having the state set to interruptible. [tiwai: the following changes have been added to Arjan's original patch: - merged akpm's fix for waitqueue adding order into a single patch - reduction of duplicated code of avail check ] Signed-off-by:
Arjan van de Ven <arjan@linux.intel.com> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Cc: <stable@kernel.org> Signed-off-by:
-
- 14 Sep, 2011 2 commits
-
-
Takashi Iwai authored
-
David Henningsson authored
This patch fixes "Surround Speaker Playback Volume" being cut off. (Commit b4dabfc4 was probably meant to fix this, but it fixed only the "Switch" name, not the "Volume" name.) Signed-off-by:
-
- 13 Sep, 2011 1 commit
-
-
Takashi Iwai authored
The recursive search of widget connections in snd_hda_get_conn_index() must be terminated at the pin and the audio-out widgets. Otherwise you'll get "too deep connection" warnings unnecessarily. Reported-by:
Francis Moreau <francis.moro@gmail.com> Signed-off-by:
-
- 12 Sep, 2011 1 commit
-
-
Arnd Bergmann authored
A fix merged in 3.1-rc2 introduced a small regression, this should get it to build again. Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Acked-by:
Liam Girdwood <lrg@ti.com> Signed-off-by:
Mark Brown <broonie@opensource.wolfsonmicro.com>
-
- 06 Sep, 2011 2 commits
-
-
Lars-Peter Clausen authored
Fix the codec_name field of the dai_link to match the actual device name of the codec. Otherwise the card won't be instantiated. Signed-off-by:
Lars-Peter Clausen <lars@metafoo.de> Acked-by:
-
Mark Brown authored
We need to report the entire jack state to the core jack code, not just the bits that were being updated by the caller, otherwise the status reported by other detection methods will be omitted from the state seen by userspace. Signed-off-by:
-
- 31 Aug, 2011 4 commits
-
-
Fabio Estevam authored
Fixes the following warning: CC sound/soc/imx/imx-pcm-fiq.o sound/soc/imx/imx-pcm-fiq.c: In function 'imx_pcm_fiq_new': sound/soc/imx/imx-pcm-fiq.c:243: warning: unused variable 'card' CC sound/soc/imx/imx-pcm-dma-mx2.o Signed-off-by:
Fabio Estevam <fabio.estevam@freescale.com> Signed-off-by:
-
Lars-Peter Clausen authored
Currently the condition for these WARN_ONs is reversed and they are placed before the actual check whether we are going to write to that register. So if the codec implements the register_writable callback we'll get a warning for each writable register when syncing the register cache. While we are at it change the check to use snd_soc_codec_writable_register instead of open-coding it. Signed-off-by:
-
Lars-Peter Clausen authored
Change the default return value of snd_soc_codec_{readable,writable}_register to true when no codec specific callback for this function is given. Otherwise all registers of that codec will neither be readable nor writable, which is most certainly not what we want. Signed-off-by: -
Peter Ujfalusi authored
We have dapm_context instead of codec parameter. Signed-off-by:
Peter Ujfalusi <peter.ujfalusi@ti.com> Signed-off-by:
-
- 29 Aug, 2011 1 commit
-
-
Mark Brown authored
Mostly input related. Signed-off-by:
-
- 26 Aug, 2011 1 commit
-
-
Takashi Iwai authored
-
- 25 Aug, 2011 1 commit
-
-
David Henningsson authored
Headphones has stopped working for the original reported (a regression compared to 2.6.38). This is because Speaker and Headphones share the same DAC, in which case no Headphones volume control was created. This patch fixes so that both Speaker and Headphones volume controls are created in such scenario. BugLink: http://bugs.launchpad.net/bugs/817943Signed-off-by:
-
- 24 Aug, 2011 6 commits
-
-
Timur Tabi authored
'struct of_device' no longer exists, and its functionality has been merged into platform_device. Update the MPC5200 audio DMA driver (mpc5200_dma) accordingly. This fixes a build break. Signed-off-by:
Timur Tabi <timur@freescale.com> Acked-by:
-
Mark Brown authored
I can count. Honest. Signed-off-by:
-
Stephen Warren authored
Board file support for Ventana is not yet mainlined, and probably won't ever be given the move to Device-Tree. Consequently, the Ventana entry is being removed from arch/arm/tools/mach-types in the next merge window, since it was registered over a year ago. This will also remove function machine_is_ventana(), which is used by the ASoC Tegra WM8903 machine driver. This will cause compilation failures. Drop Ventana support to resolve this. Hopefully, in the not-too-distant future, tegra_wm8903.c will be able to configure itself from Device-Tree, and hence we'll be able to re-instate Ventana support just by creating a .dts file for the board. Also note that Aebl support is in a similar boat. However, that board isn't scheduled for deprecation for at least another 5 months, and perhaps we will have completely removed non-Device-Tree support from tegra_wm8903.c by then and/or adjusted mach-types policy. Signed-off-by:
Stephen Warren <swarren@nvidia.com> Acked-by:
-
Sangbeom Kim authored
Signed-off-by:
Sangbeom Kim <sbkim73@samsung.com> Acked-by:
Jassi Brar <jassisinghbrar@gmail.com> Acked-by:
-
Joseph Pentland authored
Signed-off-by:
Joseph Pentland <jp@opensource.wolfsonmicro.com> Acked-by:
-
Takashi Iwai authored
The ADC-switching can work also in the auto-mic mode, too. Signed-off-by:
-
- 23 Aug, 2011 3 commits
-
-
Takashi Iwai authored
When multiple headphones or speakers are assigned but no individual DACs are available, the driver should take the first HP/SPK DAC instead of another primary output. The patch adds a bit-flag to dac field of struct pin_dac_pair indicating that it's a slave DAC. Signed-off-by: -
Takashi Iwai authored
The internal states, jack_present and line_jack_present should be updated upon unsolicited events even if no automute is set. Otherwise the wrong state is referred when the automute behavior is changed by the mixer control. Signed-off-by: -
Takashi Iwai authored
When the headphone or speaker output has no own DAC, initialize the path using the primary DAC. Otherwise the path won't be set properly and can result in the silence. Signed-off-by:
-
- 22 Aug, 2011 11 commits
-
-
Julia Lawall authored
The first change is to add an of_node_put, since codec_np has previously been allocated. The rest of the patch reorganizes the error handling code so the only code executed is that which is needed. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier x; expression E1!=0,E2,E3,E4; statement S; iterator I; @@ ( if (...) { ... when != of_node_put(x) when != x = E3 when != E3 = x * return ...; } ... when != x = E2 when != I(...,x,...) S if (...) { ... when != x = E4 of_node_put(x); ... return ...; } ) // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Acked-by:
-
Julia Lawall authored
dma_channel_np has been accessed at this point, so decrease its reference count before leaving the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier x; expression E1!=0,E2,E3,E4; statement S; iterator I; @@ ( if (...) { ... when != of_node_put(x) when != x = E3 when != E3 = x * return ...; } ... when != x = E2 when != I(...,x,...) S if (...) { ... when != x = E4 of_node_put(x); ... return ...; } ) // </smpl> Signed-off-by:
-
Julia Lawall authored
Introduce a new label that includes kfree and jump to that one. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier x; expression E1!=0,E2,E3,E4; statement S; iterator I; @@ ( if (...) { ... when != kfree(x) when != x = E3 when != E3 = x * return ...; } ... when != x = E2 when != I(...,x,...) S if (...) { ... when != x = E4 kfree(x); ... return ...; } ) // </smpl> Signed-off-by:
Alexander Sverdlin <subaparts@yandex.ru> Reviewed-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Acked-by:
-
Julia Lawall authored
Adjust the goto to jump to the error handling code that includes kfree. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier x; expression E1!=0,E2,E3,E4; statement S; iterator I; @@ ( if (...) { ... when != kfree(x) when != x = E3 when != E3 = x * return ...; } ... when != x = E2 when != I(...,x,...) S if (...) { ... when != x = E4 kfree(x); ... return ...; } ) // </smpl> Signed-off-by:
-
Axel Lin authored
GFP_ATOMIC is not needed here, use GFP_KERNEL instead. Signed-off-by:
Axel Lin <axel.lin@gmail.com> Acked-by:
-
Timur Tabi authored
of_parse_phandle increments the reference count of np, so this should be decremented before trying the next possibility. Since we don't actually use np, we can decrement the reference count immediately. Reported-by:
-
Mark Brown authored
In case we have a pending completion, for example due to a problem with the input clock which got corrected after we timed out. Signed-off-by:
-
Mark Brown authored
Ensure that we don't spuriously trigger early. Signed-off-by:
-
Mark Brown authored
We get called once per DAPM context but only need to run once. When DAPM was serialized this was a series of noops but now it can run in parallel we need to take proper care. Signed-off-by:
-
Mark Brown authored
There's no need for separate widgets for the enables (as the map already shows). Signed-off-by:
-
Mark Brown authored
Make AIFCLK supply the record paths otherwise record will not work unless there is a simultaneous playback. Signed-off-by:
-
- 20 Aug, 2011 2 commits
-
-
Julia Lawall authored
The label outnodev is only used when kzalloc has not yet taken place or has failed, so there is no need for the call for kfree under this label. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier x; expression E1!=0,E2,E3,E4; statement S; iterator I; @@ ( if (...) { ... when != kfree(x) when != x = E3 when != E3 = x * return ...; } ... when != x = E2 when != I(...,x,...) S if (...) { ... when != x = E4 kfree(x); ... return ...; } ) // </smpl> Signed-off-by:
-
Takashi Iwai authored
snd_hda_get_conn_index() returns a negative value while the current code stores it in an unsigned int. It must be stored in a signed integer. Reported-by:
Jesper Juhl <jj@chaosbits.net> Signed-off-by:
-
