Skip to content

L
linux
An error occurred fetching the project authors.
Switch branch/tag
  1. 02 Nov, 2017 1 commit
  3. 18 Sep, 2017 1 commit
    • Willy Tarreau's avatar
      auxdisplay: charlcd: properly restore atomic counter on error path · 93dc1774
      Willy Tarreau authored 
      Commit f4757af8 ("staging: panel: Fix single-open policy race condition")
introduced in 3.19-rc1 attempted to fix a race condition on the open, but
failed to properly do it and used to exit without restoring the semaphore.

This results in -EBUSY being returned after the first open error until
the module is reloaded or the system restarted (ie: consecutive to a
dual open resulting in -EBUSY or to a permission error).

[ Note for stable maintainers: the code moved from drivers/misc/panel.c
  to drivers/auxdisplay/{charlcd,panel}.c during 4.12. The patch easily
  applies there (modulo the renamed atomic counter) but I can provide a
  tested backport if desired. ]

Fixes: f4757af8 # 3.19-rc1
Cc: stable@vger.kernel.org
Cc: Mariusz Gorski <marius.gorski@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
Signed-off-by: default avatarWilly Tarreau <w@1wt.eu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      93dc1774
  5. 17 Jul, 2017 1 commit
  7. 25 May, 2017 1 commit
  9. 08 Apr, 2017 1 commit
  11. 17 Mar, 2017 1 commit
    • Geert Uytterhoeven's avatar
      auxdisplay: charlcd: Extract character LCD core from misc/panel · 39f8ea46
      Geert Uytterhoeven authored 
      Extract the character LCD core from the Parallel port LCD/Keypad Panel
driver in the misc subsystem, and convert it into a subdriver in the
auxdisplay subsystem.  This allows the character LCD core to be used by
other drivers later.

Compilation is controlled by its own Kconfig symbol CHARLCD, which is to
be selected by its users, but can be enabled manually for
compile-testing.

All functions changed their prefix from "lcd_" to "charlcd_", and gained
a "struct charlcd *" parameter to operate on a specific instance.
While the driver API thus is ready to support multiple instances, the
current limitation of a single display (/dev/lcd has a single misc minor
assigned) is retained.

No functional changes intended.
Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      39f8ea46
  13. 10 Feb, 2017 6 commits
  15. 12 Feb, 2016 1 commit
  17. 03 Feb, 2016 1 commit
  19. 29 Jan, 2016 9 commits
  21. 28 Oct, 2015 4 commits
  23. 17 Oct, 2015 1 commit
  25. 04 Oct, 2015 1 commit
  27. 13 Sep, 2015 1 commit
  29. 31 Jul, 2015 1 commit
  31. 31 May, 2015 2 commits
  33. 24 May, 2015 1 commit
    • Sudip Mukherjee's avatar
      staging: panel: fix stackdump · 7d98c63e
      Sudip Mukherjee authored 
      if we load the module, unload and then again try to load the module, we
will get a stackdump. In the module_exit function we are unregistering
the device and releasing the parport. So when we reach the detach
function parport is already null and the unregister_reboot_notifier()
is never called. When we again try to load the module it again tries
register_reboot_notifier() and gives us a stackdump as its earlier
registration is still not removed. It was caused by the
commit bb046fef ('staging: panel: register reboot')
Fix this by moving all the unregistering and releasing in the detach
function, which should be the ideal case as the detach will be called if
we try to unregister the driver or if the parport is removed.

Fixes: bb046fef ('staging: panel: register reboot')
Signed-off-by: default avatarSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      7d98c63e
  35. 30 Apr, 2015 1 commit
  37. 26 Mar, 2015 1 commit
    • Sudip Mukherjee's avatar
      staging: panel: fix lcd type · 2c20d92d
      Sudip Mukherjee authored 
      the lcd type as defined in the Kconfig is not matching in the code.
as a result the rs, rw and en pins were getting interchanged.
Kconfig defines the value of PANEL_LCD to be 1 if we select custom
configuration but in the code LCD_TYPE_CUSTOM is defined as 5.

my hardware is LCD_TYPE_CUSTOM, but the pins were assigned to it
as pins of LCD_TYPE_OLD, and it was not working.
Now values are corrected with referenece to the values defined in
Kconfig and it is working.
checked on JHD204A lcd with LCD_TYPE_CUSTOM configuration.

Cc: <stable@vger.kernel.org> # 2.6.32+
Signed-off-by: default avatarSudip Mukherjee <sudip@vectorindia.org>
Acked-by: default avatarWilly Tarreau <w@1wt.eu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      2c20d92d
  39. 20 Mar, 2015 3 commits
  41. 07 Mar, 2015 1 commit
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7