- 17 Nov, 2014 5 commits
-
-
Alex Elder authored
Add a reference counter to the operations structure. We'll need this when operations are actually allowed to complete asynchronously. Signed-off-by:
Alex Elder <elder@linaro.org> Signed-off-by:
Greg Kroah-Hartman <greg@kroah.com>
-
Alex Elder authored
This patch does some cleanup of gb_connection_operation_recv(). - Improve the header comments - Verify message is big enough for header before interpreting beginning of the message as a header - Verify at buffer creation time rather than receive time that no operation buffer is bigger than the maximum allowed. We can then compare the incoming data size against the buffer. - When a response message arrives, record its status in the operation result, not in the buffer status. - Record a buffer overflow as an operation error. Signed-off-by: -
Alex Elder authored
It's possible this function was destined to do something important, but at this point it's pretty pointless. Get rid of it. Signed-off-by:
-
Alex Elder authored
This gets rid of a block of unnecessary forward declarations in "greybus.h". Signed-off-by:
-
Alex Elder authored
Move the cancel_delayed_work() call so it's done separate from the removing the operation from the pending list. This should have been part of this commit: d3809f7 greybus: move timeout out of gb_operation_insert() Signed-off-by:
-
- 16 Nov, 2014 1 commit
-
-
Greg Kroah-Hartman authored
Flush out the Greybus UART driver to actually implement greybus requests. The number of Greybus Protocol operations has been reduced down to a managable number, and, if you look closely, you will notice it follows the CDC ACM USB specification, which can drive UART devices quite well, no need for complex UART state changes, leave all of that logic up to the firmware, if it wants/needs it. The Greybus Protocol spec has been updated to match the driver. TODO: There are 2 requests from the device to the host that need to be implemented. As this isn't fully hooked up in the Greybus core, that is not implemented here yet either. Signed-off-by:
-
- 15 Nov, 2014 1 commit
-
-
Greg Kroah-Hartman authored
Implement a skeleton for the uevent framework, to be filled in later when we figure out what type of module "matching" we want to do for things (connections, interfaces, modules, etc.) Based on a patch from Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by:
-
- 14 Nov, 2014 33 commits
-
-
Greg Kroah-Hartman authored
This reverts commit 4d1529e6687d53878b71cdcd646e28e10d62c2e8. Alex reports that this causes problems. Signed-off-by: -
Greg Kroah-Hartman authored
This reverts commit b8ba855506906de71df5b12b50cdbbf7259a930c. needed to revert an older change. Signed-off-by: -
Viresh Kumar authored
That's where it belong to. Also rename it in a similar way to: gb_interface_create() and gb_interface_destroy(). Signed-off-by:
Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by:
-
Viresh Kumar authored
Some of module specific routines were present in core.c instead of module.c. Move them to the right place. Signed-off-by:
-
Viresh Kumar authored
Signed-off-by:
-
Viresh Kumar authored
Also fix print message. Signed-off-by:
-
Viresh Kumar authored
Though this doesn't cause any logical issues as far as the behavior of the routine is concerned as the local variable would be considered inside the 'while' loop. But its better not to use the same name for variables at different levels. Signed-off-by:
-
Viresh Kumar authored
Just an extra check to make sure the list isn't corrupted. Signed-off-by:
-
Viresh Kumar authored
Signed-off-by:
-
Viresh Kumar authored
Signed-off-by:
-
Viresh Kumar authored
Signed-off-by:
-
Viresh Kumar authored
Signed-off-by:
-
Viresh Kumar authored
Signed-off-by:
-
Viresh Kumar authored
Suggested-by:
-
Viresh Kumar authored
Signed-off-by:
-
Viresh Kumar authored
Signed-off-by:
-
Viresh Kumar authored
Signed-off-by:
-
Viresh Kumar authored
Signed-off-by:
-
Viresh Kumar authored
Most of the attribute routines are created with gb_module_attr() and few are left out because they weren't printing 32 bit hexadecimal values. Extend gb_module_attr() to cover more cases. Signed-off-by:
-
Viresh Kumar authored
Also fix indentation. Signed-off-by:
-
Viresh Kumar authored
Parent objects of 'dev' are allocated with kzalloc() and so all of their fields are initialized with 0. Hence no need of marking them NULL again. Signed-off-by:
-
Viresh Kumar authored
Signed-off-by:
-
Viresh Kumar authored
Signed-off-by:
-
Viresh Kumar authored
Signed-off-by:
-
Viresh Kumar authored
Signed-off-by:
-
Viresh Kumar authored
Signed-off-by:
-
Matt Porter authored
Remove some leftover cruft from recent refactoring of connection handlers. Signed-off-by:
Matt Porter <mporter@linaro.org> Signed-off-by:
-
Alex Elder authored
When an incoming request is received, the operation type is encoded in the header and is not available in the payload. Add the operation type as a parameter to the request_recv method so the request handler knows what to do. Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Alex Elder authored
We can update a connection's operation id counter under spinlock, and thereby avoid the need to maintain it in an atomic variable. Signed-off-by:
-
Alex Elder authored
Greg raised the alarm when I first put in the red-black tree for tracking pending operations. The reality as that we're not likely to have that many operations in flight at any one time, so the complexity of the red-black tree is most likely unwarranted. I already This pulls out the red-black tree and uses a simple list instead. A connection maintains two lists of operations. An operation starts on its connection's operations list. It is moved to the pending list when its request message is sent. And it is moved back to the operations list when the response message arrives. It is removed from whatever list it's in when the operation is destroyed. We reuse the single operation->links field for both lists. Only outgoing requests are ever "pending." Incoming requests are transient--we receive them, process them, send the response, and then we're done. Change a few function names so it's clear we're working with the pending list. Signed-off-by:
-
Alex Elder authored
Currently, gb_operation_insert() arranges to time out a request if it takes too long. Move this out of that function and into gb_operation_request_send(), so we know it's getting set up after the request has actually be sent. Signed-off-by:
-
Alex Elder authored
This commit changed the timeout behavior for operations: 6a8732e operation: make the timeout a per-operation thing... It unfortunately left in place some code that was only appropriate for per-connection timeouts. In particular, the timer for an operation is currently getting started only if no existing operations are in flight. Fix that oversight, and schedule an operation's timer unconditionally. Signed-off-by: -
Alex Elder authored
The buffers allocated for CPort URBS are ES1_GBUF_MSG_SIZE bytes. But usb_fill_bulk_urb() passes PAGE_SIZE as its size. They happen to be the same, but the code is wrong, so fix it. Signed-off-by:
-
