1. 02 Jun, 2020 7 commits
  2. 01 Jun, 2020 7 commits
  3. 29 May, 2020 6 commits
  4. 28 May, 2020 5 commits
  5. 27 May, 2020 5 commits
  6. 26 May, 2020 5 commits
  7. 25 May, 2020 3 commits
  8. 23 May, 2020 1 commit
    • Animesh Manna's avatar
      drm/i915/dsb: Pre allocate and late cleanup of cmd buffer · afeda4f3
      Animesh Manna authored
      Pre-allocate command buffer in atomic_commit using intel_dsb_prepare
      function which also includes pinning and map in cpu domain.
      
      No functional change is dsb write/commit functions.
      
      Now dsb get/put function is removed and ref-count mechanism is
      not needed. Below dsb api added to do respective job mentioned
      below.
      
      intel_dsb_prepare - Allocate, pin and map the buffer.
      intel_dsb_cleanup - Unpin and release the gem object.
      
      RFC: Initial patch for design review.
      v2: included _init() part in _prepare(). [Daniel, Ville]
      v3: dsb_cleanup called after cleanup_planes. [Daniel]
      v4: dsb structure is moved to intel_crtc_state from intel_crtc. [Maarten]
      v5: dsb get/put/ref-count mechanism removed. [Maarten]
      v6: Based on review feedback following changes are added,
      - replaced intel_dsb structure by pointer in intel_crtc_state. [Maarten]
      - passing intel_crtc_state to dsp-api to simplify the code. [Maarten]
      - few dsb functions prototype modified to simplify code.
      v7: added few cosmetic changes suggested by Jani and null check for
      crtc_state in dsb_cleanup removed as suggested by Maarten.
      v8: changed the function parameter to intel_crtc_state* of
      ivb_load_lut_ext_max() from intel_crtc. [Maarten]
      v9: error handling improved in _write() and prepare(). [Maarten]
      
      Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
      Cc: Jani Nikula <jani.nikula@intel.com>
      Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
      Acked-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      Reviewed-by: default avatarMaarten Lankhorst <maarten.lankhorst@intel.com>
      Signed-off-by: default avatarAnimesh Manna <animesh.manna@intel.com>
      Signed-off-by: default avatarUma Shankar <uma.shankar@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20200520130737.11240-1-animesh.manna@intel.com
      afeda4f3
  9. 22 May, 2020 1 commit
    • Chris Wilson's avatar
      drm/i915/gem: Avoid iterating an empty list · 957ad9a0
      Chris Wilson authored
      Our __sgt_iter assumes that the scattergather list has at least one
      element. But during construction we may fail in allocating the first
      page, and so mark the first element as the terminator. This is
      unexpected!
      
      [22555.524752] RIP: 0010:shmem_get_pages+0x506/0x710 [i915]
      [22555.524759] Code: 49 8b 2c 24 31 c0 66 89 44 24 40 48 85 ed 0f 84 62 01 00 00 4c 8b 75 00 8b 5d 08 44 8b 7d 0c 48 8b 0d 7e 34 07 e2 49 83 e6 fc <49> 8b 16 41 01 df 48 89 cf 48 89 d0 48 c1 e8 2d 48 85 c9 0f 84 c8
      [22555.524765] RSP: 0018:ffffc9000053f9d0 EFLAGS: 00010246
      [22555.524770] RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffff8881ffffa000
      [22555.524774] RDX: fffffffffffffff4 RSI: ffffffffffffffff RDI: ffffffff821efe00
      [22555.524778] RBP: ffff8881b099ab00 R08: 0000000000000000 R09: 00000000fffffff4
      [22555.524782] R10: 0000000000000002 R11: 00000000ffec0a02 R12: ffff8881cd3c8d60
      [22555.524786] R13: 00000000fffffff4 R14: 0000000000000000 R15: 0000000000000000
      [22555.524790] FS:  00007f4fbeb9b9c0(0000) GS:ffff8881f8580000(0000) knlGS:0000000000000000
      [22555.524795] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
      [22555.524799] CR2: 0000000000000000 CR3: 00000001ec7f0004 CR4: 00000000001606e0
      [22555.524803] Call Trace:
      [22555.524919]  __i915_gem_object_get_pages+0x4f/0x60 [i915]
      
      Fixes: 85d1225e ("drm/i915: Introduce & use new lightweight SGL iterators")
      Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
      Cc: Matthew Auld <matthew.auld@intel.com>
      Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
      Cc: <stable@vger.kernel.org> # v4.8+
      Reviewed-by: default avatarMatthew Auld <matthew.auld@intel.com>
      Reviewed-by: default avatarMaciej Patelczyk <maciej.patelczyk@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20200522132706.5133-1-chris@chris-wilson.co.uk
      957ad9a0