- 21 Jul, 2014 11 commits
-
-
Hans Verkuil authored
Fall-out from the recent struct v4l2_framebuffer change. drivers/media/common/saa7146/saa7146_fops.c: In function ‘saa7146_vv_init’: drivers/media/common/saa7146/saa7146_fops.c:536:6: warning: assignment from incompatible pointer type [enabled by default] fmt = &vv->ov_fb.fmt; ^ Signed-off-by:Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by:
Mauro Carvalho Chehab <m.chehab@samsung.com>
-
Andrey Utkin authored
[linux-3.16-rc5/drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:210]: (style) Checking if unsigned variable 'val' is less than zero. val = get_oneshot_mode(ipipeif->input); if (val < 0) { pr_err("ipipeif: links setup required"); return -EINVAL; } but static int get_oneshot_mode(enum ipipeif_input_entity input) Introduced temporary variable for negativity check. "val" is afterwards used in a lot of bitwise operations, so changing its type to signed is not safe, according to CERT C Secure Coding Standards chapter INT13-C: "Use bitwise operators only on unsigned operands" https://www.securecoding.cert.org/confluence/display/seccode/INT13-C.+Use+bitwise+operators+only+on+unsigned+operands Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80521Reported-by:David Binderman <dcb314@hotmail.com> Signed-off-by:
Andrey Utkin <andrey.krieger.utkin@gmail.com> Signed-off-by:
-
Ian Molton authored
This driver moved over to v4l2_async_unregister_subdev() but still retained a call to v4l2_unregister_subdev(). Remove. Signed-off-by:
Ian Molton <ian.molton@codethink.co.uk> Signed-off-by:
Ben Dooks <ben.dooks@codethink.co.uk> Acked-by:
-
panpan liu authored
The CPB size is limited by the hardware. Add this limit to the s_fmt. Signed-off-by:
panpan liu <panpan1.liu@samsung.com> Signed-off-by:
Kamil Debski <k.debski@samsung.com> Signed-off-by:
-
Philipp Zabel authored
OVL and BTP IRAM buffers are never used, setup the bits for for DBK/BIT/IP usage depending on CODA version in one place. Also, use a simple allocator function and group IRAM addresses and size in a coda_aux_buf structure. This is done in preparation for CODA960 support. Signed-off-by:
Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by:
-
Philipp Zabel authored
This error was introduced by 5677e3b0 "[media] coda: update CODA7541 to firmware 1.4.50". Signed-off-by:
-
Philipp Zabel authored
If bitrate is not set, the encoder is running in VBR mode, with the I- and P-frame quantization parameters configured from userspace. For the quantization parameters, 0 is a valid value. Signed-off-by:
-
Philipp Zabel authored
Previously we'd add one to this value, allocating one additional, superfluous internal buffer. Signed-off-by:
-
Philipp Zabel authored
Currently the rotator unit is used to copy decoded frames out into buffers provided by videobuf2. Since the CODA reports the I/P/B frame type of the last decoded frame, and this frame will be copied out in a later device_run, depending on display order, we have to store the frame type until such time. This patch also adds the B-frame type. Signed-off-by:
-
Jacek Anaszewski authored
fc906b6d "Remove special clock usage in driver" removed initialization of MFC special clock, arguing that there's no need to do it explicitly, since it's one of MFC gate clock's dependencies and gets enabled along with it. However, there's no promise of keeping this hierarchy across Exynos SoC releases, therefore this approach fails to provide a stable, portable solution. Out of all MFC versions, only v6 doesn't use special clock at all. For other versions log a message only in case clk_get fails, as not all the devices with the same MFC version require initializing the clock explicitly. Signed-off-by:
Mateusz Zalega <m.zalega@samsung.com> Signed-off-by:
Seung-Woo Kim <sw0312.kim@samsung.com> Signed-off-by:
Jacek Anaszewski <j.anaszewski@samsung.com> Signed-off-by:
Kyungmin Park <kyungmin.park@samsung.com> Signed-off-by:
-
Maurizio Lombardi authored
In the s5p_mfc_alloc_firmware() function there are some mistakes where the code checks whether the DMA memory is properly allocated or not. First of all dma_alloc_coherent() returns NULL in case of error. The code also checked two times fw_virt_addr, ignoring the bank2_virt pointer. Signed-off-by:
Maurizio Lombardi <mlombard@redhat.com> Signed-off-by:
-
- 17 Jul, 2014 29 commits
-
-
Dan Carpenter authored
The ZR050_MO_COMP define is cut and pasted twice so we can delete the second instance. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Himangi Saraogi authored
This patch removes the null test on dvb. dvb is initialized at the beginning of the function to &port->dvb. Since port is dereferenced prior to the null test, port must be a valid pointer, and &port->dvb cannot be null. The following Coccinelle script is used for detecting the change: @r@ expression e,f; identifier g,y; statement S1,S2; @@ *e = &f->g <+... f->y ...+> *if (e != NULL || ...) S1 else S2 Signed-off-by:
Himangi Saraogi <himangi774@gmail.com> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Luke Hart authored
Fix the following warnings reported in radio-bcm2048.c: WARNING: else is not generally useful after a break or return 374: FILE: radio-bcm2048.c:374: + return 0; + } else { WARNING: else is not generally useful after a break or return 728: FILE: radio-bcm2048.c:728: + return BCM2048_DE_EMPHASIS_75us; + else WARNING: unchecked sscanf return value 1974: FILE: radio-bcm2048.c:1974: + sscanf(buf, mask, &value); \ WARNING: Missing a blank line after declarations 2245: FILE: radio-bcm2048.c:2245: + unsigned char tmpbuf[3]; + tmpbuf[i] = bdev->rds_info.radio_text[bdev->rd_index+i+2]; WARNING: Possible unnecessary 'out of memory' message 2601: FILE: radio-bcm2048.c:2601: + if (!bdev) { + dev_dbg(&client->dev, "Failed to alloc video device.\n"); The following error was left since it seems to be a false positive: ERROR: Macros with complex values should be enclosed in parenthesis +#define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check) \ +property_write(prop, signal size, mask, check) \ +property_read(prop, size, mask) Signed-off-by:Luke Hart <luke.hart@birchleys.eu> Signed-off-by:
-
Andrey Utkin authored
The issue was discovered by static analysis. It turns out that code is somewhat insane, being if (x) {...} else { if (x) {...} } Edited it to do the only reasonable thing, which is to log the information about the failed call. The most descriptive logging commands set is taken from original code. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=79801Reported-by:Mike Isely <isely@pobox.com> Signed-off-by:
-
Anil Belur authored
- this patch removes IRQF_DISABLED macro, as this is deprecated/noop. Signed-off-by:
Anil Belur <askb23@gmail.com> Acked-by:
Pavel Machek <pavel@ucw.cz> Signed-off-by:
-
Andrey Utkin authored
Previously, it was needed to reopen device to update GOP size and quantization parameter. Now we update device registers with new values immediately. Signed-off-by:
Andrey Utkin <andrey.utkin@corp.bluecherry.net> Signed-off-by:
Ismael Luceno <ismael.luceno@corp.bluecherry.net> Signed-off-by:
-
Andrey Utkin authored
solo6*10 boards have configurable quantization parameter which takes values from 0 to 31, inclusively. This change enables setting it with ioctl VIDIOC_S_CTRL with id V4L2_CID_MPEG_VIDEO_H264_MIN_QP. Signed-off-by:
-
Andreas Weber authored
The total number of bits is 16 (12+4). Fix it. Signed-off-by:
Andreas Weber <andy.weber.aw@gmail.com> Signed-off-by:
-
Geert Uytterhoeven authored
If CONFIG_SOLO6X10=y, but CONFIG_BITREVERSE=m: drivers/built-in.o: In function `solo_osd_print': (.text+0x1c7a1f): undefined reference to `byte_rev_table' make: *** [vmlinux] Error 1 Reported-by:kbuild test robot <fengguang.wu@intel.com> Signed-off-by:
Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by:
-
Hans Verkuil authored
The colorspace for HDTV is REC709, not SMPTE240M. Signed-off-by:
-
Hans Verkuil authored
Add support for Hauppauge model 71100: WinTV-ImpactVCB-e (PCIe, Retail, half height) Signed-off-by:
-
Hans Verkuil authored
Otherwise you cannot get the current clip and bitmap information from an overlay. Signed-off-by:
-
Hans Verkuil authored
If the vidioc_cropcap op is implemented by the driver then the v4l2 core will call that directly. If g_selection is available, then the core cropcap implementation uses g_selection to fill in the bounds and defrect and it sets the pixelaspect to 1x1. But if both are available, then I would like to use g_selection to fill in defrect and bounds before calling cropcap. That way the driver's cropcap implementation doesn't have to set defrect or bounds. Signed-off-by:
-
Hans Verkuil authored
Be sure that the reserved fields are cleared. Signed-off-by:
-
Hans Verkuil authored
The edid field is the last field of the struct, so there is nothing to clear. Signed-off-by:
-
Hans Verkuil authored
Some applications poll a lot, so prevent the poll message from flooding the log. Signed-off-by:
-
Hans Verkuil authored
Add a macro to test if the field consists of a single top or bottom field. Anyone who needs to work with fields as opposed to frame will need this. Signed-off-by:
-
Hans Verkuil authored
The VIDIOC_STREAMON/OFF ioctls are not valid for radio devices, just like the other streaming I/O ioctls. Add the streamon/off ioctls to the other streaming I/O ioctls. Signed-off-by:
-
Hans Verkuil authored
If the driver supports enum_freq_bands, but only for certain device nodes, then it may return -ENOTTY. But in that case the code should fall into the fall-back case where the current tuner/modulator range is returned. Signed-off-by:
-
Hans Verkuil authored
The other format ioctls (g/s/try_fmt) all check if the passed buffer type makes sense for the device node's vfl_type. E.g. it makes no sense for a VBI buffer type to be passed through a video node instead of a vbi node. But this check was missing in ENUM_FMT which can cause a problem if you have both video and sdr device nodes. Signed-off-by:
-
Hans Verkuil authored
The text referred to videodev.h when videodev2.h was meant. Fixed. Signed-off-by:
-
Hans Verkuil authored
The v4l2_event union has a new src_change field, but that was never added to the VIDIOC_DQEVENT documentation of that union. Fixed. Signed-off-by:
-
Hans Verkuil authored
There shouldn't be any spaces after <constant> or before </constant>. This leads to ugly results like: 'image size set by VIDIOC_S_FMT .' Signed-off-by:
-
Laurent Pinchart authored
Update the OMAP Image Signal Processor entry to cover both the OMAP3 ISP and OMAP4 ISS. Signed-off-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by:
-
Laurent Pinchart authored
When a fatal error occurs in the pipeline signal it to the vb2 queue with a call to vb2_queue_error(). The queue will then take care to return -EIO when preparing buffers, remove the driver-specific code that now duplicates that check. Signed-off-by:
-
Laurent Pinchart authored
This simplifies remove and error code paths. Signed-off-by:
-
Laurent Pinchart authored
The parameter is used to initialize the video node debug field and activate the V4L debug infrastructure. Signed-off-by:
-
Laurent Pinchart authored
Initialize the spin lock once only when initializing the video object. Signed-off-by:
-
Vitaly Osipov authored
It makes more sense to return PTR_ERR(iss->iss_ctrlclk) here. The current code looks like an oversight in pasting the block just above this one. Signed-off-by:
Vitaly Osipov <vitaly.osipov@gmail.com> Signed-off-by:
-
