1. 27 Jan, 2013 1 commit
    • Paulo Zanoni's avatar
      drm/i915: set TRANSCODER_EDP even earlier · cc464b2a
      Paulo Zanoni authored
      Instead of setting it at the beginning of haswell_crtc_mode_set, let's
      set it at the beginning of intel_crtc_mode_set. When
      intel_crt_mode_set calls drm_vblank_pre_modeset we already need to
      have the transcoder_edp correctly set, because eventually
      drm_vblank_pre_modeset calls functions that call i915_pipe_enabled
      from i915_irq.c, which will read PIPECONF(cpu_transcoder).
      
      This is a bug that affects us since we added support for
      TRANSCODER_EDP, but I was only able to see the problem after
      suspending a machine with the power well disabled (got an "unclaimed
      register" error.
      Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
      Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
      Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      cc464b2a
  2. 26 Jan, 2013 8 commits
  3. 24 Jan, 2013 24 commits
  4. 22 Jan, 2013 6 commits
  5. 21 Jan, 2013 1 commit
    • Daniel Vetter's avatar
      drm/i915: clarify concurrent hang detect/gpu reset consistency · 7db0ba24
      Daniel Vetter authored
      Damien Lespiau wondered how race the gpu reset/hang detection code is
      against concurrent gpu resets/hang detections or combinations thereof.
      Luckily the single work item is guranteed to never run concurrently,
      so reset handling is already single-threaded.
      
      Hence we only have to worry about concurrent hang detections, or a
      hang detection firing off while we're still processing an older gpu
      reset request. Due to the new mechanism of setting the reset in
      progress flag and the ordering guaranteed by the schedule_work
      function there's nothing to do but add a comment explaining why we're
      safe.
      
      The only thing I've noticed is that we still try to reset the gpu now,
      even when it is declared terminally wedged. Add a check for that to
      avoid continous warnings about failed resets, in case the hangcheck
      timer ever gets stuck.
      Reviewed-by: default avatarDamien Lespiau <damien.lespiau@intel.com>
      Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
      7db0ba24