1. 04 Feb, 2004 40 commits
    • Andrew Morton's avatar
      [PATCH] fix menuconfig choice item help display · ccd3fed5
      Andrew Morton authored
      From: Bjorn Helgaas <bjorn.helgaas@hp.com>
            Anders Gustafsson <andersg@0x63.nu>
            Roman Zippel <zippel@linux-m68k.org>
      
      This patch fixes menuconfig so it can display help text for individual
      choice group config entries.
      
      Previously it would only display the help text attached to the "choice"
      item.  There was no way to display the help attached to individual config
      entries inside the choice group.  Typically, the "choice" item has no help
      text, and all the useful help is attached to the individual entries, so
      this was a bit of a problem.
      ccd3fed5
    • Andrew Morton's avatar
      [PATCH] /proc/stat:btime fix · eb32911f
      Andrew Morton authored
      From: George Anzinger <george@mvista.com>,
            Petri Kaukasoina <kaukasoi@elektroni.ee.tut.fi>
      
      btime in /proc/stat does not stay constant but decreases at a rate of 15
      secs/day, because we're assuming that HZ is exactly 100.  Use the correct
      adjustments to fix that up.
      eb32911f
    • Andrew Morton's avatar
      [PATCH] Fine tune the time conversion to eliminate conversion errors. · 03718ae0
      Andrew Morton authored
      From: George Anzinger <george@mvista.com>
      
      The time conversion code is erroring on the side of a bit too small.  The
      attached patch forces any error to be on the high side.  The current code will
      convert 1 nanosecond to zero jiffies (standard says that should be 1).  It also
      is around 1 nanosecond late on each roll to the next jiffie.
      
      I have done some error checks with this patch applied and get the following
      errors in PPB ( Parts Per Billion):
      
      HZ     nano sec conversion     microsecond conversion
      1000    315                      45
      1024    227                      40
      100     28                       317
      
      In all cases the error is on the high side, which means that the final shift
      will, most likely, eliminate the error bits.
      03718ae0
    • Andrew Morton's avatar
      [PATCH] UFS: honour `silent' parameter. · 80cfa786
      Andrew Morton authored
      From: GOTO Masanori <gotom@debian.or.jp>
      
      Teach ufs_fill_super() to honour the `silent' parameter.
      80cfa786
    • Andrew Morton's avatar
      [PATCH] try reiserfs before other filesystems · c93123fe
      Andrew Morton authored
      reiserfs places its superblock in weird places which can result in false
      positives and various printks when other filesystems probe a resierfs
      filesystem.
      c93123fe
    • Andrew Morton's avatar
      [PATCH] namei.c: take vfsmount_lock · 5f833af7
      Andrew Morton authored
      From: Mike Waychison <Michael.Waychison@Sun.COM>
      
      The attached patch ensures that we grab vfsmount_lock when grabbing a
      reference to mnt_parent in follow_up and follow_dotdot.
      
      We also don't need to access ->mnt_parent in follow_mount and
      __follow_down to mntput because we already the parent pointer on the stack.
      5f833af7
    • Andrew Morton's avatar
      [PATCH] __d_path needs vfsmount_lock · 122eace8
      Andrew Morton authored
      From: Mike Waychison <Michael.Waychison@Sun.COM>
      
      - protect vfsmount->mnt_parent by taking vfsmount_lock in __d_path
      122eace8
    • Andrew Morton's avatar
      [PATCH] [janitor] vga16fb: add missing iounmap() · 702e97e7
      Andrew Morton authored
      From: "Randy.Dunlap" <rddunlap@osdl.org>
            Leann Ogasawara <ogasawara@osdl.org>
      
      Patch inserts missing iounmap() on error.
      702e97e7
    • Andrew Morton's avatar
      [PATCH] janitor: vgastate: cleanup iounmap() usage · e9589567
      Andrew Morton authored
      From: "Randy.Dunlap" <rddunlap@osdl.org>
      
      From: Leann Ogasawara <ogasawara@osdl.org>
      
      Patch inserts missing iounmap's on error and also removes unnecessary
      iounmap's.
      e9589567
    • Andrew Morton's avatar
      [PATCH] copy_namespace ENOMEM fix · 9f33cf76
      Andrew Morton authored
      From: Marcus Alanen <maalanen@ra.abo.fi>
      
      The copy_tree() function can return NULL, so this checks for it.
      9f33cf76
    • Andrew Morton's avatar
      [PATCH] oprofile, typo in alpha driver · 89076ac4
      Andrew Morton authored
      From: Philippe Elie <phil.el@wanadoo.fr>
      
      Unless I miss something this look like a typo, one user reported to get
      error from the daemon: 'Unknown event for counter 1' (alpha ev6) and the
      behavior was better but not completly sane after trying this patch: he get
      spurious event for counter 1 when enabling only counter 0 but rarely now.
      No alpha box to test this.
      89076ac4
    • Andrew Morton's avatar
      [PATCH] oprofile per-cpu buffer overrun · 26c8fae2
      Andrew Morton authored
      From: Philippe Elie <phil.el@wanadoo.fr>
      
      In a ring buffer controlled by a read and write positions we can't use
      buffer_size but only buffer_size - 1 entry, the last free entry act as a
      guard to avoid write pos overrun.  This bug was hidden because the writer,
      oprofile_add_sample(), request one more entry than really needed.
      26c8fae2
    • Andrew Morton's avatar
      [PATCH] console cleanup · 2c8aa408
      Andrew Morton authored
      From: Sam Ravnborg <sam@ravnborg.org>,
            Ben Collins <bcollins@debian.org>
      
      Fix up the console makefiles and logo generation.
      
      1) To make output look like the rest of the kernel build.
      
      2) To avoid make utilising chained rules, and therefore issuing a 'rm
         drivers/video/logo/linux_logo.c ...' during the build.
      
      I have previously submitted a few patches for logo/Makefile, but this is the
      first one that actually address the problems I have seen in a proper way.
      
      And no, I did not like such a simple thing to look that complicated, the
      other option was to list too many files or to use other types of kbuild/make
      magic.
      2c8aa408
    • Andrew Morton's avatar
      [PATCH] janitor: sound/oss: use C99 inits. · 3f7468a7
      Andrew Morton authored
      From: "Randy.Dunlap" <rddunlap@osdl.org>,
            "Maciej Soltysiak" <solt@dns.toxicfilms.tv>
      
      C99 initializers for linux/sound.
      3f7468a7
    • Andrew Morton's avatar
      [PATCH] janitor: dz: verify_area() removal · 8e4c6c31
      Andrew Morton authored
      From: "Randy.Dunlap" <rddunlap@osdl.org>,
            Domen Puncer <domen@coderock.org>
      8e4c6c31
    • Andrew Morton's avatar
      [PATCH] janitor: change a few SYSRQ to MAGIC_SYSRQ · c44ce779
      Andrew Morton authored
      From: "Randy.Dunlap" <rddunlap@osdl.org>,
            Domen Puncer <domen@coderock.org>
      
      Noone tested that code to see if it really works?
      c44ce779
    • Andrew Morton's avatar
      [PATCH] futex: remove redundant test · a507bf7a
      Andrew Morton authored
      From: Jamie Lokier <jamie@shareable.org>
      
      One of the tests in unqueue_me() is redundant.  If we acquire the spinlock,
      the futex must be queued.
      a507bf7a
    • Andrew Morton's avatar
      [PATCH] Zero last byte of mount option page. · d2ca78bb
      Andrew Morton authored
      From: James Morris <jmorris@redhat.com>
      
      Here's a patch which zeroes the last byte of the mount option data copied
      from userspace during mount(2).
      
      For filesystems which parse mount options as strings (the majority), lack
      of a zero terminator could cause the page to be overrun.  The source code
      comments specify that the maximum size of the mount data is PAGE_SIZE-1, so
      this patch will not affect any valid binary-formatted mount data.
      d2ca78bb
    • Andrew Morton's avatar
      [PATCH] posix_timers fixes · 81dcbaab
      Andrew Morton authored
      From: George Anzinger <george@mvista.com>
      
      - Removes C++ comment in favor of C style.
      
      - Removes the special treatment for MIPS SIGEV values.  We only require
        (and error if this fails) that the SIGEV_THREAD_ID value not share bits
        with the other SIGEV values.  Note that mips has yet to define this value
        so when they do...
      
      - Corrects the check for the signal range to be from 1 to SIGRTMAX
        inclusive.
      
      - Adds a check to verify that kmem_cache_alloc() actually returned a timer,
        error if not.
      
      - Fixes a bug in timer_gettime() where the incorrect value was returned if
        a signal was pending on the timer OR the timer was a SIGEV_NONE timer.
      81dcbaab
    • Andrew Morton's avatar
      [PATCH] Better "Losing Ticks" Error Message · bd5e36f5
      Andrew Morton authored
      From: timothy parkinson <t@timothyparkinson.com>
      
      Seems like a lot of people see the below error message, but aren't quite
      sure why it happens or how to fix it.  I sure didn't.  Here's my attempt at
      remedying that.
      bd5e36f5
    • Andrew Morton's avatar
      [PATCH] Clean up raid6 kbuild output · 3c87ddbe
      Andrew Morton authored
      From: Sam Ravnborg <sam@ravnborg.org>
      
      During raid6 compilation with KBUILD_VERBOSE unset we see invokations of
      perl commands which should not have been displayed.
      3c87ddbe
    • Andrew Morton's avatar
      [PATCH] Remove memblks from the kernel · 4c5736de
      Andrew Morton authored
      From: "Martin J. Bligh" <mbligh@aracnet.com>
      
      This patch removes memblks from the kernel ...  we don't use them, and the
      NUMA API that was planning to use them when they were originally designed
      isn't going to use them anymore.  They're just unnecessary added complexity
      now ...  time for them to go.
      
      There's a slight complication in that ia64 uses something with a similar
      name for part of its memory layout, but Jes Sorensen kindly untangled them
      from each other for us.  The patch with his modifications is below.  Jes
      tested it on ia64, and I testbuilt it with every config in my arsenal.
      4c5736de
    • Andrew Morton's avatar
      [PATCH] remove SIIG combo cards PCI ids from parport_pc · b5a2bdf9
      Andrew Morton authored
      From: Andrey Panin <pazke@donpac.ru>
      
      support for SIIG made serial/parallel conbo cards was moved to
      parport_serial driver some months ago, but their PCI ids still remain in
      parport_pc PCI device table.  Attached patch removes them.
      b5a2bdf9
    • Andrew Morton's avatar
      [PATCH] /proc/paritions: omit removable media · 32390780
      Andrew Morton authored
      From: Neil Brown <neilb@cse.unsw.edu.au>
      
      If programs like mount use /proc/partitions to find filesystems based on
      labels, then surely we want md devices in there as they often contain
      filesystems.
      
      If the problem is that mount-by-label takes forever with removable media
      then surely the "right" approch is the following patch, and then actually
      set this flag on the "floppy.c" device.  (It is already set for ide-floppy
      and sd devices).
      32390780
    • Andrew Morton's avatar
      [PATCH] md: Change the way the name of an md device is printed in error messages. · 62c10f9e
      Andrew Morton authored
      From: NeilBrown <neilb@cse.unsw.edu.au>
      
      Instead of using ("md%d", mdidx(mddev)), we now use ("%s", mdname(mddev))
      where mdname is the disk_name field in the associated gendisk structure.
      This allows future flexability in naming.
      62c10f9e
    • Andrew Morton's avatar
      [PATCH] md: Collect device IO statistics for MD personalities. · fe6498c9
      Andrew Morton authored
      From: NeilBrown <neilb@cse.unsw.edu.au>
      
      Update {read,write}{s,_sectors} on each request to an MD array.
      fe6498c9
    • Andrew Morton's avatar
      [PATCH] md: Fixes to make debuging output nicer. · 403c2172
      Andrew Morton authored
      From: NeilBrown <neilb@cse.unsw.edu.au>
      
      This patch thanks to Paul Clements <Paul.Clements@SteelEye.com> and only has
      effect if md is compiled with #define DEBUG 1
      403c2172
    • Andrew Morton's avatar
      [PATCH] md: Move the test in preferred_minor to where it is used. · 70bb57ee
      Andrew Morton authored
      From: NeilBrown <neilb@cse.unsw.edu.au>
      
      A RAID superblock can indicate which minor number the array should be
      assembled under.  As this is only meaningful when doing auto-start, we move
      the test for it being in the valid range to the place where auto-start
      happens.  When an array is started any other way, it doesn't matter what
      value is here.
      70bb57ee
    • Andrew Morton's avatar
      [PATCH] remove_suid() fix · 588d6141
      Andrew Morton authored
      From: viro@parcelfarce.linux.theplanet.co.uk
      
      bernhard_heibler@gmx.de has discovered that NFS is very slow when writing to
      a file which has execute permissions.  See
      
      	http://bugme.osdl.org/show_bug.cgi?id=1936
      
      This patch fixes remove_suid() to not try to modify the inode mode on every
      write to such a file.
      588d6141
    • Andrew Morton's avatar
      [PATCH] Fix deep stack usage in ncpfs · fea7cfba
      Andrew Morton authored
      From: Petr Vandrovec <vandrove@vc.cvut.cz>
      
      
      Arjan van de Ven pointed out to me there are no checks on name component
      lengths in ncpfs, so potentially 4KB regions could be allocated on stack,
      leading to the user controlled stack overflow.
      
      It was using variable-sized arrays, so this snuck past the static
      stack-usage checking tools.
      
      As NCP is limited to 255 bytes on components, we can simple limit these
      local variables to 256 bytes, and after this stack usage looks more
      acceptable.  Length checking occurs inside ncp_vol2io, during
      iocharset->codepage conversion.
      
      As a side effect support for multibyte codepages now works as it should,
      instead of returning -EINVAL whenever filename in 'codepage' encoding was
      longer than in 'iocharset'.
      
      Other part fixes typo where atime change updated ctime and not atime field.
      fea7cfba
    • Andrew Morton's avatar
      [PATCH] deprecate the raw driver · b2df6ea7
      Andrew Morton authored
      Fat chance, but we should try.
      b2df6ea7
    • Andrew Morton's avatar
      [PATCH] initialise cpu_vm_mask in init_mm · 32a0251f
      Andrew Morton authored
      From: Anton Blanchard <anton@samba.org>
      
      Some architectures use cpu_vm_mask to optimise TLB flushes.  On ppc64 we
      are now using a common flush infrastructure that handles both userspace and
      kernelspace (vmalloc) pages.  In order to avoid triggering this
      optimisation we need to mark the init mm as having scheduled on all cpus.
      
      Things currently work by luck (we check for the cpu only having run on the
      local cpu, and the field is initialised to 0), but it would be safer to
      initialise it CPU_MASK_ALL.
      32a0251f
    • Andrew Morton's avatar
      [PATCH] osst.c: suppress page allocation failure warnings · 7a9e704b
      Andrew Morton authored
      This driver is trying an order-9 allocation and if that fails, order 8, etc.
      Crufty, but we do expect failures, so suppress the warnings.
      7a9e704b
    • Andrew Morton's avatar
      [PATCH] remove valid_addr_bitmap · 73027d99
      Andrew Morton authored
      From: William Lee Irwin III <wli@holomorphy.com>
      
      ->valid_addr_bitmap is initialized nowhere.  Any kern_addr_valid() testing
      it returns 0 unconditionally.
      
      This patch converts kern_addr_valid() implementations using it to return 0
      as per the above and removes it from structures and zone initialization.
      Untested (not even compiletested), though a similar patch also nuking
      d_validate() was in use in -wli for several months.
      73027d99
    • Andrew Morton's avatar
      [PATCH] console: support for > 127 chars · f70ceb5a
      Andrew Morton authored
      From: Nigel Cunningham <ncunningham@users.sourceforge.net>
      
      Change the console code to support up to 256 (maybe 255?) columns.
      f70ceb5a
    • Andrew Morton's avatar
      [PATCH] fix blockdev --getro for sr, sd, ide-floppy · 2b0bcc8b
      Andrew Morton authored
      From: John McKell <mckellj@iomega.com>
      
      This 2.6.1 patch works by setting gendisk->policy to the correct value
      during initialization as the various drivers decide whether or not the disk
      is writeable.  This patch persuades "blockdev --getro ..." to correctly
      report the read-only state of a newly inserted disk.  This patch applies to
      sr.c, sd.c and ide-floppy.c.  ide-cd.c already has this functionality built
      into it.
      
      Using an Iomega Zip drive as the test case...
      
      Without the patch, I always see:
      
      $ sudo blockdev --getro /dev/sda
      0
      $
      
      That's only correct for writeable disks though.  Only when the patch
      is applied do I see a write-protected disk described correctly:
      
      $ sudo blockdev --getro /dev/sda
      1
      $
      2b0bcc8b
    • Andrew Morton's avatar
      [PATCH] ppc32: Set HZ to 1000 on ppc32 · d11e9847
      Andrew Morton authored
      From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      
      This patch has been in my tree for monthes and Paulus agrees that it should
      be made generic, so here we go, PPC32 is now proud to run at 1000HZ :)
      d11e9847
    • Andrew Morton's avatar
      [PATCH] Make naming of parititions in sysfs match /proc/partitions. · 2ae2199f
      Andrew Morton authored
      From: Neil Brown <neilb@cse.unsw.edu.au>
      
      In fs/partitions/check.c  there are two pieces of code that add a
      partition number to a block-device name:
      
        - the 'disk_name' function
        - a snprintf in add_partitions.
      
      'disk_name' inserts a 'p' before the partition number if the device
      name ends with a digit.  The snprintf in add_partitions doesn't.
      
      This patch rectifies this anomoly so that names in sysfs can be
      parsed more reliably.
      
      
      This has been extensively discussed.  It will probably break the external
      `iostat' tool.  But only for disks whose name ends in a digit, which appears
      to be only DAC960.
      2ae2199f
    • Andrew Morton's avatar
      [PATCH] missing `console_driver' with CONFIG_VT && !CONFIG_VT_CONSOLE · 057ee909
      Andrew Morton authored
      From: Jun Sun <jsun@mvista.com>
      
      'console_driver' is defined only when CONFIG_VT_CONSOLE is set.  However it
      is used by vty_init() which is outside the scope of CONFIG_VT_CONSOLE.
      057ee909
    • Andrew Morton's avatar
      [PATCH] check do_munmap() failure · 59287e5e
      Andrew Morton authored
      From: Andrea Arcangeli <andrea@suse.de>
      
      Return the proper error code
      59287e5e