1. 11 Apr, 2008 5 commits
    • Randy Dunlap's avatar
      rtc: rtc-s35390a.c needs the bitreverse library · d479540d
      Randy Dunlap authored
      rtc-s35390a uses BITREVERSE functions so it needs to select that config symbol
      to ensure that the functions are built.
      
        drivers/built-in.o: In function `s35390a_set_datetime':
        linux-2.6.25-rc8-git7/drivers/rtc/rtc-s35390a.c:144: undefined reference to `byte_rev_table'
        drivers/built-in.o: In function `s35390a_get_datetime':
        linux-2.6.25-rc8-git7/drivers/rtc/rtc-s35390a.c:163: undefined reference to `byte_rev_table'
      Signed-off-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Acked-by: default avatarAlessandro Zummo <a.zummo@towertech.it>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      d479540d
    • Paul Menage's avatar
      cgroups: include hierarchy ids in /proc/<pid>/cgroup · b6c3006d
      Paul Menage authored
      Extend the /proc/<pid>/cgroup file to include the appropriate hierarchy ID on
      each line.
      
      Currently this ID isn't really needed since a hierarchy can be completely
      identified by the set of subsystems bound to it, but this is likely to change
      in the near future in order to support stateless subsystems and
      merging/rebinding of subsystems.  Getting this change into 2.6.25 reduces the
      need for an API change later.
      Signed-off-by: default avatarPaul Menage <menage@google.com>
      Cc: Balbir Singh <balbir@in.ibm.com>
      Cc: Pavel Emelyanov <xemul@openvz.org>
      Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      b6c3006d
    • Linus Torvalds's avatar
      Add commentary about the new "asmlinkage_protect()" macro · d10d89ec
      Linus Torvalds authored
      It's really a pretty ugly thing to need, and some day it will hopefully
      be obviated by teaching gcc about the magic calling conventions for the
      low-level system call code, but in the meantime we can at least add big
      honking comments about why we need these insane and strange macros.
      
      I took my comments from my version of the macro, but I ended up deciding
      to just pick Roland's version of the actual code instead (with his
      prettier syntax that uses vararg macros).  Thus the previous two commits
      that actually implement it.
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      d10d89ec
    • Roland McGrath's avatar
      asmlinkage_protect sys_io_getevents · 598af051
      Roland McGrath authored
      Use asmlinkage_protect in sys_io_getevents, because GCC for i386 with
      CONFIG_FRAME_POINTER=n can decide to clobber an argument word on the
      stack, i.e. the user struct pt_regs.  Here the problem is not a tail
      call, but just the compiler's use of the stack when it inlines and
      optimizes the body of the called function.  This seems to avoid it.
      Signed-off-by: default avatarRoland McGrath <roland@redhat.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      598af051
    • Roland McGrath's avatar
      asmlinkage_protect replaces prevent_tail_call · 54a01510
      Roland McGrath authored
      The prevent_tail_call() macro works around the problem of the compiler
      clobbering argument words on the stack, which for asmlinkage functions
      is the caller's (user's) struct pt_regs.  The tail/sibling-call
      optimization is not the only way that the compiler can decide to use
      stack argument words as scratch space, which we have to prevent.
      Other optimizations can do it too.
      
      Until we have new compiler support to make "asmlinkage" binding on the
      compiler's own use of the stack argument frame, we have work around all
      the manifestations of this issue that crop up.
      
      More cases seem to be prevented by also keeping the incoming argument
      variables live at the end of the function.  This makes their original
      stack slots attractive places to leave those variables, so the compiler
      tends not clobber them for something else.  It's still no guarantee, but
      it handles some observed cases that prevent_tail_call() did not.
      Signed-off-by: default avatarRoland McGrath <roland@redhat.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      54a01510
  2. 10 Apr, 2008 17 commits
  3. 09 Apr, 2008 18 commits