- 25 Jan, 2013 16 commits
-
-
H Hartley Sweeten authored
This driver needs to read the on-board eeprom to determine the number of analog output channels (4 or 8) on the board. But, sinde we know the board has an eeprom and the PCI controller chip is an AMCC S5933, we can simplify the code and remove the code that sets the extra wait state neede for the AMCC S5920. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
H Hartley Sweeten authored
This driver only has one 'interrupt' function. Absorb the v_APCI3501_Interrupt() function from hwdrv_apci3501.c into the driver. Rename v_ADDI_Interrupt() to apci3501_interrupt() so that the function has namespace associated with the driver. Signed-off-by:
-
H Hartley Sweeten authored
This driver only has one 'reset' function. Absorb the i_APCI3501_Reset() function from hwdrv_apci3501.c into the driver. Rename i_ADDI_Reset() to apci3501_reset() so that the function has namespace associated with the driver. Signed-off-by:
-
H Hartley Sweeten authored
The board supported by this driver does not have analog inputs. Remove the subdevice init for it. Since the devpriv->s_EeParameters for the analog input subdevice are not used, remove the initialization of them also. Signed-off-by:
-
H Hartley Sweeten authored
The board supported by this driver has 2 digital input. Remove the conditional and always init the subdevice. Also, move the subdevice insn_bits function pointer as well as the n_chan out of the boardinfo and use them to initialize the subdevice directly. Since devpriv->s_EeParameters.i_NbrDiChannel for the digital input subdevice is no longer being used, remove initialization of it also. Copy the apci3501_di_insn_bits() function from hwrdv_apci3501.c into the main driver file. Fix the subdev_flags for the subdevice. The only required flag is SDF_READABLE. The SDF_GROUND and SDF_COMMON flags only have meaning for analog subdevices. Remove the len_chanlist initialization, it only has meaning for subdevices that support commands. Remove the io_bits initialization, it only has meaning for digital i/o subdevices that have configurable outputs. Signed-off-by:
-
H Hartley Sweeten authored
The board supported by this driver has 2 digital outputs. Remove the conditional and always init the subdevice. Also, move the subdevice insn_bits function pointer as well as the n_chan out of the boardinfo and use them to initialize the subdevice directly. Since devpriv->s_EeParameters for the digital output subdevice are no longer being used, remove initialization of them also. Copy the apci3501_do_insn_bits() function from hwrdv_apci3501.c into the main driver file. Fix the subdev_flags for the subdevice. The only required flag is SDF_WRITEABLE. The SDF_GROUND and SDF_COMMON flags only have meaning for analog subdevices and the SDF_READABLE flag is not required. Fix the maxdata for the subdevice. Digital outputs can only be 1 or 0. Remove the len_chanlist initialization, it only has meaning for subdevices that support commands. Remove the io_bits initialization, it only has meaning for digital i/o subdevices that have configurable outputs. Signed-off-by:
-
H Hartley Sweeten authored
The board supported by this driver has a timer device. Remove the conditional and always init the subdevice. Also, move the subdevice insn_* function pointers out of the boardinfo and use them to initialize the subdevice directly. Since devpriv->s_EeParameters.i_Timer is not longer being used, remove its initialization also. Signed-off-by:
-
H Hartley Sweeten authored
The board supported by this driver does not have ttl i/o. Remove the subdevice init for it. Signed-off-by:
-
H Hartley Sweeten authored
This driver is for a simple analog output board with 4 or 8, 14-bit outputs. The board also has 4 digital i/o channels (2 out/2 in) as well as a watchdog or timer. Using the addi-data "common" code in this driver introduces a lot of bloat. Copy the code in addi_common.c to this driver and remove the #include that caused it to be compiled with the driver. This will allow removing the bloat. Rename the auto_attach and detach functions so they have namespace associated with this driver. Signed-off-by:
-
Peter Huewe authored
Instead of coding calling comedi_driver_(un)register and usb_(de)register directly we can use the comedi_usb_driver_(un)register wrapper. This removes some boilerplate and is less error prone. Signed-off-by:
Peter Huewe <peterhuewe@gmx.de> Signed-off-by:
-
Dan Magenheimer authored
Replace raw constant 12 with PAGE_SHIFT to fix non-x86 arches and provoke build failure if PAGE_SHIFT is too big Signed-off-by:
Dan Magenheimer <dan.magenheimer@oracle.com> Signed-off-by:
-
Rupesh Gujare authored
As part of transition caused due to acquisition of Ozmo Devices by Atmel, my email address is changed. Signed-off-by:
Rupesh Gujare <rgujare@ozmodevices.com> Signed-off-by:
-
Chris Kelly authored
Removed myself (ckelly@ozmodevices.com) as maintainer of ozwpan. Removed my email address from the TODO file. Signed-off-by: -
Dan Carpenter authored
If we don't restrict "cp.channum" to 3 digits then the sprintf() will overflow. I've added a check and changed the sprintf() to snprintf(). Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Malcolm Priestley authored
The patch was totally wrong and is reverted. The problem was ultimately fixed by upstream commit. 1ee4c55f staging: vt6656: Fix inconsistent structure packing Reported-by:
Ben Hutchings <ben@decadent.org.uk> Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Cc: stable@vger.kernel.org # 3.8 Signed-off-by:
-
Malcolm Priestley authored
The patch is wrong and is partially reverted. The NULL check of pTransmitKey->pvKeyTable is kept. The problem was ultimately fixed by upstream commit. 1ee4c55f staging: vt6656: Fix inconsistent structure packing Reported-by:
-
- 24 Jan, 2013 5 commits
-
-
Arve Hjønnevåg authored
Fold together the NAND driver for Goldfish from Arve with cleanups by Jun Nakajima and a tidy up to 3.7 and checkpatch. This provides a virtual flash driver for the Goldfish Android Virtual Platform, and which is normally used as the root file system when testing emulated devices. Signed-off-by:
Mike A. Chan <mikechan@google.com> Signed-off-by:
Arve Hjønnevåg <arve@android.com> [Ported to handle x86] Signed-off-by:
Sheng Yang <sheng@linux.intel.com> Signed-off-by:
Yunhong Jiang <yunhong.jiang@intel.com> Signed-off-by:
Xiaohui Xin <xiaohui.xin@intel.com> Signed-off-by:
Jun Nakajima <jun.nakajima@intel.com> Signed-off-by:
Bruce Beare <bruce.j.beare@intel.com> [Ported to 3.4] Signed-off-by:
Tom Keel <thomas.keel@intel.com> [Ported to 3.7 and tided for checkpatch etc] Signed-off-by:
Alan Cox <alan@linux.intel.com> Signed-off-by:
-
Alan Cox authored
(remove change to another file that escaped into the patch set) From: Mike Lockwood <lockwood@google.com> Provide a simple audio channel between the kernel and the emulator that host sit. Queued for staging right now as this ought to be an ALSA driver not just a dumb device of its own making. Signed-off-by:
-
Alan Cox authored
Note a point in the pipe driver that wants future attention Signed-off-by:
-
David 'Digit' Turner authored
A QEMU pipe is a very fast communication channel between the guest system and the emulator. Usage from the guest is simply something like; // connect to special device fd = open("/dev/qemu_pipe", O_RDWR); // tell which service we want to talk to (must be zero-terminated) write(fd, "pipeName", strlen("pipeName")+1); // do read()/write() through fd now ... // close channel close(fd); Signed-off-by:David 'Digit' Turner <digit@android.com> [Added support for parameter buffers for speed] igned-off-by:
-
Jun Nakajima authored
This imports the current Google code and cleans it up slightly to use pr_ and to properly request its resources. Goldfish is an emulator used for Android development. It has a virtual bus where the emulator passes platform device information to the guest which then creates the appropriate devices. This part of the emulation is not architecture specific so should not be hiding in architecture trees as it does in the Google Android tree. The constants it uses do depend on the platform and the platform creates the bus device which then talks to the emulator to ascertain the actual devices present. Signed-off-by:
-
- 22 Jan, 2013 19 commits
-
-
Mark Einon authored
Dan Carpenter has pointed out that there are several sparse warnings from et131x.c, listed below. This patch fixes all these errors. drivers/staging/et131x/et131x.c:1870:33: warning: incorrect type in assignment (different address spaces) drivers/staging/et131x/et131x.c:1870:33: expected unsigned int [usertype] *num_des drivers/staging/et131x/et131x.c:1870:33: got unsigned int [noderef] <asn:2>*<noident> drivers/staging/et131x/et131x.c:1871:37: warning: incorrect type in assignment (different address spaces) drivers/staging/et131x/et131x.c:1871:37: expected unsigned int [usertype] *full_offset drivers/staging/et131x/et131x.c:1871:37: got unsigned int [noderef] <asn:2>*<noident> drivers/staging/et131x/et131x.c:1872:33: warning: incorrect type in assignment (different address spaces) drivers/staging/et131x/et131x.c:1872:33: expected unsigned int [usertype] *min_des drivers/staging/et131x/et131x.c:1872:33: got unsigned int [noderef] <asn:2>*<noident> drivers/staging/et131x/et131x.c:1873:33: warning: incorrect type in assignment (different address spaces) drivers/staging/et131x/et131x.c:1873:33: expected unsigned int [usertype] *base_hi drivers/staging/et131x/et131x.c:1873:33: got unsigned int [noderef] <asn:2>*<noident> drivers/staging/et131x/et131x.c:1874:33: warning: incorrect type in assignment (different address spaces) drivers/staging/et131x/et131x.c:1874:33: expected unsigned int [usertype] *base_lo drivers/staging/et131x/et131x.c:1874:33: got unsigned int [noderef] <asn:2>*<noident> drivers/staging/et131x/et131x.c:1876:33: warning: incorrect type in assignment (different address spaces) drivers/staging/et131x/et131x.c:1876:33: expected unsigned int [usertype] *num_des drivers/staging/et131x/et131x.c:1876:33: got unsigned int [noderef] <asn:2>*<noident> drivers/staging/et131x/et131x.c:1877:37: warning: incorrect type in assignment (different address spaces) drivers/staging/et131x/et131x.c:1877:37: expected unsigned int [usertype] *full_offset drivers/staging/et131x/et131x.c:1877:37: got unsigned int [noderef] <asn:2>*<noident> drivers/staging/et131x/et131x.c:1878:33: warning: incorrect type in assignment (different address spaces) drivers/staging/et131x/et131x.c:1878:33: expected unsigned int [usertype] *min_des drivers/staging/et131x/et131x.c:1878:33: got unsigned int [noderef] <asn:2>*<noident> drivers/staging/et131x/et131x.c:1879:33: warning: incorrect type in assignment (different address spaces) drivers/staging/et131x/et131x.c:1879:33: expected unsigned int [usertype] *base_hi drivers/staging/et131x/et131x.c:1879:33: got unsigned int [noderef] <asn:2>*<noident> drivers/staging/et131x/et131x.c:1880:33: warning: incorrect type in assignment (different address spaces) drivers/staging/et131x/et131x.c:1880:33: expected unsigned int [usertype] *base_lo drivers/staging/et131x/et131x.c:1880:33: got unsigned int [noderef] <asn:2>*<noident> drivers/staging/et131x/et131x.c:1898:24: warning: incorrect type in argument 2 (different address spaces) drivers/staging/et131x/et131x.c:1898:24: expected void volatile [noderef] <asn:2>*addr drivers/staging/et131x/et131x.c:1898:24: got unsigned int [usertype] *base_hi drivers/staging/et131x/et131x.c:1900:24: warning: incorrect type in argument 2 (different address spaces) drivers/staging/et131x/et131x.c:1900:24: expected void volatile [noderef] <asn:2>*addr drivers/staging/et131x/et131x.c:1900:24: got unsigned int [usertype] *base_lo drivers/staging/et131x/et131x.c:1901:60: warning: incorrect type in argument 2 (different address spaces) drivers/staging/et131x/et131x.c:1901:60: expected void volatile [noderef] <asn:2>*addr drivers/staging/et131x/et131x.c:1901:60: got unsigned int [usertype] *num_des drivers/staging/et131x/et131x.c:1902:39: warning: incorrect type in argument 2 (different address spaces) drivers/staging/et131x/et131x.c:1902:39: expected void volatile [noderef] <asn:2>*addr drivers/staging/et131x/et131x.c:1902:39: got unsigned int [usertype] *full_offset drivers/staging/et131x/et131x.c:1910:24: warning: incorrect type in argument 2 (different address spaces) drivers/staging/et131x/et131x.c:1910:24: expected void volatile [noderef] <asn:2>*addr drivers/staging/et131x/et131x.c:1910:24: got unsigned int [usertype] *min_des drivers/staging/et131x/et131x.c:2583:32: warning: incorrect type in assignment (different address spaces) drivers/staging/et131x/et131x.c:2583:32: expected unsigned int [usertype] *offset drivers/staging/et131x/et131x.c:2583:32: got unsigned int [noderef] <asn:2>*<noident> drivers/staging/et131x/et131x.c:2585:32: warning: incorrect type in assignment (different address spaces) drivers/staging/et131x/et131x.c:2585:32: expected unsigned int [usertype] *offset drivers/staging/et131x/et131x.c:2585:32: got unsigned int [noderef] <asn:2>*<noident> drivers/staging/et131x/et131x.c:2602:24: warning: incorrect type in argument 2 (different address spaces) drivers/staging/et131x/et131x.c:2602:24: expected void volatile [noderef] <asn:2>*addr drivers/staging/et131x/et131x.c:2602:24: got unsigned int [usertype] *offset drivers/staging/et131x/et131x.c:4093:13: warning: symbol 'et131x_isr' was not declared. Should it be static? Reported-by:
Mark Einon <mark.einon@gmail.com> Signed-off-by:
-
Harvey Yang authored
On the client side, we have a virtual hcd driver, there actually no hardware interrupts, so we do not need worry about race conditions caused by irq with spinlock held. Turning off irq is not good for system performance after all. Just replace them with a non interrupt safe version. Signed-off-by:
Harvey Yang <harvey.huawei.yang@gmail.com> Signed-off-by:
-
Harvey Yang authored
The function 'usbip_event_add()' may be called in interrupt context on the stub side: 'stub_complete'->'stub_enqueue_ret_unlink'->'usbip_event_add'. In this function it tries to get the lock 'ud->lock', so we should disable irq when we get this lock in process context. Signed-off-by:
-
Mark Einon authored
In preparation for moving et131x to drivers/net, fixup the block comments to match the preferred networking style - no /* on separate line, but */ are on a seperate line. Signed-off-by:
-
Mark Einon authored
Checkpatch now highlights some camel case flag names. Fix these issues. Also fix some remaining lines > 80chars issues for completeness. Signed-off-by:
-
Mark Einon authored
et131x_get_regs() calls et131x_mii_read(), passing the address of a u32 which is cast to a (u16 *). This works fine for little endian systems, but not for big endian. Change so that the types are cast, not pointers to the types. Reported-by:
-
Devendra Naga authored
the i and j are used in for loop and they assigned to zeros in the for loop, so no need to assign them to zeros again. Signed-off-by:
Devendra Naga <devendra.aaru@gmail.com> Signed-off-by:
-
Devendra Naga authored
while proc_create fails, the register_proc_table can do a derefernce of the null pointer causing to oops the system, instead check for a valid pointer at register and unregister Signed-off-by:
-
H Hartley Sweeten authored
The PCI device ids supported by this driver are used multiple places in the code. To improve maintainability, create #define's for them. Signed-off-by:
-
H Hartley Sweeten authored
Change the MODULE_DESCRIPTION to something more useful than the generic "Comedi low-level driver" so that modinfo provides a better description of the driver. Signed-off-by:
-
H Hartley Sweeten authored
This driver does not use any of the functionality provided by comedi_fc.h. Remove the #include. Signed-off-by:
-
H Hartley Sweeten authored
Add the missing copyright information. This information was originally in the hwdrv_apci16xx.c file. Signed-off-by:
-
H Hartley Sweeten authored
The current low-level support code in hwdrv_apci16xx.c is seriously broken. Besides that, it's overly complicated. Rewrite, and simplify, the low-level code so it complies with the comedi API. Signed-off-by:
-
H Hartley Sweeten authored
Change the MODULE_DESCRIPTION to something more useful than the generic "Comedi low-level driver" so that modinfo provides a better description of the driver. Signed-off-by:
-
H Hartley Sweeten authored
The addi-data "common" code always allocated 7 subdevices. This driver only requires 3. Change the allocation and remove the unused subdevices. Update the comments for the initialization of each subdevice. Also, update the subdevice that is passed to addi_watchdog_cleanup() to match the new subdevice number. Signed-off-by:
-
H Hartley Sweeten authored
Add the missing copyright information. This information was originally in the hwdrv_apci2200.c file. Signed-off-by:
-
H Hartley Sweeten authored
This driver does not use any of the support provided by comedi_fc.h. Remove it's include. Signed-off-by:
-
H Hartley Sweeten authored
The boardinfo is not longer needed by this driver. Remove it as well as the addi_find_boardinfo() function. This removes the final ties to the addi-data "common" code so remove the #include for it. Signed-off-by:
-
H Hartley Sweeten authored
The 'devpriv' is not used in this driver. Remove it's allocation in the auto_attach and the check for it in the detach. Signed-off-by:
-
