- 26 Jun, 2024 9 commits
-
-
Lucas Stach authored
The timeout when waiting for the PRE safe window is rather short, as normally we would only need to wait a few dozen usecs for the problematic scanline region to pass and we don't want to spin too long in case something goes wrong. This however mixes badly with preemption, as we can easily get scheduled away from the CPU for a longer time than our timeout, in which case we would hit a spurious timeout and wrongly skip the PRE update. Instead of disabling preemption across the wait loop, potentially impacting the overall system latency, use a wait loop with a fixed max number of iterations, so time spent away from the CPU is not accounted against the timeout budget. Signed-off-by:
Lucas Stach <l.stach@pengutronix.de> Reviewed-by:
Philipp Zabel <p.zabel@pengutronix.de> Link: https://lore.kernel.org/r/20240517104549.3648939-3-l.stach@pengutronix.deSigned-off-by:
-
Lucas Stach authored
imx-drm doesn't mandate a modeset when the framebuffer modifier changes, but currently the tile prefetch and resolve (TPR) configuration of the PRE is only set up on the initial modeset. As the TPR configuration is double buffered, same as all the other PRE states, we can support dynamic reconfiguration of the buffer layout from one frame to another. As switching between (super-)tiled and linear prefetch needs to touch the CTRL register make sure to do the reconfiguration inside the safe window. Signed-off-by:
-
Lucas Stach authored
Move the variables tracking the current dynamic state into a struct to separate it a bit better from the static device properties. Signed-off-by:
-
R Sundar authored
use the new cleanup magic to replace of_node_put() with __free(device_node) marking to auto release when they get out of scope. Suggested-by:
Julia Lawall <julia.lawall@inria.fr> Signed-off-by:
R Sundar <prosunofficial@gmail.com> Reviewed-by:
-
Dave Stevenson authored
Emma stepped back from VC4 maintenance a while ago, and all patches are now merged through drm-misc. Drop Emma's tree from MAINTAINERS. Signed-off-by:
Dave Stevenson <dave.stevenson@raspberrypi.com> Signed-off-by:
Maxime Ripard <mripard@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240621131926.3133484-2-dave.stevenson@raspberrypi.com
-
Dave Stevenson authored
Add myself as maintainer for VC4 alongside Maxime, and our internal review list as reviewer. Signed-off-by:
Daniel Stone <daniels@collabora.com> Signed-off-by:
-
Chen Ni authored
Add check for the return value of drm_cvt_mode() and return the error if it fails in order to avoid NULL pointer dereference. Fixes: 1b043677 ("drm/qxl: add qxl_add_mode helper function") Signed-off-by:
Chen Ni <nichen@iscas.ac.cn> Reviewed-by:
Heng Qi <hengqi@linux.alibaba.com> Signed-off-by:
-
Chen-Yu Tsai authored
With the recent switch from fbdev-generic to fbdev-dma, the driver now requires the DRM GEM DMA helpers. This dependency is missing, and will cause a link failure if fbdev emulation is enabled. Add the missing dependency. Fixes: 0992284b ("drm/mediatek: Use fbdev-dma") Signed-off-by:
Chen-Yu Tsai <wenst@chromium.org> Reviewed-by:
Thomas Zimmermann <tzimmermann@suse.de> Acked-by:
Chun-Kuang Hu <chunkuang.hu@mediatek.com> Signed-off-by:
-
Jerome Brunet authored
All Amlogic instances of the Synopsys HDMI controller need a power domain enabled. This is currently missing because the Amlogic HDMI driver directly pokes the power domain controller registers, which it should not do. Instead The HDMI controller should use the power controller. Fix the bindings accordingly. Signed-off-by:
Jerome Brunet <jbrunet@baylibre.com> Acked-by:
Conor Dooley <conor.dooley@microchip.com> Link: https://lore.kernel.org/r/20240625145017.1003346-2-jbrunet@baylibre.comSigned-off-by:
Neil Armstrong <neil.armstrong@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240625145017.1003346-2-jbrunet@baylibre.com
-
- 25 Jun, 2024 2 commits
-
-
Dmitry Baryshkov authored
If CONFIG_MODVERSIONS is enabled, then using the HDMI Connector framework can result in build failures. Rename the function to make it fit into the name requirements. ERROR: modpost: too long symbol "drm_atomic_helper_connector_hdmi_disable_audio_infoframe" [drivers/gpu/drm/msm/msm.ko] Reported-by:
Mark Brown <broonie@kernel.org> Reviewed-by:
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
-
Jeff Johnson authored
make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_device_test.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_pool_test.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_resource_test.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_tt_test.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_bo_test.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_mock_manager.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Signed-off-by:
Jeff Johnson <quic_jjohnson@quicinc.com> Acked-by:
Christian König <christian.koenig@amd.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240624-md-drivers-gpu-drm-ttm-tests-v2-1-76bb765e19c9@quicinc.comSigned-off-by:
-
- 24 Jun, 2024 20 commits
-
-
Geert Uytterhoeven authored
Re-use the existing support for boot-up logos to draw a monochrome graphical logo in the DRM panic handler. When no suitable graphical logo is available, the code falls back to the ASCII art penguin logo. Note that all graphical boot-up logos are freed during late kernel initialization, hence a copy must be made for later use. Signed-off-by:
Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by:
Jocelyn Falempe <jfalempe@redhat.com> Signed-off-by:
-
Geert Uytterhoeven authored
Rename variables related to the ASCII logo, to prepare for the advent of support for graphical logos. Signed-off-by:
-
Geert Uytterhoeven authored
Fix a misspelling of "formatter". Fixes: 54034beb ("drm/panic: Add a kmsg panic screen") Signed-off-by:
-
Geert Uytterhoeven authored
When CONFIG_FONTS ("Select compiled-in fonts") is not enabled, the user should not be asked about any fonts. However, when CONFIG_DRM_PANIC is enabled, the user is still asked about the Sparc console 12x22 and Terminus 16x32 fonts. Fix this by moving the "|| DRM_PANIC" to where it belongs. Split the dependency in two rules to improve readability. Fixes: b94605a3 ("lib/fonts: Allow to select fonts for drm_panic") Signed-off-by: -
Geert Uytterhoeven authored
Logos that are either just as wide or just as high as the display work fine. Fixes: bf9fb17c ("drm/panic: Add a drm panic handler") Signed-off-by:
-
Geert Uytterhoeven authored
No implementations of drm_plane_helper_funcs.get_scanout_buffer() fill in the optional drm_scanout_buffer.set_pixel() member. Hence the member may contain non-zero garbage, causing a crash when deferencing it during drm panic. Fix this by pre-initializing the drm_scanout_buffer object before calling drm_plane_helper_funcs.get_scanout_buffer(). Fixes: 24d07f11 ("drm/panic: Add a set_pixel() callback to drm_scanout_buffer") Signed-off-by:
-
Karolina Stolarek authored
Update the tests and helpers to use unsigned kernel types. Signed-off-by:
Karolina Stolarek <karolina.stolarek@intel.com> Suggested-by:
Thomas Hellström <thomas.hellstrom@linux.intel.com> Reviewed-by:
Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com> Link: https://patchwork.freedesktop.org/patch/msgid/b36d71de78990ac5be1538cc3f735f7e40618cfe.1718192625.git.karolina.stolarek@intel.com
-
Karolina Stolarek authored
The test files are GPL and MIT, so update the definitions accordingly. Signed-off-by:
-
Karolina Stolarek authored
List improvements for the test suite with some notes. Signed-off-by:
-
Karolina Stolarek authored
Add tests for functions that add and release pages to TTs. Test the swapin operation. Export ttm_tt_unpopulate, ttm_tt_swapin and ttm_tt_swapout symbols for testing purposes. Signed-off-by:
Somalapuram, Amaranath <asomalap@amd.com> Tested-by:
-
Karolina Stolarek authored
Add tests for ttm_bo_validate that focus on BO eviction and swapout. Update device funcs definition with eviction-related callbacks. Add alternative funcs where evict_flags() routes eviction to a domain that can't allocate resources (dubbed "busy manager" in the tests). Extract the common path of ttm_device init into a function. Signed-off-by:
-
Karolina Stolarek authored
Add test cases that check how the state of dma fences in BO's reservation object influence the ttm_bo_validation() flow. Do similar tests for resource manager's move fence. Signed-off-by:
-
Karolina Stolarek authored
Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by:
-
Karolina Stolarek authored
Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by:
Matthew Auld <matthew.auld@intel.com> Reviewed-by:
-
Karolina Stolarek authored
Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by:
-
Karolina Stolarek authored
In commit d393acce ("drm/tests: Switch to kunit devices"), DRM test helpers migrated away from using a dummy platform driver in favour of KUnit device. This means that DMA masks for the device are not set but are required by ttm_pool_alloc tests. Set the DMA mask for coherent mappings to unblock testing. Signed-off-by:
Nirmoy Das <nirmoy.das@intel.com> Signed-off-by:
-
Karolina Stolarek authored
DRM KUnit helpers are selected automatically when TTM tests are enabled, so there's no need to do it directly in the .kunitconfig file. Signed-off-by:
-
Karolina Stolarek authored
BOs in a bulk move have to share the same reservation object. That is not the case in the ttm_bo_unreserve_bulk subtest. Update ttm_bo_kunit_init() helper to accept dma_resv object so we can define buffer objects that share the same resv. Update calls to that helper accordingly. Fixes: 995279d2 ("drm/ttm/tests: Add tests for ttm_bo functions") Suggested-by:
-
Tejas Vipin authored
Use functions introduced in commit 966e397e ("drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28 ("drm/mipi-dsi: wrap more functions for streamline handling") for the raydium-rm692e5 panel. Additionally, the error handling in rm692e5_prepare() is changed to properly power the panel off in the case of a wider range of initialization commands failing than before. Reviewed-by:
Douglas Anderson <dianders@chromium.org> Signed-off-by:
Tejas Vipin <tejasvipin76@gmail.com> Link: https://lore.kernel.org/r/20240620181051.102173-1-tejasvipin76@gmail.comSigned-off-by:
-
Tejas Vipin authored
Use functions introduced in commit 966e397e ("drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28 ("drm/mipi-dsi: wrap more functions for streamline handling") for the asus-z00t-tm5p5-n35596 panel. Signed-off-by:
-
- 22 Jun, 2024 1 commit
-
-
Aradhya Bhatia authored
With new connector model, tc358767 will not create the connector, when DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and display-controller driver will rely on format negotiation to setup the encoder format. Add the missing bus format negotiation hooks in the drm_bridge_funcs to complete DRM_BRIDGE_ATTACH_NO_CONNECTOR support. Output format, for DPI/DSI to DP, is selected to MEDIA_BUS_FMT_RGB888_1X24 as default, keeping in mind what the older model used to support. Reported-by:
Jan Kiszka <jan.kiszka@siemens.com> Closes: https://lore.kernel.org/all/24282420-b4dd-45b3-bb1c-fc37fe4a8205@siemens.com/Signed-off-by:
Aradhya Bhatia <a-bhatia1@ti.com> Signed-off-by:
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231108-tc358767-v2-1-25c5f70a2159@ideasonboard.comSigned-off-by:
-
- 21 Jun, 2024 1 commit
-
-
Marek Vasut authored
Keep the list sorted numerically. No functional change. Signed-off-by:
Marek Vasut <marex@denx.de> Acked-by:
Rob Herring (Arm) <robh@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240531203031.277334-1-marex@denx.de
-
- 20 Jun, 2024 7 commits
-
-
Marek Vasut authored
The ddc-i2c-bus property should be placed in connector node, mark the HDMI TX side property as deprecated. Acked-by:
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by:
-
Marek Vasut authored
The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' property, move the property description into the DW HDMI common DT schema too, so this property can be used on all devices integrating the DW HDMI core. Signed-off-by:
-
Tejas Vipin authored
Use functions introduced in commit 966e397e ("drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28 ("drm/mipi-dsi: wrap more functions for streamline handling") for the sony tulip truly nt35521 panel. Reviewed-by:
-
Zhu Lingshan authored
ttm page fault handler ttm_bo_vm_fault_reserved() maps TTM_BO_VM_NUM_PREFAULT more pages beforehand due to the principle of locality. However, on some platform the page faults are more costly, this patch intends to increase the number of ttm pre-fault to relieve the number of page faults. When multiple levels of page table is supported, the new default value would be the PMD size, similar to huge page. Signed-off-by:
Zhu Lingshan <lingshan.zhu@amd.com> Reported-and-tested-by:
Li Jingxiang <jingxiang.li@ecarxgroup.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240604084934.225738-1-lingshan.zhu@amd.comReviewed-by:
-
Jeff Johnson authored
make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/tests/drm_hdmi_state_helper_test.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Fixes: eb66d34d ("drm/tests: Add output bpc tests") Signed-off-by:
-
Dave Stevenson authored
All the handling for the properties was present, but they were never attached to the connector to allow userspace to change them. Add them to the connector. Signed-off-by:
-
Dave Stevenson authored
The VEC supports not producing colour bursts for monochrome output. It also has an option for disabling the chroma input to remove chroma from the signal. Now that there is a DRM_MODE_TV_MODE_MONOCHROME defined, plumb this in. Signed-off-by:
-
