An error occurred fetching the project authors.
  1. 21 Sep, 2019 1 commit
  2. 19 Sep, 2019 1 commit
  3. 16 Sep, 2019 1 commit
  4. 10 Sep, 2019 1 commit
  5. 06 Sep, 2019 2 commits
  6. 29 Aug, 2019 1 commit
  7. 25 Aug, 2019 1 commit
  8. 16 Aug, 2019 1 commit
  9. 09 Aug, 2019 1 commit
  10. 06 Aug, 2019 2 commits
  11. 04 Aug, 2019 1 commit
  12. 31 Jul, 2019 2 commits
  13. 28 Jul, 2019 1 commit
  14. 26 Jul, 2019 1 commit
  15. 21 Jul, 2019 1 commit
  16. 14 Jul, 2019 1 commit
  17. 10 Jul, 2019 1 commit
  18. 03 Jul, 2019 1 commit
  19. 25 Jun, 2019 2 commits
  20. 22 Jun, 2019 2 commits
  21. 19 Jun, 2019 1 commit
  22. 17 Jun, 2019 1 commit
  23. 15 Jun, 2019 1 commit
  24. 11 Jun, 2019 1 commit
  25. 09 Jun, 2019 1 commit
  26. 04 Jun, 2019 2 commits
  27. 31 May, 2019 1 commit
  28. 25 May, 2019 1 commit
  29. 22 May, 2019 2 commits
    • Greg Kroah-Hartman's avatar
      Linux 4.19.45 · c3a07259
      Greg Kroah-Hartman authored
      c3a07259
    • Masahiro Yamada's avatar
      kbuild: turn auto.conf.cmd into a mandatory include file · 98bdd338
      Masahiro Yamada authored
      commit d2f8ae0e upstream.
      
      syncconfig is responsible for keeping auto.conf up-to-date, so if it
      fails for any reason, the build must be terminated immediately.
      
      However, since commit 9390dff6 ("kbuild: invoke syncconfig if
      include/config/auto.conf.cmd is missing"), Kbuild continues running
      even after syncconfig fails.
      
      You can confirm this by intentionally making syncconfig error out:
      
      #  diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
      #  index 08ba146..307b9de 100644
      #  --- a/scripts/kconfig/confdata.c
      #  +++ b/scripts/kconfig/confdata.c
      #  @@ -1023,6 +1023,9 @@ int conf_write_autoconf(int overwrite)
      #          FILE *out, *tristate, *out_h;
      #          int i;
      #
      #  +       if (overwrite)
      #  +               return 1;
      #  +
      #          if (!overwrite && is_present(autoconf_name))
      #                  return 0;
      
      Then, syncconfig fails, but Make would not stop:
      
        $ make -s mrproper allyesconfig defconfig
        $ make
        scripts/kconfig/conf  --syncconfig Kconfig
      
        *** Error during sync of the configuration.
      
        make[2]: *** [scripts/kconfig/Makefile;69: syncconfig] Error 1
        make[1]: *** [Makefile;557: syncconfig] Error 2
        make: *** [include/config/auto.conf.cmd] Deleting file 'include/config/tristate.conf'
        make: Failed to remake makefile 'include/config/auto.conf'.
          SYSTBL  arch/x86/include/generated/asm/syscalls_32.h
          SYSHDR  arch/x86/include/generated/asm/unistd_32_ia32.h
          SYSHDR  arch/x86/include/generated/asm/unistd_64_x32.h
          SYSTBL  arch/x86/include/generated/asm/syscalls_64.h
        [ continue running ... ]
      
      The reason is in the behavior of a pattern rule with multi-targets.
      
        %/auto.conf %/auto.conf.cmd %/tristate.conf: $(KCONFIG_CONFIG)
                $(Q)$(MAKE) -f $(srctree)/Makefile syncconfig
      
      GNU Make knows this rule is responsible for making all the three files
      simultaneously. As far as examined, auto.conf.cmd is the target in
      question when this rule is invoked. It is probably because auto.conf.cmd
      is included below the inclusion of auto.conf.
      
      The inclusion of auto.conf is mandatory, while that of auto.conf.cmd
      is optional. GNU Make does not care about the failure in the process
      of updating optional include files.
      
      I filed this issue (https://savannah.gnu.org/bugs/?56301) in case this
      behavior could be improved somehow in future releases of GNU Make.
      Anyway, it is quite easy to fix our Makefile.
      
      Given that auto.conf is already a mandatory include file, there is no
      reason to stick auto.conf.cmd optional. Make it mandatory as well.
      
      Cc: linux-stable <stable@vger.kernel.org> # 5.0+
      Fixes: 9390dff6 ("kbuild: invoke syncconfig if include/config/auto.conf.cmd is missing")
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      [commented out diff above to keep patch happy - gregkh]
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      98bdd338
  30. 16 May, 2019 1 commit
  31. 14 May, 2019 1 commit
  32. 10 May, 2019 1 commit
  33. 08 May, 2019 1 commit