An error occurred fetching the project authors.
- 21 Sep, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 19 Sep, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 16 Sep, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 10 Sep, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 06 Sep, 2019 2 commits
-
-
Greg Kroah-Hartman authored
-
Greg Kroah-Hartman authored
-
- 29 Aug, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 25 Aug, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 16 Aug, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 09 Aug, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 06 Aug, 2019 2 commits
-
-
Greg Kroah-Hartman authored
-
Masahiro Yamada authored
commit 5241ab4c upstream. CLANG_FLAGS is initialized by the following line: CLANG_FLAGS := --target=$(notdir $(CROSS_COMPILE:%-=%)) ..., which is run only when CROSS_COMPILE is set. Some build targets (bindeb-pkg etc.) recurse to the top Makefile. When you build the kernel with Clang but without CROSS_COMPILE, the same compiler flags such as -no-integrated-as are accumulated into CLANG_FLAGS. If you run 'make CC=clang' and then 'make CC=clang bindeb-pkg', Kbuild will recompile everything needlessly due to the build command change. Fix this by correctly initializing CLANG_FLAGS. Fixes: 238bcbc4 ("kbuild: consolidate Clang compiler flags") Cc: <stable@vger.kernel.org> # v5.0+ Signed-off-by:
Masahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by:
Nathan Chancellor <natechancellor@gmail.com> Acked-by:
Nick Desaulniers <ndesaulniers@google.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 04 Aug, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 31 Jul, 2019 2 commits
-
-
Greg Kroah-Hartman authored
-
Nathan Chancellor authored
[ Upstream commit 589834b3 ] In commit ebcc5928 ("arm64: Silence gcc warnings about arch ABI drift"), the arm64 Makefile added -Wno-psabi to KBUILD_CFLAGS, which is a GCC only option so clang rightfully complains: warning: unknown warning option '-Wno-psabi' [-Wunknown-warning-option] https://clang.llvm.org/docs/DiagnosticsReference.html#wunknown-warning-option However, by default, this is merely a warning so the build happily goes on with a slew of these warnings in the process. Commit c3f0d0bc ("kbuild, LLVMLinux: Add -Werror to cc-option to support clang") worked around this behavior in cc-option by adding -Werror so that unknown flags cause an error. However, this all happens silently and when an unknown flag is added to the build unconditionally like -Wno-psabi, cc-option will always fail because there is always an unknown flag in the list of flags. This manifested as link time failures in the arm64 libstub because -fno-stack-protector didn't get added to KBUILD_CFLAGS. To avoid these weird cryptic failures in the future, make clang behave like gcc and immediately error when it encounters an unknown flag by adding -Werror=unknown-warning-option to CLANG_FLAGS. This can be added unconditionally for clang because it is supported by at least 3.0.0, according to godbolt [1] and 4.0.0, according to its documentation [2], which is far earlier than we typically support. [1]: https://godbolt.org/z/7F7rm3 [2]: https://releases.llvm.org/4.0.0/tools/clang/docs/DiagnosticsReference.html#wunknown-warning-option Link: https://github.com/ClangBuiltLinux/linux/issues/511 Link: https://github.com/ClangBuiltLinux/linux/issues/517Suggested-by:
Peter Smith <peter.smith@linaro.org> Signed-off-by:
Nathan Chancellor <natechancellor@gmail.com> Tested-by:
Nick Desaulniers <ndesaulniers@google.com> Signed-off-by:
Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by:
Sasha Levin <sashal@kernel.org>
-
- 28 Jul, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 26 Jul, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 21 Jul, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 14 Jul, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 10 Jul, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 03 Jul, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 25 Jun, 2019 2 commits
-
-
Greg Kroah-Hartman authored
-
Linus Torvalds authored
commit 6f303d60 upstream. We already did this for clang, but now gcc has that warning too. Yes, yes, the address may be unaligned. And that's kind of the point. Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 22 Jun, 2019 2 commits
-
-
Greg Kroah-Hartman authored
-
Greg Kroah-Hartman authored
-
- 19 Jun, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 17 Jun, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 15 Jun, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 11 Jun, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 09 Jun, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 04 Jun, 2019 2 commits
-
-
Greg Kroah-Hartman authored
-
Masahiro Yamada authored
commit e9666d10 upstream. Currently, CONFIG_JUMP_LABEL just means "I _want_ to use jump label". The jump label is controlled by HAVE_JUMP_LABEL, which is defined like this: #if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_JUMP_LABEL) # define HAVE_JUMP_LABEL #endif We can improve this by testing 'asm goto' support in Kconfig, then make JUMP_LABEL depend on CC_HAS_ASM_GOTO. Ugly #ifdef HAVE_JUMP_LABEL will go away, and CONFIG_JUMP_LABEL will match to the real kernel capability. Signed-off-by:
Masahiro Yamada <yamada.masahiro@socionext.com> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) Tested-by:
Sedat Dilek <sedat.dilek@gmail.com> [nc: Fix trivial conflicts in 4.19 arch/xtensa/kernel/jump_label.c doesn't exist yet Ensured CC_HAVE_ASM_GOTO and HAVE_JUMP_LABEL were sufficiently eliminated] Signed-off-by:
Nathan Chancellor <natechancellor@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 31 May, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 25 May, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 22 May, 2019 2 commits
-
-
Greg Kroah-Hartman authored
-
Masahiro Yamada authored
commit d2f8ae0e upstream. syncconfig is responsible for keeping auto.conf up-to-date, so if it fails for any reason, the build must be terminated immediately. However, since commit 9390dff6 ("kbuild: invoke syncconfig if include/config/auto.conf.cmd is missing"), Kbuild continues running even after syncconfig fails. You can confirm this by intentionally making syncconfig error out: # diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c # index 08ba146..307b9de 100644 # --- a/scripts/kconfig/confdata.c # +++ b/scripts/kconfig/confdata.c # @@ -1023,6 +1023,9 @@ int conf_write_autoconf(int overwrite) # FILE *out, *tristate, *out_h; # int i; # # + if (overwrite) # + return 1; # + # if (!overwrite && is_present(autoconf_name)) # return 0; Then, syncconfig fails, but Make would not stop: $ make -s mrproper allyesconfig defconfig $ make scripts/kconfig/conf --syncconfig Kconfig *** Error during sync of the configuration. make[2]: *** [scripts/kconfig/Makefile;69: syncconfig] Error 1 make[1]: *** [Makefile;557: syncconfig] Error 2 make: *** [include/config/auto.conf.cmd] Deleting file 'include/config/tristate.conf' make: Failed to remake makefile 'include/config/auto.conf'. SYSTBL arch/x86/include/generated/asm/syscalls_32.h SYSHDR arch/x86/include/generated/asm/unistd_32_ia32.h SYSHDR arch/x86/include/generated/asm/unistd_64_x32.h SYSTBL arch/x86/include/generated/asm/syscalls_64.h [ continue running ... ] The reason is in the behavior of a pattern rule with multi-targets. %/auto.conf %/auto.conf.cmd %/tristate.conf: $(KCONFIG_CONFIG) $(Q)$(MAKE) -f $(srctree)/Makefile syncconfig GNU Make knows this rule is responsible for making all the three files simultaneously. As far as examined, auto.conf.cmd is the target in question when this rule is invoked. It is probably because auto.conf.cmd is included below the inclusion of auto.conf. The inclusion of auto.conf is mandatory, while that of auto.conf.cmd is optional. GNU Make does not care about the failure in the process of updating optional include files. I filed this issue (https://savannah.gnu.org/bugs/?56301) in case this behavior could be improved somehow in future releases of GNU Make. Anyway, it is quite easy to fix our Makefile. Given that auto.conf is already a mandatory include file, there is no reason to stick auto.conf.cmd optional. Make it mandatory as well. Cc: linux-stable <stable@vger.kernel.org> # 5.0+ Fixes: 9390dff6 ("kbuild: invoke syncconfig if include/config/auto.conf.cmd is missing") Signed-off-by:
Masahiro Yamada <yamada.masahiro@socionext.com> [commented out diff above to keep patch happy - gregkh] Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 16 May, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 14 May, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 10 May, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-
- 08 May, 2019 1 commit
-
-
Greg Kroah-Hartman authored
-