1. 24 Nov, 2020 8 commits
  2. 23 Nov, 2020 6 commits
  3. 22 Nov, 2020 1 commit
  4. 21 Nov, 2020 25 commits
    • Jakub Kicinski's avatar
      Merge tag 'linux-can-next-for-5.11-20201120' of... · 5e087239
      Jakub Kicinski authored
      Merge tag 'linux-can-next-for-5.11-20201120' of git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next
      
      Marc Kleine-Budde says:
      
      ====================
      pull-request: can-next 2020-11-20
      
      The first patch is by Yegor Yefremov and he improves the j1939 documentaton by
      adding tables for the CAN identifier and its fields.
      
      Then there are 8 patches by Oliver Hartkopp targeting the CAN driver
      infrastructure and drivers. These add support for optional DLC element to the
      Classical CAN frame structure. See patch ea780056 ("can: add optional DLC
      element to Classical CAN frame structure") for details. Oliver's last patch
      adds len8_dlc support to several drivers. Stefan Mätje provides a patch to add
      len8_dlc support to the esd_usb2 driver.
      
      The next patch is by Oliver Hartkopp, too and adds support for modification of
      Classical CAN DLCs to CAN GW sockets.
      
      The next 3 patches target the nxp,flexcan DT bindings. One patch by my adds the
      missing uint32 reference to the clock-frequency property. Joakim Zhang's
      patches fix the fsl,clk-source property and add the IMX_SC_R_CAN() macro to the
      imx firmware header file, which will be used in the flexcan driver later.
      
      Another patch by Joakim Zhang prepares the flexcan driver for SCU based
      stop-mode, by giving the existing, GPR based stop-mode, a _GPR postfix.
      
      The next 5 patches are by me, target the flexcan driver, and clean up the
      .ndo_open and .ndo_stop callbacks. These patches try to fix a sporadically
      hanging flexcan_close() during simultanious ifdown, sending of CAN messages and
      probably open CAN bus. I was never able to reproduce, but these seem to fix the
      problem at the reporting user. As these changes are rather big, I'd like to
      mainline them via net-next/master.
      
      The next patches are by Jimmy Assarsson and Christer Beskow, they add support
      for new USB devices to the existing kvaser_usb driver.
      
      The last patch is by Kaixu Xia and simplifies the return in the
      mcp251xfd_chip_softreset() function in the mcp251xfd driver.
      
      * tag 'linux-can-next-for-5.11-20201120' of git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next: (25 commits)
        can: mcp251xfd: remove useless code in mcp251xfd_chip_softreset
        can: kvaser_usb: Add new Kvaser hydra devices
        can: kvaser_usb: kvaser_usb_hydra: Add support for new device variant
        can: kvaser_usb: Add new Kvaser Leaf v2 devices
        can: kvaser_usb: Add USB_{LEAF,HYDRA}_PRODUCT_ID_END defines
        can: flexcan: flexcan_close(): change order if commands to properly shut down the controller
        can: flexcan: flexcan_open(): completely initialize controller before requesting IRQ
        can: flexcan: flexcan_rx_offload_setup(): factor out mailbox and rx-offload setup into separate function
        can: flexcan: move enabling/disabling of interrupts from flexcan_chip_{start,stop}() to callers
        can: flexcan: factor out enabling and disabling of interrupts into separate function
        can: flexcan: rename macro FLEXCAN_QUIRK_SETUP_STOP_MODE -> FLEXCAN_QUIRK_SETUP_STOP_MODE_GPR
        dt-bindings: firmware: add IMX_SC_R_CAN(x) macro for CAN
        dt-bindings: can: fsl,flexcan: fix fsl,clk-source property
        dt-bindings: can: fsl,flexcan: add uint32 reference to clock-frequency property
        can: gw: support modification of Classical CAN DLCs
        can: drivers: add len8_dlc support for esd_usb2 CAN adapter
        can: drivers: add len8_dlc support for various CAN adapters
        can: drivers: introduce helpers to access Classical CAN DLC values
        can: update documentation for DLC usage in Classical CAN
        can: rename CAN FD related can_len2dlc and can_dlc2len helpers
        ...
      ====================
      
      Link: https://lore.kernel.org/r/20201120133318.3428231-1-mkl@pengutronix.deSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      5e087239
    • Heiner Kallweit's avatar
      net: bridge: switch to net core statistics counters handling · 7609ecb2
      Heiner Kallweit authored
      Use netdev->tstats instead of a member of net_bridge for storing
      a pointer to the per-cpu counters. This allows us to use core
      functionality for statistics handling.
      Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
      Link: https://lore.kernel.org/r/9bad2be2-fd84-7c6e-912f-cee433787018@gmail.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      7609ecb2
    • Jakub Kicinski's avatar
      Merge branch 'net-hns3-misc-updates-for-next' · 9c89cc9b
      Jakub Kicinski authored
      Huazhong Tan says:
      
      ====================
      net: hns3: misc updates for -next
      
      This series includes some misc updates for the HNS3 ethernet driver.
      
       #1 adds support for 1280 queues
       #2 adds mapping for BAR45 which is needed by RoCE client.
       #3 extend the interrupt resources.
       #4&#5 add support to query firmware's calculated shaping parameters.
      ====================
      
      Link: https://lore.kernel.org/r/1605863783-36995-1-git-send-email-tanhuazhong@huawei.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      9c89cc9b
    • Yonglong Liu's avatar
      net: hns3: adds debugfs to dump more info of shaping parameters · c331ecf1
      Yonglong Liu authored
      Adds debugfs to dump new shaping parameters: rate and flag.
      Signed-off-by: default avatarYonglong Liu <liuyonglong@huawei.com>
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      c331ecf1
    • Yonglong Liu's avatar
      net: hns3: add support to utilize the firmware calculated shaping parameters · e364ad30
      Yonglong Liu authored
      Since the calculation of the driver is fixed, if the number of
      queue or clock changed, the calculated result may be inaccurate.
      
      So for compatible and maintainable, add a new flag to tell the
      firmware to calculate the shaping parameters with the specified
      rate.
      Signed-off-by: default avatarYonglong Liu <liuyonglong@huawei.com>
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      e364ad30
    • Yufeng Mo's avatar
      net: hns3: add support for pf querying new interrupt resources · 3a6863e4
      Yufeng Mo authored
      For HNAE3_DEVICE_VERSION_V3, a maximum of 1281 interrupt
      resources are supported. To utilize these new resources,
      extend the corresponding field or variable to 16bit type,
      and remove the restriction of NIC client that only use a
      maximum of 65 interrupt vectors. In addition, the I/O address
      of the extended interrupt resources are different, so an extra
      handler is needed.
      
      Currently, the total number of interrupts is the sum of RoCE's
      number and RoCE's offset (RoCE is in front of NIC), since
      the number of both NIC and RoCE are same. For readability,
      rewrite the corresponding field of the command, rename the
      RoCE's offset field as the number of NIC interrupts, then
      the total number of interrupts is sum of the number of RoCE
      and NIC, and replace vport->back with hdev in
      hclge_init_roce_base_info() for simplifying the code.
      Signed-off-by: default avatarYufeng Mo <moyufeng@huawei.com>
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      3a6863e4
    • Huazhong Tan's avatar
      net: hns3: add support for mapping device memory · 30ae7f8a
      Huazhong Tan authored
      For device who has device memory accessed through the PCI BAR4,
      IO descriptor push of NIC and direct WQE(Work Queue Element) of
      RoCE will use this device memory, so add support for mapping
      this device memory, and add this info to the RoCE client whose
      new feature needs.
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      30ae7f8a
    • Yonglong Liu's avatar
      net: hns3: add support for 1280 queues · 9a5ef4aa
      Yonglong Liu authored
      For DEVICE_VERSION_V1/2, there are total 1024 queues and
      queue sets. For DEVICE_VERSION_V3, it increases to 1280,
      and can be assigned to one pf, so remove the limitation
      of 1024.
      
      To keep compatible with DEVICE_VERSION_V1/2 and old driver
      version, the queue number is split into two part:
      tqp_num(range 0~1023) and ext_tqp_num(range 1024~1279).
      Signed-off-by: default avatarYonglong Liu <liuyonglong@huawei.com>
      Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      9a5ef4aa
    • Jakub Kicinski's avatar
      Merge branch 'ibmvnic-performance-improvements-and-other-updates' · 16de5970
      Jakub Kicinski authored
      Thomas Falcon says:
      
      ====================
      ibmvnic: Performance improvements and other updates
      
      The first three patches utilize a hypervisor call allowing multiple
      TX and RX buffer replenishment descriptors to be sent in one operation,
      which significantly reduces hypervisor call overhead. The xmit_more
      and Byte Queue Limit API's are leveraged to provide this support
      for TX descriptors.
      
      The subsequent two patches remove superfluous code and members in
      TX completion handling function and TX buffer structure, respectively,
      and remove unused routines.
      
      Finally, four patches which ensure that device queue memory is
      cache-line aligned, resolving slowdowns observed in PCI traces,
      as well as optimize the driver's NAPI polling function and
      to RX buffer replenishment are provided by Dwip Banerjee.
      
      This series provides significant performance improvements, allowing
      the driver to fully utilize 100Gb NIC's.
      ====================
      
      Link: https://lore.kernel.org/r/1605748345-32062-1-git-send-email-tlfalcon@linux.ibm.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      16de5970
    • Dwip N. Banerjee's avatar
      ibmvnic: Do not replenish RX buffers after every polling loop · 41ed0a00
      Dwip N. Banerjee authored
      Reduce the amount of time spent replenishing RX buffers by only doing
      so once available buffers has fallen under a certain threshold, in this
      case half of the total number of buffers, or if the polling loop exits
      before the packets processed is less than its budget. Non-exhaustion of
      NAPI budget implies lower incoming packet pressure, allowing the leeway
      to refill the buffers in preparation for any impending burst.
      Signed-off-by: default avatarDwip N. Banerjee <dnbanerg@us.ibm.com>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      41ed0a00
    • Dwip N. Banerjee's avatar
      ibmvnic: Use netdev_alloc_skb instead of alloc_skb to replenish RX buffers · e552aa31
      Dwip N. Banerjee authored
      Take advantage of the additional optimizations in netdev_alloc_skb when
      allocating socket buffers to be used for packet reception.
      Signed-off-by: default avatarDwip N. Banerjee <dnbanerg@us.ibm.com>
      Acked-by: default avatarLijun Pan <ljp@linux.ibm.com>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      e552aa31
    • Dwip N. Banerjee's avatar
      ibmvnic: Correctly re-enable interrupts in NAPI polling routine · ec20f36b
      Dwip N. Banerjee authored
      If the current NAPI polling loop exits without completing it's
      budget, only re-enable interrupts if there are no entries remaining
      in the queue and napi_complete_done is successful. If there are entries
      remaining on the queue that were missed, restart the polling loop.
      Signed-off-by: default avatarDwip N. Banerjee <dnbanerg@us.ibm.com>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      ec20f36b
    • Dwip N. Banerjee's avatar
      ibmvnic: Ensure that device queue memory is cache-line aligned · 9a87c3fc
      Dwip N. Banerjee authored
      PCI bus slowdowns were observed on IBM VNIC devices as a result
      of partial cache line writes and non-cache aligned full cache line writes.
      Ensure that packet data buffers are cache-line aligned to avoid these
      slowdowns.
      Signed-off-by: default avatarDwip N. Banerjee <dnbanerg@us.ibm.com>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      9a87c3fc
    • Thomas Falcon's avatar
      ibmvnic: Remove send_subcrq function · 8ed589f3
      Thomas Falcon authored
      It is not longer used, so remove it.
      Signed-off-by: default avatarThomas Falcon <tlfalcon@linux.ibm.com>
      Acked-by: default avatarLijun Pan <ljp@linux.ibm.com>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      8ed589f3
    • Thomas Falcon's avatar
      ibmvnic: Clean up TX code and TX buffer data structure · c62aa373
      Thomas Falcon authored
      Remove unused and superfluous code and members in
      existing TX implementation and data structures.
      Signed-off-by: default avatarThomas Falcon <tlfalcon@linux.ibm.com>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      c62aa373
    • Thomas Falcon's avatar
      ibmvnic: Introduce xmit_more support using batched subCRQ hcalls · 0d973388
      Thomas Falcon authored
      Include support for the xmit_more feature utilizing the
      H_SEND_SUB_CRQ_INDIRECT hypervisor call which allows the sending
      of multiple subordinate Command Response Queue descriptors in one
      hypervisor call via a DMA-mapped buffer. This update reduces hypervisor
      calls and thus hypervisor call overhead per TX descriptor.
      Signed-off-by: default avatarThomas Falcon <tlfalcon@linux.ibm.com>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      0d973388
    • Thomas Falcon's avatar
      ibmvnic: Introduce batched RX buffer descriptor transmission · 4f0b6812
      Thomas Falcon authored
      Utilize the H_SEND_SUB_CRQ_INDIRECT hypervisor call to send
      multiple RX buffer descriptors to the device in one hypervisor
      call operation. This change will reduce the number of hypervisor
      calls and thus hypervisor call overhead needed to transmit
      RX buffer descriptors to the device.
      Signed-off-by: default avatarThomas Falcon <tlfalcon@linux.ibm.com>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      4f0b6812
    • Thomas Falcon's avatar
      ibmvnic: Introduce indirect subordinate Command Response Queue buffer · f019fb63
      Thomas Falcon authored
      This patch introduces the infrastructure to send batched subordinate
      Command Response Queue descriptors, which are used by the ibmvnic
      driver to send TX frame and RX buffer descriptors.
      Signed-off-by: default avatarThomas Falcon <tlfalcon@linux.ibm.com>
      Acked-by: default avatarLijun Pan <ljp@linux.ibm.com>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      f019fb63
    • Jakub Kicinski's avatar
      Merge branch 'net-ipa-add-a-driver-shutdown-callback' · c9003783
      Jakub Kicinski authored
      Alex Elder says:
      
      ====================
      net: ipa: add a driver shutdown callback
      
      The final patch in this series adds a driver shutdown callback for
      the IPA driver.  The patches leading up to that address some issues
      encountered while ensuring that callback worked as expected:
        - The first just reports a little more information when channels
          or event rings are in unexpected states
        - The second patch recognizes a condition where an as-yet-unused
          channel does not require a reset during teardown
        - The third patch explicitly ignores a certain error condition,
          because it can't be avoided, and is harmless if it occurs
        - The fourth properly handles requests to retry a channel HALT
          request
        - The fifth makes a second attempt to stop modem activity during
          shutdown if it's busy
      
      The shutdown callback is implemented by calling the existing remove
      callback function (reporting if that returns an error).
      ====================
      
      Link: https://lore.kernel.org/r/20201119224929.23819-1-elder@linaro.orgSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      c9003783
    • Alex Elder's avatar
      net: ipa: add driver shutdown callback · ae1d72f9
      Alex Elder authored
      A system shutdown can happen at essentially any time, and it's
      possible that the IPA driver is busy when a shutdown is underway.
      IPA hardware accesses IMEM and SMEM memory regions using an IOMMU,
      and at some point during shutdown, needed I/O mappings could become
      invalid.  This could be disastrous for any "in flight" IPA activity.
      
      Avoid this by defining a new driver shutdown callback that stops all
      IPA activity and cleanly shuts down the driver.  It merely calls the
      driver's existing remove callback, reporting the error if it returns
      one.
      Signed-off-by: default avatarAlex Elder <elder@linaro.org>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      ae1d72f9
    • Alex Elder's avatar
      net: ipa: retry modem stop if busy · 7c80e838
      Alex Elder authored
      The IPA driver remove callback, ipa_remove(), calls ipa_modem_stop()
      if the setup stage of initialization is complete.  If a concurrent
      call to ipa_modem_start() or ipa_modem_stop() has begin but not
      completed, ipa_modem_stop() can return an error (-EBUSY).
      
      The next patch adds a driver shutdown callback, which will simply
      call ipa_remove().  We really want our shutdown callback to clean
      things up.  So add a single retry to the ipa_modem_stop() call in
      ipa_remove() after a short (millisecond) delay.  This offers no
      guarantee the shutdown will complete successfully, but we'll at
      least try a little harder before giving up.
      Signed-off-by: default avatarAlex Elder <elder@linaro.org>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      7c80e838
    • Alex Elder's avatar
      net: ipa: support retries on generic GSI commands · 11361456
      Alex Elder authored
      When stopping an AP RX channel, there can be a transient period
      while the channel enters STOP_IN_PROC state before reaching the
      final STOPPED state.  In that case we make another attempt to stop
      the channel.
      
      Similarly, when stopping a modem channel (using a GSI generic
      command issued from the AP), it's possible that multiple attempts
      will be required before the channel reaches STOPPED state.
      
      Add a field to the GSI structure to record an errno representing the
      result code provided when a generic command completes.  If the
      result learned in gsi_isr_gp_int1() is RETRY, record -EAGAIN in the
      result code, otherwise record 0 for success, or -EIO for any other
      result.
      
      If we time out nf gsi_generic_command() waiting for the command to
      complete, return -ETIMEDOUT (as before).  Otherwise return the
      result stashed by gsi_isr_gp_int1().
      
      Add a loop in gsi_modem_channel_halt() to reissue the HALT command
      if the result code indicates -EAGAIN.  Limit this to 10 retries
      (after the initial attempt).
      Signed-off-by: default avatarAlex Elder <elder@linaro.org>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      11361456
    • Alex Elder's avatar
      net: ipa: ignore CHANNEL_NOT_RUNNING errors · f849afcc
      Alex Elder authored
      IPA v4.2 has a hardware quirk that requires the AP to allocate GSI
      channels for the modem to use.  It is recommended that these modem
      channels get stopped (with a HALT generic command) by the AP when
      its IPA driver gets removed.
      
      The AP has no way of knowing the current state of a modem channel.
      So when the IPA driver issues a HALT command it's possible the
      channel is not running, and in that case we get an error indication.
      This error simply means we didn't need to stop the channel, so we
      can ignore it.
      
      This patch adds an explanation for this situation, and arranges for
      this condition to *not* report an error message.
      Signed-off-by: default avatarAlex Elder <elder@linaro.org>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      f849afcc
    • Alex Elder's avatar
      net: ipa: don't reset an ALLOCATED channel · 5d28913d
      Alex Elder authored
      If the rmnet_ipa0 network device has not been opened at the time
      we remove or shut down the IPA driver, its underlying TX and RX
      GSI channels will not have been started, and they will still be
      in ALLOCATED state.
      
      The RESET command on a channel is meant to return a channel to
      ALLOCATED state after it's been stopped.  But if it was never
      started, its state will still be ALLOCATED, the RESET command
      is not required.
      
      Quietly skip doing the reset without printing an error message if a
      channel is already in ALLOCATED state when we request it be reset.
      Signed-off-by: default avatarAlex Elder <elder@linaro.org>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      5d28913d
    • Alex Elder's avatar
      net: ipa: print channel/event ring number on error · f8d3bdd5
      Alex Elder authored
      When a GSI command is used to change the state of a channel or event
      ring we check the state before and after the command to ensure it is
      as expected.  If not, we print an error message, but it does not
      include the channel or event ring id, and it easily can.  Add the
      channel or event ring id to these error messages.
      Signed-off-by: default avatarAlex Elder <elder@linaro.org>
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      f8d3bdd5