- 08 Dec, 2011 40 commits
-
-
Mark Einon authored
In commit 834d0ee3 (uintxy_t removal) not all changes were trival text replacements, some converted u64 -> dma_addr_t. In some configurations dma_addr_t is a u32, meaning that some bit operations cause build warnings. From Randy Dunlap: ---------------- on i386 (X86_32) builds: drivers/staging/et131x/et131x.c:2483:8: warning: right shift count >= width of type drivers/staging/et131x/et131x.c:2531:8: warning: right shift count >= width of type ---------------- Removed these by reverting dma_addr_t back to u64 types, as well as reverting some other non-trivial changes from the aforementioned commit. Reported-by:
Randy Dunlap <rdunlap@xenotime.net> Signed-off-by:
Mark Einon <mark.einon@gmail.com> Acked-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Valentin Rothberg authored
As Dan mentioned, dcon_write() will only write u16 values. The appropriate parts have been changed. As a result of module_param() not accepting u16 as a valid data type, ushort is used. Signed-off-by:
Valentin Rothberg <valentinrothberg@googlemail.com> Signed-off-by:
-
Valentin Rothberg authored
As noted by the checkpatch script, strict_strtoul is obsolete. Unsigned longs are used, so it seems good to take kstrtoul. Signed-off-by:
-
Oren Weil authored
The following changes were made in the document: 1. Update URLs to working links 2. remove old information about module parameters 3. Add IOCTL information. 4. cleanups and fix spelling 5. driver changed from character device to misc character device Signed-off-by:
Oren Weil <oren.jer.weil@intel.com> Signed-off-by:
Tomas Winkler <tomas.winkler@intel.com> Signed-off-by:
-
Natalia Ovsyanikov authored
The irq handler processes queued mei clients connect requests, which were not transferred to the device in ioctl context due to unavailability of the write buffer. The handler may transfer the connection request only if there is no other ongoing requests for the same mei id. This condition was implemented inversely which depending on the write buffer availability lead to seemingly random failures during connection attempts. Cc: Oren Weil <oren.jer.weil@intel.com> Signed-off-by:
Natalia Ovsyanikov <natalia.ovsyanikov@intel.com> Signed-off-by:
-
Tomas Winkler authored
list_for_each_entry_safe(pos, next, &head, list) if (pos) { .... } This check isn't needed. The list cursor in a list_for_each() loop is always a valid pointer Cc: Oren Weil <oren.jer.weil@intel.com> Reported-by:Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Xi Wang authored
Change ->read_status() by separating the error handling and the status bits. This also fixes a signedness bug in dcon_interrupt() that would break the error handling. Signed-off-by:
Xi Wang <xi.wang@gmail.com> Acked-by:
Andres Salomon <dilinger@queued.net> Cc: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Jerome Marchand authored
The allocation of zram->compress_buffer is misssing a GFP_* specifier. This is equivalent to GFP_NOWAIT but it is more likely a omission. Since the allocation just above it uses GFP_KERNEL, there is no reason to use GFP_NOWAIT here. Therefore, add GFP_KERNEL. Signed-off-by:
Jerome Marchand <jmarchan@redhat.com> Signed-off-by:
-
Sergey Datsevich authored
As reported by checkpatch.pl strict_strtoX is obsolet and should be replaced by kstrtoX. Signed-off-by:
Sergey Datsevich <srgdts@gmail.com> Signed-off-by:
Bjoern Meier <bjoernmeier@hotmail.com> Signed-off-by:
-
K. Y. Srinivasan authored
Set the length field of the scatter gather elements correctly when we create the bounce buffer. When we use the bounce buffer for a "write" operation, the act of copying to the bounce buffer, correctly deals with this issue. However, on the "read" side, the current code was not correctly setting the buffer length. Fix this bug. Note that when we copy from the bounce buffer (for the read case), the amount we copy is controlled by the original scatter gather list given to the driver. Signed-off-by:
K. Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Reported-by:
Dadok Milan <dadok@kvados.cz> Signed-off-by:
-
Johannes Tenschert authored
Signed-off-by:
Johannes Tenschert <Johannes.Tenschert@informatik.stud.uni-erlangen.de> Reviewed-by:
-
Johannes Tenschert authored
Signed-off-by:
-
Johannes Tenschert authored
Signed-off-by:
-
Johannes Tenschert authored
Signed-off-by:
-
Johannes Tenschert authored
Signed-off-by:
-
Kevin McKinney authored
In this clean up patch, I altered functions: copy_to/ from_user() to return -EFAULT when an error occurs. I also replaced break statements when an error occurs from copy_to/from_user() with direct returns of -EFAULT. Signed-off-by:
Kevin McKinney <klmckinney1@gmail.com> Signed-off-by:
-
Kevin McKinney authored
Staging: bcm: Alter code to move error handling closer to the calls; and remove white space, IOCTL_BCM_NVM_WRITE. This is a clean up patch for IOCTL_BCM_NVM_WRITE that replaces the assignment of the Status variable with direct returns of the error code, replaces the break statements with direct returns, and removes a white space. Signed-off-by:
-
Kevin McKinney authored
This patch fixes a memory error in ioctl, IOCTL_BCM_NVM_WRITE. While copying data to user space, if an error occurs, pReadData is freed. Then, at the end of the ioctl, pReadData was being freed again. Signed-off-by:
-
Markus Grabner authored
This patch refactors the device information code and adds preliminary support for the POD HD 500 device. Signed-off-by:
Markus Grabner <grabner@icg.tugraz.at> Signed-off-by:
-
Markus Grabner authored
This patch removes experimental code which is no longer used. Signed-off-by:
-
Andor Daam authored
The obsolete function strict_strtoul should be replaced by the kstrto* functions. In this context kstrtou16 should be use, as midi_mask_receive is only used as unsigned short. All corresponding datatypes were adapted accordingly. Signed-off-by:
Andor Daam <andor.daam@googlemail.com> Signed-off-by:
-
Andor Daam authored
The function strict_strtoul is obsolete and should be replaced by the new kstrto* functions. The variable midi_mask_transmit is only used as unsigned short and the datatypes of all affected variables were adjusted accordingly. Signed-off-by:
-
Dan Carpenter authored
We should release the udev->sem lock before returning. Signed-off-by:
-
Dan Carpenter authored
If we had an invalid trignum (anything other than zero is invalid) then we returned without unlocking. I've modified this function to just have one return point. Signed-off-by:
-
Aaro Koskinen authored
Enable forcecrt2type as a module parameter. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
-
Aaro Koskinen authored
Make "forcecrt2type" to apply also for XG21. The patch enables user to switch LVDS LCD ON/OFF without the need to update the video BIOS. Signed-off-by:
-
Aaro Koskinen authored
Delete a redundant option. Signed-off-by:
-
Aaro Koskinen authored
Delete XGI21_LCDCapList. This data is display specific and does not belong to the driver. It should be provided by the video BIOS. Signed-off-by:
-
Aaro Koskinen authored
Move the LVDS data into a device-specific data, and eliminate the global variable usage. Signed-off-by:
-
Aaro Koskinen authored
XG27 has the second display output already hardcoded to disabled. Just in case, ensure that it has the LVDS code paths disabled. This will simplify the future cleanups. Signed-off-by:
-
Aaro Koskinen authored
Delete XGIfb_GetXG21LVDSData() and code which duplicates xgifb_read_vbios(). Signed-off-by:
-
Aaro Koskinen authored
Rename the function to xgifb_read_vbios(). Signed-off-by:
-
Aaro Koskinen authored
Only a single LVDS table entry is needed by the driver. Signed-off-by:
-
Aaro Koskinen authored
Check the BIOS size to avoid out of bounds array access. Disable LVDS in case errors are detected. Signed-off-by:
-
Aaro Koskinen authored
Use u8 for video BIOS data. Signed-off-by:
-
Aaro Koskinen authored
Delete a redundant struct member. Signed-off-by:
-
Aaro Koskinen authored
Delete a redundant struct member. Signed-off-by:
-
Aaro Koskinen authored
We need the video BIOS only on XG21 and only during the init, so let's do everything at the same place. Signed-off-by:
-
Aaro Koskinen authored
Remove video BIOS access from the routine, use the flag instead which is initialized according to the BIOS data. Signed-off-by:
-
Aaro Koskinen authored
Use a pointer variable to make some lines shorter and more readable. Signed-off-by:
-
