1. 14 May, 2004 8 commits
  2. 13 May, 2004 7 commits
    • David Brownell's avatar
      [PATCH] USB: usbhid calls itself "hid" · 5e738ff1
      David Brownell authored
      5e738ff1
    • Tony Lindgren's avatar
      [PATCH] USB: Merge support for Keyspan UPR-112 USB serial adapter from 2.4 to 2.6 · ee996862
      Tony Lindgren authored
      Following patch merges the support for Keyspan UPR-112 USB serial adapter
      from 2.4 to 2.6.
      ee996862
    • Greg Kroah-Hartman's avatar
      USB: add snooping capability to usbfs for control messages. · 0d7d76d3
      Greg Kroah-Hartman authored
      Also fix up some of the other printk() calls to be dev_* calls.
      0d7d76d3
    • Andrew Morton's avatar
      [PATCH] USB: fix ohci-hcd build error · e243c0fe
      Andrew Morton authored
      "Matt H." <lkml@lpbproductions.com> wrote:
      >
      > Just attempted to compile 2.6.6-mm2 and got this error
      >
      >    CC [M]  drivers/usb/core/driverfs.o
      >    CC [M]  drivers/usb/core/hcd-pci.o
      >    LD [M]  drivers/usb/core/usbcore.o
      >    LD      drivers/usb/host/built-in.o
      >    CC [M]  drivers/usb/host/ehci-hcd.o
      >    CC [M]  drivers/usb/host/ohci-hcd.o
      >  In file included from drivers/usb/host/ohci-hcd.c:129:
      >  drivers/usb/host/ohci-hub.c: In function `ohci_rh_resume':
      >  drivers/usb/host/ohci-hub.c:313: error: `hcd' undeclared (first use in this
      >  function)
      
      hm, not sure what's happened there...
      e243c0fe
    • Alan Stern's avatar
      [PATCH] USB: Don't delete interfaces until all are unbound · 00ee59a3
      Alan Stern authored
      On Thu, 13 May 2004, Duncan Sands wrote:
      
      > No, but the pointer for another (previous) interface may just have been
      > set to NULL, causing an Oops when usb_ifnum_to_if loops over all
      > interfaces.
      
      Of course!  I trust you won't mind me changing your suggested fix
      slightly.  This should do an equally good job of repairing things, and it
      will prevent other possible invalid references as well.
      00ee59a3
    • Duncan Sands's avatar
      [PATCH] USB: Patch to remove interface indices from devio.c · 79560d5a
      Duncan Sands authored
      > I went ahead and created a patch to change all the places where devio.c
      > uses an interface index.  Now it always uses just the interface number.
      > Does this look all right to you?  I don't have a convenient way to test
      > it.
      
      Hi Alan, thanks for doing this.  It looks and works OK.  I added some name
      changes: all struct usb_interface pointers are now called intf; and, when
      reasonable, variables holding interface numbers are now all called ifnum.
      This drowns your original changes in a sea of churning names, I hope you
      don't mind.
      79560d5a
    • David Brownell's avatar
      [PATCH] USB: missing probe() diagnostics for CDC Ethernet · e2a5c7a9
      David Brownell authored
      This patch should help correct the "missing diagnostics with
      CONFIG_USB_DEBUG during CDC Ethernet probe()" issue.  Some
      folk are having problems with firmware that doesn't respond
      properly to descriptor fetches -- which is unnecessarily
      confusing because the diagnostics aren't being printed.
      e2a5c7a9
  3. 12 May, 2004 1 commit
  4. 11 May, 2004 14 commits
    • Colin Leroy's avatar
      [PATCH] USB: cosmetic fixes for cdc-acm · 7e0cb221
      Colin Leroy authored
      7e0cb221
    • David Brownell's avatar
      [PATCH] USB: OHCI root hub suspend/resume/wakeup · c8ae88da
      David Brownell authored
      This patch goes on top of the previous two, and the hcd-0506 patch:
      
        - Moves root hub suspend/resume code out of PCI-specific bus glue
          into generic hub code.  That way it's easy to re-use it even
          for non-PCI implementations like SA1111, OMAP, and LH7A404.
          (Plus, given CONFIG_USB_SUSPEND, it can be invoked with sysfs.)
      
        - Root hub suspend is a lot more careful, as is root hub resume.
          Pending transactions are now shut down more consistently; and
          more registers are re-initialized on resume.
      
        - The PCI bus glue is now left with truly generic PCI stuff, plus
          some PMAC-specific stuff (which doesn't include irq disabling
          any more, hcd-0506 moves that up a level in the stack).
      
        - Remote wakeup support is basically working for the root hub.
          (given CONFIG_USB_SUSPEND to suspend devices and enable it).
      
        - Idle HCs will now automatically suspend themselves, and resume
          as necessary.  This saves a certain amount of power on most
          systems, and matches what UHCI has been doing for a while.
      
      The large size of this patch is mostly because of moving that
      root hub suspend/resume code out of the PCI-specific glue.
      c8ae88da
    • David Brownell's avatar
      [PATCH] USB: khubd turns port power back on after reset · 12423061
      David Brownell authored
      This goes with the OHCI anti-deadlock patch, and is what
      ensures that when a root hub loses power during suspend,
      khubd can turn port power back on so devices can enumerate.
      12423061
    • David Brownell's avatar
      [PATCH] USB: OHCI cleanups · ea2b2c10
      David Brownell authored
      This splits out a few obvious fixes, to help shrink a PM patch:
      
        - when the HC is quiescing, don't schedule any more EDs
          or re-activate any after unlink completion.
      
        - when the HC is suspended, don't access registers through
          sysfs either.
      
        - simplify locking and call for donelist processing
      ea2b2c10
    • David Brownell's avatar
      [PATCH] USB: OHCI resume/reset stops deadlocking in PM code · 2a339670
      David Brownell authored
      System-wide PM resume now happily deadlocks if one of the
      resuming devices tries to remove devices which vanished
      during the suspend(*).  IMO that's unreasonable both
      because devices can/do vanish, and because 2.4 didn't
      deadlock in those cases; but no patch to fix that has been
      merged.  The result is that ever since merging the "new" PM
      code, some OHCI-based systems deadlock on resume.
      
      So this patch handles the "lost power during resume" case
      differently:  it doesn't disconnect the root hub (or its
      children) directly.  Instead, it does part of that work
      immediately, and defers the rest to khubd:
      
        - add a "pending" list for live urbs, and use it after reset
          to abort pending URBs (and reclaim "live" EDs/TDs)
        - immediately mark all devices NOTATTACHED, so any operations
          on the devices before khubd handles the disconnects, including
          resume() callbacks, will fail
        - kick root hub so it can do the cleanup
      
      It also handles "fminterval" init/reinit a bit better, mostly
      to work better in some remote wakeup scenarios addressed in
      later patches:
      
         - save any initial value the boot firmware provided
         - use it during initialization (and eventually, remote wakeup)
      
      Other changes:
      
        - use better jiffies calculation for scheduled delays
        - the allocator does more of the one-time initialization
        - initialize hcd.can_wakeup according to boot firmware
        - move some inlines to the header
        - minor cleanups
      
      
      (*) http://marc.theaimsgroup.com/?l=linux-kernel&m=106606272103414&w=2
           reported against 2.6.0-test7.
      2a339670
    • Oliver Neukum's avatar
      [PATCH] USB: fixes of assumptions about waitqueues · ec0e3558
      Oliver Neukum authored
      quoting Linus:
      
      --
      > so there is no need to recheck the bit in do/while loop, because
      > there is no false wakeups now.
      
      You should never assume this. You should assume that there are _always_
      false wakeups.
      
      Why? Because Linux has always allowed people to leave wait-queues active,
      without being "atomic". For example, the tty read/write layer used to
      (still does?)  add itself on the wait-queue _once_, and then leave itself
      on the wait-queue while in a loop it does copies from/to user space.
      --
      
      Unfortunately, this means us. Here's the first fix. Comments?
      
        - make sure timeouts are observed even if somebody left us on a queue
      ec0e3558
    • David Brownell's avatar
      [PATCH] USB: more functional HCD PCI PM glue · 4808f141
      David Brownell authored
      This patch makes the usbcore PCI suspend/resume logic behave
      much better.  In particular:
      
        - Even HCs without PCI PM support will normally be able
          to support global suspend, saving power ... and will
          need to resume later.  Let them try to suspend; lots
          of not-that-old USB controllers don't have PM caps.
      
        - Saner order for the boilerplate PCI stuff.  It also
          explicitly disables the IRQ and DMA, which aren't
          available in D1/D2/D3 states anyway.
      
        - Uses pci_enable_wake() when the root hub supports
          remote wakeup.  Didn't fully work in one test setup;
          that controller's PME# was evidently ignored.  (Not
          enabled unless CONFIG_USB_SUSPEND.)
      
      It worked for me with brief tests with the current 2.6.6-rc
      uhci-hcd with one old UHCI; more extensive ones with various
      OHCIs (using patches which I'll post soonish); and not at all
      with EHCI (where PM hasn't ever worked).
      
      Those of you who've been having PM problems might find
      this helpful as-is, though I think that unless you're
      using UHCI you'll also need an HCD patch.
      
      - Dave
      4808f141
    • Alan Stern's avatar
      [PATCH] USB: Accept devices with funky interface/altsetting numbers · 3a6e35ad
      Alan Stern authored
      Now that all the USB drivers have been audited, we can safely accept
      devices that have noncompliant numbering for their interfaces or
      altsettings.  This patch skips bad or duplicate descriptors, allows gaps
      in the numbering, accepts more or fewer interfaces than bNumInterfaces,
      and logs warnings describing all these things.  Also, the debugging log
      messages have been improved by David Brownell.
      
      This should please a sizeable group of users.
      3a6e35ad
    • David Brownell's avatar
      [PATCH] USB: EHCI power management updates · 657dc0a0
      David Brownell authored
      This patch updates EHCI suspend/resume so that its essential
      components work on a few different implementations:
      
         - make root hub suspend/resume work
         - make remote wakeup work (given CONFIG_USB_SUSPEND patch)
         - separate root hub suspend/resume from PCI suspend/resume
         - say if controller supports remote wakeup (on this system)
         - sysfs register dump unavailable if controller is suspended
      
      Plus a handful of minor cleanups.  Please merge, along with the
      "hcd-0506.patch" I sent last week.
      
      Tested by modifying sysfs power/state files, since ACPI doesn't
      work on this system (so I can't test system suspend/resume):
      
        - For root hub(*) ... suspend/resume works, also remote wakeup
        - PCI controller ... suspend/resume works, remote wakeup
          signals PME# (according to "lspci -vv"), but that's ignored
          on my test sytem
      
      Regardless of whether USB was active, "echo 1 > /proc/acpi/sleep"
      produced a system that wouldn't resume, and the same result
      came from "echo standby > /sys/power/state".  So that's about
      as far as I can take this testing for now.
      
      - Dave
      
      (*) Doing this relies on the CONFIG_USB_SUSPEND patch.  Otherwise
           no USB devices respond to sysfs power/state updates.  The
           PCI suspend/resume is a superset of this.
      657dc0a0
    • Alan Stern's avatar
      [PATCH] USB Gadget: Fix file-storage gadget Request Sense length · 23601558
      Alan Stern authored
      On Fri, 7 May 2004, kernel@metro.cx wrote:
      > Hi All,
      >
      > I don't know where else to report this, but I found a very very very
      > minor bug in the usb gadgets drivers, specifically the file_storage.c
      > mass storage driver.
      >
      > In the function do_request_sense(..) it says:
      >
      > buf[7] = 18 - 7;                        // Additional sense length
      >
      > Whereas (according to page 38 of the USB mass storage class, UFI command spec,
      > http://www.usb.org/developers/devclass_docs#approved) this clearly neads
      > to be equal to 10, not 11.
      >
      > I checked with the 2.6.5 source, it is still there. Hope someone will find this usefull, although most USB hosts seem to ignore length bits alltogether anyway....
      >
      > Koen Martens
      
      You are quite right; thank you for pointing this out.  Greg, please apply
      the patch below.
      23601558
    • Luiz Capitulino's avatar
      [PATCH] USB: fix media/dsbr100.c unused variable. · c0e1607a
      Luiz Capitulino authored
      drivers/usb/media/dsbr100.c: In function `usb_dsbr100_probe':
      drivers/usb/media/dsbr100.c:239: warning: unused variable `videodev'
      c0e1607a
    • Hanna V. Linder's avatar
    • Greg Kroah-Hartman's avatar
      USB: make functions static in usb drivers that should be · 8d5c15b8
      Greg Kroah-Hartman authored
      Thanks to Tridge's findstatic.pl script for helping find these.
      8d5c15b8
    • Geert Uytterhoeven's avatar
      [PATCH] M68k superfluous whitespace · 141baf80
      Geert Uytterhoeven authored
      M68k: Remove superfluous whitespace that hurts my eyes with `let
      c_space_errors=1' in vim. This includes correcting trailing whitespace and
      spaces in front of tabs. `diff -urNbB' shows no difference before/after.
      141baf80
  5. 10 May, 2004 10 commits
    • Jeff Garzik's avatar
      [libata] Maintainer annotations · 3d29f7cb
      Jeff Garzik authored
      In MAINTAINERS and in individual low-level drivers.
      3d29f7cb
    • Jeff Garzik's avatar
      [libata] preparation for writeback caching support · 8962c315
      Jeff Garzik authored
      * bug fix: make sure 'nsect' member of struct ata_queued_cmd is
      initialized each time a cmd is re-used.  Only affects PIO data xfers,
      which nobody uses.
      * slightly change the way a device's flags are printed out.  currently
      the only flag is 'lba48', but soon 'wcache' will appear also.
      * add WB-cache-related constants and macros to linux/ata.h
      8962c315
    • David Eger's avatar
      [PATCH] radeon: fix overlapping copyarea · 7fb76946
      David Eger authored
      This fixes a corruption problem with overlapping copyarea()'s
      in the radeon driver.
      7fb76946
    • Paul Mackerras's avatar
      [PATCH] ppc64: extra barrier in I/O operations · 307b7297
      Paul Mackerras authored
      At the moment, on PPC64, the instruction we use for wmb() doesn't
      order cacheable stores vs. non-cacheable stores.  (It does order
      cacheable vs. cacheable and non-cacheable vs. non-cacheable.)  This
      causes problems in the sort of driver code that writes stuff into
      memory, does a wmb(), then a writel to the device to start a DMA
      operation to read the stuff it has just written to memory.
      
      This patch solves the problem by adding a sync instruction before the
      store in the write* and out* macros.  The sync is a full barrier that
      orders all loads and stores, cacheable or not.  The patch also moves
      the eieio instruction that we had after the store to before the load
      in the read* and in* macros.  With the sync before the store, we don't
      need an eieio as well in a sequence of stores, but we still need an
      eieio between a store and a load.
      
      I think it is better to do this than to turn wmb() into a full memory
      barrier (a sync instruction) because the full barrier is slow and
      isn't needed with the sync in the write*/out* macros.  This way,
      write*/out* are fully ordered with respect to preceding loads and
      stores, which is what driver writers expect, and we avoid penalizing
      users of wmb() who are only doing cacheable stores.
      307b7297
    • Linus Torvalds's avatar
      Merge bk://drm.bkbits.net/drm-2.6 · 9c152646
      Linus Torvalds authored
      into ppc970.osdl.org:/home/torvalds/v2.6/linux
      9c152646
    • Matthew Wilcox's avatar
      [PATCH] PA-RISC updates for 2.6.6 · 49e9c1cc
      Matthew Wilcox authored
       - Split PA7300LC from PA7100LC (Matthew Wilcox)
       - Handle 32-bit firmware and 64-bit kernel at runtime (Ryan Bradetich)
       - Fix building in a separate tree (Matthew Wilcox)
       - Update defconfigs (Randolph Chung)
       - Make WCHAN work (Randolph Chung)
       - Initial support for SMP in 2.6 (Grant Grundler)
       - Use 8-byte PTEs on 32-bit kernels (James Bottomley)
       - Implement L2/L3 hybrid page tables for 64 bit kernels (James Bottomley)
       - Support 8TB of physical and virtual address space (James Bottomley)
       - Macro'ise the tlb miss handlers (James Bottomley)
       - Check the ptrace flags correctly in the syscall return path (Randolph Chung)
       - Eliminate many magic numbers (James Bottomley)
       - Work around linker bug in vmlinux.lds.S (James Bottomley)
       - Many cache flushing fixes (James Bottomley)
       - first baby step for PA8800 support (Grant Grundler)
       - Self-aligning spinlocks (Randolph Chung)
      49e9c1cc
    • Geert Uytterhoeven's avatar
      [PATCH] M68k missing <linux/compiler.h> · 10190153
      Geert Uytterhoeven authored
      M68k: <asm/virtconvert.h> needs include <linux/compiler.h> for
      __attribute_const__ (from Richard Zidlicky)
      10190153
    • Geert Uytterhoeven's avatar
      [PATCH] Sun3x dummycon · 714c1464
      Geert Uytterhoeven authored
      Sun3x: Like most other platforms, Sun3x needs conswitchp set if
      CONFIG_DUMMY_CONSOLE is defined (from Sam Creasey)
      714c1464
    • Linus Torvalds's avatar
      Merge bk://gkernel.bkbits.net/libata-2.6 · 2a8941cf
      Linus Torvalds authored
      into ppc970.osdl.org:/home/torvalds/v2.6/linux
      2a8941cf
    • Linus Torvalds's avatar
      Merge bk://gkernel.bkbits.net/net-drivers-2.6 · a49b9154
      Linus Torvalds authored
      into ppc970.osdl.org:/home/torvalds/v2.6/linux
      a49b9154