1. 04 Oct, 2022 1 commit
    • Arnd Bergmann's avatar
      alpha: add full ioread64/iowrite64 implementation · e19d4ebc
      Arnd Bergmann authored
      The previous patch introduced ioread64/iowrite64 declarations, but
      this means we no longer get the io-64-nonatomic variant, and
      run into a long error when someone actually wants to use these:
      
      ERROR: modpost: "ioread64" [drivers/net/ethernet/freescale/enetc/fsl-enetc.ko] undefined!
      
      Add the (hopefully) correct implementation for each machine type,
      based on the 32-bit accessor. Since the 32-bit return type does
      not work for ioread64(), change the internal implementation to use
      the correct width consistently, but leave the external interface
      to match the asm-generic/iomap.h header that uses 32-bit or 64-bit
      return values.
      Reported-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Tested-by: default avatarGuenter Roeck <linux@roeck-us.net>
      Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      Fixes: 7e772dad ("alpha: Use generic <asm-generic/io.h>")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      e19d4ebc
  2. 23 Sep, 2022 1 commit
  3. 12 Sep, 2022 2 commits
  4. 10 Sep, 2022 3 commits
    • Christophe Leroy's avatar
      asm-generic: Remove empty #ifdef SA_RESTORER · 773428ff
      Christophe Leroy authored
      There was a #ifdef SA_RESTORER to guard the sa_restorer field
      in struct sigaction.
      
      Commit 8a1ab315 ("UAPI: (Scripted) Disintegrate
      include/asm-generic") moved that struct into
      uapi/asm-generic/signal.h but the #ifdef SA_RESTORER remained.
      
      Remove it.
      Signed-off-by: default avatarChristophe Leroy <christophe.leroy@csgroup.eu>
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      773428ff
    • Linus Walleij's avatar
      parisc: Use the generic IO helpers · 437b6b35
      Linus Walleij authored
      This enables the parisc to use <asm-generic/io.h> to fill in the
      missing (undefined) [read|write]sq I/O accessor functions.
      
      This is needed if parisc[64] ever wants to uses CONFIG_REGMAP_MMIO
      which has been patches to use accelerated _noinc accessors
      such as readsq/writesq that parisc64, while being a 64bit platform,
      as of now not yet provide.
      
      This comes with the requirement that everything the architecture
      already provides needs to be defined, rather than just being,
      say, static inline functions.
      
      Bite the bullet and just provide the definitions and make it work.
      Compile-tested on parisc32 and parisc64. Drop some of the __raw
      functions that now get implemented in <asm-generic/io.h>.
      Reported-by: default avatarkernel test robot <lkp@intel.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      Reviewed-by: default avatarArnd Bergmann <arnd@arndb.de>
      Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
      Cc: Helge Deller <deller@gmx.de>
      Cc: linux-parisc@vger.kernel.org
      Cc: linux-arch@vger.kernel.org
      Cc: Mark Brown <broonie@kernel.org>
      Cc: John David Anglin <dave.anglin@bell.net>
      Link: https://lore.kernel.org/linux-arm-kernel/62fcc351.hAyADB%2FY8JTxz+kh%25lkp@intel.com/Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      437b6b35
    • Linus Walleij's avatar
      parisc: Remove 64bit access on 32bit machines · 77bfc8bd
      Linus Walleij authored
      The parisc was using some readq/writeq accessors without special
      considerations as to what will happen on 32bit CPUs if you do
      this. Maybe we have been lucky that it "just worked" on 32bit
      due to the compiler behaviour, or the code paths were never
      executed.
      
      Fix the two offending code sites like this:
      
      arch/parisc/lib/iomap.c:
      
      - Put ifdefs around the 64bit accessors and make sure
        that ioread64, ioread64be, iowrite64 and iowrite64be
        are not available on 32bit builds.
      
      - Also fold in a bug fix where 64bit access was by
        mistake using 32bit writel() accessors rather
        than 64bit writeq().
      
      drivers/parisc/sba_iommu.c:
      
      - Access any 64bit registers using _lo_hi-semantics by way
        of the readq and writeq operations provided by
        <linux/io-64-nonatomic-lo-hi.h>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      Reviewed-by: default avatarArnd Bergmann <arnd@arndb.de>
      Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
      Cc: Helge Deller <deller@gmx.de>
      Cc: linux-parisc@vger.kernel.org
      Cc: linux-arch@vger.kernel.org
      Cc: Arnd Bergmann <arnd@arndb.de>
      Cc: John David Anglin <dave.anglin@bell.net>
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      77bfc8bd
  5. 08 Sep, 2022 2 commits
    • Linus Walleij's avatar
      sparc: Fix the generic IO helpers · 2c230431
      Linus Walleij authored
      This enables the Sparc to use <asm-generic/io.h> to fill in the
      missing (undefined) [read|write]sq I/O accessor functions.
      
      This is needed if Sparc[64] ever wants to uses CONFIG_REGMAP_MMIO
      which has been patches to use accelerated _noinc accessors
      such as readsq/writesq that Sparc64, while being a 64bit platform,
      as of now not yet provide.
      
      This comes with the requirement that everything the architecture
      already provides needs to be defined, rather than just being,
      say, static inline functions.
      
      Bite the bullet and just provide the definitions and make it work.
      Compile-tested on sparc32 and sparc64.
      Reported-by: default avatarkernel test robot <lkp@intel.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      Cc: David S. Miller <davem@davemloft.net>
      Cc: sparclinux@vger.kernel.org
      Cc: linux-arch@vger.kernel.org
      Cc: Mark Brown <broonie@kernel.org>
      Cc: Arnd Bergmann <arnd@arndb.de>
      Link: https://lore.kernel.org/linux-arm-kernel/202208201639.HXye3ke4-lkp@intel.com/Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      2c230431
    • Linus Walleij's avatar
      alpha: Use generic <asm-generic/io.h> · 7e772dad
      Linus Walleij authored
      This enables the alpha to use <asm-generic/io.h> to fill in the
      missing (undefined) I/O accessor functions.
      
      This is needed if Alpha ever wants to uses CONFIG_REGMAP_MMIO
      which has been patches to use accelerated _noinc accessors
      such as readsq/writesq that Alpha, while being a 64bit platform,
      as of now not yet provide. readq/writeq is however provided
      so the machine can do 64bit I/O.
      
      This comes with the requirement that everything the architecture
      already provides needs to be defined, rather than just being,
      say, static inline functions.
      
      Bite the bullet and just provide the definitions and make it work.
      
      Some defines need to be piled right before the inclusion of
      <asm-generic/io.h> due to the fact that alpha is including
      <asm-generic/iomap.h> without selecting GENERIC_IOMAP.
      Reported-by: default avatarkernel test robot <lkp@intel.com>
      Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      Cc: Mark Brown <broonie@kernel.org>
      Cc: Arnd Bergmann <arnd@arndb.de>
      Cc: Richard Henderson <richard.henderson@linaro.org>
      Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
      Cc: Matt Turner <mattst88@gmail.com>
      Cc: linux-arch@vger.kernel.org
      Cc: linux-alpha@vger.kernel.org
      Link: https://lore.kernel.org/linux-mm/202208181447.G9FLcMkI-lkp@intel.com/Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      7e772dad
  6. 04 Sep, 2022 5 commits
    • Linus Torvalds's avatar
      Linux 6.0-rc4 · 7e18e42e
      Linus Torvalds authored
      7e18e42e
    • Linus Torvalds's avatar
      Merge tag 'powerpc-6.0-4' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux · 59954972
      Linus Torvalds authored
      Pull powerpc fixes from Michael Ellerman:
      
       - Fix handling of PCI domains in /proc on 32-bit systems using the
         recently added support for numbering buses from zero for each domain.
      
       - A fix and a revert for some changes to use READ/WRITE_ONCE() which
         caused problems with KASAN enabled due to sanitisation calls being
         introduced in low-level paths that can't cope with it.
      
       - Fix build errors on 32-bit caused by the syscall table being
         misaligned sometimes.
      
       - Two fixes to get IBM Cell native machines booting again, which had
         bit-rotted while my QS22 was temporarily out of action.
      
       - Fix the papr_scm driver to not assume the order of events returned by
         the hypervisor is stable, and a related compile fix.
      
      Thanks to Aneesh Kumar K.V, Christophe Leroy, Jordan Niethe, Kajol Jain,
      Masahiro Yamada, Nathan Chancellor, Pali Rohár, Vaibhav Jain, and Zhouyi
      Zhou.
      
      * tag 'powerpc-6.0-4' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux:
        powerpc/papr_scm: Ensure rc is always initialized in papr_scm_pmu_register()
        Revert "powerpc/irq: Don't open code irq_soft_mask helpers"
        powerpc: Fix hard_irq_disable() with sanitizer
        powerpc/rtas: Fix RTAS MSR[HV] handling for Cell
        Revert "powerpc: Remove unused FW_FEATURE_NATIVE references"
        powerpc: align syscall table for ppc32
        powerpc/pci: Enable PCI domains in /proc when PCI bus numbers are not unique
        powerpc/papr_scm: Fix nvdimm event mappings
      59954972
    • Linus Torvalds's avatar
      Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm · 685ed983
      Linus Torvalds authored
      Pull kvm fixes from Paolo Bonzini:
       "s390:
      
         - PCI interpretation compile fixes
      
        RISC-V:
      
         - fix unused variable warnings in vcpu_timer.c
      
         - move extern sbi_ext declarations to a header
      
        x86:
      
         - check validity of argument to KVM_SET_MP_STATE
      
         - use guest's global_ctrl to completely disable guest PEBS
      
         - fix a memory leak on memory allocation failure
      
         - mask off unsupported and unknown bits of IA32_ARCH_CAPABILITIES
      
         - fix build failure with Clang integrated assembler
      
         - fix MSR interception
      
         - always flush TLBs when enabling dirty logging"
      
      * tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm:
        KVM: x86: check validity of argument to KVM_SET_MP_STATE
        perf/x86/core: Completely disable guest PEBS via guest's global_ctrl
        KVM: x86: fix memoryleak in kvm_arch_vcpu_create()
        KVM: x86: Mask off unsupported and unknown bits of IA32_ARCH_CAPABILITIES
        KVM: s390: pci: Hook to access KVM lowlevel from VFIO
        riscv: kvm: move extern sbi_ext declarations to a header
        riscv: kvm: vcpu_timer: fix unused variable warnings
        KVM: selftests: Fix ambiguous mov in KVM_ASM_SAFE()
        KVM: selftests: Fix KVM_EXCEPTION_MAGIC build with Clang
        KVM: VMX: Heed the 'msr' argument in msr_write_intercepted()
        kvm: x86: mmu: Always flush TLBs when enabling dirty logging
        kvm: x86: mmu: Drop the need_remote_flush() function
      685ed983
    • Nick Desaulniers's avatar
      Makefile.extrawarn: re-enable -Wformat for clang; take 2 · b0839b28
      Nick Desaulniers authored
      -Wformat was recently re-enabled for builds with clang, then quickly
      re-disabled, due to concerns stemming from the frequency of default
      argument promotion related warning instances.
      
      commit 258fafcd ("Makefile.extrawarn: re-enable -Wformat for clang")
      commit 21f9c8a1 ("Revert "Makefile.extrawarn: re-enable -Wformat for clang"")
      
      ISO WG14 has ratified N2562 to address default argument promotion
      explicitly for printf, as part of the upcoming ISO C2X standard.
      
      The behavior of clang was changed in clang-16 to not warn for the cited
      cases in all language modes.
      
      Add a version check, so that users of clang-16 now get the full effect
      of -Wformat. For older clang versions, re-enable flags under the
      -Wformat group that way users still get some useful checks related to
      format strings, without noisy default argument promotion warnings. I
      intentionally omitted -Wformat-y2k and -Wformat-security from being
      re-enabled, which are also part of -Wformat in clang-16.
      
      Link: https://github.com/ClangBuiltLinux/linux/issues/378
      Link: https://github.com/llvm/llvm-project/issues/57102
      Link: https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2562.pdfSuggested-by: default avatarJustin Stitt <jstitt007@gmail.com>
      Suggested-by: default avatarNathan Chancellor <nathan@kernel.org>
      Suggested-by: default avatarYoungmin Nam <youngmin.nam@samsung.com>
      Signed-off-by: default avatarNick Desaulniers <ndesaulniers@google.com>
      Reviewed-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
      Reviewed-by: default avatarNathan Chancellor <nathan@kernel.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      b0839b28
    • Linus Torvalds's avatar
      Merge tag 'gpio-fixes-for-v6.0-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux · 7726d4c3
      Linus Torvalds authored
      Pull gpio fixes from Bartosz Golaszewski:
       "A a set of fixes from the GPIO subsystem.
      
        Most are small driver fixes except the realtek-otto driver patch which
        is pretty big but addresses a significant flaw that can cause the CPU
        to stay infinitely busy on uncleared ISR on some platforms.
      
        Summary:
         - MAINTAINERS update
         - fix resource leaks in gpio-mockup and gpio-pxa
         - add missing locking in gpio-pca953x
         - use 32-bit I/O in gpio-realtek-otto
         - make irq_chip structures immutable in four more drivers"
      
      * tag 'gpio-fixes-for-v6.0-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux:
        gpio: ws16c48: Make irq_chip immutable
        gpio: 104-idio-16: Make irq_chip immutable
        gpio: 104-idi-48: Make irq_chip immutable
        gpio: 104-dio-48e: Make irq_chip immutable
        gpio: realtek-otto: switch to 32-bit I/O
        gpio: pca953x: Add mutex_lock for regcache sync in PM
        gpio: mockup: remove gpio debugfs when remove device
        gpio: pxa: use devres for the clock struct
        MAINTAINERS: rectify entry for XILINX GPIO DRIVER
      7726d4c3
  7. 03 Sep, 2022 19 commits
  8. 02 Sep, 2022 7 commits
    • Linus Torvalds's avatar
      Merge tag 'block-6.0-2022-09-02' of git://git.kernel.dk/linux-block · d895ec79
      Linus Torvalds authored
      Pull block fixes from Jens Axboe:
      
       - NVMe pull request via Christoph:
           - error handling fix for the new auth code (Hannes Reinecke)
           - fix unhandled tcp states in nvmet_tcp_state_change (Maurizio
             Lombardi)
           - add NVME_QUIRK_BOGUS_NID for Lexar NM610 (Shyamin Ayesh)
      
       - Add documentation for the ublk driver merged in this merge window
         (Ming)
      
      * tag 'block-6.0-2022-09-02' of git://git.kernel.dk/linux-block:
        Documentation: document ublk
        nvmet-tcp: fix unhandled tcp states in nvmet_tcp_state_change()
        nvmet-auth: add missing goto in nvmet_setup_auth()
        nvme-pci: add NVME_QUIRK_BOGUS_NID for Lexar NM610
      d895ec79
    • Linus Torvalds's avatar
      Merge tag 'io_uring-6.0-2022-09-02' of git://git.kernel.dk/linux-block · cec53f4c
      Linus Torvalds authored
      Pull io_uring fixes from Jens Axboe:
      
       - A single fix for over-eager retries for networking (Pavel)
      
       - Revert the notification slot support for zerocopy sends.
      
         It turns out that even after more than a year or development and
         testing, there's not full agreement on whether just using plain
         ordered notifications is Good Enough to avoid the complexity of using
         the notifications slots. Because of that, we decided that it's best
         left to a future final decision.
      
         We can always bring back this feature, but we can't really change it
         or remove it once we've released 6.0 with it enabled. The reverts
         leave the usual CQE notifications as the primary interface for
         knowing when data was sent, and when it was acked. (Pavel)
      
      * tag 'io_uring-6.0-2022-09-02' of git://git.kernel.dk/linux-block:
        selftests/net: return back io_uring zc send tests
        io_uring/net: simplify zerocopy send user API
        io_uring/notif: remove notif registration
        Revert "io_uring: rename IORING_OP_FILES_UPDATE"
        Revert "io_uring: add zc notification flush requests"
        selftests/net: temporarily disable io_uring zc test
        io_uring/net: fix overexcessive retries
      cec53f4c
    • Linus Torvalds's avatar
      Merge tag '6.0-rc3-smb3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6 · 1551f8f2
      Linus Torvalds authored
      Pull cifs fixes from Steve French:
       "Five fixes, all also marked for stable:
      
         - fixes for collapse range and insert range (also fixes xfstest
           generic/031)
      
         - memory leak fix"
      
      * tag '6.0-rc3-smb3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6:
        cifs: fix small mempool leak in SMB2_negotiate()
        smb3: use filemap_write_and_wait_range instead of filemap_write_and_wait
        smb3: fix temporary data corruption in insert range
        smb3: fix temporary data corruption in collapse range
        smb3: Move the flush out of smb2_copychunk_range() into its callers
      1551f8f2
    • Linus Torvalds's avatar
      Merge tag 'landlock-6.0-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/mic/linux · 0c95f022
      Linus Torvalds authored
      Pull landlock fix from Mickaël Salaün:
       "This fixes a mis-handling of the LANDLOCK_ACCESS_FS_REFER right when
        multiple rulesets/domains are stacked.
      
        The expected behaviour was that an additional ruleset can only
        restrict the set of permitted operations, but in this particular case,
        it was potentially possible to re-gain the LANDLOCK_ACCESS_FS_REFER
        right"
      
      * tag 'landlock-6.0-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/mic/linux:
        landlock: Fix file reparenting without explicit LANDLOCK_ACCESS_FS_REFER
      0c95f022
    • Linus Torvalds's avatar
      Merge tag 'mmc-v6.0-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc · b307e704
      Linus Torvalds authored
      Pull MMC fixes from Ulf Hansson:
      
       - Fix workaround for SD UHS-I voltage switch
      
      * tag 'mmc-v6.0-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc:
        mmc: core: Fix inconsistent sd3_bus_mode at UHS-I SD voltage switch failure
        mmc: core: Fix UHS-I SD 1.8V workaround branch
      b307e704
    • Linus Torvalds's avatar
      Merge tag 'drm-fixes-2022-09-02' of git://anongit.freedesktop.org/drm/drm · 1e8e515e
      Linus Torvalds authored
      Pull drm fixes from Dave Airlie:
       "Regular fixes pull. One core dma-buf fix, then two weeks of i915
        fixes, a lot of amdgpu fixes mostly for new IP, and a bunch of msm
        fixes, mostly modesetting ones.
      
        Nothing seems too bad at this point.
      
        dma-buf/dma-resv:
         - Fence-handling fix
      
        i915:
         - GVT fixes including fix for a CommetLake regression in mmio table
           and misc doc and typo fixes
         - Fix CCS handling
         - Fix for guc requests after reset
         - Display DSI related fixes
         - Display backlight related fixes
         - Fix for a null pointer dereference
         - HDMI related quirk for ECS Liva Q2 with GLK graphics
         - Skip wm/ddb readout for disabled pipes
      
        amdgpu:
         - FRU error message fix
         - MES 11 updates
         - DCN 3.2.x fixes
         - DCN 3.1.4 fixes
         - Fix possible use after free in CS IOCTL
         - SMU 13.0.x fixes
         - Fix iolink reporting on devices with direct connections to CPU
         - GFX10 tap delay firmware fixes
      
        msm:
         - Fix for inconsistent indenting in msm_dsi_dphy_timing_calc_v3().
         - Fix to make eDP the first connector in the connected list.
         - Fix to populate intf_cfg correctly before calling reset_intf_cfg().
         - Specify the correct number of DSI regulators for SDM660.
         - Specify the correct number of DSI regulators for MSM8996.
         - Fix for removing DP_RECOVERED_CLOCK_OUT_EN bit for tps4 link training
         - Fix probe-deferral crash in gpu devfreq
         - Fix gpu debugfs deadlock"
      
      * tag 'drm-fixes-2022-09-02' of git://anongit.freedesktop.org/drm/drm: (51 commits)
        drm/amd/amdgpu: skip ucode loading if ucode_size == 0
        drm/amdgpu: only init tap_delay ucode when it's included in ucode binary
        drm/amd/display: Fix black flash when switching from ODM2to1 to ODMBypass
        drm/amd/display: Fix check for stream and plane
        drm/amd/display: Re-initialize viewport after pipe merge
        drm/amd/display: Use correct plane for CAB cursor size allocation
        drm/amdgpu: ensure no PCIe peer access for CPU XGMI iolinks
        drm/amd/pm: bump SMU 13.0.0 driver_if header version
        drm/amd/pm: use vbios carried pptable for all SMU13.0.7 SKUs
        drm/amd/pm: use vbios carried pptable for those supported SKUs
        drm/amd/display: fix wrong register access
        drm/amd/display: use actual cursor size instead of max for CAB allocation
        drm/amd/display: disable display fresh from MALL on an edge case for DCN321
        drm/amd/display: Fix CAB cursor size allocation for DCN32/321
        drm/amd/display: Missing HPO instance added
        drm/amd/display: set dig fifo read start level to 7 before dig fifo reset
        drm/amdgpu: Fix use-after-free in amdgpu_cs_ioctl
        drm/amd/display: Fix OTG H timing reset for dcn314
        drm/amd/display: Fix DCN32 DPSTREAMCLK_CNTL programming
        drm/amdgpu: Update mes_v11_api_def.h
        ...
      1e8e515e
    • Linus Torvalds's avatar
      Merge tag 'driver-core-6.0-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core · 0b3acd1c
      Linus Torvalds authored
      Pull driver core fixes from Greg KH:
       "Here are some small driver core fixes for some oft-reported problems
        in 6.0-rc1.  They include:
      
         - a bunch of reverts to handle driver_deferred_probe_check_state()
           problems that were part of the 6.0-rc1 merge.
      
         - firmware_loader bugfixes now that the code is being properly tested
           and used by others
      
         - arch_topology fix
      
         - deferred driver probe bugfix to solve a long-suffering amba bus
           problem that many people have reported.
      
        All of these have been in linux-next for a while with no reported
        problems"
      
      * tag 'driver-core-6.0-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core:
        firmware_loader: Fix memory leak in firmware upload
        firmware_loader: Fix use-after-free during unregister
        arch_topology: Silence early cacheinfo errors when non-existent
        driver core: Don't probe devices after bus_type.match() probe deferral
        Revert "iommu/of: Delete usage of driver_deferred_probe_check_state()"
        Revert "PM: domains: Delete usage of driver_deferred_probe_check_state()"
        Revert "net: mdio: Delete usage of driver_deferred_probe_check_state()"
        Revert "driver core: Delete driver_deferred_probe_check_state()"
      0b3acd1c