1. 11 Dec, 2020 10 commits
  2. 10 Dec, 2020 1 commit
  3. 24 Nov, 2020 13 commits
  4. 22 Nov, 2020 12 commits
    • Zhihao Cheng's avatar
      drivers: soc: ti: knav_qmss_queue: Fix error return code in knav_queue_probe · 4cba398f
      Zhihao Cheng authored
      Fix to return the error code from of_get_child_by_name() instaed of 0
      in knav_queue_probe().
      
      Fixes: 41f93af9 ("soc: ti: add Keystone Navigator QMSS driver")
      Reported-by: default avatarHulk Robot <hulkci@huawei.com>
      Signed-off-by: default avatarZhihao Cheng <chengzhihao1@huawei.com>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
      4cba398f
    • Zhang Qilong's avatar
      soc: ti: Fix reference imbalance in knav_dma_probe · b4fa7335
      Zhang Qilong authored
      The patch fix two reference leak.
      
        1) pm_runtime_get_sync will increment pm usage counter even it
           failed. Forgetting to call put operation will result in
           reference leak.
      
        2) The pm_runtime_enable will increase power disable depth. Thus
           a pairing decrement is needed on the error handling path to
           keep it balanced.
      
      We fix it by: 1) adding call pm_runtime_put_noidle or
      pm_runtime_put_sync in error handling. 2) adding pm_runtime_disable
      in error handling, to keep usage counter and disable depth balanced.
      
      Fixes: 88139ed0 ("soc: ti: add Keystone Navigator DMA support")
      Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
      b4fa7335
    • Grzegorz Jaszczyk's avatar
      soc: ti: pruss: Remove wrong check against *get_match_data return value · 8465c7d1
      Grzegorz Jaszczyk authored
      Since the of_device_get_match_data() doesn't return error code, remove
      wrong IS_ERR test. Proper check against NULL pointer is already done
      later before usage: if (data && data->...).
      
      Additionally, proceeding with empty device data is valid (e.g. in case
      of "ti,am3356-pruss").
      Reported-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
      Signed-off-by: default avatarGrzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
      8465c7d1
    • Nishanth Menon's avatar
      soc: ti: Kconfig: Drop ARM64 SoC specific configs · e83b2358
      Nishanth Menon authored
      With the integration of chip-id detection scheme in kernel[1], there
      is no specific need to maintain multitudes of SoC specific config
      options, discussed as per [2], we have deprecated the usage in other
      places for v5.10-rc1. Drop the configuration for the follow on kernel.
      
      [1] drivers/soc/ti/k3-socinfo.c commit 907a2b7e ("soc: ti: add k3 platforms chipid module driver")
      Signed-off-by: default avatarNishanth Menon <nm@ti.com>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
      e83b2358
    • Lee Jones's avatar
      soc: ti: k3-ringacc: Provide documentation for 'k3_ring's 'state' · 50883aff
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/soc/ti/k3-ringacc.c:163: warning: Function parameter or member 'state' not described in 'k3_ring'
      
      Cc: Santosh Shilimkar <ssantosh@kernel.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
      50883aff
    • Lee Jones's avatar
      soc: ti: wkup_m3_ipc: Document 'm3_ipc' parameter throughout · 7be1c9c1
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/soc/ti/wkup_m3_ipc.c:227: warning: Function parameter or member 'm3_ipc' not described in 'wkup_m3_set_mem_type'
       drivers/soc/ti/wkup_m3_ipc.c:236: warning: Function parameter or member 'm3_ipc' not described in 'wkup_m3_set_resume_address'
       drivers/soc/ti/wkup_m3_ipc.c:248: warning: Function parameter or member 'm3_ipc' not described in 'wkup_m3_request_pm_status'
       drivers/soc/ti/wkup_m3_ipc.c:268: warning: Function parameter or member 'm3_ipc' not described in 'wkup_m3_prepare_low_power'
       drivers/soc/ti/wkup_m3_ipc.c:322: warning: Function parameter or member 'm3_ipc' not described in 'wkup_m3_finish_low_power'
       drivers/soc/ti/wkup_m3_ipc.c:369: warning: Function parameter or member 'm3_ipc' not described in 'wkup_m3_set_rtc_only'
       drivers/soc/ti/wkup_m3_ipc.c:369: warning: Excess function parameter 'wkup_m3_wakeup' description in 'wkup_m3_set_rtc_only'
      
      Cc: Santosh Shilimkar <ssantosh@kernel.org>
      Cc: Dave Gerlach <d-gerlach@ti.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
      7be1c9c1
    • Lee Jones's avatar
      soc: ti: pm33xx: Remove set but unused variable 'ret' · edac869e
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/soc/ti/pm33xx.c: In function ‘am33xx_do_sram_idle’:
       drivers/soc/ti/pm33xx.c:138:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
      
      Cc: Santosh Shilimkar <ssantosh@kernel.org>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
      edac869e
    • Lee Jones's avatar
      soc: ti: knav_dma: Fix a kernel function doc formatting issue · ed93a9e2
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/soc/ti/knav_dma.c:507: warning: Function parameter or member 'channel' not described in 'knav_dma_close_channel'
      
      Cc: Santosh Shilimkar <ssantosh@kernel.org>
      Cc: Sandeep Nair <sandeep_n@ti.com>
      Cc: Cyril Chemparathy <cyril@ti.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
      ed93a9e2
    • Lee Jones's avatar
      soc: ti: knav_qmss_queue: Fix a whole host of function documentation issues · e8ebf411
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/soc/ti/knav_qmss_queue.c:528: warning: Function parameter or member 'flags' not described in 'knav_queue_open'
       drivers/soc/ti/knav_qmss_queue.c:528: warning: Function parameter or member 'id' not described in 'knav_queue_open'
       drivers/soc/ti/knav_qmss_queue.c:528: warning: Function parameter or member 'name' not described in 'knav_queue_open'
       drivers/soc/ti/knav_qmss_queue.c:551: warning: Excess function parameter 'qh' description in 'knav_queue_close'
       drivers/soc/ti/knav_qmss_queue.c:551: warning: Function parameter or member 'qhandle' not described in 'knav_queue_close'
       drivers/soc/ti/knav_qmss_queue.c:583: warning: Excess function parameter 'qh' description in 'knav_queue_device_control'
       drivers/soc/ti/knav_qmss_queue.c:583: warning: Function parameter or member 'arg' not described in 'knav_queue_device_control'
       drivers/soc/ti/knav_qmss_queue.c:583: warning: Function parameter or member 'cmd' not described in 'knav_queue_device_control'
       drivers/soc/ti/knav_qmss_queue.c:583: warning: Function parameter or member 'qhandle' not described in 'knav_queue_device_control'
       drivers/soc/ti/knav_qmss_queue.c:635: warning: Excess function parameter 'data' description in 'knav_queue_push'
       drivers/soc/ti/knav_qmss_queue.c:635: warning: Excess function parameter 'qh' description in 'knav_queue_push'
       drivers/soc/ti/knav_qmss_queue.c:635: warning: Function parameter or member 'dma' not described in 'knav_queue_push'
       drivers/soc/ti/knav_qmss_queue.c:635: warning: Function parameter or member 'flags' not described in 'knav_queue_push'
       drivers/soc/ti/knav_qmss_queue.c:635: warning: Function parameter or member 'qhandle' not described in 'knav_queue_push'
       drivers/soc/ti/knav_qmss_queue.c:635: warning: Function parameter or member 'size' not described in 'knav_queue_push'
       drivers/soc/ti/knav_qmss_queue.c:655: warning: Excess function parameter 'qh' description in 'knav_queue_pop'
       drivers/soc/ti/knav_qmss_queue.c:655: warning: Function parameter or member 'qhandle' not described in 'knav_queue_pop'
       drivers/soc/ti/knav_qmss_queue.c:655: warning: Function parameter or member 'size' not described in 'knav_queue_pop'
       drivers/soc/ti/knav_qmss_queue.c:759: warning: Function parameter or member 'name' not described in 'knav_pool_create'
       drivers/soc/ti/knav_qmss_queue.c:759: warning: Function parameter or member 'num_desc' not described in 'knav_pool_create'
       drivers/soc/ti/knav_qmss_queue.c:759: warning: Function parameter or member 'region_id' not described in 'knav_pool_create'
       drivers/soc/ti/knav_qmss_queue.c:862: warning: Excess function parameter 'pool' description in 'knav_pool_destroy'
       drivers/soc/ti/knav_qmss_queue.c:862: warning: Function parameter or member 'ph' not described in 'knav_pool_destroy'
       drivers/soc/ti/knav_qmss_queue.c:892: warning: Excess function parameter 'pool' description in 'knav_pool_desc_get'
       drivers/soc/ti/knav_qmss_queue.c:892: warning: Function parameter or member 'ph' not described in 'knav_pool_desc_get'
       drivers/soc/ti/knav_qmss_queue.c:911: warning: Excess function parameter 'pool' description in 'knav_pool_desc_put'
       drivers/soc/ti/knav_qmss_queue.c:911: warning: Function parameter or member 'desc' not described in 'knav_pool_desc_put'
       drivers/soc/ti/knav_qmss_queue.c:911: warning: Function parameter or member 'ph' not described in 'knav_pool_desc_put'
       drivers/soc/ti/knav_qmss_queue.c:931: warning: Excess function parameter 'pool' description in 'knav_pool_desc_map'
       drivers/soc/ti/knav_qmss_queue.c:931: warning: Function parameter or member 'desc' not described in 'knav_pool_desc_map'
       drivers/soc/ti/knav_qmss_queue.c:931: warning: Function parameter or member 'dma' not described in 'knav_pool_desc_map'
       drivers/soc/ti/knav_qmss_queue.c:931: warning: Function parameter or member 'dma_sz' not described in 'knav_pool_desc_map'
       drivers/soc/ti/knav_qmss_queue.c:931: warning: Function parameter or member 'ph' not described in 'knav_pool_desc_map'
       drivers/soc/ti/knav_qmss_queue.c:931: warning: Function parameter or member 'size' not described in 'knav_pool_desc_map'
       drivers/soc/ti/knav_qmss_queue.c:956: warning: Excess function parameter 'pool' description in 'knav_pool_desc_unmap'
       drivers/soc/ti/knav_qmss_queue.c:956: warning: Function parameter or member 'dma' not described in 'knav_pool_desc_unmap'
       drivers/soc/ti/knav_qmss_queue.c:956: warning: Function parameter or member 'dma_sz' not described in 'knav_pool_desc_unmap'
       drivers/soc/ti/knav_qmss_queue.c:956: warning: Function parameter or member 'ph' not described in 'knav_pool_desc_unmap'
       drivers/soc/ti/knav_qmss_queue.c:975: warning: Excess function parameter 'pool' description in 'knav_pool_count'
       drivers/soc/ti/knav_qmss_queue.c:975: warning: Function parameter or member 'ph' not described in 'knav_pool_count'
      
      Cc: Santosh Shilimkar <ssantosh@kernel.org>
      Cc: Sandeep Nair <sandeep_n@ti.com>
      Cc: Cyril Chemparathy <cyril@ti.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
      e8ebf411
    • Lee Jones's avatar
      soc: ti: knav_qmss_queue: Remove set but unchecked variable 'ret' · e7250109
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/soc/ti/knav_qmss_queue.c: In function ‘knav_setup_queue_pools’:
       drivers/soc/ti/knav_qmss_queue.c:1310:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
      
      Cc: Santosh Shilimkar <ssantosh@kernel.org>
      Cc: Sandeep Nair <sandeep_n@ti.com>
      Cc: Cyril Chemparathy <cyril@ti.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
      e7250109
    • Tony Lindgren's avatar
      soc: ti: omap-prm: Do not check rstst bit on deassert if already deasserted · fd79aebe
      Tony Lindgren authored
      If a rstctrl reset bit is already deasserted, we can just bail out early
      not wait for rstst to clear. Otherwise we can have deassert fail for
      already deasserted resets.
      
      Fixes: c5117a78 ("soc: ti: omap-prm: poll for reset complete during de-assert")
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
      fd79aebe
    • Zhang Qilong's avatar
      soc: ti: knav_qmss: fix reference leak in knav_queue_probe · ec868484
      Zhang Qilong authored
      pm_runtime_get_sync will increment pm usage counter even it
      failed. Forgetting to pm_runtime_put_noidle will result in
      reference leak in knav_queue_probe, so we should fix it.
      
      Fixes: 41f93af9 ("soc: ti: add Keystone Navigator QMSS driver")
      Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
      Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
      ec868484
  5. 18 Nov, 2020 4 commits