- 09 Mar, 2014 16 commits
-
-
Peng Tao authored
Kernel provides isspace(). Cc: Andreas Dilger <andreas.dilger@intel.com> Cc: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
Peng Tao <bergwolf@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Peng Tao authored
cfs_expr_list_print is removed due to no callers. Other internal functions are held unexported. Cc: Andreas Dilger <andreas.dilger@intel.com> Cc: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Peng Tao authored
The only difference against generic strncasecmp() is that cfs_strncasecmp() check NULL pointers and zero length parameter, which all callers have already taken care of. Cc: Andreas Dilger <andreas.dilger@intel.com> Cc: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Peng Tao authored
They are not called by anyone and cause gcc warning: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:609: warning: ‘kiblnd_debug_conn’ defined but not used drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:589: warning: ‘kiblnd_debug_rx’ defined but not used drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:597: warning: ‘kiblnd_debug_tx’ defined but not used Cc: Andreas Dilger <andreas.dilger@intel.com> Cc: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Himangi Saraogi authored
This patch replaces printk with pr_warn as the printk calls are used to display warnings to remove the checkpatch.pl warnings: WARNING: printk() should include KERN_ facility level and then WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... on adding KERN_WARNING message designation. Signed-off-by:
Himangi Saraogi <himangi774@gmail.com> Signed-off-by:
-
Conrad Meyer authored
Minor style cleanup per checkpatch.pl. Signed-off-by:
Conrad Meyer <cse.cem@gmail.com> Signed-off-by:
-
Conrad Meyer authored
Nudge the commenting in this mess a little further from 'bad.' Much of it was incorrectly indented. Another sed cleanup: $ sed -i -e '/\/\*\*\*\*\*\*\*\*\**\//,1d' addi-data/hwdrv_apci1500.c Signed-off-by:
-
Conrad Meyer authored
Brought to you with the help of sed and manual clean-up after. $ sed -i -e 's|printk("\\n|dev_warn(dev->hw_dev,\n\t"|' \ addi-data/hwdrv_apci1500.c Since all of these printk()s were for invalid API inputs and most of them returned -EINVAL, I fixed the rest of them to return -EINVAL as well. Signed-off-by: -
Fred Akers authored
This check is unnecessary because range_table will always be initialized to range_unknown by comedi_device_postconfig() for drivers that do not initialize range_table or range_table_list Signed-off-by:
Fred Akers <knivey@botops.net> Reviewed-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Fred Akers authored
Refactor this function to remove an extra indent level Signed-off-by:
-
Conrad Meyer authored
Rename some very long functions in addi-data/hwdrv_apci1500.c. Signed-off-by:
-
Chase Southwood authored
This patch fixes the register map defines for the counter registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Signed-off-by:
Chase Southwood <chase.southwood@yahoo.com> Reviewed-by:
-
Chase Southwood authored
This patch for fixes the register map defines for the timer registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Signed-off-by:
-
Chase Southwood authored
This patch for fixes the register map defines for the watchdog registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Signed-off-by:
-
Chase Southwood authored
This patch fixes the register map defines for the digital output registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Further, some of the old defines were being used incorrectly in the i_APCI1564_Reset() function. Upon swapping the old defines out for the new ones in this function, their use has been corrected. Signed-off-by:
-
Chase Southwood authored
This patch fixes the register map defines for the digital input registers such that they are all the real offsets to each register, rather than a mix of real offsets and adders to those offsets. Further, some of the old defines were being used incorrectly in the i_APCI1564_Reset() function. Upon swapping the old defines out for the new ones in this function, their use has been corrected. Signed-off-by:
-
- 08 Mar, 2014 9 commits
-
-
Himangi Saraogi authored
Since the argument morefrag is being used as a booleon in the function rtl8180_tx, the type for the argument is changed to booleon in the function definition and declaration. This ensures that the variable morefrag is always in the range 0-1 and overflow dooes not cause errors if it is assigned a value. Also, this improves code readability. Signed-off-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
-
Ana Rey authored
The Documentation/CodingStyle doesn't recommend the use of typedef, and The typedef _ThreeWire is not used in the driver. I delete it. Signed-off-by:
Ana Rey <anarey@gmail.com> Signed-off-by:
-
Ana Rey authored
The Documentation/CodingStyle doesn't recommend the use of typedef, convert this to structure. Signed-off-by:
-
Ana Rey authored
The Documentation/CodingStyle doesn't recommend the use of typedef, convert this to structure. Signed-off-by:
-
Monam Agarwal authored
This patch fixes following sparse warnings: drivers/staging/rtl8192e/rtllib_tx.c:942:45: warning: invalid assignment: += drivers/staging/rtl8192e/rtllib_tx.c:942:45: left side has type unsigned long drivers/staging/rtl8192e/rtllib_tx.c:942:45: right side has type restricted __le16 drivers/staging/rtl8192e/rtllib_tx.c:947:49: warning: invalid assignment: += drivers/staging/rtl8192e/rtllib_tx.c:947:49: left side has type unsigned long drivers/staging/rtl8192e/rtllib_tx.c:947:49: right side has type restricted __le16 Signed-off-by:
Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by:
-
Ana Rey authored
This patch fixes whitespaces as the codingStyle of the kernel recommends. Thus, this patch fixes these errors found by checkpatch.pl in r8180.h ERROR: space required after that close brace '}' ERROR: space required after that ',' (ctx:VxV) ERROR: spaces required around that '==' (ctx:VxV) ERROR: spaces required around that '=' (ctx:VxV) ERROR: space required after that ',' (ctx:VxV) Signed-off-by:
Bob Copeland <me@bobcopeland.com> Signed-off-by:
-
Raluca Oncioiu authored
Remove brackets from single line branches of if statements. Break long lines. Signed-off-by:
Raluca Oncioiu <raluca.oncioiu91@gmail.com> Acked-by:
-
Raluca Oncioiu authored
Break up long lines. Signed-off-by:
-
Himangi Saraogi authored
This patch fixes the following sparse warnings in ieee80211_rx.c: drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:2201:34: warning: cast to restricted __le32 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:2202:34: warning: cast to restricted __le32 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:2203:36: warning: cast to restricted __le32 by changing the annotation in the structure header file for struct ieee80211_probe_response for time_stamp and altering the cast for beacon_interval to le16. Signed-off-by:
-
- 07 Mar, 2014 15 commits
-
-
Himangi Saraogi authored
This patch fixes the following sparse warnings: drivers/staging/rtl8712/rtl871x_cmd.c:471:30: warning: incorrect type in assignment (different base types) drivers/staging/rtl8712/rtl871x_cmd.c:471:30: expected unsigned int [unsigned] [usertype] Length drivers/staging/rtl8712/rtl871x_cmd.c:471:30: got restricted __le32 [usertype] <noident> drivers/staging/rtl8712/rtl871x_cmd.c:472:32: warning: incorrect type in assignment (different base types) drivers/staging/rtl8712/rtl871x_cmd.c:472:32: expected unsigned int [unsigned] [usertype] IELength drivers/staging/rtl8712/rtl871x_cmd.c:472:32: got restricted __le32 [usertype] <noident> drivers/staging/rtl8712/rtl871x_cmd.c:473:39: warning: incorrect type in assignment (different base types) drivers/staging/rtl8712/rtl871x_cmd.c:473:39: expected unsigned int [unsigned] [usertype] SsidLength drivers/staging/rtl8712/rtl871x_cmd.c:473:39: got restricted __le32 [usertype] <noident> Signed-off-by:
-
Himangi Saraogi authored
This patch fixes the checkpatch.pl warning: line over 80 charcters. Signed-off-by:
Sarah Sharp <sarah.a.sharp@linux.intel.com> Signed-off-by:
-
Ebru Akagunduz authored
Fix checkpatch.pl issues with __packed is preferred over __attribute__((packed)) in ft1000_ioctl.h Signed-off-by:
Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by:
-
Monam Agarwal authored
This patch fixes following sparse warnings: drivers/staging/gdm72xx/gdm_wimax.c:543:37: warning: incorrect type in argument 1 (different address spaces) drivers/staging/gdm72xx/gdm_wimax.c:543:37: expected void [noderef] <asn:1>*to drivers/staging/gdm72xx/gdm_wimax.c:543:37: got void *buf drivers/staging/gdm72xx/gdm_wimax.c:566:41: warning: incorrect type in argument 2 (different address spaces) drivers/staging/gdm72xx/gdm_wimax.c:566:41: expected void const [noderef] <asn:1>*from drivers/staging/gdm72xx/gdm_wimax.c:566:41: got void *buf Signed-off-by:
-
Himangi Saraogi authored
This patch fixes the following warning for gdm_wimax.c WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: -
Ebru Akagunduz authored
Fix checkpatch.pl issues with line over 80 characters in wb35rx.c Signed-off-by:
-
Himangi Saraogi authored
This patch moves shared private data kzalloc to managed devm_kzalloc and cleans now unneccessary kfree in probe and remove functions. Signed-off-by:
-
Himangi Saraogi authored
This patch fixes the following Sparse warnings : drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:27:4: warning: symbol 'rsn_authen_cipher_suite' was not declared. Should it be static? drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:352:6: warning: symbol 'ext_ieee80211_send_beacon_wq' was not declared. Should it be static? Signed-off-by:
-
Himangi Saraogi authored
This patch fixes sparse warnings like : (1) drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:331:31: warning: incorrect type in assignment (different base types) drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:331:31: expected unsigned short [unsigned] [usertype] frame_ctl drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:331:31: got restricted __le16 [usertype] <noident> (2) drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:1091:32: warning: incorrect type in assignment (different base types) drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:1091:32: expected restricted __le16 [usertype] duration_id drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:1091:32: got int Signed-off-by:
-
Keerthimai Janarthanan authored
Unnecessary space between function pointer name. Signed-off-by:
Keerthimai Janarthanan <keerthimaipb@gmail.com> Acked-by:
-
Monam Agarwal authored
This patch fixes the following sparse warning in rts51x.c drivers/staging/rts5139/rts51x.c:218:5: warning: symbol 'rts51x_pre_reset' was not declared. Should it be static? drivers/staging/rts5139/rts51x.c:229:5: warning: symbol 'rts51x_post_reset' was not declared. Should it be static? Signed-off-by:
-
Monam Agarwal authored
This patch fixes the following Sparse warnings : formatter_inquiry_str should be static queuecommand_lck should be static Signed-off-by:
-
Georgiana Rodica Chelu authored
This patch fixes the quoted string split across lines in staging/rts5139/ms.c Signed-off-by:
Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> Acked-by:
-
Georgiana Rodica Chelu authored
Remove unnecessary parentheses from staging/rts5208/rtsx_scsi.c Signed-off-by:
-
Monam Agarwal authored
This patch fixes following sparse warning in rts51x_fop.c Warning: incorrect type in assignment Signed-off-by:
-
