1. 10 Jul, 2020 8 commits
    • Lee Jones's avatar
      ASoC: codecs: rt5659: Remove many unused const variables · e57f0e4d
      Lee Jones authored
      Looks as though they've never been used.
      
      Fixes the following W=1 kernel build warning(s):
      
       In file included from  sound/soc/codecs/rt5659.c:25:
       In file included from sound/soc/codecs/rt5659.c:25:
       sound/soc/codecs/rt5659.c:1232:2: warning: ‘rt5659_ad_monor_asrc_enum’ defined but not used [-Wunused-const-variable=]
       1232 | rt5659_ad_monor_asrc_enum, RT5659_ASRC_3, RT5659_AD_MONO_R_T_SFT, 0x7,
       | ^~~~~~~~~~~~~~~~~~~~~~~~~
       include/sound/soc.h:359:24: note: in definition of macro ‘SOC_VALUE_ENUM_DOUBLE_DECL’
       359 | const struct soc_enum name = SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, | ^~~~
       sound/soc/codecs/rt5659.c:1231:8: note: in expansion of macro ‘SOC_VALUE_ENUM_SINGLE_DECL’
       1231 | static SOC_VALUE_ENUM_SINGLE_DECL(
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~
       sound/soc/codecs/rt5659.c:1228:2: warning: ‘rt5659_ad_monol_asrc_enum’ defined but not used [-Wunused-const-variable=]
       1228 | rt5659_ad_monol_asrc_enum, RT5659_ASRC_3, RT5659_AD_MONO_L_T_SFT, 0x7,
       | ^~~~~~~~~~~~~~~~~~~~~~~~~
       include/sound/soc.h:359:24: note: in definition of macro ‘SOC_VALUE_ENUM_DOUBLE_DECL’
       359 | const struct soc_enum name = SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, | ^~~~
       sound/soc/codecs/rt5659.c:1227:8: note: in expansion of macro ‘SOC_VALUE_ENUM_SINGLE_DECL’
       1227 | static SOC_VALUE_ENUM_SINGLE_DECL(
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~
       sound/soc/codecs/rt5659.c:1224:2: warning: ‘rt5659_ad_sto2_asrc_enum’ defined but not used [-Wunused-const-variable=]
       1224 | rt5659_ad_sto2_asrc_enum, RT5659_ASRC_3, RT5659_AD_STO2_T_SFT, 0x7,
       | ^~~~~~~~~~~~~~~~~~~~~~~~
       include/sound/soc.h:359:24: note: in definition of macro ‘SOC_VALUE_ENUM_DOUBLE_DECL’
       359 | const struct soc_enum name = SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, | ^~~~
       sound/soc/codecs/rt5659.c:1223:8: note: in expansion of macro ‘SOC_VALUE_ENUM_SINGLE_DECL’
       1223 | static SOC_VALUE_ENUM_SINGLE_DECL(
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~
       sound/soc/codecs/rt5659.c:1220:2: warning: ‘rt5659_ad_sto1_asrc_enum’ defined but not used [-Wunused-const-variable=]
       1220 | rt5659_ad_sto1_asrc_enum, RT5659_ASRC_2, RT5659_AD_STO1_T_SFT, 0x7,
       | ^~~~~~~~~~~~~~~~~~~~~~~~
       include/sound/soc.h:359:24: note: in definition of macro ‘SOC_VALUE_ENUM_DOUBLE_DECL’
       359 | const struct soc_enum name = SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, | ^~~~
       sound/soc/codecs/rt5659.c:1219:8: note: in expansion of macro ‘SOC_VALUE_ENUM_SINGLE_DECL’
       1219 | static SOC_VALUE_ENUM_SINGLE_DECL(
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~
       sound/soc/codecs/rt5659.c:1216:2: warning: ‘rt5659_da_monor_asrc_enum’ defined but not used [-Wunused-const-variable=]
       1216 | rt5659_da_monor_asrc_enum, RT5659_ASRC_2, RT5659_DA_MONO_R_T_SFT, 0x7,
       | ^~~~~~~~~~~~~~~~~~~~~~~~~
       include/sound/soc.h:359:24: note: in definition of macro ‘SOC_VALUE_ENUM_DOUBLE_DECL’
       359 | const struct soc_enum name = SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, | ^~~~
       sound/soc/codecs/rt5659.c:1215:8: note: in expansion of macro ‘SOC_VALUE_ENUM_SINGLE_DECL’
       1215 | static SOC_VALUE_ENUM_SINGLE_DECL(
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~
       sound/soc/codecs/rt5659.c:1212:2: warning: ‘rt5659_da_monol_asrc_enum’ defined but not used [-Wunused-const-variable=]
       1212 | rt5659_da_monol_asrc_enum, RT5659_ASRC_2, RT5659_DA_MONO_L_T_SFT, 0x7,
       | ^~~~~~~~~~~~~~~~~~~~~~~~~
       include/sound/soc.h:359:24: note: in definition of macro ‘SOC_VALUE_ENUM_DOUBLE_DECL’
       359 | const struct soc_enum name = SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, | ^~~~
       sound/soc/codecs/rt5659.c:1211:8: note: in expansion of macro ‘SOC_VALUE_ENUM_SINGLE_DECL’
       1211 | static SOC_VALUE_ENUM_SINGLE_DECL(
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~
       sound/soc/codecs/rt5659.c:1208:2: warning: ‘rt5659_da_sto_asrc_enum’ defined but not used [-Wunused-const-variable=]
       1208 | rt5659_da_sto_asrc_enum, RT5659_ASRC_2, RT5659_DA_STO_T_SFT, 0x7,
       | ^~~~~~~~~~~~~~~~~~~~~~~
       include/sound/soc.h:359:24: note: in definition of macro ‘SOC_VALUE_ENUM_DOUBLE_DECL’
       359 | const struct soc_enum name = SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, | ^~~~
       sound/soc/codecs/rt5659.c:1207:8: note: in expansion of macro ‘SOC_VALUE_ENUM_SINGLE_DECL’
       1207 | static SOC_VALUE_ENUM_SINGLE_DECL(
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Cc: Oder Chiou <oder_chiou@realtek.com>
      Link: https://lore.kernel.org/r/20200709162328.259586-9-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      e57f0e4d
    • Pierre-Louis Bossart's avatar
      ASoC: codecs: rt5631: fix spurious kernel-doc start and missing arguments · 762a3d43
      Pierre-Louis Bossart authored
      Fixes the following W=1 kernel build warning(s):
      
      sound/soc/codecs/rt5631.c:72: warning: Function parameter or member
      'component' not described in 'rt5631_write_index'
      sound/soc/codecs/rt5631.c:72: warning: Function parameter or member
      'reg' not described in 'rt5631_write_index'
      sound/soc/codecs/rt5631.c:72: warning: Function parameter or member
      'value' not described in 'rt5631_write_index'
      sound/soc/codecs/rt5631.c:82: warning: Function parameter or member
      'component' not described in 'rt5631_read_index'
      sound/soc/codecs/rt5631.c:82: warning: Function parameter or member
      'reg' not described in 'rt5631_read_index'
      sound/soc/codecs/rt5631.c:367: warning: Function parameter or member
      'component' not described in 'onebit_depop_power_stage'
      sound/soc/codecs/rt5631.c:405: warning: Function parameter or member
      'component' not described in 'onebit_depop_mute_stage'
      sound/soc/codecs/rt5631.c:443: warning: Function parameter or member
      'component' not described in 'depop_seq_power_stage'
      sound/soc/codecs/rt5631.c:515: warning: Function parameter or member
       'component' not described in 'depop_seq_mute_stage'
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Link: https://lore.kernel.org/r/20200709162328.259586-8-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      762a3d43
    • Lee Jones's avatar
      ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR' · 79b094c9
      Lee Jones authored
      Looks like these have been unchecked since the driver's inception in 2012.
      
      Fixes the following W=1 kernel build warning(s):
      
      sound/soc/ux500/ux500_msp_i2s.c: In function ‘flush_fifo_rx’:
      sound/soc/ux500/ux500_msp_i2s.c:398:6: warning: variable ‘reg_val_DR’
      set but not used [-Wunused-but-set-variable]
      sound/soc/ux500/ux500_msp_i2s.c: In function ‘flush_fifo_tx’:
      sound/soc/ux500/ux500_msp_i2s.c:415:6: warning: variable
      ‘reg_val_TSTDR’ set but not used [-Wunused-but-set-variable]
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Cc: zhong jiang <zhongjiang@huawei.com>
      Cc: Ola Lilja <ola.o.lilja@stericsson.com>
      Cc: Roger Nilsson <roger.xr.nilsson@stericsson.com>
      Cc: Sandeep Kaushik <sandeep.kaushik@st.com>
      Link: https://lore.kernel.org/r/20200709162328.259586-7-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      79b094c9
    • Lee Jones's avatar
      ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header · 701f4727
      Lee Jones authored
      This is the only use of kerneldoc in the sourcefile and full
      descriptions are not provided.
      
      Fixes the following W=1 kernel build warning(s):
      
      sound/soc/pxa/pxa-ssp.c:186: warning: Function parameter or member
      'ssp' not described in 'pxa_ssp_set_scr'
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Cc: Daniel Mack <daniel@zonque.org>
      Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
      Cc: Robert Jarzmik <robert.jarzmik@free.fr>
      Link: https://lore.kernel.org/r/20200709162328.259586-6-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      701f4727
    • Lee Jones's avatar
      ASoC: sunxi: sun4i-spdif: Fix misspelling of 'reg_dac_txdata' in kernel-doc · c7202a19
      Lee Jones authored
      Property name descriptions need to match exactly.
      
      Fixes the following W=1 kernel build warning(s):
      
      sound/soc/sunxi/sun4i-spdif.c:178: warning: Function parameter or
      member 'reg_dac_txdata' not described in 'sun4i_spdif_quirks'
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Cc: Maxime Ripard <mripard@kernel.org>
      Cc: Chen-Yu Tsai <wens@csie.org>
      Cc: Philipp Zabel <p.zabel@pengutronix.de>
      Cc: Andrea Venturi <be17068@iperbole.bo.it>
      Cc: Marcus Cooper <codekipper@gmail.com>
      Link: https://lore.kernel.org/r/20200709162328.259586-5-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      c7202a19
    • Pierre-Louis Bossart's avatar
      ASoC: sunxi: sun4i-i2s: add missing clock and format arguments in kernel-doc · 643e305e
      Pierre-Louis Bossart authored
      Fix W=1 warnings - missing fields in description
      
      sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or
       member 'bclk_dividers' not described in 'sun4i_i2s_quirks'
      sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member
      'num_bclk_dividers' not described in 'sun4i_i2s_quirks'
      sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member
      'mclk_dividers' not described in 'sun4i_i2s_quirks'
      sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member
      'num_mclk_dividers' not described in 'sun4i_i2s_quirks'
      sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member
      'get_bclk_parent_rate' not described in 'sun4i_i2s_quirks'
      sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member
      'get_sr' not described in 'sun4i_i2s_quirks'
      sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member
      'get_wss' not described in 'sun4i_i2s_quirks'
      sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member
      'set_chan_cfg' not described in 'sun4i_i2s_quirks'
      sound/soc/sunxi/sun4i-i2s.c:160: warning: Function parameter or member
      'set_fmt' not described in 'sun4i_i2s_quirks'
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Cc: Maxime Ripard <mripard@kernel.org>
      Cc: Chen-Yu Tsai <wens@csie.org>
      Cc: Philipp Zabel <p.zabel@pengutronix.de>
      Cc: Andrea Venturi <be17068@iperbole.bo.it>
      Link: https://lore.kernel.org/r/20200709162328.259586-4-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      643e305e
    • Pierre-Louis Bossart's avatar
      ASoC: qcom: qdsp6: q6asm: Provide documentation for 'codec_profile' · d4633504
      Pierre-Louis Bossart authored
      Fixes the following W=1 kernel build warning(s):
      
      sound/soc/qcom/qdsp6/q6asm.c:924: warning: Function parameter or
      member 'codec_profile' not described in 'q6asm_open_write'
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Cc: Patrick Lai <plai@codeaurora.org>
      Cc: Banajit Goswami <bgoswami@codeaurora.org>
      Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
      Cc: Vinod Koul <vkoul@kernel.org>
      Link: https://lore.kernel.org/r/20200709162328.259586-3-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      d4633504
    • Pierre-Louis Bossart's avatar
      ASoC: sti: uniperif: fix 'defined by not used' warning · 97d73032
      Pierre-Louis Bossart authored
      Fix W=1 warning. The table uni_tdm_hw is declared in a header included
      by multiple C file. This isn't really a good practice but for now
      using __maybe_unused makes the following warning go away.
      
      sound/soc/sti/sti_uniperif.c:12:
      sound/soc/sti/uniperif.h:1351:38: warning: ‘uni_tdm_hw’ defined but
      not used [-Wunused-const-variable=]
       1351 | static const struct snd_pcm_hardware uni_tdm_hw = {
            |                                      ^~~~~~~~~~
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Acked-by: default avatarArnaud Pouliquen <arnaud.pouliquen@st.com>
      Link: https://lore.kernel.org/r/20200709162328.259586-2-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      97d73032
  2. 08 Jul, 2020 14 commits
  3. 07 Jul, 2020 12 commits
  4. 06 Jul, 2020 1 commit
  5. 03 Jul, 2020 5 commits