- 18 Mar, 2014 5 commits
-
-
Andreea-Cristina Bernat authored
This patch solves the sparse warning: "symbol 'ieee80211_ccmp_aes_encrypt' was not declared. Should it be static?" Signed-off-by:
Andreea-Cristina Bernat <bernat.ada@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Himangi Saraogi authored
This patch fixes the following sparse warning in r8180_core.c - warning: restricted __le16 degrades to integer. Also, the variable morefrag is changed to bool as it is being used as a bool. Signed-off-by:
Himangi Saraogi <himangi774@gmail.com> Reviewed-by:
Bob Copeland <me@bobcopeland.com> Signed-off-by:
-
Aybuke Ozdemir authored
This patch fixes these errors and warning messages found by checkpatch.pl: ERROR: return is not a function, parentheses are not required. WARNING: space prohibited before semicolon. Signed-off-by:
Aybuke Ozdemir <aybuke.147@gmail.com> Acked-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
-
Aybuke Ozdemir authored
The patch fixes the following checkpatch.pl warnings: WARNING: Unnecessary space after function pointer name. Signed-off-by:
-
Monam Agarwal authored
This patch fixes following smatch warnings: /drivers/staging/iio/light/tsl2583.c:436 taos_chip_on() info: why not propagate 'ret' from i2c_smbus_write_byte_data() instead of (-1)? /drivers/staging/iio/light/tsl2583.c:448 taos_chip_on() info: why not propagate 'ret' from i2c_smbus_write_byte_data() instead of (-1)? /drivers/staging/iio/light/tsl2583.c:461 taos_chip_on() info: why not propagate 'ret' from i2c_smbus_write_byte_data() instead of (-1)? Signed-off-by:
Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by:
-
- 17 Mar, 2014 35 commits
-
-
Chi Pham authored
Coccinelle was used for this patch. The script is not complete (semantically) and might raise some checkpatch warnings in terms of indentation depending on existing code. *** IFASSIGNMENT.COCCI START *** /* Coccinelle script to handle assignments in if statements * For compound statements, can so far only handle statements with the * assignment on either extreme */ /* This rule is for simple cases * e.g. just an assignment in if, possibly with unary operator */ @simple@ expression E1, E2; statement S1, S2; @@ + E1 = E2; if ( - (E1 = E2) + E1 ) S1 else S2 /* This rule is for compound statements where the assignment is on the right.*/ @right@ expression E, E1, E2; statement S1, S2; @@ ( /* and */ - if (E && (E1 = E2)) + if (E) { + E1 = E2; + if (E1) S1 else S2 + } else S2 | - if (E && (E1 = E2)) + if (E) { + E1 = E2; + if (E1) S1 + } /* or */ | - if (E || (E1 = E2)) + if (!E) { + E1 = E2; + if (E1) S1 else S2 + } + else S1 | - if (E || (E1 = E2)) + if (!E) { + E1 = E2; + if (E1) S1 + } else S1 /* not equal */ | - if (E != (E1 = E2)) + E1 = E2; + if (E != E1) S1 else S2 | - if (E != (E1 = E2)) + E1 = E2; + if (E != E1) S1 /* equal */ | - if (E == (E1 = E2)) + E1 = E2; + if (E == E1) S1 else S2 | - if (E == (E1 = E2)) + E1 = E2; + if (E == E1) S1 /* greater than */ | - if (E > (E1 = E2)) + E1 = E2; + if (E > E1) S1 else S2 | - if (E > (E1 = E2)) + E1 = E2; + if (E > E1) S1 /* less than */ | - if (E < (E1 = E2)) + E1 = E2; + if (E < E1) S1 else S2 | - if (E < (E1 = E2)) + E1 = E2; + if (E < E1) S1 /* lesser than or equal to */ | - if (E <= (E1 = E2)) + E1 = E2; + if (E <= E1) S1 else S2 | - if (E <= (E1 = E2)) + E1 = E2; + if (E <= E1) S1 /* greater than or equal to */ | - if (E >= (E1 = E2)) + E1 = E2; + if (E >= E1) S1 else S2 | - if (E >= (E1 = E2)) + E1 = E2; + if (E >= E1) S1 ) /* This rule is for compound statements where the assignment is on the left.*/ @left@ expression E, E1, E2; statement S1, S2; @@ ( /* and */ - if ((E1 = E2) && E) + E1 = E2; + if (E1 && E) S1 else S2 | - if ((E1 = E2) && E) + E1 = E2; + if (E1 && E) S1 | /* or */ - if ((E1 = E2) || E) + E1 = E2; + if (E1 || E) S1 | - if ((E1 = E2) || E) + E1 = E2; + if (E1 || E) S1 else S2 | /* not equal */ - if ((E1 = E2) != E) + E1 = E2; + if (E1 != E) S1 | - if ((E1 = E2) != E) + E1 = E2; + if (E1 != E) S1 else S2 | /* equal */ - if ((E1 = E2) == E) + E1 = E2; + if (E1 == E) S1 | - if ((E1 = E2) == E) + E1 = E2; + if (E1 == E) S1 else S2 | /* greater */ - if ((E1 = E2) > E) + E1 = E2; + if (E1 > E) S1 | - if ((E1 = E2) > E) + E1 = E2; + if (E1 > E) S1 else S2 | /* less */ - if ((E1 = E2) < E) + E1 = E2; + if (E1 < E) S1 | - if ((E1 = E2) < E) + E1 = E2; + if (E1 < E) S1 else S2 /* lesser than or equal to */ - if ((E1 = E2) <= E) + E1 = E2; + if (E1 <= E) S1 | - if ((E1 = E2) <= E) + E1 = E2; + if (E1 <= E) S1 else S2 /* greater than or equal to */ - if ((E1 = E2) >= E) + E1 = E2; + if (E1 >= E) S1 | - if ((E1 = E2) >= E) + E1 = E2; + if (E1 >= E) S1 else S2 ) *** IFASSIGNMENT.COCCI END *** Signed-off-by:Chi Pham <fempsci@gmail.com> Signed-off-by:
-
Georgiana Rodica Chelu authored
This patch fixes coding style issue: removing the whitespace Signed-off-by:
Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> Signed-off-by:
-
Daniel Ngu authored
Line over 80 characters Signed-off-by:
Daniel Ngu <daniel.dy.ngu@gmail.com> Signed-off-by:
-
Daniel Ngu authored
Line over 80 characters Signed-off-by:
-
Malcolm Priestley authored
Stable kernels will need patches staging: vt6656: s_nsInterruptUsbIoCompleteRead remove usb_fill_bulk_urb staging: vt6656: PIPEnsInterruptRead use usb_fill_int_urb and a backported version of this patch. Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by:
-
Fengguang Wu authored
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:8030:3-9: Replace memcpy with struct assignment Generated by: coccinelle/misc/memcpy-assign.cocci Signed-off-by:
Fengguang Wu <fengguang.wu@intel.com> Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Jérôme Pinot authored
This fixes the following issues detected by checkpatch.pl: WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) #220: FILE: drivers/staging/ozwpan/ozcdev.c:220: + memcpy(g_cdev.active_addr, addr, ETH_ALEN); WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) #286: FILE: drivers/staging/ozwpan/ozcdev.c:286: + memcpy(addr, g_cdev.active_addr, ETH_ALEN); WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) #176: FILE: drivers/staging/ozwpan/ozpd.c:176: + memcpy(pd->mac_addr, mac_addr, ETH_ALEN); Signed-off-by:
Jerome Pinot <ngc891@gmail.com> Signed-off-by:
-
Ken Cox authored
Clean up code to get rid of sparse warnings. Also fixed variable length arrays declared on the stack by removing visor_hexDumpToBuffer() and using hex_dump_to_buffer() instead. Signed-off-by:
Ken Cox <jkc@redhat.com> Signed-off-by:
-
Ken Cox authored
Clean up code to get rid of sparse warnings due to accessing I/O space. Also declared functions and variables as static if they are only used locally. Signed-off-by:
-
Ken Cox authored
Clean up code to get rid of sparse warnings, mostly due to accessing I/O space. Remove visorchannel_get_safe_queue(), visorchannel_safesignalremove(), and visorchannel_safesignalinsert() since they were not called from anywhere. Signed-off-by:
-
Ken Cox authored
Clean up code to get rid of sparse warnings, mostly related to accessing I/O space. Remove uislibcmpxchg64() and use cmpxchg() instead. Signed-off-by:
-
Ken Cox authored
Cleaned up multiple sparse warnings, mostly due to improper access of I/O space. Also declared functions and variables that were only used locally as static. Removed ULTRA_disp_channel_header(), ULTRA_disp_channel(), ULTRA_disp_vnic_channel() because they were never called. Signed-off-by:
-
Ken Cox authored
Clean up multiple sparse warnings mostly due to different address spaces when accessing I/O memory. Also, remove SignalRemoveAll(), SignalQueueHasOneElement(), SignalQueueIsFull(), because they were never called. Signed-off-by:
-
Daeseok Youn authored
The queue_delayed_work() return false if the work is already on the queue, true otherwise. So return value cannot be less than zero. Signed-off-by:
Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by:
-
Daeseok Youn authored
It doesn't need to use while loop for getting newrate, because it always breaks out the end of while loop with "break". So just replace while with if. And the type of newrate is "unsigned int", this type is never less than zero. If it can be set to negative value by user application with ioctl(), it is not zero but it can be a unexpected value for setting custom baudrate. Also smatch says: drivers/staging/dgnc/dgnc_tty.c:967 dgnc_set_custom_speed() warn: unsigned 'newrate' is never less than zero. drivers/staging/dgnc/dgnc_tty.c:981 dgnc_set_custom_speed() info: ignoring unreachable code. Signed-off-by:
-
Mark Hounschell authored
This patch adds a pr_info per board that indicates board number, type, etc.. Signed-off-by:
Mark Hounschell <markh@compro.net> Signed-off-by:
-
Mark Hounschell authored
This patch removes more unneeded brd-state states Signed-off-by:
-
Mark Hounschell authored
This patch removes unused brd->state states previously used in the userland firmware download process. Signed-off-by:
-
Mark Hounschell authored
The only driver states we need now is READY or !READY. No need for a sysfs method of seeing those 2 states so the sysfs entries for dgap_driver_state is also removed. Signed-off-by:
-
Mark Hounschell authored
This patch gets rid of the DGAP_SPINLOCK_INIT macro Signed-off-by:
-
Mark Hounschell authored
This patch removes the unused DGAP_TRYLOCK macro Signed-off-by:
-
Mark Hounschell authored
This patch removes more unneeded code that was supporting the old firmware loading process Signed-off-by:
-
Mark Hounschell authored
This patch removes some unused defines in dgap.h Signed-off-by:
-
Mark Hounschell authored
This patch fixes a few more 80+ char lines as reported by checkpatch Signed-off-by:
-
Mark Hounschell authored
This patch fixes a few more 80+ char lines as reported by checkpatch Signed-off-by:
-
Mark Hounschell authored
This patch fixes a few 80+ char lines as reported by checkpatch Signed-off-by:
-
Malcolm Priestley authored
As result of patch staging: vt6656: [BUG] Fix Warning BOGUS urb xfer, pipe 3 != type 1 has resulted in sluggish TX performance due to interupt inverval being too long. Set int_interval to 1 as set in bInterval of endpoint 1. Signed-off-by:
-
Gary Rookard authored
unsplit strings from two lines to one. Changes resulted in line over 80 characters warning. Leaving the latter of the two warnings for possible string grepping reasons. Signed-off-by:
Gary Alan Rookard <garyrookard@gmail.com> Signed-off-by:
-
Gary Rookard authored
fixed up a spacing issue. Signed-off-by:
-
Gary Rookard authored
unsplit string from two lines to one. Signed-off-by:
-
Gary Rookard authored
unsplit strings from two lines to one. Signed-off-by:
-
Daeseok Youn authored
The banner array doens't need to set to 0. sprintf() adds a terminating '\0'. And the sn array can be declared and initialized to zero. So remove redundant memset() with zero. Remove unnecessary cast for memcpy(). Signed-off-by:
-
Daeseok Youn authored
The name array doens't need to set to 0. Because sprintf/snprintf adds a terminating '\0'. And also it doesn't need to assign name array address to np pointer. Signed-off-by:
-
Monam Agarwal authored
This patch moves the macro "SLIC_GET_SLIC_HANDLE(_adapter, _pslic_handle)" to inline in slicoss.c since it has been used only once. Signed-off-by:
-
H Hartley Sweeten authored
This driver is _really_ broken. It initializes an analog input subdevice that only has a (*cancel) function. It also does a request_irq() to hookup an interrupt handler using it->options[0] as the IRQ. This option is actually the base address of the I/O region used by the board. If the interrupt handler actually did get hooked up, the rest of the code assumes that IRQ 10 is being used. Rewrite the driver to properly support the hardware. The DAS6402-12/16 boards have 64 single-ended / 32 differential analog inputs, 2 analog outputs, 8 digital inputs, and 8 digital outputs. Add proper support for these subdevices. Stub in the analog input async command support. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
