- 10 May, 2021 40 commits
-
-
Andy Shevchenko authored
The infamous commit c440eee1 ("Staging: staging: fbtft: Switch to the GPIO descriptor interface") broke GPIO handling completely. It has already four commits to rectify and it seems not enough. In order to fix the mess here we: 1) Set default to "inactive" for all requested pins 2) Fix CS#, RD#, and WR# pins polarity since it's active low and GPIO descriptor interface takes it into consideration from the Device Tree or ACPI 3) Consolidate chip activation (CS# assertion) under default ->reset() callback To summarize the expectations about polarity for GPIOs: RD# Low WR# Low CS# Low RESET# Low DC or RS High RW High Data 0 .. 15 High See also Adafruit learning course [1] for the example of the schematics. While at it, drop unneeded NULL checks, since GPIO API is tolerant to that. [1]: https://learn.adafruit.com/adafruit-2-8-and-3-2-color-tft-touchscreen-breakout-v2/downloads Fixes: 92e3e884 ("Staging: fbtft: Fix GPIO handling") Fixes: b918d1c2 ("Staging: fbtft: Fix reset assertion when using gpio descriptor") Fixes: dbc4f989 ("Staging: fbtft: Fix probing of gpio descriptor") Fixes: c440eee1 ("Staging: fbtft: Switch to the gpio descriptor interface") Cc: Jan Sebastian Götte <linux@jaseg.net> Cc: Nishad Kamdar <nishadkamdar@gmail.com> Reviewed-by:
Phil Reid <preid@electromag.com.au> Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20210503172114.27891-2-andriy.shevchenko@linux.intel.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Fabio Aiuto authored
remove obsolete odm_debug.h header file. Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Fabio Aiuto <fabioaiuto83@gmail.com> Link: https://lore.kernel.org/r/58f3ed0c7706fdb33614d3e38ed802d56d77f0ec.1619794331.git.fabioaiuto83@gmail.comSigned-off-by:
-
Fabio Aiuto authored
remove DebugLevel in dm_odm_t struct, remove private debug level tracing. remove unused variable as well to suppress compiler warning. Reviewed-by:
-
Fabio Aiuto authored
remove DebugComponent in dm_odm_t struct, remove private debug component tracing. Reviewed-by:
-
Fabio Aiuto authored
remove file left empty after function deletion. remove related target in Makefile. Reviewed-by:
-
Fabio Aiuto authored
remove ODM_InitDebugSetting() function. It was intended to initialize removed private debug system. So remove it. Reviewed-by:
-
Fabio Aiuto authored
remove unused RT_DISP macro definition. Reviewed-by:
-
Fabio Aiuto authored
remove commented out ODM_RT_DISP and RT_DISP logs. Reviewed-by:
-
Fabio Aiuto authored
remove unused DbgPrint macro definition. Reviewed-by:
-
Fabio Aiuto authored
remove commented out DbgPrint logs. Reviewed-by:
-
Fabio Aiuto authored
remove obsolete debug macros. Reviewed-by:
-
Fabio Aiuto authored
remove unused enum. Reviewed-by:
-
Fabio Aiuto authored
remove obsolete GLBtcDbgType declarations for it was intended for private debug facilities. Reviewed-by:
-
Fabio Aiuto authored
halbtcoutsrc_DbgInit() static function was intended for manual activation of private tracing facilities. So remove it. Reviewed-by:
-
Fabio Aiuto authored
remove unused hal_btcoex_GetDBG() function definition and prototype. Reviewed-by:
-
Fabio Aiuto authored
remove unused hal_btcoex_SetDBG() function definition and prototype. Reviewed-by:
-
Fabio Aiuto authored
remove empty #ifdef block. Reviewed-by:
-
Fabio Aiuto authored
remove unused BTC_PRINT_F macro definition. Reviewed-by:
-
Fabio Aiuto authored
remove unused BTC_PRINT_DATA definitions. Reviewed-by:
-
Fabio Aiuto authored
remove unused BTC_PRINT_ADDR macro definitions. Reviewed-by:
-
Fabio Aiuto authored
remove unused BTC_PRINT macro definitions. Reviewed-by:
-
Fabio Aiuto authored
remove commented out BTC_PRINT logs. Reviewed-by:
-
Fabio Aiuto authored
fix following post-commit hook checkatch issue: WARNING: braces {} are not necessary for single statement blocks 21: FILE: drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c:609: + if (!bBtHsOn) { algorithm = BT_8723B_1ANT_COEX_ALGO_PANEDR_HID; } Reviewed-by: -
Fabio Aiuto authored
remove if-else blocks left empty after BTC_PRINT removal. Reviewed-by:
-
Fabio Aiuto authored
Remove BTC_PRINT logs. BTC_PRINT macro's default behavoiur is _do nothing_. It's enabled by uncommenting some code in hal/hal_btcoex.c file. So just remove it. Applied following semantic patch: @@ @@ - BTC_PRINT(...); Reviewed-by:
-
Fabio Aiuto authored
remove unused RT_PRINTK macro definition. Reviewed-by:
-
Fabio Aiuto authored
remove commented out obsoete RT_ASSERT macro occurences. Reviewed-by:
-
Fabio Aiuto authored
remove empty ifndef block. Reviewed-by:
-
Fabio Aiuto authored
remove unused do nothing ASSERT macro definition. Reviewed-by:
-
Fabio Aiuto authored
remove empty ifdef block Reviewed-by:
-
Fabio Aiuto authored
remove unused ODM_dbg_exit macro definition. Reviewed-by:
-
Fabio Aiuto authored
remove unused ODM_dbg_enter macro definition. Reviewed-by:
-
Fabio Aiuto authored
remove unused ODM_dbg_trace macro definitions. Reviewed-by:
-
Fabio Aiuto authored
remove unused ODM_PRINT_ADDR macro definitions. Reviewed-by:
-
Fabio Aiuto authored
remove unused ODM_RT_ASSERT macro declarations. Reviewed-by:
-
Fabio Aiuto authored
replace ODM_RT_ASSERT with netdev dbg. Marco ODM_RT_ASSERT wraps a raw prink and prints a message everytime second argument is false. This occurrence prints always, so replace it with netdev_dbg() Reviewed-by:
-
Fabio Aiuto authored
remove all commented out ODM_RT_TRACE logs. Reviewed-by:
-
Fabio Aiuto authored
remove unused ODM_RT_TRACE* macro defs. Reviewed-by:
-
Fabio Aiuto authored
remove empty header file. Reviewed-by:
-
Fabio Aiuto authored
remove undefined function prototypes. Reviewed-by:
-
