1. 04 Sep, 2013 4 commits
    • NeilBrown's avatar
      NFSv4: Don't try to recover NFSv4 locks when they are lost. · ef1820f9
      NeilBrown authored
      When an NFSv4 client loses contact with the server it can lose any
      locks that it holds.
      
      Currently when it reconnects to the server it simply tries to reclaim
      those locks.  This might succeed even though some other client has
      held and released a lock in the mean time.  So the first client might
      think the file is unchanged, but it isn't.  This isn't good.
      
      If, when recovery happens, the locks cannot be claimed because some
      other client still holds the lock, then we get a message in the kernel
      logs, but the client can still write.  So two clients can both think
      they have a lock and can both write at the same time.  This is equally
      not good.
      
      There was a patch a while ago
        http://comments.gmane.org/gmane.linux.nfs/41917
      
      which tried to address some of this, but it didn't seem to go
      anywhere.  That patch would also send a signal to the process.  That
      might be useful but for now this patch just causes writes to fail.
      
      For NFSv4 (unlike v2/v3) there is a strong link between the lock and
      the write request so we can fairly easily fail any IO of the lock is
      gone.  While some applications might not expect this, it is still
      safer than allowing the write to succeed.
      
      Because this is a fairly big change in behaviour a module parameter,
      "recover_locks", is introduced which defaults to true (the current
      behaviour) but can be set to "false" to tell the client not to try to
      recover things that were lost.
      Signed-off-by: default avatarNeilBrown <neilb@suse.de>
      Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
      ef1820f9
    • Trond Myklebust's avatar
      SUNRPC: Add tracepoints to help debug socket connection issues · 40b5ea0c
      Trond Myklebust authored
      Add client side debugging to help trace socket connection/disconnection
      and unexpected state change issues.
      Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
      40b5ea0c
    • Chuck Lever's avatar
      NFS: Fix warning introduced by NFSv4.0 transport blocking patches · b6a85258
      Chuck Lever authored
      When CONFIG_NFS_V4_1 is not enabled, gcc emits this warning:
      
      linux/fs/nfs/nfs4state.c:255:12: warning:
       ‘nfs4_begin_drain_session’ defined but not used [-Wunused-function]
       static int nfs4_begin_drain_session(struct nfs_client *clp)
                  ^
      
      Eventually NFSv4.0 migration recovery will invoke this function, but
      that has not yet been merged.  Hide nfs4_begin_drain_session()
      behind CONFIG_NFS_V4_1 for now.
      Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
      Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
      b6a85258
    • Chuck Lever's avatar
      When CONFIG_NFS_V4_1 is not enabled, "make C=2" emits this warning: · 1cec16ab
      Chuck Lever authored
      linux/fs/nfs/nfs4session.c:337:6: warning:
       symbol 'nfs41_set_target_slotid' was not declared. Should it be static?
      
      Move nfs41_set_target_slotid() and nfs41_update_target_slotid() back
      behind CONFIG_NFS_V4_1, since, in the final revision of this work,
      they are used only in NFSv4.1 and later.
      Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
      Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
      1cec16ab
  2. 03 Sep, 2013 21 commits
  3. 02 Sep, 2013 2 commits
  4. 01 Sep, 2013 6 commits
  5. 30 Aug, 2013 7 commits