- 14 Dec, 2017 7 commits
-
-
Akinobu Mita authored
When iterating through all endpoints using of_graph_get_next_endpoint(), the refcount of the returned endpoint node is incremented and the refcount of the node which is passed as previous endpoint is decremented. So the caller doesn't need to call of_node_put() for each iterated node except for error exit paths. Otherwise we get "OF: ERROR: Bad of_node_put() on ..." messages. Cc: Hyun Kwon <hyun.kwon@xilinx.com> Signed-off-by:
Akinobu Mita <akinobu.mita@gmail.com> Reviewed-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by:
Mauro Carvalho Chehab <mchehab@s-opensource.com>
-
Christophe JAILLET authored
This is odd to call 'pci_disable_device()' in an error path before a coresponding successful 'pci_enable_device()'. Return directly instead. Fixes: 77e0be12 ("V4L/DVB (4176): Bug-fix: Fix memory overflow") Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by:
-
Colin Ian King authored
Currently a user can pass in an unsanitized slot number which will lead to and out of range index into ca->slot_info. Fix this by checking that the slot number is no more than the allowed maximum number of slots. Seems that this bug has been in the driver forever. Detected by CoverityScan, CID#139381 ("Untrusted pointer read") Signed-off-by:Colin Ian King <colin.king@canonical.com> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
Jasmin Jessich <jasmin@anw.at> Signed-off-by:
-
Gustavo A. R. Silva authored
Add suffix ULL to constant 65535 in order to avoid a potential integer overflow. This constant is used in a context that expects an expression of type u64. Addresses-Coverity-ID: 1056806 Signed-off-by:
Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by:
-
Stefan Brüns authored
Mygica T230 DVB-T/T2/C USB stick support. It uses the same FX2/Si2168 bridge/demodulator combo as the other devices supported by the driver, but uses the Si2141 tuner. Several DVB-T (MPEG2) and DVB-T2 (H.265) channels were tested, as well as the included remote control. Signed-off-by:
Stefan Brüns <stefan.bruens@rwth-aachen.de> Signed-off-by:
-
Dmitry Osipenko authored
NVIDIA Tegra20/30/114/124/132 SoC's have video decoder engine that supports standard set of video formats like H.264 / MPEG-4 / WMV / VC1. Signed-off-by:
Dmitry Osipenko <digetx@gmail.com> Signed-off-by:
Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by:
-
Dmitry Osipenko authored
Add binding documentation for the Video Decoder Engine which is found on NVIDIA Tegra20/30/114/124/132 SoC's. Signed-off-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
- 13 Dec, 2017 23 commits
-
-
Daniel Scheller authored
This change makes sure that demod frontends are always detached whenever a tuner frontend attach failed. Achieve this by moving the detach-on- failure logic at the end of dvb_input_attach(), and adding a goto to this block on every tuner attach failure case, so if an error occurs, there are no stray attached frontends left. As a side effect, this removes some duplicated code. Signed-off-by:
Daniel Scheller <d.scheller@gmx.net> Signed-off-by:
-
Pravin Shedge authored
These duplicate includes have been found with scripts/checkincludes.pl but they have been removed manually to avoid removing false positives. Signed-off-by:
Pravin Shedge <pravin.shedge4linux@gmail.com> Signed-off-by:
-
Benjamin Gaignard authored
Add SPDX identifiers to files under sti directory Signed-off-by:
Benjamin Gaignard <benjamin.gaignard@st.com> Reviewed-by:
Fabien Dessenne <fabien.dessenne@st.com> Acked-by:
Philippe Ombredanne <pombredanne@nexb.com> Acked-by:
Hugues Fruchet <hugues.fruchet@st.com> Signed-off-by:
-
Jaedon Shin authored
The dtv_properties structure and the dtv_property structure are different sizes in 32-bit and 64-bit system. This patch provides FE_SET_PROPERTY and FE_GET_PROPERTY ioctl commands implementation for 32-bit user space applications. Signed-off-by:
Jaedon Shin <jaedon.shin@gmail.com> Signed-off-by:
-
Jaedon Shin authored
Adds compat_ioctl for 32-bit user space applications on a 64-bit system. [m.chehab@osg.samsung.com: add missing include compat.h] Signed-off-by:
-
Jaedon Shin authored
Adds unlocked ioctl function directly in dvb_frontend.c instead of using dvb_generic_ioctl(). Signed-off-by:
-
Wolfgang Rohdewald authored
dvb_frontend will call dvb_detach for: - stb0899_detach in dvb_frontend_release and - stb0899_release in __dvb_frontend_free But we only do dvb_attach(stb0899_attach). Increment the module refcount instead. Signed-off-by:
Wolfgang Rohdewald <wolfgang@rohdewald.de> Signed-off-by:
-
Fengguang Wu authored
drivers/media/dvb-core/dvb_frontend.c:154:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Fixes: b1cb7372 ("dvb_frontend: don't use-after-free the frontend struct") Signed-off-by:
Fengguang Wu <fengguang.wu@intel.com> Signed-off-by:
-
Daniel Scheller authored
Since nothing from dvb_math.h is used, remove the unneeded include. Signed-off-by:
-
Daniel Scheller authored
tracking_optimization() doesn't make use of the symbol rate reported by the demodulator, so remove the unneeded inquiry and the now unneeded variable. Reported-by:
Richard Scobie <rascobie@slingshot.co.nz> Cc: Ralph Metzler <rjkm@metzlerbros.de> Signed-off-by:
-
Daniel Scheller authored
Utilise get_cur_symbol_rate() in get_frontend() to update the dtv_frontend_properties with the current symbol rate as reported by the demodulator. Reported-by:
-
Daniel Scheller authored
The result (if any) isn't used anywhere besides being assigned to a local variable (and the only current companion stv6111 doesn't even implement get_if_frequency()), thus remove the ptr check and the call, and also remove the now unused iffreq variable. Reported-by:
-
Daniel Scheller authored
When a parent (demod) driver encounters and signals a problem with gate_ctrl(), don't blindly continue poking the I2C bus. Signed-off-by:
-
Daniel Scheller authored
Stack dump when gate_ctrl() is called in a way that consecutive unlocks happen. This is a clear indication that other drivers interfacing with the stv0910 driver don't do things properly or don't check for failures, so dump stack so that those drivers can be identified and fixed. Signed-off-by:
-
Daniel Scheller authored
Each field (FSTV0910_XX) is declared as reg/off/unused/sign/mask. Add the missing offset value to the defines. Picked up from dddvb master, commit 8a1f27c3d22c ("add field offset to field defines") by Ralph Metzler <rjkm@metzlerbros.de>, adapted to match the comment style in the mainline driver. Cc: Ralph Metzler <rjkm@metzlerbros.de> Signed-off-by: -
Colin Ian King authored
The assignment status to itself is redundant and can be removed. Detected with Coccinelle. Signed-off-by:
-
Olli Salonen authored
Xbox One Digital TV Tuner is a low-cost USB 2.0 multistandard TV tuner. It supports DVB-T, DVB-T2 and DVB-C broadcast standards. USB bridge: DibCom 0700C Demodulator: Panasonic MN88472 Tuner: TDA18250BHN The demodulator requires firmware. Download one from here: http://palosaari.fi/linux/v4l-dvb/firmware/MN88472/02/latest/Signed-off-by:
Olli Salonen <olli.salonen@iki.fi> Signed-off-by:
-
Olli Salonen authored
NXP TDA18250 silicon tuner driver. Version 4 includes some checkpatch fixes. Signed-off-by:
-
Colin Ian King authored
The self assignment of temporary is redundant and can be removed. Detected using coccinelle. Signed-off-by:
-
Colin Ian King authored
The self assignment of k_indirect is redundant and can be removed. Detected using coccinelle. Signed-off-by:
-
Vasyl Gomonovych authored
To adapt fei->sram_size calculation via resource_size for memory size calculation before, in fei->sram = devm_ioremap_resource(dev, res). And make memory initialization range in memset_io for fei->sram appropriate Signed-off-by:
Vasyl Gomonovych <gomonovych@gmail.com> Acked-by:
Patrice Chotard <patrice.chotard@st.com> Signed-off-by:
-
Gustavo A. R. Silva authored
_channel_ is being dereferenced before it is null checked, hence there is a potential null pointer dereference. Fix this by moving the pointer dereference after _channel_ has been null checked. This issue was detected with the help of Coccinelle. Fixes: c5f5d0f9 ("[media] c8sectpfe: STiH407/10 Linux DVB demux support") Signed-off-by:
Gustavo A. R. Silva <garsilva@embeddedor.com> Acked-by:
-
Geert Uytterhoeven authored
If NO_DMA=y: ERROR: "bad_dma_ops" [drivers/media/platform/sti/c8sectpfe/c8sectpfe.ko] undefined! Add a dependency on HAS_DMA to fix this. Signed-off-by:Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by:
-
- 12 Dec, 2017 10 commits
-
-
Joe Perches authored
Line continuations with excess spacing causes unexpected output. Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
The correct error code when a function is not defined is -ENOTSUPP. It was typoed wrong as -EOPNOTSUPP, with, unfortunately, exists, but it is not used by the DVB core. Thanks-to: Geert Uytterhoeven <geert@linux-m68k.org> Thanks-to: Arnd Bergmann <arnd@arndb.de> To make me revisit this code. Fixes: a9cb97c3 ("media: dvb_frontend: be sure to init dvb_frontend_handle_ioctl() return code") Signed-off-by:
-
Matthias Schwarzott authored
Silicon Labs Si2165 DVB-C/T demod driver Signed-off-by:
Matthias Schwarzott <zzam@gentoo.org> Signed-off-by:
-
Matthias Schwarzott authored
End assignments by semicolon instead of comma. Signed-off-by:
-
Matthias Schwarzott authored
End assignments by semicolon instead of comma. Signed-off-by:
-
Matthias Schwarzott authored
Add read_ber function that reads from property cache to support DVBv3. The implementation is inspired by the cx24120 driver. Signed-off-by:
-
Matthias Schwarzott authored
Add read_snr function that reads from property cache to support DVBv3. Signed-off-by:
-
Matthias Schwarzott authored
Add support for BER statistics. Configure a measurement period of 30000 packets. Signed-off-by:
-
Matthias Schwarzott authored
Add C/N statistics in dB to read_status (DVBv5). Signed-off-by:
-
Matthias Schwarzott authored
Use check_signal register for DVB-T additionally. For DVB-C use ps_lock additionally. Signed-off-by:
-
