1. 30 Apr, 2014 9 commits
    • Vlad Yasevich's avatar
      Revert "macvlan : fix checksums error when we are in bridge mode" · f114890c
      Vlad Yasevich authored
      This reverts commit 12a2856b.
      The commit above doesn't appear to be necessary any more as the
      checksums appear to be correctly computed/validated.
      
      Additionally the above commit breaks kvm configurations where
      one VM is using a device that support checksum offload (virtio) and
      the other VM does not.
      In this case, packets leaving virtio device will have CHECKSUM_PARTIAL
      set.  The packets is forwarded to a macvtap that has offload features
      turned off.  Since we use CHECKSUM_UNNECESSARY, the host does does not
      update the checksum and thus a bad checksum is passed up to
      the guest.
      
      CC: Daniel Lezcano <daniel.lezcano@free.fr>
      CC: Patrick McHardy <kaber@trash.net>
      CC: Andrian Nord <nightnord@gmail.com>
      CC: Eric Dumazet <eric.dumazet@gmail.com>
      CC: Michael S. Tsirkin <mst@redhat.com>
      CC: Jason Wang <jasowang@redhat.com>
      Signed-off-by: default avatarVlad Yasevich <vyasevic@redhat.com>
      Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Acked-by: default avatarJason Wang <jasowang@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f114890c
    • Vlad Yasevich's avatar
      mactap: Fix checksum errors for non-gso packets in bridge mode · cbdb0427
      Vlad Yasevich authored
      The following is a problematic configuration:
      
       VM1: virtio-net device connected to macvtap0@eth0
       VM2: e1000 device connect to macvtap1@eth0
      
      The problem is is that virtio-net supports checksum offloading
      and thus sends the packets to the host with CHECKSUM_PARTIAL set.
      On the other hand, e1000 does not support any acceleration.
      
      For small TCP packets (and this includes the 3-way handshake),
      e1000 ends up receiving packets that only have a partial checksum
      set.  This causes TCP to fail checksum validation and to drop
      packets.  As a result tcp connections can not be established.
      
      Commit 3e4f8b78
      	macvtap: Perform GSO on forwarding path.
      fixes this issue for large packets wthat will end up undergoing GSO.
      This commit adds a check for the non-GSO case and attempts to
      compute the checksum for partially checksummed packets in the
      non-GSO case.
      
      CC: Daniel Lezcano <daniel.lezcano@free.fr>
      CC: Patrick McHardy <kaber@trash.net>
      CC: Andrian Nord <nightnord@gmail.com>
      CC: Eric Dumazet <eric.dumazet@gmail.com>
      CC: Michael S. Tsirkin <mst@redhat.com>
      CC: Jason Wang <jasowang@redhat.com>
      Signed-off-by: default avatarVlad Yasevich <vyasevic@redhat.com>
      Acked-by: default avatarJason Wang <jasowang@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      cbdb0427
    • Eric Dumazet's avatar
      tcp: increment retransmit counters in tlp and fast open · fc9f3501
      Eric Dumazet authored
      Both TLP and Fast Open call __tcp_retransmit_skb() instead of
      tcp_retransmit_skb() to avoid changing tp->retrans_out.
      
      This has the side effect of missing SNMP counters increments as well
      as tcp_info tcpi_total_retrans updates.
      
      Fix this by moving the stats increments of into __tcp_retransmit_skb()
      Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
      Acked-by: default avatarNandita Dukkipati <nanditad@google.com>
      Acked-by: default avatarNeal Cardwell <ncardwell@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      fc9f3501
    • Byungho An's avatar
      net: sxgbe: Added set function for interrupt on complete · 3dc638d1
      Byungho An authored
      This patch adds set_rx_int_on_com function for interrupt when
      dma is completed.
      Signed-off-by: default avatarByungho An <bh74.an@samsung.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3dc638d1
    • Byungho An's avatar
      net: sxgbe: Added rxqueue enable function · 325b94f7
      Byungho An authored
      This patch adds rxqueue enable function according to number of rxqueue
      and adds rxqueue disable function for removing.
      Signed-off-by: default avatarByungho An <bh74.an@samsung.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      325b94f7
    • Byungho An's avatar
      net: sxgbe: sw reset moved to probe function · 0a0347b1
      Byungho An authored
      This patch moves sw reset to probe function because
      sw reset is needed early stage before open function.
      Signed-off-by: default avatarByungho An <bh74.an@samsung.net>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0a0347b1
    • Roland Dreier's avatar
      cxgb4: Decode PCIe Gen3 link speed · d2e752db
      Roland Dreier authored
      Add handling for " 8 GT/s" in print_port_info().
      Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d2e752db
    • Tobias Klauser's avatar
      Altera TSE: Add missing include to silence sparse warnings · 652f99ea
      Tobias Klauser authored
      This fixes the following sparse warnings:
      
      drivers/net/ethernet/altera/altera_msgdma.c:23:5: warning: symbol 'msgdma_initialize' was not declared. Should it be static?
      drivers/net/ethernet/altera/altera_msgdma.c:28:6: warning: symbol 'msgdma_uninitialize' was not declared. Should it be static?
      drivers/net/ethernet/altera/altera_msgdma.c:32:6: warning: symbol 'msgdma_reset' was not declared. Should it be static?
      drivers/net/ethernet/altera/altera_msgdma.c:77:6: warning: symbol 'msgdma_disable_rxirq' was not declared. Should it be static?
      drivers/net/ethernet/altera/altera_msgdma.c:83:6: warning: symbol 'msgdma_enable_rxirq' was not declared. Should it be static?
      drivers/net/ethernet/altera/altera_msgdma.c:89:6: warning: symbol 'msgdma_disable_txirq' was not declared. Should it be static?
      drivers/net/ethernet/altera/altera_msgdma.c:95:6: warning: symbol 'msgdma_enable_txirq' was not declared. Should it be static?
      drivers/net/ethernet/altera/altera_msgdma.c:101:6: warning: symbol 'msgdma_clear_rxirq' was not declared. Should it be static?
      drivers/net/ethernet/altera/altera_msgdma.c:107:6: warning: symbol 'msgdma_clear_txirq' was not declared. Should it be static?
      drivers/net/ethernet/altera/altera_msgdma.c:114:5: warning: symbol 'msgdma_tx_buffer' was not declared. Should it be static?
      drivers/net/ethernet/altera/altera_msgdma.c:129:5: warning: symbol 'msgdma_tx_completions' was not declared. Should it be static?
      drivers/net/ethernet/altera/altera_msgdma.c:154:5: warning: symbol 'msgdma_add_rx_desc' was not declared. Should it be static?
      drivers/net/ethernet/altera/altera_msgdma.c:181:5: warning: symbol 'msgdma_rx_status' was not declared. Should it be static?
      Signed-off-by: default avatarTobias Klauser <tklauser@distanz.ch>
      Acked-by: default avatarVince Bridgers <vbridgers2013@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      652f99ea
    • Tobias Klauser's avatar
      Altera TSE: Fix DMA secriptor length initialization · 1b444881
      Tobias Klauser authored
      sgdma_descrip is a function name as well as the name of a struct. In
      sgdma_initialize(), we should initialize the descriptor length field
      with the actual length of a descriptor not with the size of the
      function. In order to prevent such things from happening in the future,
      rename the function to sgdma_setup_descrip().
      
      Found by sparse which yields the following warning:
      
      drivers/net/ethernet/altera/altera_sgdma.c:74:30: warning: expression using sizeof on a function
      Signed-off-by: default avatarTobias Klauser <tklauser@distanz.ch>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1b444881
  2. 28 Apr, 2014 12 commits
  3. 27 Apr, 2014 5 commits
  4. 26 Apr, 2014 11 commits
  5. 24 Apr, 2014 3 commits