- 16 Oct, 2016 40 commits
-
-
Andrey Shvetsov authored
In case the networking interface goes down and up again, the USB HDM does not report the state the MOST networking interface controller is in. This might lead to nonfunctional network. Since the networking AIM already takes care of hardware address checking and tracing it can be removed from the HDM USB, which is what this patch is doing. Signed-off-by:
Andrey Shvetsov <andrey.shvetsov@k2l.de> Signed-off-by:
Christian Gromm <christian.gromm@microchip.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Andrey Shvetsov authored
This patch removes the needless call of function netdev_info() from function most_nd_setup(). Signed-off-by:
-
Andrey Shvetsov authored
The networking AIM implements a non-standard behavior as it starts the networking interface with an invalid MAC address and changes it by the time a valid one is available. This patch introduces a completion object to set the MAC address of the networking interface before the .ndo_open callback (ifup) of the net_device returns. Signed-off-by:
-
Andrey Shvetsov authored
In case the networking interface (running on MediaLB) is being started before the MOST network is, it remains disabled even after the MOST network has transitioned to active mode. This patch removes the dependency on the MOST link status to keep the networking queue active and the networking interface working for the case described above. Signed-off-by:
-
Andrey Shvetsov authored
This patch updates the comments with examples on how to use the "add_link" and "remove_link" properties. Signed-off-by:
-
Andrey Shvetsov authored
The USB HDM does not use the "@" character for channel names anymore. This patch cleans up the code processing such names and adapts the corresponding examples on how to use the properties "add_link" and "remove_link". Signed-off-by:
-
Andrey Shvetsov authored
The attribute "remove_link" returns the latest link that has been removed of a certain channel. Since this piece information isn't particulary useful this patch is going to remove it. Signed-off-by:
-
Andrey Shvetsov authored
This patch removes the unused field add_link of struct most_aim_obj. Signed-off-by:
-
Bhumika Goyal authored
The function fill_unplug_req is not used anywhere in the kernel, so remove it. Done using Coccinelle. @r1@ identifier func; type T; @@ static T func(...) { ... } @r@ identifier r1.func; @@ func @delete depends on !r@ identifier r1.func; type r1.T; @@ - static T func(...){...} Signed-off-by:Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Harman Kalra authored
This patch resolves all the following CHECKs caught by checkpatch.pl CHECK: Alignment should match open parenthesis Signed-off-by:
Harman Kalra <harman4linux@gmail.com> Signed-off-by:
-
Bhumika Goyal authored
Declare the structure usb_ep_ops as constant as it is only stored in the ops field of a usb_ep structure which is a field of a nbu2ss_ep structure. The ops field is of type const struct usb_ep_ops *, so usb_ep_ops structures having this property can be decalared as const. Done using coccinelle: @r1 disable optional_qualifier @ identifier i; position p; @@ static struct usb_ep_ops i@p = {...}; @ok1@ identifier r1.i; position p; struct nbu2ss_ep s; @@ s.ep.ops=&i@p @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ static +const struct usb_ep_ops i={...}; @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct usb_ep_ops i; File size before: text data bss dec hex filename 16007 376 3720 20103 4e87 drivers/staging/emxx_udc/emxx_udc.o File size after: text data bss dec hex filename 16095 280 3720 20095 4e7f drivers/staging/emxx_udc/emxx_udc.o Signed-off-by:Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Bhumika Goyal authored
Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)(&a) + &a ) Signed-off-by:
-
Bhumika Goyal authored
Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)(&a) + &a ) Signed-off-by:
-
Jakub Jedelsky authored
Block comments should align the * on each line as reported by checkpatch Signed-off-by:
Jakub Jedelsky <jakub.jedelsky@gmail.com> Signed-off-by:
-
Elizabeth Ferdman authored
Fix checkpatch error "missing blank line after declarations" to conform to kernel coding style. Signed-off-by:
Elizabeth Ferdman <gnudevliz@gmail.com> Signed-off-by:
-
Elizabeth Ferdman authored
Fix checkpatch error "open brace should be on previous line" since only functions should have their opening brace on a new line. Signed-off-by:
-
Benoit Hiller authored
Fixes the following sparse warning: drivers/staging/dgnc/dgnc_tty.c:933:19: warning: symbol 'find_board_by_major' was not declared. Should it be static? Signed-off-by:
Benoit Hiller <benoit.hiller@gmail.com> Signed-off-by:
-
Wayne Porter authored
Checkpatch found multiple assignments on one line so move them to their own lines. Signed-off-by:
Wayne Porter <wporter82@gmail.com> Signed-off-by:
-
Wayne Porter authored
Covert CamelCase as checkpatch suggests Signed-off-by:
-
Wayne Porter authored
Checkpatch recommended changes Signed-off-by:
-
Wayne Porter authored
Issues found with checkpatch Signed-off-by:
-
Wayne Porter authored
Checkpatch detected multiple instances of logical continuation warnings Signed-off-by:
-
Wayne Porter authored
Coding style checks found by checkpatch Signed-off-by:
-
Wayne Porter authored
Change alignment to match open parenthesis Signed-off-by:
-
Bhumika Goyal authored
Declare the structure v4l2_ioctl_ops as const as it is only stored in the ioctl_ops field of video_device structure. As this field is of type const struct v4l2_ioctl_ops *, so v4l2_ioctl_ops structures having this property can also be made const. Done using coccinelle: @r1 disable optional_qualifier @ identifier i; position p; @@ static struct v4l2_ioctl_ops i@p = {...}; @ok1@ identifier r1.i; position p; struct video_device s; @@ s.ioctl_ops=&i@p; @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ static +const struct v4l2_ioctl_ops i={...}; @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct v4l2_ioctl_ops i; File size before: text data bss dec hex filename 20465 3220 32 23717 5ca5 drivers/staging/media/bcm2048/radio-bcm2048.o File size after: text data bss dec hex filename 21425 2260 32 23717 5ca5 drivers/staging/media/bcm2048/radio-bcm2048.o Signed-off-by: -
Elise Lennion authored
Fix checkpatch warning: WARNING: Block comments use a trailing */ on a separate line Signed-off-by:
Elise Lennion <elise.lennion@gmail.com> Signed-off-by:
-
Sabitha George authored
This patch replaces inclusion of asm/atomic.h with linux/atomic.h and asm/io.h with linux/io.h to fix checkpatch warning in ks_wlan.h Signed-off-by:
Sabitha George <sabitha.george@gmail.com> Signed-off-by:
-
Mihaela Muraru authored
This is a patch to ks_hostif.c file that fixes up a checkpatch.pl WARNING: void function return statements are not generally useful. The 'return' statement is not useful here, because it is not necessary to be forced the exit of the function. Signed-off-by:
Mihaela Muraru <mihaela.muraru21@gmail.com> Signed-off-by:
-
Mihaela Muraru authored
Fix a issue found by checkpatch.pl tool: "WARNING: __packed is preferred over __attribute__((packed))". Replace __attribute__((packed)) with __packed. Signed-off-by:
-
Ebru Akagunduz authored
This patch removes else statement which is not usefull after a return. Issue found by checkpatch.pl. Signed-off-by:
Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by:
-
Pontus Fuchs authored
Convert to %pM instead of custom code. Signed-off-by:
Pontus Fuchs <pontus.fuchs@gmail.com> Signed-off-by:
-
Pontus Fuchs authored
sdio functions takes unsigned int as address. No need to cast. Signed-off-by:
-
Muraru Mihaela authored
This is a patch to the ks_wlan_net.c file that fixes up a brace coding style warning found by checkpatch.pl tool, by deleting the unnecessary braces for single statement blocks. Signed-off-by:
-
Muraru Mihaela authored
This patch fixes a coding style WARNING: Missing a blank line after declaration, found by checkpatch.pl. By adding a blank line after declaration of a variable. Signed-off-by:
-
Philipp Hoefflin authored
Fix checkpatch "ERROR: exactly one space required after that #ifdef" error in ks_hostif.c. Signed-off-by:
Philipp Hoefflin <p.hoefflin@posteo.de> Signed-off-by:
-
Philipp Hoefflin authored
Reformat the makro ps_confirm_wait_inc() to fix several checkpatch errors and warnings: - ERROR: space required before the open brace '{' - ERROR: space required before the open parenthesis '(' - ERROR: code indent should use tabs where possible - ERROR: space required after that close brace '}' - ERROR: space required before the open parenthesis '(' - WARNING: line over 80 characters - WARNING: please, no spaces at the start of a line Signed-off-by: -
Philipp Hoefflin authored
Fix all occurences of checkpatch "ERROR: code indent should use tabs where possible" errors in ks_hostif.c. Signed-off-by:
-
Philipp Hoefflin authored
Fix all occurences of the following checkpatch errors in ks_hostif.c: - ERROR: space prohibited after that '&' (ctx:WxW) - ERROR: space prohibited after that open parenthesis '(' - ERROR: space prohibited before that close parenthesis ')' Signed-off-by: -
Juliana Rodrigues authored
Fixes a tabstop alignment checkpatch issue by removing extra blank spaces. Signed-off-by:
Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by:
-
Juliana Rodrigues authored
Removes unecessary parenthesis from rtw_led.c file that were causing checkpatch warnings. Signed-off-by:
-
