Skip to content

L
linux
Switch branch/tag
  1. 12 Jan, 2010 1 commit
    • Bartlomiej Zolnierkiewicz's avatar
      icside: bring back ->maskproc method · f75d4a23
      Bartlomiej Zolnierkiewicz authored 
      Bring back ->maskproc method since it is still needed for proper operation,
as noticed by Russell King:

> This change is bogus.
>
>         writeb(0, base + ICS_ARCIN_V6_INTROFFSET_1);
>         readb(base + ICS_ARCIN_V6_INTROFFSET_2);
>
>         writeb(0, base + ICS_ARCIN_V6_INTROFFSET_2);
>         readb(base + ICS_ARCIN_V6_INTROFFSET_1);
>
> This sequence of code does:
>
> 1. enable interrupt 1
> 2. disable interrupt 2
> 3. enable interrupt 2
> 4. disable interrupt 1
>
> which results in the interrupt for the second channel being enabled -
> leaving channel 1 blocked.
>
> Firstly, icside shares its two IDE channels with one DMA engine - so it's
> a simplex interface.  IDE supports those (or did when the code was written)
> serializing requests between the two interfaces.  libata does not.
>
> Secondly, the interrupt lines on icside float when there's no drive connected
> or when the drive has its NIEN bit set, which means that you get spurious
> screaming interrupts which can kill off all expansion card interrupts on
> the machine unless you disable the channel interrupt on the card.
>
> Since libata can not serialize the operation of the two channels like IDE
> can, the libata version of the icside driver does not contain the interrupt
> stearing logic.  Instead, it looks at the status after reset, and if
> nothing was found on that channel, it masks the interrupt from that
> channel.

This patch reverts changes done in commit dff8817b (I became confused due to
non-standard & undocumented ->maskproc method, anyway sorry about that).
Noticed-by: default avatarRussell King <rmk@arm.linux.org.uk>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f75d4a23
  3. 08 Jan, 2010 1 commit
  5. 14 Dec, 2009 1 commit
    • Thadeu Lima de Souza Cascardo's avatar
      ide: doc: remove compilation options section from ide-cd documentation · 1c8a3751
      Thadeu Lima de Souza Cascardo authored 
      This section pointed out to compilation options which no longer exist.

VERBOSE_IDE_CD_ERRORS has been replace by config option
CONFIG_BLK_DEV_IDECD_VERBOSE_ERRORS.

STANDARD_ATAPI is no longer needed, since the non-standard drivers, which
required bcd2bin are now detected, and there's a flag for them.

NO_DOOR_LOCKING is now a sysctl parameter for cdrom drivers.

CDROM_NBLOCKS_BUFFER is not used anymore. The READAUDIO is now in cdrom.c and it
allocates as much as user space has requested to read, backing off if it fails.

TEST is not there anymore or in cdrom either. ide allows to send ATA commands
through ioctl, although it may be helpful to send MMC packets through the cdrom
layer directly.
Signed-off-by: default avatarThadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1c8a3751
  7. 12 Dec, 2009 37 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7