- 27 Aug, 2024 8 commits
-
-
Javier Carrasco authored
There is no need to actively disable a regulator that has not been enabled by the driver, which makes the call to cc2_disable() in the probe function meaningless, because the probe function never enables the device's dedicated regulator. Once the call to cc2_disable() is dropped, the error paths can directly return dev_err_probe() in all cases. Signed-off-by:
Javier Carrasco <javier.carrasco.cruz@gmail.com> Message-ID: <20240813-chipcap2-probe-improvements-v2-1-e9a2932a8a00@gmail.com> Signed-off-by:
Guenter Roeck <linux@roeck-us.net>
-
Guenter Roeck authored
Update datasheet references. Replace misleading 'force parameter needed' with 'must be instantiated explicitly'. Explain the reason for the missing auto-detection. Mention all supported chips in Kconfig. Reviewed-by:
Tzung-Bi Shih <tzungbi@kernel.org> Signed-off-by:
-
Guenter Roeck authored
Convert driver to with_info hwmon API to simplify the code and to reduce its size. No functional change. Reviewed-by:
-
Guenter Roeck authored
Use regmap for local caching and for multi-byte operations to be able to use regmap API functions and to reduce the need for locking in the driver. Reviewed-by:
-
Guenter Roeck authored
The chip IDs are not used by the driver. Drop them. Use driver data to store the limit register resolution instead, and use this information when writing temperature limits to improve chip specific rounding and to avoid writing into unused register bits. Reviewed-by:
-
Guenter Roeck authored
Simplify driver maintenance by reordering files to alphabetic order. No functional change. Reviewed-by:
-
Guenter Roeck authored
Checking three configuration register bits and the manufacturer ID register to auto-detect LM92 is a bit vague. Repeat twice on replicated register addresses to improve detection accuracy. Check the manufacturer ID first and bail out immediately without reading the other register if there is a mismatch to reduce the number of i2c transfers needed in that case. Also explicitly test for an error from reading the configuration register to avoid potential situations where the returned error masked against 0xe0 is 0. While at it, drop "lm92: Found National Semiconductor LM92 chip" detection noise. Reviewed-by:
-
Rob Herring (Arm) authored
Use of_property_present() to test for property presence rather than of_get_property(). This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed. Signed-off-by:
Rob Herring (Arm) <robh@kernel.org> Reviewed-by:
Sudeep Holla <sudeep.holla@arm.com> Link: https://lore.kernel.org/r/20240731191312.1710417-13-robh@kernel.orgSigned-off-by:
-
- 31 Jul, 2024 32 commits
-
-
Guenter Roeck authored
Bail out immediately if reading any of the registers used for chip detection fails, or if it returns an unexpected value. Drop all log messages from detection code. Reviewed-by:
-
Guenter Roeck authored
The chip supports reading and writing the conversion rate. Add support for the update_interval sysfs attribute. Reviewed-by:
-
Guenter Roeck authored
Convert driver to with_info hwmon API to simplify the code and with it its maintainability. Reviewed-by:
-
Guenter Roeck authored
Use regmap for local caching, to hide register read/write address differences, and for multi-byte operations. With this change, the driver specific lock is no longer necessary. While at it, check errors seen when initializing the chip and bail out if chip initialization fails. Reviewed-by:
-
Guenter Roeck authored
Bit 0, 5, and 6 in the status register are reserved and, if set, do not indicate an alarm. Bit 7 is the 'busy' bit and also does not indicate an alarm. Mask the non-alarm bits to avoid reporting them to userspace. Cc: Tzung-Bi Shih <tzungbi@kernel.org> Reviewed-by:
-
Guenter Roeck authored
Simplify maintenance by reordering include files to alphabetic order. Reviewed-by:
-
Guenter Roeck authored
Module test code reports underflows when writing sensor limits. temp2_min: Suspected underflow: [min=-77000, read 101000, written -2147483648] temp2_max: Suspected underflow: [min=-77000, read 101000, written -2147483648] temp2_crit: Suspected underflow: [min=-77000, read 101000, written -2147483648] Clamp temperature ranges when writing limits to fix the problem. While at it, use sign_extend32() when reading temperatures to make the code easier to understand. Reviewed-by:
-
Guenter Roeck authored
In the MAX6581 datasheet Revision 0 to 3, the local channel overtemperature status is reported in bit 6 of register 0x45, and the overtemperature status for remote channel 7 is reported in bit 7. In Revision 4 and later, the local channel overtemperature status is reported in bit 7, and the remote channel 7 overtemperature status is reported in bit 6. A real chip was found to match the functionality documented in Revision 4 and later. The code was fixed with commit 1ea3fd1e ("hwmon: (max6697) Fix swapped temp{1,8} critical alarms"). At that time it looked like this was an original bug. It only turned out later that the problem was the result of incorrect information in the chip datasheet. Document the discrepancy to avoid confusion caused by old versions of the datasheet. Cc: Tzung-Bi Shih <tzungbi@kernel.org> Reviewed-by:
-
Guenter Roeck authored
Convert to use with_info API to simplify the code and to reduce its size. This patch reduces object file size by approximately 25%. Reviewed-by:
-
Guenter Roeck authored
The only difference between supported chips is the number of channels. Drop enum chips and list the number of channels in struct i2c_device_id directly. Reviewed-by:
-
Guenter Roeck authored
Use regmap for caching to simplify the code and to hide read/write register address differences. Reviewed-by:
-
Guenter Roeck authored
Use bit macro to make the code easier to understand and reduce duplication. Reviewed-by:
-
Guenter Roeck authored
Reorder include files to alphabetic order to simplify driver maintenance. Reviewed-by:
-
Cryolitia PukNgae authored
RMP -> RPM Signed-off-by:
Cryolitia PukNgae <Cryolitia@gmail.com> Link: https://lore.kernel.org/r/20240726-typo-v1-1-3ca3f07f93e9@gmail.comSigned-off-by:
-
Nuno Sa authored
Use the device property APIs so the driver does not depend on OF to work. While at it, properly include mod_devicetable for struct of_device_id and fix some parameter alignment in the changed places. Signed-off-by:
Nuno Sa <nuno.sa@analog.com> Link: https://lore.kernel.org/r/20240726-dev-hwmon-ltc6947-fw-agnostic-v1-1-f7d6cab7d438@analog.comSigned-off-by:
-
Chris Packham authored
By default the PWM duty cycle in hardware is 100%. On some systems this can cause unwanted fan noise. Add the ability to specify the fan connections and initial state of the PWMs via device properties. Signed-off-by:
Chris Packham <chris.packham@alliedtelesis.co.nz> Link: https://lore.kernel.org/r/20240722221737.3407958-4-chris.packham@alliedtelesis.co.nz [groeck: Cleaned up formatting] Signed-off-by:
-
Chris Packham authored
Now that we have fan child nodes that can specify flags for the PWM outputs we no longer need the adi,pwm-active-state property. Signed-off-by:
-
Chris Packham authored
Add fan child nodes that allow describing the connections for the ADT7475 to the fans it controls. This also allows setting some initial values for the pwm duty cycle and frequency. Signed-off-by:
-
Guenter Roeck authored
MAX6581 supports setting the minimum temperature as well as minimum temperature alarms. Add support for it. Reviewed-by:
-
Guenter Roeck authored
Convert to with_info hwmon API to simplify the code and reduce its size. This patch reduces object file size by approximately 25%. Reviewed-by:
-
Guenter Roeck authored
Use regmap for register caching, and use regmap API for bit operations to simplify the code. This patch reduces object file size by approximately 10%. Reviewed-by:
-
Guenter Roeck authored
Use bit operations to improve code maintainability. Reviewed-by:
-
Guenter Roeck authored
Platform data is not used anywhere in the upstram kernel. Drop support for it to simplify code maintenance. Reviewed-by:
-
Guenter Roeck authored
Reorder include files to alphabetic order to improve maintainability. Reviewed-by:
-
Guenter Roeck authored
Chips reporting overcurrent alarms report it in the second alarm register. That means the second alarm register has to be read, even if the chip only supports 8 or fewer ADC channels. MAX16067 and MAX16068 report undervoltage and overvoltage alarms in separate registers. Fold register contents together to report both with the existing alarm attribute. This requires actually storing the chip type in struct max16065_data. Rename the variable 'chip' to match the variable name used in the probe function. Reviewed-by:
-
Guenter Roeck authored
Writing large limits resulted in overflows as reported by module tests. in0_lcrit: Suspected overflow: [max=5538, read 0, written 2147483647] in0_crit: Suspected overflow: [max=5538, read 0, written 2147483647] in0_min: Suspected overflow: [max=5538, read 0, written 2147483647] Fix the problem by clamping prior to multiplications and the use of DIV_ROUND_CLOSEST, and by using consistent variable types. Reviewed-by:
-
Javier Carrasco authored
The iterated nodes are direct children of the device node, and the `device_for_each_child_node()` macro accounts for child node availability. `fwnode_for_each_available_child_node()` is meant to access the child nodes of an fwnode, and therefore not direct child nodes of the device node. In this case, the child nodes are not required outside the loop, and the scoped version of the macro can be used to remove the repetitive `goto put` pattern. Use `device_for_each_child_node_scoped_scoped()` to indicate device's direct child nodes. Reviewed-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by:
-
Armin Wolf authored
Add the Dell Latitude 7320 to the fan control whitelist to allow for manual fan control. Closes: https://github.com/Wer-Wolf/i8kutils/issues/8Signed-off-by:
Armin Wolf <W_Armin@gmx.de> Acked-by:
Pali Rohár <pali@kernel.org> Link: https://lore.kernel.org/r/20240719203706.19466-1-W_Armin@gmx.deSigned-off-by:
-
Guenter Roeck authored
Use multi-byte regmap operations to simplify the code and to reduce dependency on locking. No functional change. Reviewed-by:
-
Guenter Roeck authored
LM95233/LM95234 support enabling temperature channels one by one. Add support for tempX_enable attribute to be able to use that functionality. Reviewed-by:
-
Guenter Roeck authored
Convert to with_info API to simplify the code and reduce its size. This patch reduces the object file size by about 30%. No functional change. Reviewed-by:
-
Guenter Roeck authored
Use regmap to replace local caching and to be able to use regmap API functions. No functional change. Reviewed-by:
-
